wikimedia / mediawiki

includes/jobqueue/aggregator/JobQueueAggregatorRedis.php

Doc Comments +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
 	/**
 	 * Get a connection to the server that handles all sub-queues for this queue
 	 *
-	 * @return RedisConnRef|bool Returns false on failure
+	 * @return boolean Returns false on failure
 	 * @throws MWException
 	 */
 	protected function getConnection() {
@@ -122,7 +122,7 @@ 
 
 	/**
 	 * @param string $name
-	 * @return string
+	 * @return string[]
 	 */
 	private function decodeQueueName( $name ) {
 		list( $type, $wiki ) = explode( '/', $name, 2 );

includes/jobqueue/Job.php

Doc Comments +3 added lines, -3 removed lines

@@ -130,7 +130,7 @@ 
 	}
 
 	/**
-	 * @return int|null UNIX timestamp to delay running this job until, otherwise null
+	 * @return string|null UNIX timestamp to delay running this job until, otherwise null
 	 * @since 1.22
 	 */
 	public function getReleaseTimestamp() {
@@ -140,7 +140,7 @@ 
 	}
 
 	/**
-	 * @return int|null UNIX timestamp of when the job was queued, or null
+	 * @return string|null UNIX timestamp of when the job was queued, or null
 	 * @since 1.26
 	 */
 	public function getQueuedTimestamp() {
@@ -150,7 +150,7 @@ 
 	}
 
 	/**
-	 * @return int|null UNIX timestamp of when the job was runnable, or null
+	 * @return string|null UNIX timestamp of when the job was runnable, or null
 	 * @since 1.26
 	 */
 	public function getReadyTimestamp() {

includes/jobqueue/JobQueueDB.php

Doc Comments +7 added lines, -7 removed lines

@@ -315,7 +315,7 @@ 
 	 * @param string $uuid 32 char hex string
 	 * @param int $rand Random unsigned integer (31 bits)
 	 * @param bool $gte Search for job_random >= $random (otherwise job_random <= $random)
-	 * @return stdClass|bool Row|false
+	 * @return boolean Row|false
 	 */
 	protected function claimRandom( $uuid, $rand, $gte ) {
 		$dbw = $this->getMasterDB();
@@ -392,7 +392,7 @@ 
 	 * Reserve a row with a single UPDATE without holding row locks over RTTs...
 	 *
 	 * @param string $uuid 32 char hex string
-	 * @return stdClass|bool Row|false
+	 * @return boolean Row|false
 	 */
 	protected function claimOldest( $uuid ) {
 		$dbw = $this->getMasterDB();
@@ -453,7 +453,7 @@ 
 	 * @see JobQueue::doAck()
 	 * @param Job $job
 	 * @throws MWException
-	 * @return Job|bool
+	 * @return boolean
 	 */
 	protected function doAck( Job $job ) {
 		if ( !isset( $job->metadata['id'] ) ) {
@@ -549,7 +549,7 @@ 
 
 	/**
 	 * @see JobQueue::getAllQueuedJobs()
-	 * @return Iterator
+	 * @return MappedIterator|null
 	 */
 	public function getAllQueuedJobs() {
 		return $this->getJobIterator( array( 'job_cmd' => $this->getType(), 'job_token' => '' ) );
@@ -557,7 +557,7 @@ 
 
 	/**
 	 * @see JobQueue::getAllAcquiredJobs()
-	 * @return Iterator
+	 * @return MappedIterator|null
 	 */
 	public function getAllAcquiredJobs() {
 		return $this->getJobIterator( array( 'job_cmd' => $this->getType(), "job_token > ''" ) );
@@ -565,7 +565,7 @@ 
 
 	/**
 	 * @param array $conds Query conditions
-	 * @return Iterator
+	 * @return MappedIterator|null
 	 */
 	protected function getJobIterator( array $conds ) {
 		$dbr = $this->getSlaveDB();
@@ -817,7 +817,7 @@ 
 	/**
 	 * Return the list of job fields that should be selected.
 	 * @since 1.23
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectFields() {
 		return array(

includes/jobqueue/JobQueueGroup.php

Doc Comments +1 added lines, -1 removed lines

@@ -179,7 +179,7 @@
 	 * This pops a job off a queue as specified by $wgJobTypeConf and
 	 * updates the aggregate job queue information cache as needed.
 	 *
-	 * @param int|string $qtype JobQueueGroup::TYPE_* constant or job type string
+	 * @param integer $qtype JobQueueGroup::TYPE_* constant or job type string
 	 * @param int $flags Bitfield of JobQueueGroup::USE_* constants
 	 * @param array $blacklist List of job types to ignore
 	 * @return Job|bool Returns false on failure

includes/jobqueue/JobQueueRedis.php

Doc Comments +3 added lines, -3 removed lines

@@ -378,7 +378,7 @@ 
 	/**
 	 * @see JobQueue::doAck()
 	 * @param Job $job
-	 * @return Job|bool
+	 * @return boolean
 	 * @throws UnexpectedValueException
 	 * @throws JobQueueError
 	 */
@@ -480,7 +480,7 @@ 
 
 	/**
 	 * @see JobQueue::doDelete()
-	 * @return bool
+	 * @return boolean|null
 	 * @throws JobQueueError
 	 */
 	protected function doDelete() {
@@ -693,7 +693,7 @@ 
 
 	/**
 	 * @param array $fields
-	 * @return Job|bool
+	 * @return Job
 	 */
 	protected function getJobFromFields( array $fields ) {
 		$title = Title::makeTitle( $fields['namespace'], $fields['title'] );

includes/jobqueue/jobs/ThumbnailRenderJob.php

Doc Comments +4 added lines

@@ -77,6 +77,10 @@
 		}
 	}
 
+	/**
+	 * @param File $file
+	 * @param string $thumbUrl
+	 */
 	protected function hitThumbUrl( $file, $transformParams, &$thumbUrl ) {
 		global $wgUploadThumbnailRenderHttpCustomHost, $wgUploadThumbnailRenderHttpCustomDomain;
 

includes/libs/ArrayUtils.php

Doc Comments -1 removed lines

@@ -151,7 +151,6 @@
 	 * @since 1.23
 	 *
 	 * @param array $array1 The array to compare from
-	 * @param array $array2,... More arrays to compare against
 	 * @return array An array containing all the values from array1
 	 *               that are not present in any of the other arrays.
 	 */

includes/libs/BufferingStatsdDataFactory.php

Doc Comments +3 added lines

@@ -35,6 +35,9 @@
 class BufferingStatsdDataFactory extends StatsdDataFactory {
 	protected $buffer = array();
 
+	/**
+	 * @param string $prefix
+	 */
 	public function __construct( $prefix ) {
 		parent::__construct();
 		$this->prefix = $prefix;

includes/libs/Cookie.php

Doc Comments +4 added lines

@@ -33,6 +33,10 @@
 	// TO IMPLEMENT? protected $version
 	// TO IMPLEMENT? protected $comment
 
+	/**
+	 * @param string $name
+	 * @param string $value
+	 */
 	function __construct( $name, $value, $attr ) {
 		$this->name = $name;
 		$this->set( $value, $attr );