MssqlUpdater::getCoreUpdateList() - Code Metrics - Inspection of "Daily Inspection: Merge "Point skins/extension REA..." - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (33c24b)

unknown

created 2016-05-04 17:47 UTC

MssqlUpdater::getCoreUpdateList() A

↳ Parent: MssqlUpdater

Complexity

Conditions	1
Paths	1

Size

Total Lines	51
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	38
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	51
rs	9.4109

How to fix Long Method

<?php
/**
 * Microsoft SQL Server-specific installer.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 * @ingroup Deployment
 */

/**
 * Class for setting up the MediaWiki database using Microsoft SQL Server.
 *
 * @ingroup Deployment
 * @since 1.23
 */

class MssqlUpdater extends DatabaseUpdater {

	/**
	 * @var DatabaseMssql
	 */
	protected $db;

	protected function getCoreUpdateList() {
		return [
			// 1.23
			[ 'addField', 'mwuser', 'user_password_expires', 'patch-user_password_expires.sql' ],

			// 1.24
			[ 'addField', 'page', 'page_lang', 'patch-page_page_lang.sql' ],

			// 1.25
			[ 'dropTable', 'hitcounter' ],
			[ 'dropField', 'site_stats', 'ss_total_views', 'patch-drop-ss_total_views.sql' ],
			[ 'dropField', 'page', 'page_counter', 'patch-drop-page_counter.sql' ],
			// scripts were updated in 1.27 due to SQL errors; retaining old updatekeys so that people
			// updating from 1.23->1.25->1.27 do not execute these scripts twice even though the
			// updatekeys no longer make sense as they are.
			[ 'updateSchema', 'categorylinks', 'cl_type-category_types-ck',
				'patch-categorylinks-constraints.sql' ],
			[ 'updateSchema', 'filearchive', 'fa_major_mime-major_mime-ck',
				'patch-filearchive-constraints.sql' ],
			[ 'updateSchema', 'oldimage', 'oi_major_mime-major_mime-ck',
				'patch-oldimage-constraints.sql' ],
			[ 'updateSchema', 'image', 'img_major_mime-major_mime-ck', 'patch-image-constraints.sql' ],
			[ 'updateSchema', 'uploadstash', 'us_media_type-media_type-ck',
				'patch-uploadstash-constraints.sql' ],

			[ 'modifyField', 'image', 'img_major_mime',
				'patch-img_major_mime-chemical.sql' ],
			[ 'modifyField', 'oldimage', 'oi_major_mime',
				'patch-oi_major_mime-chemical.sql' ],
			[ 'modifyField', 'filearchive', 'fa_major_mime',
				'patch-fa_major_mime-chemical.sql' ],

			// 1.27
			[ 'dropTable', 'msg_resource_links' ],
			[ 'dropTable', 'msg_resource' ],
			[ 'addField', 'watchlist', 'wl_id', 'patch-watchlist-wl_id.sql' ],
			[ 'dropField', 'mwuser', 'user_options', 'patch-drop-user_options.sql' ],
			[ 'addTable', 'bot_passwords', 'patch-bot_passwords.sql' ],
			[ 'addField', 'pagelinks', 'pl_from_namespace', 'patch-pl_from_namespace.sql' ],
			[ 'addField', 'templatelinks', 'tl_from_namespace', 'patch-tl_from_namespace.sql' ],
			[ 'addField', 'imagelinks', 'il_from_namespace', 'patch-il_from_namespace.sql' ],
			[ 'dropIndex', 'categorylinks', 'cl_collation', 'patch-kill-cl_collation_index.sql' ],
			[ 'addIndex', 'categorylinks', 'cl_collation_ext',
				'patch-add-cl_collation_ext_index.sql' ],
			[ 'dropField', 'recentchanges', 'rc_cur_time', 'patch-drop-rc_cur_time.sql' ],
			[ 'addField', 'page_props', 'pp_sortkey', 'patch-pp_sortkey.sql' ],
			[ 'updateSchema', 'oldimage', 'oldimage varchar', 'patch-oldimage-schema.sql' ],
			[ 'updateSchema', 'filearchive', 'filearchive varchar', 'patch-filearchive-schema.sql' ],
			[ 'updateSchema', 'image', 'image varchar', 'patch-image-schema.sql' ]
		];
	}

	protected function applyPatch( $path, $isFullPath = false, $msg = null ) {
		$prevScroll = $this->db->scrollableCursor( false );
		$prevPrep = $this->db->prepareStatements( false );
		parent::applyPatch( $path, $isFullPath, $msg );
		$this->db->scrollableCursor( $prevScroll );
		$this->db->prepareStatements( $prevPrep );
	}

	/**
	 * General schema update for a table that touches more than one field or requires
	 * destructive actions (such as dropping and recreating the table).
	 *
	 * @param string $table
	 * @param string $updatekey
	 * @param string $patch
	 * @param bool $fullpath
	 */
	protected function updateSchema( $table, $updatekey, $patch, $fullpath = false ) {
		if ( !$this->db->tableExists( $table, __METHOD__ ) ) {
			$this->output( "...$table table does not exist, skipping schema update patch.\n" );
		} elseif ( $this->updateRowExists( $updatekey ) ) {
			$this->output( "...$table already had schema updated by $patch.\n" );
		} else {
			$this->insertUpdateRow( $updatekey );

			return $this->applyPatch( $patch, $fullpath, "Updating schema of table $table" );
		}

		return true;
	}
}


1			<?php
2			/**
3			* Microsoft SQL Server-specific installer.
4			*
5			* This program is free software; you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation; either version 2 of the License, or
8			* (at your option) any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			*
15			* You should have received a copy of the GNU General Public License along
16			* with this program; if not, write to the Free Software Foundation, Inc.,
17			* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18			* http://www.gnu.org/copyleft/gpl.html
19			*
20			* @file
21			* @ingroup Deployment
22			*/
23
24			/**
25			* Class for setting up the MediaWiki database using Microsoft SQL Server.
26			*
27			* @ingroup Deployment
28			* @since 1.23
29			*/
30
31			class MssqlUpdater extends DatabaseUpdater {
32
33			/**
34			* @var DatabaseMssql
35			*/
36			protected $db;
37
38			protected function getCoreUpdateList() {
39			return [
40			// 1.23
41			[ 'addField', 'mwuser', 'user_password_expires', 'patch-user_password_expires.sql' ],
42
43			// 1.24
44			[ 'addField', 'page', 'page_lang', 'patch-page_page_lang.sql' ],
45
46			// 1.25
47			[ 'dropTable', 'hitcounter' ],
48			[ 'dropField', 'site_stats', 'ss_total_views', 'patch-drop-ss_total_views.sql' ],
49			[ 'dropField', 'page', 'page_counter', 'patch-drop-page_counter.sql' ],
50			// scripts were updated in 1.27 due to SQL errors; retaining old updatekeys so that people
51			// updating from 1.23->1.25->1.27 do not execute these scripts twice even though the
52			// updatekeys no longer make sense as they are.
53			[ 'updateSchema', 'categorylinks', 'cl_type-category_types-ck',
54			'patch-categorylinks-constraints.sql' ],
55			[ 'updateSchema', 'filearchive', 'fa_major_mime-major_mime-ck',
56			'patch-filearchive-constraints.sql' ],
57			[ 'updateSchema', 'oldimage', 'oi_major_mime-major_mime-ck',
58			'patch-oldimage-constraints.sql' ],
59			[ 'updateSchema', 'image', 'img_major_mime-major_mime-ck', 'patch-image-constraints.sql' ],
60			[ 'updateSchema', 'uploadstash', 'us_media_type-media_type-ck',
61			'patch-uploadstash-constraints.sql' ],
62
63			[ 'modifyField', 'image', 'img_major_mime',
64			'patch-img_major_mime-chemical.sql' ],
65			[ 'modifyField', 'oldimage', 'oi_major_mime',
66			'patch-oi_major_mime-chemical.sql' ],
67			[ 'modifyField', 'filearchive', 'fa_major_mime',
68			'patch-fa_major_mime-chemical.sql' ],
69
70			// 1.27
71			[ 'dropTable', 'msg_resource_links' ],
72			[ 'dropTable', 'msg_resource' ],
73			[ 'addField', 'watchlist', 'wl_id', 'patch-watchlist-wl_id.sql' ],
74			[ 'dropField', 'mwuser', 'user_options', 'patch-drop-user_options.sql' ],
75			[ 'addTable', 'bot_passwords', 'patch-bot_passwords.sql' ],
76			[ 'addField', 'pagelinks', 'pl_from_namespace', 'patch-pl_from_namespace.sql' ],
77			[ 'addField', 'templatelinks', 'tl_from_namespace', 'patch-tl_from_namespace.sql' ],
78			[ 'addField', 'imagelinks', 'il_from_namespace', 'patch-il_from_namespace.sql' ],
79			[ 'dropIndex', 'categorylinks', 'cl_collation', 'patch-kill-cl_collation_index.sql' ],
80			[ 'addIndex', 'categorylinks', 'cl_collation_ext',
81			'patch-add-cl_collation_ext_index.sql' ],
82			[ 'dropField', 'recentchanges', 'rc_cur_time', 'patch-drop-rc_cur_time.sql' ],
83			[ 'addField', 'page_props', 'pp_sortkey', 'patch-pp_sortkey.sql' ],
84			[ 'updateSchema', 'oldimage', 'oldimage varchar', 'patch-oldimage-schema.sql' ],
85			[ 'updateSchema', 'filearchive', 'filearchive varchar', 'patch-filearchive-schema.sql' ],
86			[ 'updateSchema', 'image', 'image varchar', 'patch-image-schema.sql' ]
87			];
88			}
89
90			protected function applyPatch( $path, $isFullPath = false, $msg = null ) {
91			$prevScroll = $this->db->scrollableCursor( false );
92			$prevPrep = $this->db->prepareStatements( false );
93			parent::applyPatch( $path, $isFullPath, $msg );
94			$this->db->scrollableCursor( $prevScroll );
95			$this->db->prepareStatements( $prevPrep );
96			}
97
98			/**
99			* General schema update for a table that touches more than one field or requires
100			* destructive actions (such as dropping and recreating the table).
101			*
102			* @param string $table
103			* @param string $updatekey
104			* @param string $patch
105			* @param bool $fullpath
106			*/
107			protected function updateSchema( $table, $updatekey, $patch, $fullpath = false ) {
108			if ( !$this->db->tableExists( $table, __METHOD__ ) ) {
109			$this->output( "...$table table does not exist, skipping schema update patch.\n" );
110			} elseif ( $this->updateRowExists( $updatekey ) ) {
111			$this->output( "...$table already had schema updated by $patch.\n" );
112			} else {
113			$this->insertUpdateRow( $updatekey );
114
115			return $this->applyPatch( $patch, $fullpath, "Updating schema of table $table" );
116			}
117
118			return true;
119			}
120			}
121

wikimedia / mediawiki

Branch — master (33c24b)

MssqlUpdater::getCoreUpdateList() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like