AutoCommitUpdate::doUpdate() - Code Metrics - Inspection of "Daily Inspection: Merge "Avoid the use of DB rollb..." - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (c42d81)

unknown

created 2016-07-22 17:18 UTC

AutoCommitUpdate::doUpdate() B

↳ Parent: AutoCommitUpdate

Complexity

Conditions	5
Paths	9

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	5
eloc	13
nc	9
nop	0
dl	0
loc	20
rs	8.8571
c	1
b	0
f	1

<?php

/**
 * Deferrable Update for closure/callback updates that should use auto-commit mode
 * @since 1.28
 */
class AutoCommitUpdate implements DeferrableUpdate {
	/** @var IDatabase */
	private $dbw;
	/** @var string */
	private $fname;
	/** @var callable */
	private $callback;

	/**
	 * @param IDatabase $dbw
	 * @param string $fname Caller name (usually __METHOD__)
	 * @param callable $callback Callback that takes (IDatabase, method name string)
	 */
	public function __construct( IDatabase $dbw, $fname, callable $callback ) {
		$this->dbw = $dbw;
		$this->fname = $fname;
		$this->callback = $callback;

		if ( $this->dbw->trxLevel() ) {
			$this->dbw->onTransactionResolution( [ $this, 'cancelOnRollback' ] );
		}
	}

	public function doUpdate() {
		if ( !$this->callback ) {
			return;
		}

		$autoTrx = $this->dbw->getFlag( DBO_TRX );
		$this->dbw->clearFlag( DBO_TRX );
		try {
			/** @var Exception $e */
			$e = null;
			call_user_func_array( $this->callback, [ $this->dbw, $this->fname ] );
		} catch ( Exception $e ) {

		}
		if ( $autoTrx ) {
			$this->dbw->setFlag( DBO_TRX );
		}
		if ( $e ) {
			throw $e;
		}
	}

	public function cancelOnRollback( $trigger ) {
		if ( $trigger === IDatabase::TRIGGER_ROLLBACK ) {
			$this->callback = null;
		}
	}
}


1		<?php
2
3		/**
4		* Deferrable Update for closure/callback updates that should use auto-commit mode
5		* @since 1.28
6		*/
7		class AutoCommitUpdate implements DeferrableUpdate {
8		/** @var IDatabase */
9		private $dbw;
10		/** @var string */
11		private $fname;
12		/** @var callable */
13		private $callback;
14
15		/**
16		* @param IDatabase $dbw
17		* @param string $fname Caller name (usually __METHOD__)
18		* @param callable $callback Callback that takes (IDatabase, method name string)
19		*/
20	View Code Duplication	public function __construct( IDatabase $dbw, $fname, callable $callback ) {
21		$this->dbw = $dbw;
22		$this->fname = $fname;
23		$this->callback = $callback;
24
25		if ( $this->dbw->trxLevel() ) {
26		$this->dbw->onTransactionResolution( [ $this, 'cancelOnRollback' ] );
27		}
28		}
29
30		public function doUpdate() {
31		if ( !$this->callback ) {
32		return;
33		}
34
35		$autoTrx = $this->dbw->getFlag( DBO_TRX );
36		$this->dbw->clearFlag( DBO_TRX );
37		try {
38		/** @var Exception $e */
39		$e = null;
40		call_user_func_array( $this->callback, [ $this->dbw, $this->fname ] );
41		} catch ( Exception $e ) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-07-22 17:42 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
42		}
43		if ( $autoTrx ) {
44		$this->dbw->setFlag( DBO_TRX );
45		}
46		if ( $e ) {
47		throw $e;
48		}
49		}
50
51		public function cancelOnRollback( $trigger ) {
52		if ( $trigger === IDatabase::TRIGGER_ROLLBACK ) {
53		$this->callback = null;
54		}
55		}
56		}
57

wikimedia / mediawiki

Branch — master (c42d81)

AutoCommitUpdate::doUpdate() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like