wikimedia / mediawiki

includes/resourceloader/ResourceLoaderFileModule.php

Doc Comments +3 added lines, -2 removed lines

@@ -381,7 +381,7 @@ 
 	 * Get all styles for a given context.
 	 *
 	 * @param ResourceLoaderContext $context
-	 * @return array CSS code for $context as an associative array mapping media type to CSS text.
+	 * @return string CSS code for $context as an associative array mapping media type to CSS text.
 	 */
 	public function getStyles( ResourceLoaderContext $context ) {
 		$styles = $this->readStyleFiles(
@@ -631,7 +631,7 @@ 
 	 * @param array $list List of file paths in any combination of index/path
 	 *     or path/options pairs
 	 * @param string $option Option name
-	 * @param mixed $default Default value if the option isn't set
+	 * @param string $default Default value if the option isn't set
 	 * @return array List of file paths, collated by $option
 	 */
 	protected static function collateFilePathListByOption( array $list, $option, $default ) {
@@ -1007,6 +1007,7 @@ 
 	 * the BOM character is not valid in the middle of a string.
 	 * We already assume UTF-8 everywhere, so this should be safe.
 	 *
+	 * @param string $input
 	 * @return string input minus the intial BOM char
 	 */
 	protected function stripBom( $input ) {

includes/deferred/LinksDeletionUpdate.php

Doc Comments +3 added lines

@@ -163,6 +163,9 @@
 		} );
 	}
 
+	/**
+	 * @param string $table
+	 */
 	private function batchDeleteByPK( $table, array $conds, array $pk, $bSize ) {
 		$dbw = $this->mDb; // convenience
 		$res = $dbw->select( $table, $pk, $conds, __METHOD__ );

includes/api/ApiCSPReport.php

Doc Comments +2 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
 	/**
 	 * Log CSP report, with a different severity depending on $flags
 	 * @param $flags Array Flags for this report
-	 * @param $logLine String text of log entry
+	 * @param string $logLine String text of log entry
 	 * @param $context Array logging context
 	 */
 	private function logReport( $flags, $logLine, $context ) {
@@ -165,7 +165,7 @@ 
 	 * Stop processing the request, and output/log an error
 	 *
 	 * @param $code String error code
-	 * @param $method String method that made error
+	 * @param string $method String method that made error
 	 * @throws UsageException Always
 	 */
 	private function error( $code, $method ) {

includes/specialpage/ChangesListSpecialPage.php

Doc Comments +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
 	/**
 	 * Create a FormOptions object with options as specified by the user
 	 *
-	 * @param array $parameters
+	 * @param string $parameters
 	 *
 	 * @return FormOptions
 	 */

includes/changes/ChangesList.php

Doc Comments +9 added lines, -3 removed lines

@@ -153,7 +153,7 @@ 
 	 * @param RecentChange|RCCacheEntry $rc
 	 * @param string|bool $watched Optionally timestamp for adding watched class
 	 *
-	 * @return array of classes
+	 * @return string[] of classes
 	 */
 	protected function getHTMLClasses( $rc, $watched ) {
 		$classes = [];
@@ -228,7 +228,7 @@ 
 	}
 
 	/**
-	 * @param ResultWrapper|array $rows
+	 * @param ResultWrapper $rows
 	 */
 	public function initChangesListRows( $rows ) {
 		Hooks::run( 'ChangesListInitRows', [ $this, $rows ] );
@@ -478,6 +478,8 @@ 
 	 *
 	 * @param string &$s HTML to update
 	 * @param RecentChange &$rc
+	 * @param string $s
+	 * @param RecentChange $rc
 	 */
 	public function insertUserRelatedLinks( &$s, &$rc ) {
 		if ( $this->isDeleted( $rc, Revision::DELETED_USER ) ) {
@@ -636,7 +638,7 @@ 
 
 	/**
 	 * @param RecentChange $rc
-	 * @param array $classes
+	 * @param string[] $classes
 	 * @return string
 	 * @since 1.26
 	 */
@@ -646,6 +648,10 @@ 
 		return $s;
 	}
 
+	/**
+	 * @param string $s
+	 * @param RecentChange $rc
+	 */
 	public function insertExtra( &$s, &$rc, &$classes ) {
 		// Empty, used for subclasses to add anything special.
 	}

includes/gallery/SlideshowImageGallery.php

Doc Comments +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 	}
 
 	/**
-	 * @return array
+	 * @return string[]
 	 */
 	function getOrderFields() {
 		return array( 'rd_namespace', 'rd_title', 'rd_from' );

includes/Sanitizer.php

Doc Comments +4 added lines, -4 removed lines

@@ -1206,7 +1206,7 @@ 
 	 * @since 1.27
 	 *
 	 * @param string $referenceString Space delimited list of ids
-	 * @param string|array $options String or array of strings (default is array()):
+	 * @param string $options String or array of strings (default is array()):
 	 *   'noninitial': This is a non-initial fragment of an id, not a full id,
 	 *       so don't pay attention if the first character isn't valid at the
 	 *       beginning of an id.  Only matters if $wgExperimentalHtmlIds is
@@ -1334,7 +1334,7 @@ 
 	 * Pick the appropriate attribute value from a match set from the
 	 * attribs regex matches.
 	 *
-	 * @param array $set
+	 * @param string[] $set
 	 * @throws MWException When tag conditions are not met.
 	 * @return string
 	 */
@@ -1850,7 +1850,7 @@ 
 
 	/**
 	 * @param string $url
-	 * @return mixed|string
+	 * @return string
 	 */
 	static function cleanUrl( $url ) {
 		# Normalize any HTML entities in input. They will be
@@ -1936,7 +1936,7 @@ 
 	 * @since 1.18
 	 *
 	 * @param string $addr E-mail address
-	 * @return bool
+	 * @return null|boolean
 	 */
 	public static function validateEmail( $addr ) {
 		$result = null;

includes/utils/MWGrants.php

Doc Comments +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
 
 	/**
 	 * Fetch the rights allowed by a set of grants.
-	 * @param string[]|string $grants
+	 * @param string[] $grants
 	 * @return string[]
 	 */
 	public static function getGrantRights( $grants ) {

includes/api/ApiBase.php

Doc Comments +9 added lines, -5 removed lines

@@ -421,7 +421,7 @@ 
 	 *
 	 * @since 1.24
 	 * @param array $params All supplied parameters for the module
-	 * @return string|array|null
+	 * @return string
 	 */
 	protected function getWebUITokenSalt( array $params ) {
 		return null;
@@ -627,6 +627,7 @@ 
 	/**
 	 * Set the continuation manager
 	 * @param ApiContinuationManager|null
+	 * @param ApiContinuationManager|null $manager
 	 */
 	public function setContinuationManager( $manager ) {
 		// Main module has setContinuationManager() method overridden
@@ -710,6 +711,7 @@ 
 	 *
 	 * @param array $params User provided set of parameters, as from $this->extractRequestParams()
 	 * @param string $required,... Names of parameters of which exactly one must be set
+	 * @param string $required
 	 */
 	public function requireOnlyOneParameter( $params, $required /*...*/ ) {
 		$required = func_get_args();
@@ -736,6 +738,7 @@ 
 	 *
 	 * @param array $params User provided set of parameters, as from $this->extractRequestParams()
 	 * @param string $required,... Names of parameters of which at most one must be set
+	 * @param string $required
 	 */
 	public function requireMaxOneParameter( $params, $required /*...*/ ) {
 		$required = func_get_args();
@@ -759,6 +762,7 @@ 
 	 * @since 1.23
 	 * @param array $params User provided set of parameters, as from $this->extractRequestParams()
 	 * @param string $required,... Names of parameters of which at least one must be set
+	 * @param string $required
 	 */
 	public function requireAtLeastOneParameter( $params, $required /*...*/ ) {
 		$required = func_get_args();
@@ -2543,7 +2547,7 @@ 
 	 * "apihelp-{$this->getModulePath()}-description".
 	 *
 	 * @deprecated since 1.25
-	 * @return Message|string|array
+	 * @return boolean
 	 */
 	protected function getDescription() {
 		return false;
@@ -2698,7 +2702,7 @@ 
 	 * Generates the parameter descriptions for this module, to be displayed in the
 	 * module's help.
 	 * @deprecated since 1.25
-	 * @return string|bool
+	 * @return string|false
 	 */
 	public function makeHelpMsgParameters() {
 		wfDeprecated( __METHOD__, '1.25' );
@@ -2889,7 +2893,7 @@ 
 
 	/**
 	 * @deprecated since 1.25, always returns 0
-	 * @return float
+	 * @return integer
 	 */
 	public function getProfileTime() {
 		wfDeprecated( __METHOD__, '1.25' );
@@ -2912,7 +2916,7 @@ 
 
 	/**
 	 * @deprecated since 1.25, always returns 0
-	 * @return float
+	 * @return integer
 	 */
 	public function getProfileDBTime() {
 		wfDeprecated( __METHOD__, '1.25' );