ChangePassword::execute() - Code Metrics - Inspection of "Daily Inspection: Change the way installer overrid..." - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (d1effa)

unknown

created 2016-06-09 17:40 UTC

ChangePassword::execute() C

↳ Parent: ChangePassword

Complexity

Conditions	8
Paths	60

Size

Total Lines	33
Code Lines	25

Duplication

Lines	12
Ratio	36.36 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	8
eloc	25
c	1
b	0
f	1
nc	60
nop	0
dl	12
loc	33
rs	5.3846

<?php

/**
 * Change the password of a given user
 *
 * Copyright © 2005, Ævar Arnfjörð Bjarmason
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 * @author Ævar Arnfjörð Bjarmason <[email protected]>
 * @ingroup Maintenance
 */

require_once __DIR__ . '/Maintenance.php';

/**
 * Maintenance script to change the password of a given user.
 *
 * @ingroup Maintenance
 */
class ChangePassword extends Maintenance {
	public function __construct() {
		parent::__construct();
		$this->addOption( "user", "The username to operate on", false, true );
		$this->addOption( "userid", "The user id to operate on", false, true );
		$this->addOption( "password", "The password to use", true, true );
		$this->addDescription( "Change a user's password" );
	}

	public function execute() {
		global $wgDisableAuthManager;

		if ( $this->hasOption( "user" ) ) {
			$user = User::newFromName( $this->getOption( 'user' ) );
		} elseif ( $this->hasOption( "userid" ) ) {
			$user = User::newFromId( $this->getOption( 'userid' ) );
		} else {
			$this->error( "A \"user\" or \"userid\" must be set to change the password for", true );
		}
		if ( !$user || !$user->getId() ) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			$this->error( "No such user: " . $this->getOption( 'user' ), true );
		}
		$password = $this->getOption( 'password' );
		try {
			if ( $wgDisableAuthManager ) {
				$user->setPassword( $password );
			} else {
				$status = $user->changeAuthenticationData( [
					'username' => $user->getName(),
					'password' => $password,
					'retype' => $password,
				] );
				if ( !$status->isGood() ) {
					throw new PasswordError( $status->getWikiText( null, null, 'en' ) );
				}
			}
			$user->saveSettings();
			$this->output( "Password set for " . $user->getName() . "\n" );
		} catch ( PasswordError $pwe ) {
			$this->error( $pwe->getText(), true );
		}
	}
}

$maintClass = "ChangePassword";
require_once RUN_MAINTENANCE_IF_MAIN;


1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-02-23 18:14 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 34 and the first side effect is on line 27. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		/**
3		* Change the password of a given user
4		*
5		* Copyright © 2005, Ævar Arnfjörð Bjarmason
6		*
7		* This program is free software; you can redistribute it and/or modify
8		* it under the terms of the GNU General Public License as published by
9		* the Free Software Foundation; either version 2 of the License, or
10		* (at your option) any later version.
11		*
12		* This program is distributed in the hope that it will be useful,
13		* but WITHOUT ANY WARRANTY; without even the implied warranty of
14		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15		* GNU General Public License for more details.
16		*
17		* You should have received a copy of the GNU General Public License along
18		* with this program; if not, write to the Free Software Foundation, Inc.,
19		* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
20		* http://www.gnu.org/copyleft/gpl.html
21		*
22		* @file
23		* @author Ævar Arnfjörð Bjarmason <[email protected]>
24		* @ingroup Maintenance
25		*/
26
27		require_once __DIR__ . '/Maintenance.php';
28
29		/**
30		* Maintenance script to change the password of a given user.
31		*
32		* @ingroup Maintenance
33		*/
34		class ChangePassword extends Maintenance {
35		public function __construct() {
36		parent::__construct();
37		$this->addOption( "user", "The username to operate on", false, true );
38		$this->addOption( "userid", "The user id to operate on", false, true );
39		$this->addOption( "password", "The password to use", true, true );
40		$this->addDescription( "Change a user's password" );
41		}
42
43		public function execute() {
44		global $wgDisableAuthManager;
45
46		if ( $this->hasOption( "user" ) ) {
47		$user = User::newFromName( $this->getOption( 'user' ) );
48		} elseif ( $this->hasOption( "userid" ) ) {
49		$user = User::newFromId( $this->getOption( 'userid' ) );
50		} else {
51		$this->error( "A \"user\" or \"userid\" must be set to change the password for", true );
52		}
53		if ( !$user \|\| !$user->getId() ) {
		0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report The variable `$user` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
54		$this->error( "No such user: " . $this->getOption( 'user' ), true );
55		}
56		$password = $this->getOption( 'password' );
57		try {
58	View Code Duplication	if ( $wgDisableAuthManager ) {
59		$user->setPassword( $password );
60		} else {
61		$status = $user->changeAuthenticationData( [
62		'username' => $user->getName(),
63		'password' => $password,
64		'retype' => $password,
65		] );
66		if ( !$status->isGood() ) {
67		throw new PasswordError( $status->getWikiText( null, null, 'en' ) );
68		}
69		}
70		$user->saveSettings();
71		$this->output( "Password set for " . $user->getName() . "\n" );
72		} catch ( PasswordError $pwe ) {
73		$this->error( $pwe->getText(), true );
74		}
75		}
76		}
77
78		$maintClass = "ChangePassword";
79		require_once RUN_MAINTENANCE_IF_MAIN;
80

wikimedia / mediawiki

Branch — master (d1effa)

ChangePassword::execute() C

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like