@@ -189,7 +189,7 @@ discard block |
||
| 189 | 189 | * @param float $rand Random number between 0 and 1 |
| 190 | 190 | * @param int $offset Extra offset to fudge randomness |
| 191 | 191 | * @param bool $up True to get the result above the random number, false for below |
| 192 | - * @return array Query information. |
|
| 192 | + * @return string Query information. |
|
| 193 | 193 | * @throws MWException |
| 194 | 194 | * @note The $up parameter is supposed to counteract what would happen if there |
| 195 | 195 | * was a large gap in the distribution of cl_timestamp values. This way instead |
@@ -231,7 +231,7 @@ discard block |
||
| 231 | 231 | /** |
| 232 | 232 | * @param float $rand Random number between 0 and 1 |
| 233 | 233 | * |
| 234 | - * @return int|bool A random (unix) timestamp from the range of the category or false on failure |
|
| 234 | + * @return integer A random (unix) timestamp from the range of the category or false on failure |
|
| 235 | 235 | */ |
| 236 | 236 | protected function getTimestampOffset( $rand ) { |
| 237 | 237 | if ( $rand === false ) { |
@@ -158,6 +158,9 @@ |
||
| 158 | 158 | ); |
| 159 | 159 | } |
| 160 | 160 | |
| 161 | + /** |
|
| 162 | + * @param string $randstr |
|
| 163 | + */ |
|
| 161 | 164 | private function selectRandomPageFromDB( $randstr, $fname = __METHOD__ ) { |
| 162 | 165 | $dbr = wfGetDB( DB_SLAVE ); |
| 163 | 166 | |
@@ -173,7 +173,7 @@ discard block |
||
| 173 | 173 | * Return an array of conditions depending of options set in $opts |
| 174 | 174 | * |
| 175 | 175 | * @param FormOptions $opts |
| 176 | - * @return array |
|
| 176 | + * @return string[] |
|
| 177 | 177 | */ |
| 178 | 178 | public function buildMainQueryConds( FormOptions $opts ) { |
| 179 | 179 | $dbr = $this->getDB(); |
@@ -535,7 +535,7 @@ discard block |
||
| 535 | 535 | * Creates the choose namespace selection |
| 536 | 536 | * |
| 537 | 537 | * @param FormOptions $opts |
| 538 | - * @return string |
|
| 538 | + * @return string[] |
|
| 539 | 539 | */ |
| 540 | 540 | protected function namespaceFilterForm( FormOptions $opts ) { |
| 541 | 541 | $nsSelect = Html::namespaceSelector( |
@@ -561,7 +561,7 @@ discard block |
||
| 561 | 561 | * Create an input to filter changes by categories |
| 562 | 562 | * |
| 563 | 563 | * @param FormOptions $opts |
| 564 | - * @return array |
|
| 564 | + * @return string[] |
|
| 565 | 565 | */ |
| 566 | 566 | protected function categoryFilterForm( FormOptions $opts ) { |
| 567 | 567 | list( $label, $input ) = Xml::inputLabelSep( $this->msg( 'rc_categories' )->text(), |
@@ -214,7 +214,7 @@ |
||
| 214 | 214 | /** |
| 215 | 215 | * Show the main upload form |
| 216 | 216 | * |
| 217 | - * @param HTMLForm|string $form An HTMLForm instance or HTML string to show |
|
| 217 | + * @param UploadForm $form An HTMLForm instance or HTML string to show |
|
| 218 | 218 | */ |
| 219 | 219 | protected function showUploadForm( $form ) { |
| 220 | 220 | # Add links if file was previously deleted |
@@ -57,7 +57,7 @@ discard block |
||
| 57 | 57 | * |
| 58 | 58 | * @param string $subPage Subpage, e.g. in |
| 59 | 59 | * http://example.com/wiki/Special:UploadStash/foo.jpg, the "foo.jpg" part |
| 60 | - * @return bool Success |
|
| 60 | + * @return boolean|null Success |
|
| 61 | 61 | */ |
| 62 | 62 | public function execute( $subPage ) { |
| 63 | 63 | $this->useTransactionalTimeLimit(); |
@@ -78,7 +78,7 @@ discard block |
||
| 78 | 78 | * |
| 79 | 79 | * @param string $key The key of a particular requested file |
| 80 | 80 | * @throws HttpError |
| 81 | - * @return bool |
|
| 81 | + * @return boolean|null |
|
| 82 | 82 | */ |
| 83 | 83 | public function showUpload( $key ) { |
| 84 | 84 | // prevent callers from doing standard HTML output -- we'll take it from here |
@@ -157,7 +157,7 @@ discard block |
||
| 157 | 157 | * @param File $file |
| 158 | 158 | * @param array $params |
| 159 | 159 | * |
| 160 | - * @return bool Success |
|
| 160 | + * @return boolean|null Success |
|
| 161 | 161 | */ |
| 162 | 162 | private function outputThumbFromStash( $file, $params ) { |
| 163 | 163 | $flags = 0; |
@@ -308,7 +308,7 @@ |
||
| 308 | 308 | * @param User $user |
| 309 | 309 | * @param array $oldGroups |
| 310 | 310 | * @param array $newGroups |
| 311 | - * @param array $reason |
|
| 311 | + * @param string $reason |
|
| 312 | 312 | */ |
| 313 | 313 | function addLogEntry( $user, $oldGroups, $newGroups, $reason ) { |
| 314 | 314 | $logEntry = new ManualLogEntry( 'rights', 'rights' ); |
@@ -360,7 +360,7 @@ discard block |
||
| 360 | 360 | |
| 361 | 361 | /** |
| 362 | 362 | * @since 1.22 Returns the HEAD date in addition to the sha1 and link |
| 363 | - * @return bool|string Global wgVersion + HEAD sha1 stripped to the first 7 chars |
|
| 363 | + * @return false|string Global wgVersion + HEAD sha1 stripped to the first 7 chars |
|
| 364 | 364 | * with link and date, or false on failure |
| 365 | 365 | */ |
| 366 | 366 | private static function getVersionLinkedGit() { |
@@ -934,6 +934,10 @@ discard block |
||
| 934 | 934 | } |
| 935 | 935 | } |
| 936 | 936 | |
| 937 | + /** |
|
| 938 | + * @param string $text |
|
| 939 | + * @param string $name |
|
| 940 | + */ |
|
| 937 | 941 | private function openExtType( $text = null, $name = null ) { |
| 938 | 942 | $out = ''; |
| 939 | 943 | |
@@ -1052,7 +1056,7 @@ discard block |
||
| 1052 | 1056 | * |
| 1053 | 1057 | * @since 1.23 |
| 1054 | 1058 | * |
| 1055 | - * @return bool|string False if no such file exists, otherwise returns |
|
| 1059 | + * @return false|string False if no such file exists, otherwise returns |
|
| 1056 | 1060 | * a path to it. |
| 1057 | 1061 | */ |
| 1058 | 1062 | public static function getExtAuthorsFileName( $extDir ) { |
@@ -1081,7 +1085,7 @@ discard block |
||
| 1081 | 1085 | * |
| 1082 | 1086 | * @since 1.23 |
| 1083 | 1087 | * |
| 1084 | - * @return bool|string False if no such file exists, otherwise returns |
|
| 1088 | + * @return false|string False if no such file exists, otherwise returns |
|
| 1085 | 1089 | * a path to it. |
| 1086 | 1090 | */ |
| 1087 | 1091 | public static function getExtLicenseFileName( $extDir ) { |
@@ -293,6 +293,9 @@ discard block |
||
| 293 | 293 | ); |
| 294 | 294 | } |
| 295 | 295 | |
| 296 | + /** |
|
| 297 | + * @param FormOptions $opts |
|
| 298 | + */ |
|
| 296 | 299 | protected function runMainQueryHook( &$tables, &$fields, &$conds, &$query_options, |
| 297 | 300 | &$join_conds, $opts |
| 298 | 301 | ) { |
@@ -516,6 +519,9 @@ discard block |
||
| 516 | 519 | $this->setBottomText( $opts ); |
| 517 | 520 | } |
| 518 | 521 | |
| 522 | + /** |
|
| 523 | + * @param FormOptions $options |
|
| 524 | + */ |
|
| 519 | 525 | function cutoffselector( $options ) { |
| 520 | 526 | // Cast everything to strings immediately, so that we know all of the values have the same |
| 521 | 527 | // precision, and can be compared with '==='. 2/24 has a few more decimal places than its |
@@ -625,7 +631,7 @@ discard block |
||
| 625 | 631 | * Count the number of items on a user's watchlist |
| 626 | 632 | * |
| 627 | 633 | * @param IDatabase $dbr A database connection |
| 628 | - * @return int |
|
| 634 | + * @return double |
|
| 629 | 635 | */ |
| 630 | 636 | protected function countItems( $dbr ) { |
| 631 | 637 | # Fetch the raw count |
@@ -303,10 +303,17 @@ discard block |
||
| 303 | 303 | } |
| 304 | 304 | } |
| 305 | 305 | |
| 306 | + /** |
|
| 307 | + * @param integer $level |
|
| 308 | + */ |
|
| 306 | 309 | protected function listStart( $level ) { |
| 307 | 310 | return Xml::openElement( 'ul', ( $level ? array() : array( 'id' => 'mw-whatlinkshere-list' ) ) ); |
| 308 | 311 | } |
| 309 | 312 | |
| 313 | + /** |
|
| 314 | + * @param Title $nt |
|
| 315 | + * @param Title $target |
|
| 316 | + */ |
|
| 310 | 317 | protected function listItem( $row, $nt, $target, $notClose = false ) { |
| 311 | 318 | $dirmark = $this->getLanguage()->getDirMark(); |
| 312 | 319 | |
@@ -405,6 +412,9 @@ discard block |
||
| 405 | 412 | return $this->getLanguage()->pipeList( $links ); |
| 406 | 413 | } |
| 407 | 414 | |
| 415 | + /** |
|
| 416 | + * @param string $text |
|
| 417 | + */ |
|
| 408 | 418 | function makeSelfLink( $text, $query ) { |
| 409 | 419 | return Linker::linkKnown( |
| 410 | 420 | $this->selfTitle, |
@@ -414,6 +424,9 @@ discard block |
||
| 414 | 424 | ); |
| 415 | 425 | } |
| 416 | 426 | |
| 427 | + /** |
|
| 428 | + * @param integer $prevId |
|
| 429 | + */ |
|
| 417 | 430 | function getPrevNext( $prevId, $nextId ) { |
| 418 | 431 | $currentLimit = $this->opts->getValue( 'limit' ); |
| 419 | 432 | $prev = $this->msg( 'whatlinkshere-prev' )->numParams( $currentLimit )->escaped(); |