wikimedia / mediawiki

includes/resourceloader/ResourceLoaderWikiModule.php

Doc Comments +3 added lines, -3 removed lines

@@ -136,14 +136,14 @@ 
 	 * NOTE: This ONLY works for getTitleInfo() and isKnownEmpty(), NOT FOR ANYTHING ELSE.
 	 * In particular, it doesn't work for getContent() or getScript() etc.
 	 *
-	 * @return IDatabase|null
+	 * @return DatabaseBase|null
 	 */
 	protected function getDB() {
 		return wfGetDB( DB_REPLICA );
 	}
 
 	/**
-	 * @param string $title
+	 * @param string $titleText
 	 * @return null|string
 	 */
 	protected function getContent( $titleText ) {
@@ -332,7 +332,7 @@ 
 	 * @since 1.28
 	 * @param ResourceLoaderContext $context
 	 * @param IDatabase $db
-	 * @param string[] $modules
+	 * @param string[] $moduleNames
 	 */
 	public static function preloadTitleInfo(
 		ResourceLoaderContext $context, IDatabase $db, array $moduleNames

includes/Revision.php

Doc Comments +8 added lines, -8 removed lines

@@ -436,7 +436,7 @@ 
 	/**
 	 * Return the list of revision fields that should be selected to create
 	 * a new revision.
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectFields() {
 		global $wgContentHandlerUseDB;
@@ -467,7 +467,7 @@ 
 	/**
 	 * Return the list of revision fields that should be selected to create
 	 * a new revision from an archive row.
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectArchiveFields() {
 		global $wgContentHandlerUseDB;
@@ -498,7 +498,7 @@ 
 	/**
 	 * Return the list of text fields that should be selected to read the
 	 * revision text
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectTextFields() {
 		return [
@@ -509,7 +509,7 @@ 
 
 	/**
 	 * Return the list of page fields that should be selected from page table
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectPageFields() {
 		return [
@@ -524,7 +524,7 @@ 
 
 	/**
 	 * Return the list of user fields that should be selected from user table
-	 * @return array
+	 * @return string[]
 	 */
 	public static function selectUserFields() {
 		return [ 'user_name' ];
@@ -872,7 +872,7 @@ 
 	/**
 	 * Fetch revision's user id without regard for the current user's permissions
 	 *
-	 * @return string
+	 * @return integer
 	 * @deprecated since 1.25, use getUser( Revision::RAW )
 	 */
 	public function getRawUser() {
@@ -1795,7 +1795,7 @@ 
 	 *
 	 * @param Title $title
 	 * @param int $id
-	 * @return string|bool False if not found
+	 * @return string|false False if not found
 	 */
 	static function getTimestampFromId( $title, $id, $flags = 0 ) {
 		$db = ( $flags & self::READ_LATEST )
@@ -1894,7 +1894,7 @@ 
 	 * @param IDatabase $db
 	 * @param int $pageId Page ID
 	 * @param int $revId Known current revision of this page
-	 * @return Revision|bool Returns false if missing
+	 * @return Revision Returns false if missing
 	 * @since 1.28
 	 */
 	public static function newKnownCurrent( IDatabase $db, $pageId, $revId ) {

includes/revisiondelete/RevisionDeleteUser.php

Doc Comments +11 added lines

@@ -126,16 +126,27 @@
 		return true;
 	}
 
+	/**
+	 * @param string $field
+	 * @param string $op
+	 * @param null|IDatabase $dbw
+	 */
 	private static function buildSetBitDeletedField( $field, $op, $value, $dbw ) {
 		return $field . ' = ' . ( $op === '&'
 			? $dbw->bitAnd( $field, $value )
 			: $dbw->bitOr( $field, $value ) );
 	}
 
+	/**
+	 * @param integer $userId
+	 */
 	public static function suppressUserName( $name, $userId, $dbw = null ) {
 		return self::setUsernameBitfields( $name, $userId, '|', $dbw );
 	}
 
+	/**
+	 * @param integer|null $userId
+	 */
 	public static function unsuppressUserName( $name, $userId, $dbw = null ) {
 		return self::setUsernameBitfields( $name, $userId, '&', $dbw );
 	}

includes/SiteStats.php

Doc Comments +1 added lines, -1 removed lines

@@ -371,7 +371,7 @@
 	 * Do all updates and commit them. More or less a replacement
 	 * for the original initStats, but without output.
 	 *
-	 * @param IDatabase|bool $database
+	 * @param DatabaseBase|null $database
 	 * - boolean: Whether to use the master DB
 	 * - IDatabase: Database connection to use
 	 * @param array $options Array of options, may contain the following values

includes/specialpage/ChangesListSpecialPage.php

Doc Comments +2 added lines, -2 removed lines

@@ -107,7 +107,7 @@ 
 	/**
 	 * Create a FormOptions object with options as specified by the user
 	 *
-	 * @param array $parameters
+	 * @param string $parameters
 	 *
 	 * @return FormOptions
 	 */
@@ -337,7 +337,7 @@ 
 	/**
 	 * Return a IDatabase object for reading
 	 *
-	 * @return IDatabase
+	 * @return DatabaseBase|null
 	 */
 	protected function getDB() {
 		return wfGetDB( DB_REPLICA );

includes/specialpage/QueryPage.php

Doc Comments +7 added lines, -4 removed lines

@@ -161,7 +161,7 @@ 
 	 * Subclasses return an array of fields to order by here. Don't append
 	 * DESC to the field names, that'll be done automatically if
 	 * sortDescending() returns true.
-	 * @return array
+	 * @return string[]
 	 * @since 1.18
 	 */
 	function getOrderFields() {
@@ -373,7 +373,7 @@ 
 
 	/**
 	 * Get a DB connection to be used for slow recache queries
-	 * @return IDatabase
+	 * @return DatabaseBase|null
 	 */
 	function getRecacheDB() {
 		return wfGetDB( DB_REPLICA, [ $this->getName(), 'QueryPage::recache', 'vslow' ] );
@@ -434,7 +434,7 @@ 
 	/**
 	 * Somewhat deprecated, you probably want to be using execute()
 	 * @param int|bool $offset
-	 * @param int|bool $limit
+	 * @param integer $limit
 	 * @return ResultWrapper
 	 */
 	public function doQuery( $offset = false, $limit = false ) {
@@ -775,7 +775,7 @@ 
 	/**
 	 * Override for custom handling. If the titles/links are ok, just do
 	 * feedItemDesc()
-	 * @param object $row
+	 * @param null|stdClass $row
 	 * @return FeedItem|null
 	 */
 	function feedResult( $row ) {
@@ -807,6 +807,9 @@ 
 		return isset( $row->comment ) ? htmlspecialchars( $row->comment ) : '';
 	}
 
+	/**
+	 * @return string
+	 */
 	function feedItemAuthor( $row ) {
 		return isset( $row->user_text ) ? $row->user_text : '';
 	}

includes/specials/pagers/DeletedContribsPager.php

Doc Comments +4 added lines, -1 removed lines

@@ -35,6 +35,9 @@ 
 	 */
 	protected $mNavigationBar;
 
+	/**
+	 * @param string|null $target
+	 */
 	function __construct( IContextSource $context, $target, $namespace = false ) {
 		parent::__construct( $context );
 		$msgs = [ 'deletionlog', 'undeleteviewlink', 'diff' ];
@@ -347,7 +350,7 @@ 
 	/**
 	 * Get the Database object in use
 	 *
-	 * @return IDatabase
+	 * @return DatabaseBase|null
 	 */
 	public function getDatabase() {
 		return $this->mDb;

includes/specials/SpecialWatchlist.php

Doc Comments +8 added lines, -2 removed lines

@@ -296,6 +296,9 @@ 
 		);
 	}
 
+	/**
+	 * @param FormOptions $opts
+	 */
 	protected function runMainQueryHook( &$tables, &$fields, &$conds, &$query_options,
 		&$join_conds, $opts
 	) {
@@ -310,7 +313,7 @@ 
 	/**
 	 * Return a IDatabase object for reading
 	 *
-	 * @return IDatabase
+	 * @return DatabaseBase|null
 	 */
 	protected function getDB() {
 		return wfGetDB( DB_REPLICA, 'watchlist' );
@@ -534,6 +537,9 @@ 
 		$this->setBottomText( $opts );
 	}
 
+	/**
+	 * @param FormOptions $options
+	 */
 	function cutoffselector( $options ) {
 		// Cast everything to strings immediately, so that we know all of the values have the same
 		// precision, and can be compared with '==='. 2/24 has a few more decimal places than its
@@ -648,7 +654,7 @@ 
 	 * The assumption made here is that when a subject page is watched a talk page is also watched.
 	 * Hence the number of individual items is halved.
 	 *
-	 * @return int
+	 * @return double
 	 */
 	protected function countItems() {
 		$store = MediaWikiServices::getInstance()->getWatchedItemStore();

maintenance/cleanupImages.php

Doc Comments +6 added lines

@@ -117,10 +117,16 @@
 		return $this->repo->getRootDirectory() . '/' . $this->repo->getHashPath( $name ) . $name;
 	}
 
+	/**
+	 * @param Database|null $db
+	 */
 	private function imageExists( $name, $db ) {
 		return $db->selectField( 'image', '1', [ 'img_name' => $name ], __METHOD__ );
 	}
 
+	/**
+	 * @param Database|null $db
+	 */
 	private function pageExists( $name, $db ) {
 		return $db->selectField(
 			'page',