wikimedia / mediawiki

includes/specialpage/AuthManagerSpecialPage.php

Doc Comments +3 added lines, -2 removed lines

@@ -197,7 +197,7 @@ 
 	 * Get the default action for this special page, if none is given via URL/POST data.
 	 * Subclasses should override this (or override loadAuth() so this is never called).
 	 * @param string $subPage Subpage of the special page.
-	 * @return string an AuthManager::ACTION_* constant.
+	 * @return string|null an AuthManager::ACTION_* constant.
 	 */
 	protected function getDefaultAction( $subPage ) {
 		throw new BadMethodCallException( 'Subclass did not implement getDefaultAction' );
@@ -206,6 +206,7 @@ 
 	/**
 	 * Return custom message key.
 	 * Allows subclasses to customize messages.
+	 * @param string $defaultKey
 	 * @return string
 	 */
 	protected function messageKey( $defaultKey ) {
@@ -708,7 +709,7 @@ 
 	 * Get an array value, or a default if it does not exist.
 	 * @param array $array
 	 * @param string $fieldName
-	 * @param mixed $default
+	 * @param integer $default
 	 * @return mixed
 	 */
 	protected static function getField( array $array, $fieldName, $default = null ) {

includes/specialpage/LoginSignupSpecialPage.php

Doc Comments +11 added lines, -2 removed lines

@@ -81,6 +81,9 @@ 
 	 */
 	abstract protected function logAuthResult( $success, $status = null );
 
+	/**
+	 * @param string $name
+	 */
 	public function __construct( $name ) {
 		global $wgUseMediaWikiUIEverywhere;
 		parent::__construct( $name );
@@ -342,7 +345,7 @@ 
 	 * Show the success page.
 	 *
 	 * @param string $type Condition of return to; see `executeReturnTo`
-	 * @param string|Message $title Page's title
+	 * @param Message $title Page's title
 	 * @param string $msgname
 	 * @param string $injected_html
 	 * @param StatusValue|null $extraMessages
@@ -391,7 +394,6 @@ 
 	/**
 	 * Replace some globals to make sure the fact that the user has just been logged in is
 	 * reflected in the current request.
-	 * @param User $user
 	 */
 	protected function setSessionUserForCurrentRequest() {
 		global $wgUser, $wgLang;
@@ -1322,6 +1324,9 @@ 
 class LoginForm extends SpecialPage {
 	private $realLoginForm;
 
+	/**
+	 * @param DerivativeRequest $request
+	 */
 	public function __construct( $request = null ) {
 		global $wgDisableAuthManager;
 		if ( $wgDisableAuthManager ) {
@@ -1418,6 +1423,10 @@ 
 	function getPageTitle( $subpage = false ) {
 		return call_user_func_array( [ $this->realLoginForm, __FUNCTION__ ], func_get_args() );
 	}
+
+	/**
+	 * @param IContextSource $context
+	 */
 	public function setContext( $context ) {
 		return call_user_func_array( [ $this->realLoginForm, __FUNCTION__ ], func_get_args() );
 	}

includes/specials/helpers/LoginHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 	}
 
 	/**
-	 * @return array
+	 * @return string[]
 	 */
 	function getOrderFields() {
 		return array( 'rd_namespace', 'rd_title', 'rd_from' );

includes/specials/pre-authmanager/SpecialUserlogin.php

Doc Comments +3 added lines, -3 removed lines

@@ -136,7 +136,7 @@ 
 	/**
 	 * Returns an array of all valid error messages.
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	public static function getValidErrorMessages() {
 		static $messages = null;
@@ -1222,7 +1222,7 @@ 
 	 * Display a "successful action" page.
 	 *
 	 * @param string $type Condition of return to; see `executeReturnTo`
-	 * @param string|Message $title Page's title
+	 * @param Message $title Page's title
 	 * @param string $msgname
 	 * @param string $injected_html
 	 */
@@ -1735,7 +1735,7 @@ 
 	 * Private function to check password expiration, until AuthManager comes
 	 * along to handle that.
 	 * @param User $user
-	 * @return string|bool
+	 * @return string|false
 	 */
 	private function checkUserPasswordExpired( User $user ) {
 		global $wgPasswordExpireGrace;

includes/diff/DairikiDiff.php

Doc Comments +1 added lines, -1 removed lines

@@ -232,7 +232,7 @@
 	 *    $diff = new Diff($lines1, $lines2);
 	 *    $rev = $diff->reverse();
 	 *
-	 * @return Object A Diff object representing the inverse of the
+	 * @return Diff A Diff object representing the inverse of the
 	 *   original diff.
 	 */
 	public function reverse() {

includes/diff/DiffEngine.php

Doc Comments +18 added lines

@@ -222,6 +222,13 @@ 
 		return $ranges;
 	}
 
+	/**
+	 * @param integer $bottoml1
+	 * @param integer $topl1
+	 * @param integer $bottoml2
+	 * @param integer $topl2
+	 * @param integer[] $snake
+	 */
 	private function lcs_rec( $bottoml1, $topl1, $bottoml2, $topl2, &$V, &$snake ) {
 		// check that both sequences are non-empty
 		if ( $bottoml1 > $topl1 || $bottoml2 > $topl2 ) {
@@ -490,6 +497,11 @@ 
 		*/
 	}
 
+	/**
+	 * @param double $M
+	 * @param double $N
+	 * @param double $limit
+	 */
 	private static function findMostProgress( $M, $N, $limit, $V ) {
 		$delta = $N - $M;
 
@@ -609,6 +621,12 @@ 
 	/** @var int */
 	public $rightlength;
 
+	/**
+	 * @param integer $leftstart
+	 * @param integer $leftend
+	 * @param integer $rightstart
+	 * @param integer $rightend
+	 */
 	function __construct( $leftstart, $leftend, $rightstart, $rightend ) {
 		$this->leftstart = $leftstart;
 		$this->leftend = $leftend;

includes/interwiki/ClassicInterwikiLookup.php

Doc Comments +3 added lines

@@ -112,6 +112,9 @@
 		}
 	}
 
+	/**
+	 * @return string
+	 */
 	function stripParameters( $text ) {
 		if ( !$this->stripParametersEnabled ) {
 			return $text;

includes/linker/LinkRenderer.php

Doc Comments +4 added lines, -1 removed lines

@@ -98,7 +98,7 @@ 
 	}
 
 	/**
-	 * @param string|bool|int $expand A PROTO_* constant or false
+	 * @param string $expand A PROTO_* constant or false
 	 */
 	public function setExpandURLs( $expand ) {
 		$this->expandUrls = $expand;
@@ -189,6 +189,9 @@ 
 		return $options;
 	}
 
+	/**
+	 * @param boolean $isKnown
+	 */
 	private function runBeginHook( LinkTarget $target, &$text, &$extraAttribs, &$query, $isKnown ) {
 		$ret = null;
 		if ( !Hooks::run( 'HtmlPageLinkRendererBegin',

includes/resourceloader/ResourceLoaderFileModule.php

Doc Comments +3 added lines, -2 removed lines

@@ -381,7 +381,7 @@ 
 	 * Get all styles for a given context.
 	 *
 	 * @param ResourceLoaderContext $context
-	 * @return array CSS code for $context as an associative array mapping media type to CSS text.
+	 * @return string CSS code for $context as an associative array mapping media type to CSS text.
 	 */
 	public function getStyles( ResourceLoaderContext $context ) {
 		$styles = $this->readStyleFiles(
@@ -631,7 +631,7 @@ 
 	 * @param array $list List of file paths in any combination of index/path
 	 *     or path/options pairs
 	 * @param string $option Option name
-	 * @param mixed $default Default value if the option isn't set
+	 * @param string $default Default value if the option isn't set
 	 * @return array List of file paths, collated by $option
 	 */
 	protected static function collateFilePathListByOption( array $list, $option, $default ) {
@@ -1007,6 +1007,7 @@ 
 	 * the BOM character is not valid in the middle of a string.
 	 * We already assume UTF-8 everywhere, so this should be safe.
 	 *
+	 * @param string $input
 	 * @return string input minus the intial BOM char
 	 */
 	protected function stripBom( $input ) {