Completed
Branch master (37eb21)
by
unknown
25:17
created
includes/session/CookieSessionProvider.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -302,8 +302,8 @@
 block discarded – undo
302 302
 	 * @param \WebRequest $request
303 303
 	 * @param string $key
304 304
 	 * @param string $prefix
305
-	 * @param mixed $default
306
-	 * @return mixed
305
+	 * @param boolean $default
306
+	 * @return string
307 307
 	 */
308 308
 	protected function getCookie( $request, $key, $prefix, $default = null ) {
309 309
 		$value = $request->getCookie( $key, $prefix, $default );
Please login to merge, or discard this patch.
includes/db/loadbalancer/LoadBalancer.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
 	 * @param string|bool $group Query group, or false for the generic reader
233 233
 	 * @param string|bool $wiki Wiki ID, or false for the current wiki
234 234
 	 * @throws MWException
235
-	 * @return bool|int|string
235
+	 * @return string
236 236
 	 */
237 237
 	public function getReaderIndex( $group = false, $wiki = false ) {
238 238
 		global $wgDBtype;
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
437 437
 	 * Returns false if there is no connection open
438 438
 	 *
439 439
 	 * @param int $i
440
-	 * @return DatabaseBase|bool False on failure
440
+	 * @return DatabaseBase|null False on failure
441 441
 	 */
442 442
 	public function getAnyOpenConnection( $i ) {
443 443
 		foreach ( $this->mConns as $conns ) {
@@ -968,7 +968,7 @@  discard block
 block discarded – undo
968 968
 
969 969
 	/**
970 970
 	 * Get the current master position for chronology control purposes
971
-	 * @return mixed
971
+	 * @return DBMasterPos
972 972
 	 */
973 973
 	public function getMasterPos() {
974 974
 		# If this entire request was served from a slave without opening a connection to the
@@ -1289,7 +1289,7 @@  discard block
 block discarded – undo
1289 1289
 	/**
1290 1290
 	 * Call a function with each open connection object
1291 1291
 	 * @param callable $callback
1292
-	 * @param array $params
1292
+	 * @param string[] $params
1293 1293
 	 */
1294 1294
 	public function forEachOpenConnection( $callback, array $params = [] ) {
1295 1295
 		foreach ( $this->mConns as $conns2 ) {
@@ -1364,7 +1364,7 @@  discard block
 block discarded – undo
1364 1364
 	 * case on many installations.
1365 1365
 	 *
1366 1366
 	 * @param IDatabase $conn
1367
-	 * @return int|bool Returns false on error
1367
+	 * @return integer Returns false on error
1368 1368
 	 */
1369 1369
 	public function safeGetLag( IDatabase $conn ) {
1370 1370
 		if ( $this->getServerCount() == 1 ) {
Please login to merge, or discard this patch.
includes/search/SearchSuggestion.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,9 +55,9 @@
 block discarded – undo
55 55
 	/**
56 56
 	 * Construct a new suggestion
57 57
 	 * @param float $score the suggestion score
58
-	 * @param string $text|null the suggestion text
59 58
 	 * @param Title|null $suggestedTitle the suggested title
60 59
 	 * @param int|null $suggestedTitleID the suggested title ID
60
+	 * @param string $text
61 61
 	 */
62 62
 	public function __construct( $score, $text = null, Title $suggestedTitle = null,
63 63
 			$suggestedTitleID = null ) {
Please login to merge, or discard this patch.
includes/WebRequest.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
 	 * This is for use prior to Setup.php, when no WebRequest object is available.
224 224
 	 * At other times, use the non-static function getProtocol().
225 225
 	 *
226
-	 * @return array
226
+	 * @return string
227 227
 	 */
228 228
 	public static function detectProtocol() {
229 229
 		if ( ( !empty( $_SERVER['HTTPS'] ) && $_SERVER['HTTPS'] !== 'off' ) ||
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
 	 * Set an arbitrary value into our get/post data.
382 382
 	 *
383 383
 	 * @param string $key Key name to use
384
-	 * @param mixed $value Value to set
384
+	 * @param string $value Value to set
385 385
 	 * @return mixed Old value if one was present, null otherwise
386 386
 	 */
387 387
 	public function setVal( $key, $value ) {
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
 	/**
570 570
 	 * Returns the names of all input values excluding those in $exclude.
571 571
 	 *
572
-	 * @param array $exclude
572
+	 * @param string[] $exclude
573 573
 	 * @return array
574 574
 	 */
575 575
 	public function getValueNames( $exclude = [] ) {
@@ -698,7 +698,7 @@  discard block
 block discarded – undo
698 698
 	 * @param string $key The name of the cookie
699 699
 	 * @param string $prefix A prefix to use for the cookie name, if not $wgCookiePrefix
700 700
 	 * @param mixed $default What to return if the value isn't found
701
-	 * @return mixed Cookie value or $default if the cookie not set
701
+	 * @return string Cookie value or $default if the cookie not set
702 702
 	 */
703 703
 	public function getCookie( $key, $prefix = null, $default = null ) {
704 704
 		if ( $prefix === null ) {
Please login to merge, or discard this patch.
includes/MagicWordArray.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -771,7 +771,7 @@  discard block
 block discarded – undo
771 771
 
772 772
 	/**
773 773
 	 * Get the base regex
774
-	 * @return array
774
+	 * @return string[]
775 775
 	 */
776 776
 	function getBaseRegex() {
777 777
 		if ( is_null( $this->baseRegex ) ) {
@@ -815,7 +815,7 @@  discard block
 block discarded – undo
815 815
 	/**
816 816
 	 * Get a regex for matching variables with parameters
817 817
 	 *
818
-	 * @return string
818
+	 * @return string[]
819 819
 	 */
820 820
 	function getVariableRegex() {
821 821
 		return str_replace( "\\$1", "(.*?)", $this->getRegex() );
@@ -868,7 +868,7 @@  discard block
 block discarded – undo
868 868
 	 * Returns array(magic word ID, parameter value)
869 869
 	 * If there is no parameter value, that element will be false.
870 870
 	 *
871
-	 * @param array $m
871
+	 * @param string[] $m
872 872
 	 *
873 873
 	 * @throws MWException
874 874
 	 * @return array
Please login to merge, or discard this patch.
includes/logging/PatrolLog.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 	/**
31 31
 	 * Record a log event for a change being patrolled
32 32
 	 *
33
-	 * @param int|RecentChange $rc Change identifier or RecentChange object
33
+	 * @param RecentChange $rc Change identifier or RecentChange object
34 34
 	 * @param bool $auto Was this patrol event automatic?
35 35
 	 * @param User $user User performing the action or null to use $wgUser
36 36
 	 * @param string|string[] $tags Change tags to add to the patrol log entry
Please login to merge, or discard this patch.
maintenance/findHooks.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -296,7 +296,7 @@
 block discarded – undo
296 296
 	/**
297 297
 	 * Get hooks from a directory of PHP files.
298 298
 	 * @param string $dir Directory path to start at
299
-	 * @param int $recursive Pass self::FIND_RECURSIVE
299
+	 * @param int $recurse Pass self::FIND_RECURSIVE
300 300
 	 * @return array Array: key => hook name; value => array of arguments or string 'unknown'
301 301
 	 */
302 302
 	private function getHooksFromDir( $dir, $recurse = 0 ) {
Please login to merge, or discard this patch.
includes/WatchedItemStore.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -410,6 +410,11 @@
 block discarded – undo
410 410
 		return true;
411 411
 	}
412 412
 
413
+	/**
414
+	 * @param WatchedItem|null $item
415
+	 * @param string $force
416
+	 * @param integer $oldid
417
+	 */
413 418
 	private function getNotificationTimestamp( User $user, Title $title, $item, $force, $oldid ) {
414 419
 		if ( !$oldid ) {
415 420
 			// No oldid given, assuming latest revision; clear the timestamp.
Please login to merge, or discard this patch.
includes/filerepo/FileRepo.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
 	 * Get an explanatory message if this repo is read-only.
221 221
 	 * This checks if an administrator disabled writes to the backend.
222 222
 	 *
223
-	 * @return string|bool Returns false if the repo is not read-only
223
+	 * @return string|false Returns false if the repo is not read-only
224 224
 	 */
225 225
 	public function getReadOnlyReason() {
226 226
 		return $this->backend->getReadOnlyReason();
@@ -716,7 +716,7 @@  discard block
 block discarded – undo
716 716
 	 *
717 717
 	 * @param string $query Query string to append
718 718
 	 * @param string $entry Entry point; defaults to index
719
-	 * @return string|bool False on failure
719
+	 * @return string|false False on failure
720 720
 	 */
721 721
 	public function makeUrl( $query = '', $entry = 'index' ) {
722 722
 		if ( isset( $this->scriptDirUrl ) ) {
@@ -797,7 +797,7 @@  discard block
 block discarded – undo
797 797
 	/**
798 798
 	 * Get the URL of the stylesheet to apply to description pages
799 799
 	 *
800
-	 * @return string|bool False on failure
800
+	 * @return string|false False on failure
801 801
 	 */
802 802
 	public function getDescriptionStylesheetUrl() {
803 803
 		if ( isset( $this->scriptDirUrl ) ) {
@@ -958,7 +958,7 @@  discard block
 block discarded – undo
958 958
 	 *
959 959
 	 * @param string|FSFile $src Source file system path, storage path, or virtual URL
960 960
 	 * @param string $dst Virtual URL or storage path
961
-	 * @param array|string|null $options An array consisting of a key named headers
961
+	 * @param string $options An array consisting of a key named headers
962 962
 	 *   listing extra headers. If a string, taken as content-disposition header.
963 963
 	 *   (Support for array of options new in 1.23)
964 964
 	 * @return FileRepoStatus
@@ -1158,7 +1158,7 @@  discard block
 block discarded – undo
1158 1158
 	 * Options to $options include:
1159 1159
 	 *   - headers : name/value map of HTTP headers to use in response to GET/HEAD requests
1160 1160
 	 *
1161
-	 * @param string|FSFile $src The source file system path, storage path, or URL
1161
+	 * @param string $src The source file system path, storage path, or URL
1162 1162
 	 * @param string $dstRel The destination relative path
1163 1163
 	 * @param string $archiveRel The relative path where the existing file is to
1164 1164
 	 *   be archived, if there is one. Relative to the public zone root.
Please login to merge, or discard this patch.