Issues in TitleInputWidget.php - All Issues - Inspection of "Daily Inspection: Merge "Add GENDER support to pro..." - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (939199)

unknown

created 2016-11-04 17:19 UTC

includes/widget/TitleInputWidget.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Amir E. Aharoni 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * MediaWiki Widgets – TitleInputWidget class.
 *
 * @copyright 2011-2015 MediaWiki Widgets Team and others; see AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
 */
namespace MediaWiki\Widget;

/**
 * Title input widget.
 */
class TitleInputWidget extends \OOUI\TextInputWidget {

	protected $namespace = null;
	protected $relative = null;
	protected $suggestions = null;
	protected $highlightFirst = null;
	protected $validateTitle = null;

	/**
	 * @param array $config Configuration options
	 * @param int|null $config['namespace'] Namespace to prepend to queries
	 * @param bool|null $config['relative'] If a namespace is set,
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
	 *  return a title relative to it (default: true)
	 * @param bool|null $config['suggestions'] Display search suggestions (default: true)
	 * @param bool|null $config['highlightFirst'] Automatically highlight
	 *  the first result (default: true)
	 * @param bool|null $config['validateTitle'] Whether the input must
	 *  be a valid title (default: true)
	 */
	public function __construct( array $config = [] ) {
		// Parent constructor
		parent::__construct(
			array_merge( [ 'maxLength' => 255 ], $config )
		);

		// Properties, which are ignored in PHP and just shipped back to JS
		if ( isset( $config['namespace'] ) ) {
			$this->namespace = $config['namespace'];
		}
		if ( isset( $config['relative'] ) ) {
			$this->relative = $config['relative'];
		}
		if ( isset( $config['suggestions'] ) ) {
			$this->suggestions = $config['suggestions'];
		}
		if ( isset( $config['highlightFirst'] ) ) {
			$this->highlightFirst = $config['highlightFirst'];
		}
		if ( isset( $config['validateTitle'] ) ) {
			$this->validateTitle = $config['validateTitle'];
		}

		// Initialization
		$this->addClasses( [ 'mw-widget-titleInputWidget' ] );
	}

	protected function getJavaScriptClassName() {
		return 'mw.widgets.TitleInputWidget';
	}

	public function getConfig( &$config ) {
		if ( $this->namespace !== null ) {
			$config['namespace'] = $this->namespace;
		}
		if ( $this->relative !== null ) {
			$config['relative'] = $this->relative;
		}
		if ( $this->suggestions !== null ) {
			$config['suggestions'] = $this->suggestions;
		}
		if ( $this->highlightFirst !== null ) {
			$config['highlightFirst'] = $this->highlightFirst;
		}
		if ( $this->validateTitle !== null ) {
			$config['validateTitle'] = $this->validateTitle;
		}
		return parent::getConfig( $config );
	}
}


1			<?php
2			/**
3			* MediaWiki Widgets – TitleInputWidget class.
4			*
5			* @copyright 2011-2015 MediaWiki Widgets Team and others; see AUTHORS.txt
6			* @license The MIT License (MIT); see LICENSE.txt
7			*/
8			namespace MediaWiki\Widget;
9
10			/**
11			* Title input widget.
12			*/
13			class TitleInputWidget extends \OOUI\TextInputWidget {
14
15			protected $namespace = null;
16			protected $relative = null;
17			protected $suggestions = null;
18			protected $highlightFirst = null;
19			protected $validateTitle = null;
20
21			/**
22			* @param array $config Configuration options
23			* @param int\|null $config['namespace'] Namespace to prepend to queries
24			* @param bool\|null $config['relative'] If a namespace is set,
			0 ignored issues – show Documentation introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$config['relative']`. Did you maybe mean `$config`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
25			* return a title relative to it (default: true)
26			* @param bool\|null $config['suggestions'] Display search suggestions (default: true)
27			* @param bool\|null $config['highlightFirst'] Automatically highlight
28			* the first result (default: true)
29			* @param bool\|null $config['validateTitle'] Whether the input must
30			* be a valid title (default: true)
31			*/
32			public function __construct( array $config = [] ) {
33			// Parent constructor
34			parent::__construct(
35			array_merge( [ 'maxLength' => 255 ], $config )
36			);
37
38			// Properties, which are ignored in PHP and just shipped back to JS
39			if ( isset( $config['namespace'] ) ) {
40			$this->namespace = $config['namespace'];
41			}
42			if ( isset( $config['relative'] ) ) {
43			$this->relative = $config['relative'];
44			}
45			if ( isset( $config['suggestions'] ) ) {
46			$this->suggestions = $config['suggestions'];
47			}
48			if ( isset( $config['highlightFirst'] ) ) {
49			$this->highlightFirst = $config['highlightFirst'];
50			}
51			if ( isset( $config['validateTitle'] ) ) {
52			$this->validateTitle = $config['validateTitle'];
53			}
54
55			// Initialization
56			$this->addClasses( [ 'mw-widget-titleInputWidget' ] );
57			}
58
59			protected function getJavaScriptClassName() {
60			return 'mw.widgets.TitleInputWidget';
61			}
62
63			public function getConfig( &$config ) {
64			if ( $this->namespace !== null ) {
65			$config['namespace'] = $this->namespace;
66			}
67			if ( $this->relative !== null ) {
68			$config['relative'] = $this->relative;
69			}
70			if ( $this->suggestions !== null ) {
71			$config['suggestions'] = $this->suggestions;
72			}
73			if ( $this->highlightFirst !== null ) {
74			$config['highlightFirst'] = $this->highlightFirst;
75			}
76			if ( $this->validateTitle !== null ) {
77			$config['validateTitle'] = $this->validateTitle;
78			}
79			return parent::getConfig( $config );
80			}
81			}
82

wikimedia / mediawiki

Branch — master (939199)

includes/widget/TitleInputWidget.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like