Issues in ComposerInstalled.php - All Issues - Inspection of "Daily Inspection: Merge "Add GENDER support to pro..." - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (939199)

unknown

created 2016-11-04 17:19 UTC

includes/libs/composer/ComposerInstalled.php (2 issues)

Labels

Severity

Perside Rosalie 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Reads an installed.json file and provides accessors to get what is
 * installed
 *
 * @since 1.27
 */
class ComposerInstalled {


	/**
	 * @param string $location
	 */
	public function __construct( $location ) {
		$this->contents = json_decode( file_get_contents( $location ), true );
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	/**
	 * Dependencies currently installed according to installed.json
	 *
	 * @return array
	 */
	public function getInstalledDependencies() {
		$deps = [];
		foreach ( $this->contents as $installed ) {
			$deps[$installed['name']] = [
				'version' => ComposerJson::normalizeVersion( $installed['version'] ),
				'type' => $installed['type'],
				'licenses' => isset( $installed['license'] ) ? $installed['license'] : [],
				'authors' => isset( $installed['authors'] ) ? $installed['authors'] : [],
				'description' => isset( $installed['description'] ) ? $installed['description']: '',
			];
		}

		ksort( $deps );
		return $deps;
	}
}


1		<?php
2
3		/**
4		* Reads an installed.json file and provides accessors to get what is
5		* installed
6		*
7		* @since 1.27
8		*/
9	View Code Duplication	class ComposerInstalled {
		0 ignored issues – show Duplication introduced 2016-10-17 17:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10
11		/**
12		* @param string $location
13		*/
14		public function __construct( $location ) {
15		$this->contents = json_decode( file_get_contents( $location ), true );
		0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `contents` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16		}
17
18		/**
19		* Dependencies currently installed according to installed.json
20		*
21		* @return array
22		*/
23		public function getInstalledDependencies() {
24		$deps = [];
25		foreach ( $this->contents as $installed ) {
26		$deps[$installed['name']] = [
27		'version' => ComposerJson::normalizeVersion( $installed['version'] ),
28		'type' => $installed['type'],
29		'licenses' => isset( $installed['license'] ) ? $installed['license'] : [],
30		'authors' => isset( $installed['authors'] ) ? $installed['authors'] : [],
31		'description' => isset( $installed['description'] ) ? $installed['description']: '',
32		];
33		}
34
35		ksort( $deps );
36		return $deps;
37		}
38		}
39

wikimedia / mediawiki

Branch — master (939199)

includes/libs/composer/ComposerInstalled.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like