$like was never initialized. Although not strictly required by PHP, it is generally a good practice to add $like = array(); before regardless.
Adding an explicit array definition is generally preferable to implicit array
definition as it guarantees a stable state of the code.
Let’s take a look at an example:
foreach($collectionas$item){$myArray['foo']=$item->getFoo();if($item->hasBar()){$myArray['bar']=$item->getBar();}// do something with $myArray}
As you can see in this example, the array $myArray is initialized the first
time when the foreach loop is entered. You can also see that the value of the
bar key is only written conditionally; thus, its value might result from a
previous iteration.
This might or might not be intended. To make your intention clear, your code
more readible and to avoid accidental bugs, we recommend to add an explicit
initialization $myArray=array() either outside or inside the foreach loop.
Loading history...
135
136
if ( $subdomains ) {
137
$like[] = $db->anyString();
138
}
139
140
if ( isset( $bits['port'] ) ) {
141
$like[] = ':' . $bits['port'];
142
}
143
if ( isset( $bits['path'] ) ) {
144
$like[] = $bits['path'];
145
} elseif ( !$subdomains ) {
146
$like[] = '/';
147
}
148
if ( isset( $bits['query'] ) ) {
149
$like[] = '?' . $bits['query'];
150
}
151
if ( isset( $bits['fragment'] ) ) {
152
$like[] = '#' . $bits['fragment'];
153
}
154
155
// Check for stray asterisks: asterisk only allowed at the start of the domain
wikimedia /
mediawiki
mrbluesky
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.