wikimedia / mediawiki

includes/api/ApiQueryBase.php

Doc Comments +4 added lines, -4 removed lines

@@ -118,7 +118,7 @@ 
 	 * See ApiQuery::getNamedDB() for more information
 	 * @param string $name Name to assign to the database connection
 	 * @param int $db One of the DB_* constants
-	 * @param array $groups Query groups
+	 * @param string $groups Query groups
 	 * @return Database
 	 */
 	public function selectNamedDB( $name, $db, $groups ) {
@@ -398,7 +398,7 @@ 
 	 * here in the same way it treats a false return from addValue().
 	 *
 	 * @since 1.28
-	 * @param object $row Database row
+	 * @param stdClass|null $row Database row
 	 * @param array &$data Data to be added to the result
 	 * @param array &$hookData Hook data from ApiQueryBase::select()
 	 * @return bool Return false if row processing should end with continuation
@@ -581,7 +581,7 @@ 
 
 	/**
 	 * @param string $hash
-	 * @return bool
+	 * @return integer
 	 */
 	public function validateSha1Hash( $hash ) {
 		return preg_match( '/^[a-f0-9]{40}$/', $hash );
@@ -589,7 +589,7 @@ 
 
 	/**
 	 * @param string $hash
-	 * @return bool
+	 * @return integer
 	 */
 	public function validateSha1Base36Hash( $hash ) {
 		return preg_match( '/^[a-z0-9]{31}$/', $hash );

includes/user/BotPassword.php

Doc Comments +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 	/**
 	 * Get a database connection for the bot passwords database
 	 * @param int $db Index of the connection to get, e.g. DB_MASTER or DB_REPLICA.
-	 * @return Database
+	 * @return DBConnRef
 	 */
 	public static function getDB( $db ) {
 		global $wgBotPasswordsCluster, $wgBotPasswordsDatabase;

includes/tidy/Balancer.php

Doc Comments +17 added lines, -2 removed lines

@@ -809,7 +809,7 @@ 
 
 	/**
 	 * Determine if the stack has $tag in button scope.
-	 * @param BalanceElement|array|string $tag
+	 * @param string $tag
 	 * @return bool
 	 * @see https://html.spec.whatwg.org/multipage/syntax.html#has-an-element-in-button-scope
 	 */
@@ -899,6 +899,7 @@ 
 
 	/**
 	 * Return the adjusted current node.
+	 * @param BalanceElement|null $fragmentContext
 	 */
 	public function adjustedCurrentNode( $fragmentContext ) {
 		return ( $fragmentContext && count( $this->elements ) === 1 ) ?
@@ -1144,7 +1145,7 @@ 
 	 * @param string $tag The subject tag name.
 	 * @param BalanceActiveFormattingElements $afe The current
 	 *   active formatting elements list.
-	 * @return true if the adoption agency algorithm "did something", false
+	 * @return boolean if the adoption agency algorithm "did something", false
 	 *   if more processing is required by the caller.
 	 * @see https://html.spec.whatwg.org/multipage/syntax.html#adoption-agency-algorithm
 	 */
@@ -1510,6 +1511,7 @@ 
 	 * Find and return the last element with the specified tag between the
 	 * end of the list and the last marker on the list.
 	 * Used when parsing <a> "in body mode".
+	 * @param string $tag
 	 */
 	public function findElementByTag( $tag ) {
 		$elt = $this->tail;
@@ -1666,6 +1668,10 @@ 
 	 * @see https://html.spec.whatwg.org/multipage/syntax.html#reconstruct-the-active-formatting-elements
 	 */
 	// @codingStandardsIgnoreEnd
+
+	/**
+	 * @param BalanceStack $stack
+	 */
 	public function reconstruct( $stack ) {
 		$entry = $this->tail;
 		// If there are no entries in the list of active formatting elements,
@@ -2240,6 +2246,10 @@ 
 		return $oldMode;
 	}
 
+	/**
+	 * @param string $mode
+	 * @param boolean $selfClose
+	 */
 	private function switchModeAndReprocess( $mode, $token, $value, $attribs, $selfClose ) {
 		$this->switchMode( $mode );
 		return $this->insertToken( $token, $value, $attribs, $selfClose );
@@ -3325,6 +3335,11 @@ 
 			return false;
 		}
 	}
+
+	/**
+	 * @param string $token
+	 * @param string $value
+	 */
 	private function inCellMode( $token, $value, $attribs = null, $selfClose = false ) {
 		if ( $token === 'tag' ) {
 			switch ( $value ) {

includes/skins/BaseTemplate.php

Doc Comments +6 added lines, -1 removed lines

@@ -29,13 +29,15 @@ 
 	 * Get a Message object with its context set
 	 *
 	 * @param string $name Message name
-	 * @param ... $params Message params
 	 * @return Message
 	 */
 	public function getMsg( $name /* ... */ ) {
 		return call_user_func_array( [ $this->getSkin(), 'msg' ], func_get_args() );
 	}
 
+	/**
+	 * @param string $str
+	 */
 	function msg( $str ) {
 		echo $this->getMsg( $str )->escaped();
 	}
@@ -507,6 +509,9 @@ 
 		return Html::element( 'input', $realAttrs );
 	}
 
+	/**
+	 * @param string $mode
+	 */
 	function makeSearchButton( $mode, $attrs = [] ) {
 		switch ( $mode ) {
 			case 'go':

includes/diff/DifferenceEngine.php

Doc Comments +5 added lines, -5 removed lines

@@ -106,7 +106,7 @@ 
 	 * Constructor
 	 * @param IContextSource $context Context to use, anything else will be ignored
 	 * @param int $old Old ID we want to show and diff with.
-	 * @param string|int $new Either revision ID or 'prev' or 'next'. Default: 0.
+	 * @param integer $new Either revision ID or 'prev' or 'next'. Default: 0.
 	 * @param int $rcid Deprecated, no longer used!
 	 * @param bool $refreshCache If set, refreshes the diff cache
 	 * @param bool $unhide If set, allow viewing deleted revs
@@ -176,7 +176,7 @@ 
 	 *
 	 * @param int $id Revision ID
 	 *
-	 * @return string|bool Link HTML or false
+	 * @return string|false Link HTML or false
 	 */
 	public function deletedLink( $id ) {
 		if ( $this->getUser()->isAllowed( 'deletedhistory' ) ) {
@@ -712,7 +712,7 @@ 
 	 * @param string|bool $ntitle Header for new text or false
 	 * @param string $notice HTML between diff header and body
 	 *
-	 * @return mixed
+	 * @return false|string
 	 */
 	public function getDiff( $otitle, $ntitle, $notice = '' ) {
 		$body = $this->getDiffBody();
@@ -734,7 +734,7 @@ 
 	/**
 	 * Get the diff table body, without header
 	 *
-	 * @return mixed (string/false)
+	 * @return false|string (string/false)
 	 */
 	public function getDiffBody() {
 		$this->mCacheHit = true;
@@ -996,7 +996,7 @@ 
 	 *
 	 * @param string $text
 	 *
-	 * @return mixed
+	 * @return string
 	 */
 	public function localiseLineNumbers( $text ) {
 		return preg_replace_callback(

includes/libs/mime/IEContentAnalyzer.php

Doc Comments +8 added lines, -8 removed lines

@@ -384,9 +384,9 @@ 
 	/**
 	 * Get the MIME type for a given named version
 	 * @param $version
-	 * @param $fileName
-	 * @param $chunk
-	 * @param $proposed
+	 * @param string $fileName
+	 * @param string $chunk
+	 * @param string $proposed
 	 * @return bool|string
 	 */
 	protected function getMimeTypeForVersion( $version, $fileName, $chunk, $proposed ) {
@@ -554,8 +554,8 @@ 
 	 * Check for text headers at the start of the chunk
 	 * Confirmed same in 5 and 7.
 	 * @param $version
-	 * @param $chunk
-	 * @return bool|string
+	 * @param string $chunk
+	 * @return string|false
 	 */
 	private function checkTextHeaders( $version, $chunk ) {
 		$chunk2 = substr( $chunk, 0, 2 );
@@ -580,8 +580,8 @@ 
 	 * Check for binary headers at the start of the chunk
 	 * Confirmed same in 5 and 7.
 	 * @param $version
-	 * @param $chunk
-	 * @return bool|string
+	 * @param string $chunk
+	 * @return string|false
 	 */
 	private function checkBinaryHeaders( $version, $chunk ) {
 		$chunk2 = substr( $chunk, 0, 2 );
@@ -681,7 +681,7 @@ 
 	 * Do heuristic checks on the bulk of the data sample.
 	 * Search for HTML tags.
 	 * @param $version
-	 * @param $chunk
+	 * @param string $chunk
 	 * @return array
 	 */
 	protected function sampleData( $version, $chunk ) {

includes/libs/mime/MimeAnalyzer.php

Doc Comments +1 added lines, -1 removed lines

@@ -620,7 +620,7 @@
 	 * @todo Remove $ext param
 	 *
 	 * @param string $file
-	 * @param mixed $ext
+	 * @param boolean|string $ext
 	 * @return bool|string
 	 * @throws MWException
 	 */

includes/libs/mime/XmlTypeCheck.php

Doc Comments +6 added lines, -2 removed lines

@@ -134,7 +134,8 @@ 
 
 
 	/**
-	 * @param string $fname the filename
+	 * @param string $xml
+	 * @param boolean $isFile
 	 */
 	private function validateFromInput( $xml, $isFile ) {
 		$reader = new XMLReader();
@@ -175,6 +176,9 @@ 
 		$this->wellFormed = false;
 	}
 
+	/**
+	 * @param XMLReader $reader
+	 */
 	private function validate( $reader ) {
 
 		// First, move through anything that isn't an element, and
@@ -286,7 +290,7 @@ 
 	}
 
 	/**
-	 * @param $name
+	 * @param string $name
 	 * @param $attribs
 	 */
 	private function elementOpen( $name, $attribs ) {

includes/MWGrants.php

Doc Comments +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
 
 	/**
 	 * Fetch the rights allowed by a set of grants.
-	 * @param string[]|string $grants
+	 * @param string[] $grants
 	 * @return string[]
 	 */
 	public static function getGrantRights( $grants ) {