@@ -296,6 +296,9 @@ discard block |
||
296 | 296 | ); |
297 | 297 | } |
298 | 298 | |
299 | + /** |
|
300 | + * @param FormOptions $opts |
|
301 | + */ |
|
299 | 302 | protected function runMainQueryHook( &$tables, &$fields, &$conds, &$query_options, |
300 | 303 | &$join_conds, $opts |
301 | 304 | ) { |
@@ -310,7 +313,7 @@ discard block |
||
310 | 313 | /** |
311 | 314 | * Return a IDatabase object for reading |
312 | 315 | * |
313 | - * @return IDatabase |
|
316 | + * @return Database|null |
|
314 | 317 | */ |
315 | 318 | protected function getDB() { |
316 | 319 | return wfGetDB( DB_REPLICA, 'watchlist' ); |
@@ -534,6 +537,9 @@ discard block |
||
534 | 537 | $this->setBottomText( $opts ); |
535 | 538 | } |
536 | 539 | |
540 | + /** |
|
541 | + * @param FormOptions $options |
|
542 | + */ |
|
537 | 543 | function cutoffselector( $options ) { |
538 | 544 | // Cast everything to strings immediately, so that we know all of the values have the same |
539 | 545 | // precision, and can be compared with '==='. 2/24 has a few more decimal places than its |
@@ -648,7 +654,7 @@ discard block |
||
648 | 654 | * The assumption made here is that when a subject page is watched a talk page is also watched. |
649 | 655 | * Hence the number of individual items is halved. |
650 | 656 | * |
651 | - * @return int |
|
657 | + * @return double |
|
652 | 658 | */ |
653 | 659 | protected function countItems() { |
654 | 660 | $store = MediaWikiServices::getInstance()->getWatchedItemStore(); |
@@ -146,7 +146,7 @@ |
||
146 | 146 | * |
147 | 147 | * @param string $database |
148 | 148 | * @param bool $ignoreInvalidDB If true, don't check if $database is in $wgLocalDatabases |
149 | - * @return IDatabase|null If invalid selection |
|
149 | + * @return Database|null If invalid selection |
|
150 | 150 | */ |
151 | 151 | public static function getDB( $database, $ignoreInvalidDB = false ) { |
152 | 152 | global $wgDBname; |
@@ -152,6 +152,10 @@ |
||
152 | 152 | } |
153 | 153 | |
154 | 154 | /* Core function which does whatever the maintenance script is designed to do */ |
155 | + |
|
156 | + /** |
|
157 | + * @param Database $rev |
|
158 | + */ |
|
155 | 159 | abstract public function processRevision( $rev ); |
156 | 160 | } |
157 | 161 |
@@ -295,7 +295,7 @@ discard block |
||
295 | 295 | /** |
296 | 296 | * Get an argument. |
297 | 297 | * @param int $argId The integer value (from zero) for the arg |
298 | - * @param mixed $default The default if it doesn't exist |
|
298 | + * @param string $default The default if it doesn't exist |
|
299 | 299 | * @return mixed |
300 | 300 | */ |
301 | 301 | protected function getArg( $argId = 0, $default = null ) { |
@@ -1344,6 +1344,7 @@ discard block |
||
1344 | 1344 | * Unlock and lock again |
1345 | 1345 | * Since the lock is low-priority, queued reads will be able to complete |
1346 | 1346 | * @param Database &$db |
1347 | + * @param Database $db |
|
1347 | 1348 | */ |
1348 | 1349 | private function relockSearchindex( $db ) { |
1349 | 1350 | $this->unlockSearchindex( $db ); |
@@ -39,6 +39,9 @@ |
||
39 | 39 | private $failed; |
40 | 40 | private $outputCallback; |
41 | 41 | |
42 | + /** |
|
43 | + * @param Database $database |
|
44 | + */ |
|
42 | 45 | function __construct( &$database, $outputCallback ) { |
43 | 46 | $this->db = $database; |
44 | 47 | $this->outputCallback = $outputCallback; |
@@ -162,7 +162,7 @@ |
||
162 | 162 | * @param array $options (optional) extra params to pass (see Http::request()) |
163 | 163 | * @param string $caller The method making this request, for profiling |
164 | 164 | * @throws MWException |
165 | - * @return CurlHttpRequest|PhpHttpRequest |
|
165 | + * @return string |
|
166 | 166 | * @see MWHttpRequest::__construct |
167 | 167 | */ |
168 | 168 | public static function factory( $url, $options = null, $caller = __METHOD__ ) { |
@@ -164,7 +164,7 @@ |
||
164 | 164 | |
165 | 165 | /** |
166 | 166 | * Generate the feed items given a row from the database, printing the feed. |
167 | - * @param object $rows IDatabase resource with recentchanges rows |
|
167 | + * @param ResultWrapper $rows IDatabase resource with recentchanges rows |
|
168 | 168 | * @param ChannelFeed $feed |
169 | 169 | */ |
170 | 170 | public static function generateFeed( $rows, &$feed ) { |
@@ -1219,7 +1219,7 @@ discard block |
||
1219 | 1219 | * $ttl = $cache->adaptiveTTL( $mtime, $cache::TTL_DAY ); |
1220 | 1220 | * @endcode |
1221 | 1221 | * |
1222 | - * @param integer|float $mtime UNIX timestamp |
|
1222 | + * @param string|boolean $mtime UNIX timestamp |
|
1223 | 1223 | * @param integer $maxTTL Maximum TTL (seconds) |
1224 | 1224 | * @param integer $minTTL Minimum TTL (seconds); Default: 30 |
1225 | 1225 | * @param float $factor Value in the range (0,1); Default: .2 |
@@ -1383,7 +1383,7 @@ discard block |
||
1383 | 1383 | * @param mixed $value |
1384 | 1384 | * @param integer $ttl [0=forever] |
1385 | 1385 | * @param float $now Unix Current timestamp just before calling set() |
1386 | - * @return array |
|
1386 | + * @return integer |
|
1387 | 1387 | */ |
1388 | 1388 | protected function wrap( $value, $ttl, $now ) { |
1389 | 1389 | return [ |
@@ -450,7 +450,7 @@ discard block |
||
450 | 450 | |
451 | 451 | /** |
452 | 452 | * Get a connection to the replica DB |
453 | - * @return IDatabase |
|
453 | + * @return Database|null |
|
454 | 454 | */ |
455 | 455 | function getSlaveDB() { |
456 | 456 | return wfGetDB( DB_REPLICA ); |
@@ -458,7 +458,7 @@ discard block |
||
458 | 458 | |
459 | 459 | /** |
460 | 460 | * Get a connection to the master DB |
461 | - * @return IDatabase |
|
461 | + * @return Database|null |
|
462 | 462 | */ |
463 | 463 | function getMasterDB() { |
464 | 464 | return wfGetDB( DB_MASTER ); |