wikimedia / mediawiki

includes/libs/filebackend/SwiftFileBackend.php

Doc Comments +3 added lines, -3 removed lines

@@ -1314,7 +1314,7 @@ 
 	 * (lists are truncated to 10000 item with no way to page), and is just a performance risk.
 	 *
 	 * @param string $container Resolved Swift container
-	 * @param array $readGrps List of the possible criteria for a request to have
+	 * @param string[] $readGrps List of the possible criteria for a request to have
 	 * access to read a container. Each item is one of the following formats:
 	 *   - account:user        : Grants access if the request is by the given user
 	 *   - ".r:<regex>"        : Grants access if the request is from a referrer host that
@@ -1322,7 +1322,7 @@ 
 	 *                           Setting this to '*' effectively makes a container public.
 	 *   -".rlistings:<regex>" : Grants access if the request is from a referrer host that
 	 *                           matches the expression and the request is for a listing.
-	 * @param array $writeGrps A list of the possible criteria for a request to have
+	 * @param string[] $writeGrps A list of the possible criteria for a request to have
 	 * access to write to a container. Each item is of the following format:
 	 *   - account:user       : Grants access if the request is by the given user
 	 * @return Status
@@ -1705,7 +1705,7 @@ 
 	 * @param array $creds From getAuthentication()
 	 * @param string $container
 	 * @param string $object
-	 * @return array
+	 * @return string
 	 */
 	protected function storageUrl( array $creds, $container = null, $object = null ) {
 		$parts = [ $creds['storage_url'] ];

includes/libs/objectcache/RedisBagOStuff.php

Doc Comments +2 added lines, -2 removed lines

@@ -307,7 +307,7 @@ 
 
 	/**
 	 * @param string $data
-	 * @return mixed
+	 * @return boolean|string
 	 */
 	protected function unserialize( $data ) {
 		return ctype_digit( $data ) ? intval( $data ) : unserialize( $data );
@@ -316,7 +316,7 @@ 
 	/**
 	 * Get a Redis object with a connection suitable for fetching the specified key
 	 * @param string $key
-	 * @return array (server, RedisConnRef) or (false, false)
+	 * @return false[] (server, RedisConnRef) or (false, false)
 	 */
 	protected function getConnection( $key ) {
 		$candidates = array_keys( $this->serverTagMap );

maintenance/updateDoubleWidthSearch.php

Doc Comments +3 added lines

@@ -121,6 +121,9 @@
 		}
 	}
 
+	/**
+	 * @param Database|null $dbw
+	 */
 	public function doSpecialPageCacheUpdates( $dbw ) {
 		global $wgSpecialPageCacheUpdates;
 

includes/htmlform/fields/HTMLDateTimeField.php

Doc Comments +3 added lines

@@ -142,6 +142,9 @@
 		}
 	}
 
+	/**
+	 * @param integer $value
+	 */
 	protected function formatDate( $value ) {
 		switch ( $this->mType ) {
 			case 'date':

includes/widget/DateTimeInputWidget.php

Doc Comments -4 removed lines

@@ -21,10 +21,6 @@
 
 	/**
 	 * @param array $config Configuration options
-	 * @param string $config['type'] 'date', 'time', or 'datetime'
-	 * @param string $config['min'] Minimum date, time, or datetime
-	 * @param string $config['max'] Maximum date, time, or datetime
-	 * @param bool $config['clearable'] Whether to provide for blanking the value.
 	 */
 	public function __construct( array $config = [] ) {
 		// We need $this->type set before calling the parent constructor

includes/specialpage/AuthManagerSpecialPage.php

Doc Comments +2 added lines, -2 removed lines

@@ -196,7 +196,7 @@ 
 	 * Get the default action for this special page, if none is given via URL/POST data.
 	 * Subclasses should override this (or override loadAuth() so this is never called).
 	 * @param string $subPage Subpage of the special page.
-	 * @return string an AuthManager::ACTION_* constant.
+	 * @return string|null an AuthManager::ACTION_* constant.
 	 */
 	protected function getDefaultAction( $subPage ) {
 		throw new BadMethodCallException( 'Subclass did not implement getDefaultAction' );
@@ -732,7 +732,7 @@ 
 	 * Get an array value, or a default if it does not exist.
 	 * @param array $array
 	 * @param string $fieldName
-	 * @param mixed $default
+	 * @param integer $default
 	 * @return mixed
 	 */
 	protected static function getField( array $array, $fieldName, $default = null ) {

includes/db/DatabaseOracle.php

Doc Comments +28 added lines

@@ -85,6 +85,9 @@ 
 		unset( $this->db );
 	}
 
+	/**
+	 * @param integer $row
+	 */
 	public function seek( $row ) {
 		$this->cursor = min( $row, $this->nrows );
 	}
@@ -440,6 +443,9 @@ 
 		}
 	}
 
+	/**
+	 * @return string
+	 */
 	function lastError() {
 		if ( $this->mConn === false ) {
 			$e = oci_error();
@@ -480,6 +486,9 @@ 
 		return false;
 	}
 
+	/**
+	 * @param string $table
+	 */
 	function insert( $table, $a, $fname = __METHOD__, $options = [] ) {
 		if ( !count( $a ) ) {
 			return true;
@@ -509,6 +518,9 @@ 
 		return $retVal;
 	}
 
+	/**
+	 * @param string $table
+	 */
 	private function fieldBindStatement( $table, $col, &$val, $includeCol = false ) {
 		$col_info = $this->fieldInfoMulti( $table, $col );
 		$col_type = $col_info != false ? $col_info->type() : 'CONSTANT';
@@ -751,6 +763,9 @@ 
 		return strtoupper( parent::tableName( $name, $format ) );
 	}
 
+	/**
+	 * @param string $name
+	 */
 	function tableNameInternal( $name ) {
 		$name = $this->tableName( $name );
 
@@ -1173,6 +1188,9 @@ 
 		return true;
 	}
 
+	/**
+	 * @param string $db
+	 */
 	function selectDB( $db ) {
 		$this->mDBname = $db;
 		if ( $db == null || $db == $this->mUser ) {
@@ -1208,6 +1226,9 @@ 
 		return "'" . $this->strencode( $s ) . "'";
 	}
 
+	/**
+	 * @param string $s
+	 */
 	public function addIdentifierQuotes( $s ) {
 		if ( !$this->getFlag( DBO_DDLMODE ) ) {
 			$s = '/*Q*/' . $s;
@@ -1311,6 +1332,10 @@ 
 		return [ $startOpts, $useIndex, $preLimitTail, $postLimitTail, $ignoreIndex ];
 	}
 
+	/**
+	 * @param string $table
+	 * @param string $conds
+	 */
 	public function delete( $table, $conds, $fname = __METHOD__ ) {
 		if ( is_array( $conds ) ) {
 			$conds = $this->wrapConditionsForWhere( $table, $conds );
@@ -1472,6 +1497,9 @@ 
 		return 'BITOR(' . $fieldLeft . ', ' . $fieldRight . ')';
 	}
 
+	/**
+	 * @return string
+	 */
 	function getDBname() {
 		return $this->mDBname;
 	}

includes/pager/IndexPager.php

Doc Comments +1 added lines, -1 removed lines

@@ -182,7 +182,7 @@
 	/**
 	 * Get the Database object in use
 	 *
-	 * @return IDatabase
+	 * @return Database|null
 	 */
 	public function getDatabase() {
 		return $this->mDb;

includes/PrefixSearch.php

Doc Comments +5 added lines

@@ -186,6 +186,11 @@
 			$this->handleResultFromHook( $srchres, $namespaces, $search, $limit, $offset ) );
 	}
 
+	/**
+	 * @param string $search
+	 * @param integer $limit
+	 * @param integer $offset
+	 */
 	private function handleResultFromHook( $srchres, $namespaces, $search, $limit, $offset ) {
 		if ( $offset === 0 ) {
 			// Only perform exact db match if offset === 0