Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like LBFactory often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LBFactory, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
33 | abstract class LBFactory implements DestructibleService { |
||
34 | /** @var ChronologyProtector */ |
||
35 | protected $chronProt; |
||
36 | /** @var TransactionProfiler */ |
||
37 | protected $trxProfiler; |
||
38 | /** @var LoggerInterface */ |
||
39 | protected $trxLogger; |
||
40 | /** @var BagOStuff */ |
||
41 | protected $srvCache; |
||
42 | /** @var WANObjectCache */ |
||
43 | protected $wanCache; |
||
44 | |||
45 | /** @var mixed */ |
||
46 | protected $ticket; |
||
47 | /** @var string|bool String if a requested DBO_TRX transaction round is active */ |
||
48 | protected $trxRoundId = false; |
||
49 | /** @var string|bool Reason all LBs are read-only or false if not */ |
||
50 | protected $readOnlyReason = false; |
||
51 | /** @var callable[] */ |
||
52 | protected $replicationWaitCallbacks = []; |
||
53 | |||
54 | const SHUTDOWN_NO_CHRONPROT = 1; // don't save ChronologyProtector positions (for async code) |
||
55 | |||
56 | /** |
||
57 | * Construct a factory based on a configuration array (typically from $wgLBFactoryConf) |
||
58 | * @param array $conf |
||
59 | * @TODO: inject objects via dependency framework |
||
60 | */ |
||
61 | public function __construct( array $conf ) { |
||
83 | |||
84 | /** |
||
85 | * Disables all load balancers. All connections are closed, and any attempt to |
||
86 | * open a new connection will result in a DBAccessError. |
||
87 | * @see LoadBalancer::disable() |
||
88 | */ |
||
89 | public function destroy() { |
||
93 | |||
94 | /** |
||
95 | * Disables all access to the load balancer, will cause all database access |
||
96 | * to throw a DBAccessError |
||
97 | */ |
||
98 | public static function disableBackend() { |
||
101 | |||
102 | /** |
||
103 | * Get an LBFactory instance |
||
104 | * |
||
105 | * @deprecated since 1.27, use MediaWikiServices::getDBLoadBalancerFactory() instead. |
||
106 | * |
||
107 | * @return LBFactory |
||
108 | */ |
||
109 | public static function singleton() { |
||
112 | |||
113 | /** |
||
114 | * Returns the LBFactory class to use and the load balancer configuration. |
||
115 | * |
||
116 | * @todo instead of this, use a ServiceContainer for managing the different implementations. |
||
117 | * |
||
118 | * @param array $config (e.g. $wgLBFactoryConf) |
||
119 | * @return string Class name |
||
120 | */ |
||
121 | public static function getLBFactoryClass( array $config ) { |
||
143 | |||
144 | /** |
||
145 | * Shut down, close connections and destroy the cached instance. |
||
146 | * |
||
147 | * @deprecated since 1.27, use LBFactory::destroy() |
||
148 | */ |
||
149 | public static function destroyInstance() { |
||
152 | |||
153 | /** |
||
154 | * Create a new load balancer object. The resulting object will be untracked, |
||
155 | * not chronology-protected, and the caller is responsible for cleaning it up. |
||
156 | * |
||
157 | * @param bool|string $wiki Wiki ID, or false for the current wiki |
||
158 | * @return LoadBalancer |
||
159 | */ |
||
160 | abstract public function newMainLB( $wiki = false ); |
||
161 | |||
162 | /** |
||
163 | * Get a cached (tracked) load balancer object. |
||
164 | * |
||
165 | * @param bool|string $wiki Wiki ID, or false for the current wiki |
||
166 | * @return LoadBalancer |
||
167 | */ |
||
168 | abstract public function getMainLB( $wiki = false ); |
||
169 | |||
170 | /** |
||
171 | * Create a new load balancer for external storage. The resulting object will be |
||
172 | * untracked, not chronology-protected, and the caller is responsible for |
||
173 | * cleaning it up. |
||
174 | * |
||
175 | * @param string $cluster External storage cluster, or false for core |
||
176 | * @param bool|string $wiki Wiki ID, or false for the current wiki |
||
177 | * @return LoadBalancer |
||
178 | */ |
||
179 | abstract protected function newExternalLB( $cluster, $wiki = false ); |
||
180 | |||
181 | /** |
||
182 | * Get a cached (tracked) load balancer for external storage |
||
183 | * |
||
184 | * @param string $cluster External storage cluster, or false for core |
||
185 | * @param bool|string $wiki Wiki ID, or false for the current wiki |
||
186 | * @return LoadBalancer |
||
187 | */ |
||
188 | abstract public function &getExternalLB( $cluster, $wiki = false ); |
||
189 | |||
190 | /** |
||
191 | * Execute a function for each tracked load balancer |
||
192 | * The callback is called with the load balancer as the first parameter, |
||
193 | * and $params passed as the subsequent parameters. |
||
194 | * |
||
195 | * @param callable $callback |
||
196 | * @param array $params |
||
197 | */ |
||
198 | abstract public function forEachLB( $callback, array $params = [] ); |
||
199 | |||
200 | /** |
||
201 | * Prepare all tracked load balancers for shutdown |
||
202 | * @param integer $flags Supports SHUTDOWN_* flags |
||
203 | */ |
||
204 | public function shutdown( $flags = 0 ) { |
||
210 | |||
211 | /** |
||
212 | * Call a method of each tracked load balancer |
||
213 | * |
||
214 | * @param string $methodName |
||
215 | * @param array $args |
||
216 | */ |
||
217 | private function forEachLBCallMethod( $methodName, array $args = [] ) { |
||
225 | |||
226 | /** |
||
227 | * Flush any master transaction snapshots and set DBO_TRX (if DBO_DEFAULT is set) |
||
228 | * |
||
229 | * The DBO_TRX setting will be reverted to the default in each of these methods: |
||
230 | * - commitMasterChanges() |
||
231 | * - rollbackMasterChanges() |
||
232 | * - commitAll() |
||
233 | * This allows for custom transaction rounds from any outer transaction scope. |
||
234 | * |
||
235 | * @param string $fname |
||
236 | * @throws DBTransactionError |
||
237 | * @since 1.28 |
||
238 | */ |
||
239 | public function beginMasterChanges( $fname = __METHOD__ ) { |
||
250 | |||
251 | /** |
||
252 | * Commit on all connections. Done for two reasons: |
||
253 | * 1. To commit changes to the masters. |
||
254 | * 2. To release the snapshot on all connections, master and slave. |
||
255 | * @param string $fname Caller name |
||
256 | * @param array $options Options map: |
||
257 | * - maxWriteDuration: abort if more than this much time was spent in write queries |
||
258 | */ |
||
259 | public function commitAll( $fname = __METHOD__, array $options = [] ) { |
||
263 | |||
264 | /** |
||
265 | * Commit changes on all master connections |
||
266 | * @param string $fname Caller name |
||
267 | * @param array $options Options map: |
||
268 | * - maxWriteDuration: abort if more than this much time was spent in write queries |
||
269 | * @throws Exception |
||
270 | */ |
||
271 | public function commitMasterChanges( $fname = __METHOD__, array $options = [] ) { |
||
295 | |||
296 | /** |
||
297 | * Rollback changes on all master connections |
||
298 | * @param string $fname Caller name |
||
299 | * @since 1.23 |
||
300 | */ |
||
301 | public function rollbackMasterChanges( $fname = __METHOD__ ) { |
||
310 | |||
311 | /** |
||
312 | * Log query info if multi DB transactions are going to be committed now |
||
313 | */ |
||
314 | private function logIfMultiDbTransaction() { |
||
333 | |||
334 | /** |
||
335 | * Determine if any master connection has pending changes |
||
336 | * @return bool |
||
337 | * @since 1.23 |
||
338 | */ |
||
339 | public function hasMasterChanges() { |
||
347 | |||
348 | /** |
||
349 | * Detemine if any lagged slave connection was used |
||
350 | * @since 1.27 |
||
351 | * @return bool |
||
352 | */ |
||
353 | public function laggedSlaveUsed() { |
||
361 | |||
362 | /** |
||
363 | * Determine if any master connection has pending/written changes from this request |
||
364 | * @return bool |
||
365 | * @since 1.27 |
||
366 | */ |
||
367 | public function hasOrMadeRecentMasterChanges() { |
||
374 | |||
375 | /** |
||
376 | * Waits for the slave DBs to catch up to the current master position |
||
377 | * |
||
378 | * Use this when updating very large numbers of rows, as in maintenance scripts, |
||
379 | * to avoid causing too much lag. Of course, this is a no-op if there are no slaves. |
||
380 | * |
||
381 | * By default this waits on all DB clusters actually used in this request. |
||
382 | * This makes sense when lag being waiting on is caused by the code that does this check. |
||
383 | * In that case, setting "ifWritesSince" can avoid the overhead of waiting for clusters |
||
384 | * that were not changed since the last wait check. To forcefully wait on a specific cluster |
||
385 | * for a given wiki, use the 'wiki' parameter. To forcefully wait on an "external" cluster, |
||
386 | * use the "cluster" parameter. |
||
387 | * |
||
388 | * Never call this function after a large DB write that is *still* in a transaction. |
||
389 | * It only makes sense to call this after the possible lag inducing changes were committed. |
||
390 | * |
||
391 | * @param array $opts Optional fields that include: |
||
392 | * - wiki : wait on the load balancer DBs that handles the given wiki |
||
393 | * - cluster : wait on the given external load balancer DBs |
||
394 | * - timeout : Max wait time. Default: ~60 seconds |
||
395 | * - ifWritesSince: Only wait if writes were done since this UNIX timestamp |
||
396 | * @throws DBReplicationWaitError If a timeout or error occured waiting on a DB cluster |
||
397 | * @since 1.27 |
||
398 | */ |
||
399 | public function waitForReplication( array $opts = [] ) { |
||
462 | |||
463 | /** |
||
464 | * Add a callback to be run in every call to waitForReplication() before waiting |
||
465 | * |
||
466 | * Callbacks must clear any transactions that they start |
||
467 | * |
||
468 | * @param string $name Callback name |
||
469 | * @param callable|null $callback Use null to unset a callback |
||
470 | * @since 1.28 |
||
471 | */ |
||
472 | public function setWaitForReplicationListener( $name, callable $callback = null ) { |
||
479 | |||
480 | /** |
||
481 | * Get a token asserting that no transaction writes are active |
||
482 | * |
||
483 | * @param string $fname Caller name (e.g. __METHOD__) |
||
484 | * @return mixed A value to pass to commitAndWaitForReplication() |
||
485 | * @since 1.28 |
||
486 | */ |
||
487 | public function getEmptyTransactionTicket( $fname ) { |
||
495 | |||
496 | /** |
||
497 | * Convenience method for safely running commitMasterChanges()/waitForReplication() |
||
498 | * |
||
499 | * This will commit and wait unless $ticket indicates it is unsafe to do so |
||
500 | * |
||
501 | * @param string $fname Caller name (e.g. __METHOD__) |
||
502 | * @param mixed $ticket Result of getOuterTransactionScopeTicket() |
||
503 | * @param array $opts Options to waitForReplication() |
||
504 | * @throws DBReplicationWaitError |
||
505 | * @since 1.28 |
||
506 | */ |
||
507 | public function commitAndWaitForReplication( $fname, $ticket, array $opts = [] ) { |
||
517 | |||
518 | /** |
||
519 | * Disable the ChronologyProtector for all load balancers |
||
520 | * |
||
521 | * This can be called at the start of special API entry points |
||
522 | * |
||
523 | * @since 1.27 |
||
524 | */ |
||
525 | public function disableChronologyProtection() { |
||
528 | |||
529 | /** |
||
530 | * @return ChronologyProtector |
||
531 | */ |
||
532 | protected function newChronologyProtector() { |
||
551 | |||
552 | /** |
||
553 | * @param ChronologyProtector $cp |
||
554 | */ |
||
555 | protected function shutdownChronologyProtector( ChronologyProtector $cp ) { |
||
573 | |||
574 | /** |
||
575 | * @param LoadBalancer $lb |
||
576 | */ |
||
577 | protected function initLoadBalancer( LoadBalancer $lb ) { |
||
582 | |||
583 | /** |
||
584 | * Close all open database connections on all open load balancers. |
||
585 | * @since 1.28 |
||
586 | */ |
||
587 | public function closeAll() { |
||
590 | |||
591 | } |
||
592 |
This check looks for function calls that miss required arguments.