wikimedia / mediawiki

includes/cache/CacheDependency.php

Doc Comments +10 added lines, -1 removed lines

@@ -172,7 +172,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return string[]
 	 */
 	function __sleep() {
 		$this->loadDependencyValues();
@@ -228,6 +228,9 @@ 
 	private $name;
 	private $value;
 
+	/**
+	 * @param string $name
+	 */
 	function __construct( $name ) {
 		$this->name = $name;
 		$this->value = $GLOBALS[$name];
@@ -252,6 +255,9 @@ 
 	private $name;
 	private $value;
 
+	/**
+	 * @param string $name
+	 */
 	function __construct( $name ) {
 		$this->name = $name;
 		$this->value = $this->getConfig()->get( $this->name );
@@ -280,6 +286,9 @@ 
 	private $name;
 	private $value;
 
+	/**
+	 * @param string $name
+	 */
 	function __construct( $name ) {
 		$this->name = $name;
 		$this->value = constant( $name );

includes/libs/StatusValue.php

Doc Comments +2 added lines, -2 removed lines

@@ -139,7 +139,7 @@ 
 	/**
 	 * Add a new warning
 	 *
-	 * @param string|MessageSpecifier $message Message key or object
+	 * @param Message $message Message key or object
 	 */
 	public function warning( $message /*, parameters... */ ) {
 		$this->errors[] = [
@@ -167,7 +167,7 @@ 
 	 * Add an error and set OK to false, indicating that the operation
 	 * as a whole was fatal
 	 *
-	 * @param string|MessageSpecifier $message Message key or object
+	 * @param string $message Message key or object
 	 */
 	public function fatal( $message /*, parameters... */ ) {
 		$this->errors[] = [

includes/skins/QuickTemplate.php

Doc Comments +1 added lines

@@ -97,6 +97,7 @@
 	/**
 	 * Main function, used by classes that subclass QuickTemplate
 	 * to show the actual HTML output
+	 * @return string
 	 */
 	abstract public function execute();
 

includes/specialpage/AuthManagerSpecialPage.php

Doc Comments +3 added lines, -2 removed lines

@@ -197,7 +197,7 @@ 
 	 * Get the default action for this special page, if none is given via URL/POST data.
 	 * Subclasses should override this (or override loadAuth() so this is never called).
 	 * @param string $subPage Subpage of the special page.
-	 * @return string an AuthManager::ACTION_* constant.
+	 * @return string|null an AuthManager::ACTION_* constant.
 	 */
 	protected function getDefaultAction( $subPage ) {
 		throw new BadMethodCallException( 'Subclass did not implement getDefaultAction' );
@@ -206,6 +206,7 @@ 
 	/**
 	 * Return custom message key.
 	 * Allows subclasses to customize messages.
+	 * @param string $defaultKey
 	 * @return string
 	 */
 	protected function messageKey( $defaultKey ) {
@@ -708,7 +709,7 @@ 
 	 * Get an array value, or a default if it does not exist.
 	 * @param array $array
 	 * @param string $fieldName
-	 * @param mixed $default
+	 * @param integer $default
 	 * @return mixed
 	 */
 	protected static function getField( array $array, $fieldName, $default = null ) {

includes/specialpage/LoginSignupSpecialPage.php

Doc Comments +11 added lines, -2 removed lines

@@ -81,6 +81,9 @@ 
 	 */
 	abstract protected function logAuthResult( $success, $status = null );
 
+	/**
+	 * @param string $name
+	 */
 	public function __construct( $name ) {
 		global $wgUseMediaWikiUIEverywhere;
 		parent::__construct( $name );
@@ -342,7 +345,7 @@ 
 	 * Show the success page.
 	 *
 	 * @param string $type Condition of return to; see `executeReturnTo`
-	 * @param string|Message $title Page's title
+	 * @param Message $title Page's title
 	 * @param string $msgname
 	 * @param string $injected_html
 	 * @param StatusValue|null $extraMessages
@@ -391,7 +394,6 @@ 
 	/**
 	 * Replace some globals to make sure the fact that the user has just been logged in is
 	 * reflected in the current request.
-	 * @param User $user
 	 */
 	protected function setSessionUserForCurrentRequest() {
 		global $wgUser, $wgLang;
@@ -1322,6 +1324,9 @@ 
 class LoginForm extends SpecialPage {
 	private $realLoginForm;
 
+	/**
+	 * @param DerivativeRequest $request
+	 */
 	public function __construct( $request = null ) {
 		global $wgDisableAuthManager;
 		if ( $wgDisableAuthManager ) {
@@ -1418,6 +1423,10 @@ 
 	function getPageTitle( $subpage = false ) {
 		return call_user_func_array( [ $this->realLoginForm, __FUNCTION__ ], func_get_args() );
 	}
+
+	/**
+	 * @param IContextSource $context
+	 */
 	public function setContext( $context ) {
 		return call_user_func_array( [ $this->realLoginForm, __FUNCTION__ ], func_get_args() );
 	}

includes/specialpage/SpecialPage.php

Doc Comments +2 added lines, -2 removed lines

@@ -107,7 +107,7 @@ 
 	 * @param string $name Name of the special page, as seen in links and URLs
 	 * @param string $restriction User right required, e.g. "block" or "delete"
 	 * @param bool $listed Whether the page is listed in Special:Specialpages
-	 * @param callable|bool $function Unused
+	 * @param boolean $function Unused
 	 * @param string $file Unused
 	 * @param bool $includable Whether the page can be included in normal pages
 	 */
@@ -302,7 +302,7 @@ 
 	 * Tells if the special page does something security-sensitive and needs extra defense against
 	 * a stolen account (e.g. a reauthentication). What exactly that will mean is decided by the
 	 * authentication framework.
-	 * @return bool|string False or the argument for AuthManager::securitySensitiveOperationStatus().
+	 * @return boolean False or the argument for AuthManager::securitySensitiveOperationStatus().
 	 *   Typically a special page needing elevated security would return its name here.
 	 */
 	protected function getLoginSecurityLevel() {

includes/specials/helpers/LoginHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 	}
 
 	/**
-	 * @return array
+	 * @return string[]
 	 */
 	function getOrderFields() {
 		return array( 'rd_namespace', 'rd_title', 'rd_from' );

includes/specials/pre-authmanager/SpecialUserlogin.php

Doc Comments +3 added lines, -3 removed lines

@@ -136,7 +136,7 @@ 
 	/**
 	 * Returns an array of all valid error messages.
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	public static function getValidErrorMessages() {
 		static $messages = null;
@@ -1222,7 +1222,7 @@ 
 	 * Display a "successful action" page.
 	 *
 	 * @param string $type Condition of return to; see `executeReturnTo`
-	 * @param string|Message $title Page's title
+	 * @param Message $title Page's title
 	 * @param string $msgname
 	 * @param string $injected_html
 	 */
@@ -1735,7 +1735,7 @@ 
 	 * Private function to check password expiration, until AuthManager comes
 	 * along to handle that.
 	 * @param User $user
-	 * @return string|bool
+	 * @return string|false
 	 */
 	private function checkUserPasswordExpired( User $user ) {
 		global $wgPasswordExpireGrace;

includes/diff/DairikiDiff.php

Doc Comments +1 added lines, -1 removed lines

@@ -232,7 +232,7 @@
 	 *    $diff = new Diff($lines1, $lines2);
 	 *    $rev = $diff->reverse();
 	 *
-	 * @return Object A Diff object representing the inverse of the
+	 * @return Diff A Diff object representing the inverse of the
 	 *   original diff.
 	 */
 	public function reverse() {