Complex classes like DBConnRef often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DBConnRef, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | class DBConnRef implements IDatabase { |
||
| 11 | /** @var LoadBalancer */ |
||
| 12 | private $lb; |
||
| 13 | |||
| 14 | /** @var DatabaseBase|null */ |
||
| 15 | private $conn; |
||
| 16 | |||
| 17 | /** @var array|null */ |
||
| 18 | private $params; |
||
| 19 | |||
| 20 | /** |
||
| 21 | * @param LoadBalancer $lb |
||
| 22 | * @param DatabaseBase|array $conn Connection or (server index, group, wiki ID) array |
||
| 23 | */ |
||
| 24 | public function __construct( LoadBalancer $lb, $conn ) { |
||
| 32 | |||
| 33 | function __call( $name, array $arguments ) { |
||
| 41 | |||
| 42 | public function getServerInfo() { |
||
| 45 | |||
| 46 | public function bufferResults( $buffer = null ) { |
||
| 49 | |||
| 50 | public function trxLevel() { |
||
| 53 | |||
| 54 | public function trxTimestamp() { |
||
| 57 | |||
| 58 | public function tablePrefix( $prefix = null ) { |
||
| 61 | |||
| 62 | public function dbSchema( $schema = null ) { |
||
| 65 | |||
| 66 | public function getLBInfo( $name = null ) { |
||
| 69 | |||
| 70 | public function setLBInfo( $name, $value = null ) { |
||
| 73 | |||
| 74 | public function implicitGroupby() { |
||
| 77 | |||
| 78 | public function implicitOrderby() { |
||
| 81 | |||
| 82 | public function lastQuery() { |
||
| 85 | |||
| 86 | public function doneWrites() { |
||
| 89 | |||
| 90 | public function lastDoneWrites() { |
||
| 93 | |||
| 94 | public function writesPending() { |
||
| 97 | |||
| 98 | public function writesOrCallbacksPending() { |
||
| 101 | |||
| 102 | public function pendingWriteQueryDuration() { |
||
| 105 | |||
| 106 | public function pendingWriteCallers() { |
||
| 109 | |||
| 110 | public function isOpen() { |
||
| 113 | |||
| 114 | public function setFlag( $flag ) { |
||
| 117 | |||
| 118 | public function clearFlag( $flag ) { |
||
| 121 | |||
| 122 | public function getFlag( $flag ) { |
||
| 125 | |||
| 126 | public function getProperty( $name ) { |
||
| 129 | |||
| 130 | public function getWikiID() { |
||
| 133 | |||
| 134 | public function getType() { |
||
| 137 | |||
| 138 | public function open( $server, $user, $password, $dbName ) { |
||
| 141 | |||
| 142 | public function fetchObject( $res ) { |
||
| 145 | |||
| 146 | public function fetchRow( $res ) { |
||
| 149 | |||
| 150 | public function numRows( $res ) { |
||
| 153 | |||
| 154 | public function numFields( $res ) { |
||
| 157 | |||
| 158 | public function fieldName( $res, $n ) { |
||
| 161 | |||
| 162 | public function insertId() { |
||
| 165 | |||
| 166 | public function dataSeek( $res, $row ) { |
||
| 169 | |||
| 170 | public function lastErrno() { |
||
| 173 | |||
| 174 | public function lastError() { |
||
| 177 | |||
| 178 | public function fieldInfo( $table, $field ) { |
||
| 181 | |||
| 182 | public function affectedRows() { |
||
| 185 | |||
| 186 | public function getSoftwareLink() { |
||
| 189 | |||
| 190 | public function getServerVersion() { |
||
| 193 | |||
| 194 | public function close() { |
||
| 197 | |||
| 198 | public function reportConnectionError( $error = 'Unknown error' ) { |
||
| 201 | |||
| 202 | public function query( $sql, $fname = __METHOD__, $tempIgnore = false ) { |
||
| 205 | |||
| 206 | public function reportQueryError( $error, $errno, $sql, $fname, $tempIgnore = false ) { |
||
| 209 | |||
| 210 | public function freeResult( $res ) { |
||
| 213 | |||
| 214 | public function selectField( |
||
| 219 | |||
| 220 | public function selectFieldValues( |
||
| 225 | |||
| 226 | public function select( |
||
| 232 | |||
| 233 | public function selectSQLText( |
||
| 239 | |||
| 240 | public function selectRow( |
||
| 246 | |||
| 247 | public function estimateRowCount( |
||
| 252 | |||
| 253 | public function selectRowCount( |
||
| 258 | |||
| 259 | public function fieldExists( $table, $field, $fname = __METHOD__ ) { |
||
| 262 | |||
| 263 | public function indexExists( $table, $index, $fname = __METHOD__ ) { |
||
| 266 | |||
| 267 | public function tableExists( $table, $fname = __METHOD__ ) { |
||
| 270 | |||
| 271 | public function indexUnique( $table, $index ) { |
||
| 274 | |||
| 275 | public function insert( $table, $a, $fname = __METHOD__, $options = [] ) { |
||
| 278 | |||
| 279 | public function update( $table, $values, $conds, $fname = __METHOD__, $options = [] ) { |
||
| 282 | |||
| 283 | public function makeList( $a, $mode = LIST_COMMA ) { |
||
| 286 | |||
| 287 | public function makeWhereFrom2d( $data, $baseKey, $subKey ) { |
||
| 290 | |||
| 291 | public function bitNot( $field ) { |
||
| 294 | |||
| 295 | public function bitAnd( $fieldLeft, $fieldRight ) { |
||
| 298 | |||
| 299 | public function bitOr( $fieldLeft, $fieldRight ) { |
||
| 302 | |||
| 303 | public function buildConcat( $stringList ) { |
||
| 306 | |||
| 307 | public function buildGroupConcatField( |
||
| 312 | |||
| 313 | public function selectDB( $db ) { |
||
| 316 | |||
| 317 | public function getDBname() { |
||
| 320 | |||
| 321 | public function getServer() { |
||
| 324 | |||
| 325 | public function addQuotes( $s ) { |
||
| 328 | |||
| 329 | public function buildLike() { |
||
| 332 | |||
| 333 | public function anyChar() { |
||
| 336 | |||
| 337 | public function anyString() { |
||
| 340 | |||
| 341 | public function nextSequenceValue( $seqName ) { |
||
| 344 | |||
| 345 | public function replace( $table, $uniqueIndexes, $rows, $fname = __METHOD__ ) { |
||
| 348 | |||
| 349 | public function upsert( |
||
| 354 | |||
| 355 | public function deleteJoin( |
||
| 360 | |||
| 361 | public function delete( $table, $conds, $fname = __METHOD__ ) { |
||
| 364 | |||
| 365 | public function insertSelect( |
||
| 371 | |||
| 372 | public function unionSupportsOrderAndLimit() { |
||
| 375 | |||
| 376 | public function unionQueries( $sqls, $all ) { |
||
| 379 | |||
| 380 | public function conditional( $cond, $trueVal, $falseVal ) { |
||
| 383 | |||
| 384 | public function strreplace( $orig, $old, $new ) { |
||
| 387 | |||
| 388 | public function getServerUptime() { |
||
| 391 | |||
| 392 | public function wasDeadlock() { |
||
| 395 | |||
| 396 | public function wasLockTimeout() { |
||
| 399 | |||
| 400 | public function wasErrorReissuable() { |
||
| 403 | |||
| 404 | public function wasReadOnlyError() { |
||
| 407 | |||
| 408 | public function masterPosWait( DBMasterPos $pos, $timeout ) { |
||
| 411 | |||
| 412 | public function getSlavePos() { |
||
| 415 | |||
| 416 | public function getMasterPos() { |
||
| 419 | |||
| 420 | public function serverIsReadOnly() { |
||
| 423 | |||
| 424 | public function onTransactionResolution( callable $callback ) { |
||
| 427 | |||
| 428 | public function onTransactionIdle( callable $callback ) { |
||
| 431 | |||
| 432 | public function onTransactionPreCommitOrIdle( callable $callback ) { |
||
| 435 | |||
| 436 | public function startAtomic( $fname = __METHOD__ ) { |
||
| 439 | |||
| 440 | public function endAtomic( $fname = __METHOD__ ) { |
||
| 443 | |||
| 444 | public function doAtomicSection( $fname, callable $callback ) { |
||
| 447 | |||
| 448 | public function begin( $fname = __METHOD__ ) { |
||
| 451 | |||
| 452 | public function commit( $fname = __METHOD__, $flush = '' ) { |
||
| 455 | |||
| 456 | public function rollback( $fname = __METHOD__, $flush = '' ) { |
||
| 459 | |||
| 460 | public function listTables( $prefix = null, $fname = __METHOD__ ) { |
||
| 463 | |||
| 464 | public function timestamp( $ts = 0 ) { |
||
| 467 | |||
| 468 | public function timestampOrNull( $ts = null ) { |
||
| 471 | |||
| 472 | public function ping() { |
||
| 475 | |||
| 476 | public function getLag() { |
||
| 479 | |||
| 480 | public function getSessionLagStatus() { |
||
| 483 | |||
| 484 | public function maxListLen() { |
||
| 487 | |||
| 488 | public function encodeBlob( $b ) { |
||
| 491 | |||
| 492 | public function decodeBlob( $b ) { |
||
| 495 | |||
| 496 | public function setSessionOptions( array $options ) { |
||
| 499 | |||
| 500 | public function setSchemaVars( $vars ) { |
||
| 503 | |||
| 504 | public function lockIsFree( $lockName, $method ) { |
||
| 507 | |||
| 508 | public function lock( $lockName, $method, $timeout = 5 ) { |
||
| 511 | |||
| 512 | public function unlock( $lockName, $method ) { |
||
| 515 | |||
| 516 | public function getScopedLockAndFlush( $lockKey, $fname, $timeout ) { |
||
| 519 | |||
| 520 | public function namedLocksEnqueue() { |
||
| 523 | |||
| 524 | public function getInfinity() { |
||
| 527 | |||
| 528 | public function encodeExpiry( $expiry ) { |
||
| 531 | |||
| 532 | public function decodeExpiry( $expiry, $format = TS_MW ) { |
||
| 535 | |||
| 536 | public function setBigSelects( $value = true ) { |
||
| 539 | |||
| 540 | public function isReadOnly() { |
||
| 543 | |||
| 544 | /** |
||
| 545 | * Clean up the connection when out of scope |
||
| 546 | */ |
||
| 547 | function __destruct() { |
||
| 552 | } |
||
| 553 |