wikimedia / mediawiki

includes/specials/SpecialUserlogin.php

Doc Comments +3 added lines, -3 removed lines

@@ -136,7 +136,7 @@ 
 	/**
 	 * Returns an array of all valid error messages.
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	public static function getValidErrorMessages() {
 		static $messages = null;
@@ -1222,7 +1222,7 @@ 
 	 * Display a "successful action" page.
 	 *
 	 * @param string $type Condition of return to; see `executeReturnTo`
-	 * @param string|Message $title Page's title
+	 * @param Message $title Page's title
 	 * @param string $msgname
 	 * @param string $injected_html
 	 */
@@ -1735,7 +1735,7 @@ 
 	 * Private function to check password expiration, until AuthManager comes
 	 * along to handle that.
 	 * @param User $user
-	 * @return string|bool
+	 * @return string|false
 	 */
 	private function checkUserPasswordExpired( User $user ) {
 		global $wgPasswordExpireGrace;

includes/specials/SpecialUserrights.php

Doc Comments +1 added lines, -1 removed lines

@@ -308,7 +308,7 @@
 	 * @param User $user
 	 * @param array $oldGroups
 	 * @param array $newGroups
-	 * @param array $reason
+	 * @param string $reason
 	 */
 	function addLogEntry( $user, $oldGroups, $newGroups, $reason ) {
 		$logEntry = new ManualLogEntry( 'rights', 'rights' );

includes/specials/SpecialVersion.php

Doc Comments +7 added lines, -3 removed lines

@@ -360,7 +360,7 @@ 
 
 	/**
 	 * @since 1.22 Returns the HEAD date in addition to the sha1 and link
-	 * @return bool|string Global wgVersion + HEAD sha1 stripped to the first 7 chars
+	 * @return false|string Global wgVersion + HEAD sha1 stripped to the first 7 chars
 	 *   with link and date, or false on failure
 	 */
 	private static function getVersionLinkedGit() {
@@ -934,6 +934,10 @@ 
 		}
 	}
 
+	/**
+	 * @param string $text
+	 * @param string $name
+	 */
 	private function openExtType( $text = null, $name = null ) {
 		$out = '';
 
@@ -1052,7 +1056,7 @@ 
 	 *
 	 * @since 1.23
 	 *
-	 * @return bool|string False if no such file exists, otherwise returns
+	 * @return false|string False if no such file exists, otherwise returns
 	 * a path to it.
 	 */
 	public static function getExtAuthorsFileName( $extDir ) {
@@ -1081,7 +1085,7 @@ 
 	 *
 	 * @since 1.23
 	 *
-	 * @return bool|string False if no such file exists, otherwise returns
+	 * @return false|string False if no such file exists, otherwise returns
 	 * a path to it.
 	 */
 	public static function getExtLicenseFileName( $extDir ) {

includes/specials/SpecialWatchlist.php

Doc Comments +7 added lines, -1 removed lines

@@ -293,6 +293,9 @@ 
 		);
 	}
 
+	/**
+	 * @param FormOptions $opts
+	 */
 	protected function runMainQueryHook( &$tables, &$fields, &$conds, &$query_options,
 		&$join_conds, $opts
 	) {
@@ -516,6 +519,9 @@ 
 		$this->setBottomText( $opts );
 	}
 
+	/**
+	 * @param FormOptions $options
+	 */
 	function cutoffselector( $options ) {
 		// Cast everything to strings immediately, so that we know all of the values have the same
 		// precision, and can be compared with '==='. 2/24 has a few more decimal places than its
@@ -625,7 +631,7 @@ 
 	 * Count the number of items on a user's watchlist
 	 *
 	 * @param IDatabase $dbr A database connection
-	 * @return int
+	 * @return double
 	 */
 	protected function countItems( $dbr ) {
 		# Fetch the raw count

includes/specials/SpecialWhatlinkshere.php

Doc Comments +13 added lines

@@ -303,10 +303,17 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $level
+	 */
 	protected function listStart( $level ) {
 		return Xml::openElement( 'ul', ( $level ? array() : array( 'id' => 'mw-whatlinkshere-list' ) ) );
 	}
 
+	/**
+	 * @param Title $nt
+	 * @param Title $target
+	 */
 	protected function listItem( $row, $nt, $target, $notClose = false ) {
 		$dirmark = $this->getLanguage()->getDirMark();
 
@@ -405,6 +412,9 @@ 
 		return $this->getLanguage()->pipeList( $links );
 	}
 
+	/**
+	 * @param string $text
+	 */
 	function makeSelfLink( $text, $query ) {
 		return Linker::linkKnown(
 			$this->selfTitle,
@@ -414,6 +424,9 @@ 
 		);
 	}
 
+	/**
+	 * @param integer $prevId
+	 */
 	function getPrevNext( $prevId, $nextId ) {
 		$currentLimit = $this->opts->getValue( 'limit' );
 		$prev = $this->msg( 'whatlinkshere-prev' )->numParams( $currentLimit )->escaped();

includes/Status.php

Doc Comments +4 added lines, -4 removed lines

@@ -147,7 +147,7 @@ 
 	 * Add an error, do not set fatal flag
 	 * This can be used for non-fatal errors
 	 *
-	 * @param string|Message $message Message name or object
+	 * @param string|false $message Message name or object
 	 */
 	public function error( $message /*, parameters... */ ) {
 		call_user_func_array( array( $this->sv, 'error' ), func_get_args() );
@@ -400,7 +400,7 @@ 
 	/**
 	 * Returns true if the specified message is present as a warning or error
 	 *
-	 * @param string|Message $message Message key or object to search for
+	 * @param string $message Message key or object to search for
 	 *
 	 * @return bool
 	 */
@@ -415,8 +415,8 @@ 
 	 * Note, due to the lack of tools for comparing Message objects, this
 	 * function will not work when using a Message object as the search parameter.
 	 *
-	 * @param Message|string $source Message key or object to search for
-	 * @param Message|string $dest Replacement message key or object
+	 * @param string $source Message key or object to search for
+	 * @param string $dest Replacement message key or object
 	 * @return bool Return true if the replacement was done, false otherwise.
 	 */
 	public function replaceMessage( $source, $dest ) {

includes/TitleArrayFromResult.php

Doc Comments +3 added lines

@@ -32,6 +32,9 @@
 
 	public $current;
 
+	/**
+	 * @param ResultWrapper $res
+	 */
 	function __construct( $res ) {
 		$this->res = $res;
 		$this->key = 0;

includes/upload/UploadBase.php

Doc Comments +2 added lines, -3 removed lines

@@ -265,7 +265,7 @@ 
 
 	/**
 	 * @param string $srcPath The source path
-	 * @return string|bool The real path if it was a virtual URL Returns false on failure
+	 * @return string|false The real path if it was a virtual URL Returns false on failure
 	 */
 	function getRealPath( $srcPath ) {
 		$repo = RepoGroup::singleton()->getLocalRepo();
@@ -1513,7 +1513,6 @@ 
 	 * Check a block of CSS or CSS fragment for anything that looks like
 	 * it is bringing in remote code.
 	 * @param string $value a string of CSS
-	 * @param bool $propOnly only check css properties (start regex with :)
 	 * @return bool true if the CSS contains an illegal string, false if otherwise
 	 */
 	private static function checkCssFragment( $value ) {
@@ -1887,7 +1886,7 @@ 
 	 * format, presumably.
 	 *
 	 * @param ApiResult $result
-	 * @return array Image info
+	 * @return User Image info
 	 */
 	public function getImageInfo( $result ) {
 		$file = $this->getLocalFile();

includes/upload/UploadFromChunks.php

Doc Comments +3 added lines

@@ -333,6 +333,9 @@
 		return $storeStatus;
 	}
 
+	/**
+	 * @param integer $index
+	 */
 	private function getChunkFileKey( $index = null ) {
 		if ( $index === null ) {
 			$index = $this->getChunkIndex();