wikimedia / mediawiki

includes/debug/MWDebug.php

Doc Comments +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
 	 * Adds a line to the log
 	 *
 	 * @since 1.19
-	 * @param mixed $str
+	 * @param string $str
 	 */
 	public static function log( $str ) {
 		if ( !self::$enabled ) {

includes/filebackend/FSFileBackend.php

Doc Comments +5 added lines, -1 removed lines

@@ -470,6 +470,10 @@ 
 		return $status;
 	}
 
+	/**
+	 * @param string $fullCont
+	 * @param string $dirRel
+	 */
 	protected function doSecureInternal( $fullCont, $dirRel, array $params ) {
 		$status = Status::newGood();
 		list( , $shortCont, ) = FileBackend::splitStoragePath( $params['dir'] );
@@ -885,7 +889,7 @@ 
 
 	/**
 	 * @see Iterator::current()
-	 * @return string|bool String or false
+	 * @return string String or false
 	 */
 	public function current() {
 		return $this->getRelPath( $this->iter->current()->getPathname() );

includes/jobqueue/JobQueue.php

Doc Comments +1 added lines, -1 removed lines

@@ -377,7 +377,7 @@
 
 	/**
 	 * @see JobQueue::pop()
-	 * @return Job|bool
+	 * @return Job
 	 */
 	abstract protected function doPop();
 

includes/session/CookieSessionProvider.php

Doc Comments +2 added lines, -2 removed lines

@@ -302,8 +302,8 @@
 	 * @param \WebRequest $request
 	 * @param string $key
 	 * @param string $prefix
-	 * @param mixed $default
-	 * @return mixed
+	 * @param boolean $default
+	 * @return string
 	 */
 	protected function getCookie( $request, $key, $prefix, $default = null ) {
 		$value = $request->getCookie( $key, $prefix, $default );

includes/EditPage.php

Doc Comments +15 added lines, -8 removed lines

@@ -2169,7 +2169,7 @@ 
 	 *
 	 * @param string $text
 	 *
-	 * @return string|bool Matching string or false
+	 * @return string|false Matching string or false
 	 */
 	public static function matchSpamRegex( $text ) {
 		global $wgSpamRegex;
@@ -2183,7 +2183,7 @@ 
 	 *
 	 * @param string $text
 	 *
-	 * @return string|bool Matching string or false
+	 * @return string|false Matching string or false
 	 */
 	public static function matchSummarySpamRegex( $text ) {
 		global $wgSummarySpamRegex;
@@ -2194,7 +2194,7 @@ 
 	/**
 	 * @param string $text
 	 * @param array $regexes
-	 * @return bool|string
+	 * @return string|false
 	 */
 	protected static function matchSpamRegexInternal( $text, $regexes ) {
 		foreach ( $regexes as $regex ) {
@@ -2437,7 +2437,7 @@ 
 	 * $this->allowNonTextContent to true to allow editing of non-textual
 	 * content.
 	 *
-	 * @param string|null|bool $text Text to unserialize
+	 * @param false|string $text Text to unserialize
 	 * @return Content The content object created from $text. If $text was false
 	 *   or null, false resp. null will be  returned instead.
 	 *
@@ -3128,6 +3128,10 @@ 
 		$this->showTextbox( $this->textbox2, 'wpTextbox2', array( 'tabindex' => 6, 'readonly' ) );
 	}
 
+	/**
+	 * @param string $text
+	 * @param string $name
+	 */
 	protected function showTextbox( $text, $name, $customAttribs = array() ) {
 		global $wgOut, $wgUser;
 
@@ -3157,6 +3161,9 @@ 
 		$wgOut->addHTML( Html::textarea( $name, $wikitext, $attribs ) );
 	}
 
+	/**
+	 * @param string $previewOutput
+	 */
 	protected function displayPreviewArea( $previewOutput, $isOnTop = false ) {
 		global $wgOut;
 		$classes = array();
@@ -3740,7 +3747,7 @@ 
 	}
 
 	/**
-	 * @return array
+	 * @return Title[]
 	 */
 	function getTemplates() {
 		if ( $this->preview || $this->section != '' ) {
@@ -3763,7 +3770,7 @@ 
 	 * Shows a bulletin board style toolbar for common editing functions.
 	 * It can be disabled in the user preferences.
 	 *
-	 * @param $title Title object for the page being edited (optional)
+	 * @param Title $title Title object for the page being edited (optional)
 	 * @return string
 	 */
 	static function getEditToolbar( $title = null ) {
@@ -3903,7 +3910,7 @@ 
 	 * @param array $checked Array of checkbox => bool, where bool indicates the checked
 	 *                 status of the checkbox
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public function getCheckboxes( &$tabindex, $checked ) {
 		global $wgUser, $wgUseMediaWikiUIEverywhere;
@@ -3967,7 +3974,7 @@ 
 	 *
 	 * @param int $tabindex Current tabindex
 	 *
-	 * @return array
+	 * @return string
 	 */
 	public function getEditButtons( &$tabindex ) {
 		$buttons = array();

includes/db/DatabaseOracle.php

Doc Comments +14 added lines, -2 removed lines

@@ -85,6 +85,9 @@ 
 		unset( $this->db );
 	}
 
+	/**
+	 * @param integer $row
+	 */
 	public function seek( $row ) {
 		$this->cursor = min( $row, $this->nrows );
 	}
@@ -484,7 +487,7 @@ 
 
 	/**
 	 * This must be called after nextSequenceVal
-	 * @return null|int
+	 * @return integer
 	 */
 	function insertId() {
 		return $this->mInsertId;
@@ -571,6 +574,9 @@ 
 		return $retVal;
 	}
 
+	/**
+	 * @param string $table
+	 */
 	private function fieldBindStatement( $table, $col, &$val, $includeCol = false ) {
 		$col_info = $this->fieldInfoMulti( $table, $col );
 		$col_type = $col_info != false ? $col_info->type() : 'CONSTANT';
@@ -812,6 +818,9 @@ 
 		return strtoupper( parent::tableName( $name, $format ) );
 	}
 
+	/**
+	 * @param string $name
+	 */
 	function tableNameInternal( $name ) {
 		$name = $this->tableName( $name );
 
@@ -1269,6 +1278,9 @@ 
 		return "'" . $this->strencode( $s ) . "'";
 	}
 
+	/**
+	 * @param string $s
+	 */
 	public function addIdentifierQuotes( $s ) {
 		if ( !$this->getFlag( DBO_DDLMODE ) ) {
 			$s = '/*Q*/' . $s;
@@ -1332,7 +1344,7 @@ 
 	 *
 	 * @param array $options An associative array of options to be turned into
 	 *   an SQL query, valid keys are listed in the function.
-	 * @return array
+	 * @return string[]
 	 */
 	function makeSelectOptions( $options ) {
 		$preLimitTail = $postLimitTail = '';

includes/db/loadbalancer/LoadBalancer.php

Doc Comments +5 added lines, -5 removed lines

@@ -232,7 +232,7 @@ 
 	 * @param string|bool $group Query group, or false for the generic reader
 	 * @param string|bool $wiki Wiki ID, or false for the current wiki
 	 * @throws MWException
-	 * @return bool|int|string
+	 * @return string
 	 */
 	public function getReaderIndex( $group = false, $wiki = false ) {
 		global $wgDBtype;
@@ -437,7 +437,7 @@ 
 	 * Returns false if there is no connection open
 	 *
 	 * @param int $i
-	 * @return DatabaseBase|bool False on failure
+	 * @return DatabaseBase|null False on failure
 	 */
 	public function getAnyOpenConnection( $i ) {
 		foreach ( $this->mConns as $conns ) {
@@ -968,7 +968,7 @@ 
 
 	/**
 	 * Get the current master position for chronology control purposes
-	 * @return mixed
+	 * @return DBMasterPos
 	 */
 	public function getMasterPos() {
 		# If this entire request was served from a slave without opening a connection to the
@@ -1289,7 +1289,7 @@ 
 	/**
 	 * Call a function with each open connection object
 	 * @param callable $callback
-	 * @param array $params
+	 * @param string[] $params
 	 */
 	public function forEachOpenConnection( $callback, array $params = [] ) {
 		foreach ( $this->mConns as $conns2 ) {
@@ -1364,7 +1364,7 @@ 
 	 * case on many installations.
 	 *
 	 * @param IDatabase $conn
-	 * @return int|bool Returns false on error
+	 * @return integer Returns false on error
 	 */
 	public function safeGetLag( IDatabase $conn ) {
 		if ( $this->getServerCount() == 1 ) {

includes/interwiki/Interwiki.php

Doc Comments +6 added lines

@@ -53,6 +53,9 @@ 
 	/** @var bool Whether interwiki transclusions are allowed */
 	protected $mTrans;
 
+	/**
+	 * @param string $prefix
+	 */
 	public function __construct( $prefix = null, $url = '', $api = '', $wikiId = '', $local = 0,
 		$trans = 0
 	) {
@@ -192,6 +195,9 @@ 
 		return $value;
 	}
 
+	/**
+	 * @return string
+	 */
 	private static function getCacheValue( $key ) {
 		global $wgInterwikiCache;
 		static $reader;

includes/page/ImagePage.php

Doc Comments +5 added lines, -5 removed lines

@@ -55,7 +55,7 @@ 
 	/**
 	 * Constructor from a page id
 	 * @param int $id Article ID to load
-	 * @return ImagePage|null
+	 * @return ImagePage
 	 */
 	public static function newFromID( $id ) {
 		$t = Title::newFromID( $id );
@@ -266,7 +266,7 @@ 
 	 *
 	 * @todo FIXME: Bad interface, see note on MediaHandler::formatMetadata().
 	 *
-	 * @param array $metadata The array containing the Exif data
+	 * @param boolean $metadata The array containing the Exif data
 	 * @return string The metadata table. This is treated as Wikitext (!)
 	 */
 	protected function makeMetadataTable( $metadata ) {
@@ -295,7 +295,7 @@ 
 	 *
 	 * Omit noarticletext if sharedupload; text will be fetched from the
 	 * shared upload server if possible.
-	 * @return string
+	 * @return null|Content
 	 */
 	public function getContentObject() {
 		$this->loadFile();
@@ -636,7 +636,7 @@ 
 	 * Make the text under the image to say what size preview
 	 *
 	 * @param $params Array parameters for thumbnail
-	 * @param $sizeLinkBigImagePreview HTML for the current size
+	 * @param string $sizeLinkBigImagePreview HTML for the current size
 	 * @return string HTML output
 	 */
 	private function getThumbPrevText( $params, $sizeLinkBigImagePreview ) {
@@ -1211,7 +1211,7 @@ 
 
 	/**
 	 * @see WikiFilePage::getFile
-	 * @return bool|File
+	 * @return File
 	 */
 	public function getFile() {
 		return $this->mPage->getFile();