View GitHub Repository mediawiki

Schedule Inspection
Subscribe

Code Duplication    Length = 5-5 lines in 2 locations

includes/auth/AuthPluginPrimaryAuthenticationProvider.php 2 locations

@@ 194-198 (lines=5) @@
191 

                                

                                                            

                                    192
                                    
                                    
	public function beginPrimaryAuthentication( array $reqs ) {

                                

                                                            

                                    193
                                    
                                    
		$req = AuthenticationRequest::getRequestByClass( $reqs, $this->requestType );

                                

                                                            

                                    194
                                    
                                    
		if ( !$req || $req->username === null || $req->password === null ||

                                

                                                            

                                    195
                                    
                                    
			( $this->hasDomain && $req->domain === null )

                                

                                                            

                                    196
                                    
                                    
		) {

                                

                                                            

                                    197
                                    
                                    
			return AuthenticationResponse::newAbstain();

                                

                                                            

                                    198
                                    
                                    
		}

                                

                                                            

                                    199
                                    
                                    

                                

                                                            

                                    200
                                    
                                    
		$username = User::getCanonicalName( $req->username, 'usable' );

                                

                                                            

                                    201
                                    
                                    
		if ( $username === false ) {

                                

                                                                                

                                
                                
                                    @@ 396-400 (lines=5) @@
                                
                            


                                                            

                                    393
                                    
                                    
		}

                                

                                                            

                                    394
                                    
                                    

                                

                                                            

                                    395
                                    
                                    
		$req = AuthenticationRequest::getRequestByClass( $reqs, $this->requestType );

                                

                                                            

                                    396
                                    
                                    
		if ( !$req || $req->username === null || $req->password === null ||

                                

                                                            

                                    397
                                    
                                    
			( $this->hasDomain && $req->domain === null )

                                

                                                            

                                    398
                                    
                                    
		) {

                                

                                                            

                                    399
                                    
                                    
			return AuthenticationResponse::newAbstain();

                                

                                                            

                                    400
                                    
                                    
		}

                                

                                                            

                                    401
                                    
                                    

                                

                                                            

                                    402
                                    
                                    
		$username = User::getCanonicalName( $req->username, 'usable' );

                                

                                                            

                                    403
                                    
                                    
		if ( $username === false ) {