wikimedia /
mediawiki
| Conditions | 15 |
| Paths | 256 |
| Total Lines | 102 |
| Code Lines | 69 |
| Lines | 22 |
| Ratio | 21.57 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 44 | public function execute() { |
||
| 45 | global $wgUploadStashMaxAge; |
||
| 46 | |||
| 47 | $repo = RepoGroup::singleton()->getLocalRepo(); |
||
| 48 | $tempRepo = $repo->getTempRepo(); |
||
| 49 | |||
| 50 | $dbr = $repo->getSlaveDB(); |
||
| 51 | |||
| 52 | // how far back should this look for files to delete? |
||
| 53 | $cutoff = time() - $wgUploadStashMaxAge; |
||
| 54 | |||
| 55 | $this->output( "Getting list of files to clean up...\n" ); |
||
| 56 | $res = $dbr->select( |
||
| 57 | 'uploadstash', |
||
| 58 | 'us_key', |
||
| 59 | 'us_timestamp < ' . $dbr->addQuotes( $dbr->timestamp( $cutoff ) ), |
||
| 60 | __METHOD__ |
||
| 61 | ); |
||
| 62 | |||
| 63 | // Delete all registered stash files... |
||
| 64 | if ( $res->numRows() == 0 ) { |
||
| 65 | $this->output( "No stashed files to cleanup according to the DB.\n" ); |
||
| 66 | } else { |
||
| 67 | // finish the read before starting writes. |
||
| 68 | $keys = []; |
||
| 69 | foreach ( $res as $row ) { |
||
| 70 | array_push( $keys, $row->us_key ); |
||
| 71 | } |
||
| 72 | |||
| 73 | $this->output( 'Removing ' . count( $keys ) . " file(s)...\n" ); |
||
| 74 | // this could be done some other, more direct/efficient way, but using |
||
| 75 | // UploadStash's own methods means it's less likely to fall accidentally |
||
| 76 | // out-of-date someday |
||
| 77 | $stash = new UploadStash( $repo ); |
||
| 78 | |||
| 79 | $i = 0; |
||
| 80 | foreach ( $keys as $key ) { |
||
| 81 | $i++; |
||
| 82 | try { |
||
| 83 | $stash->getFile( $key, true ); |
||
| 84 | $stash->removeFileNoAuth( $key ); |
||
| 85 | } catch ( UploadStashException $ex ) { |
||
| 86 | $type = get_class( $ex ); |
||
| 87 | $this->output( "Failed removing stashed upload with key: $key ($type)\n" ); |
||
| 88 | } |
||
| 89 | if ( $i % 100 == 0 ) { |
||
| 90 | wfWaitForSlaves(); |
||
| 91 | $this->output( "$i\n" ); |
||
| 92 | } |
||
| 93 | } |
||
| 94 | $this->output( "$i done\n" ); |
||
| 95 | } |
||
| 96 | |||
| 97 | // Delete all the corresponding thumbnails... |
||
| 98 | $dir = $tempRepo->getZonePath( 'thumb' ); |
||
| 99 | $iterator = $tempRepo->getBackend()->getFileList( [ 'dir' => $dir, 'adviseStat' => 1 ] ); |
||
| 100 | $this->output( "Deleting old thumbnails...\n" ); |
||
| 101 | $i = 0; |
||
| 102 | $batch = []; // operation batch |
||
| 103 | View Code Duplication | foreach ( $iterator as $file ) { |
|
| 104 | if ( wfTimestamp( TS_UNIX, $tempRepo->getFileTimestamp( "$dir/$file" ) ) < $cutoff ) { |
||
| 105 | $batch[] = [ 'op' => 'delete', 'src' => "$dir/$file" ]; |
||
| 106 | if ( count( $batch ) >= $this->mBatchSize ) { |
||
| 107 | $this->doOperations( $tempRepo, $batch ); |
||
| 108 | $i += count( $batch ); |
||
| 109 | $batch = []; |
||
| 110 | $this->output( "$i\n" ); |
||
| 111 | } |
||
| 112 | } |
||
| 113 | } |
||
| 114 | if ( count( $batch ) ) { |
||
| 115 | $this->doOperations( $tempRepo, $batch ); |
||
| 116 | $i += count( $batch ); |
||
| 117 | } |
||
| 118 | $this->output( "$i done\n" ); |
||
| 119 | |||
| 120 | // Apparently lots of stash files are not registered in the DB... |
||
| 121 | $dir = $tempRepo->getZonePath( 'public' ); |
||
| 122 | $iterator = $tempRepo->getBackend()->getFileList( [ 'dir' => $dir, 'adviseStat' => 1 ] ); |
||
| 123 | $this->output( "Deleting orphaned temp files...\n" ); |
||
| 124 | if ( strpos( $dir, '/local-temp' ) === false ) { // sanity check |
||
| 125 | $this->error( "Temp repo is not using the temp container.", 1 ); // die |
||
| 126 | } |
||
| 127 | $i = 0; |
||
| 128 | $batch = []; // operation batch |
||
| 129 | View Code Duplication | foreach ( $iterator as $file ) { |
|
| 130 | if ( wfTimestamp( TS_UNIX, $tempRepo->getFileTimestamp( "$dir/$file" ) ) < $cutoff ) { |
||
| 131 | $batch[] = [ 'op' => 'delete', 'src' => "$dir/$file" ]; |
||
| 132 | if ( count( $batch ) >= $this->mBatchSize ) { |
||
| 133 | $this->doOperations( $tempRepo, $batch ); |
||
| 134 | $i += count( $batch ); |
||
| 135 | $batch = []; |
||
| 136 | $this->output( "$i\n" ); |
||
| 137 | } |
||
| 138 | } |
||
| 139 | } |
||
| 140 | if ( count( $batch ) ) { |
||
| 141 | $this->doOperations( $tempRepo, $batch ); |
||
| 142 | $i += count( $batch ); |
||
| 143 | } |
||
| 144 | $this->output( "$i done\n" ); |
||
| 145 | } |
||
| 146 | |||
| 157 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.