wikimedia /
mediawiki
| Conditions | 20 |
| Paths | 8832 |
| Total Lines | 88 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 60 | public function execute() { |
||
| 61 | global $wgLocalisationCacheConf; |
||
| 62 | |||
| 63 | $force = $this->hasOption( 'force' ); |
||
| 64 | $threads = $this->getOption( 'threads', 1 ); |
||
| 65 | if ( $threads < 1 || $threads != intval( $threads ) ) { |
||
| 66 | $this->output( "Invalid thread count specified; running single-threaded.\n" ); |
||
| 67 | $threads = 1; |
||
| 68 | } |
||
| 69 | if ( $threads > 1 && wfIsWindows() ) { |
||
| 70 | $this->output( "Threaded rebuild is not supported on Windows; running single-threaded.\n" ); |
||
| 71 | $threads = 1; |
||
| 72 | } |
||
| 73 | if ( $threads > 1 && !function_exists( 'pcntl_fork' ) ) { |
||
| 74 | $this->output( "PHP pcntl extension is not present; running single-threaded.\n" ); |
||
| 75 | $threads = 1; |
||
| 76 | } |
||
| 77 | |||
| 78 | $conf = $wgLocalisationCacheConf; |
||
| 79 | $conf['manualRecache'] = false; // Allow fallbacks to create CDB files |
||
| 80 | if ( $force ) { |
||
| 81 | $conf['forceRecache'] = true; |
||
| 82 | } |
||
| 83 | if ( $this->hasOption( 'outdir' ) ) { |
||
| 84 | $conf['storeDirectory'] = $this->getOption( 'outdir' ); |
||
| 85 | } |
||
| 86 | $lc = new LocalisationCacheBulkLoad( $conf ); |
||
| 87 | |||
| 88 | $allCodes = array_keys( Language::fetchLanguageNames( null, 'mwfile' ) ); |
||
| 89 | if ( $this->hasOption( 'lang' ) ) { |
||
| 90 | # Validate requested languages |
||
| 91 | $codes = array_intersect( $allCodes, |
||
| 92 | explode( ',', $this->getOption( 'lang' ) ) ); |
||
| 93 | # Bailed out if nothing is left |
||
| 94 | if ( count( $codes ) == 0 ) { |
||
| 95 | $this->error( 'None of the languages specified exists.', 1 ); |
||
| 96 | } |
||
| 97 | } else { |
||
| 98 | # By default get all languages |
||
| 99 | $codes = $allCodes; |
||
| 100 | } |
||
| 101 | sort( $codes ); |
||
| 102 | |||
| 103 | // Initialise and split into chunks |
||
| 104 | $numRebuilt = 0; |
||
| 105 | $total = count( $codes ); |
||
| 106 | $chunks = array_chunk( $codes, ceil( count( $codes ) / $threads ) ); |
||
| 107 | $pids = []; |
||
| 108 | $parentStatus = 0; |
||
| 109 | foreach ( $chunks as $codes ) { |
||
| 110 | // Do not fork for only one thread |
||
| 111 | $pid = ( $threads > 1 ) ? pcntl_fork() : -1; |
||
| 112 | |||
| 113 | if ( $pid === 0 ) { |
||
| 114 | // Child, reseed because there is no bug in PHP: |
||
| 115 | // https://bugs.php.net/bug.php?id=42465 |
||
| 116 | mt_srand( getmypid() ); |
||
| 117 | |||
| 118 | $this->doRebuild( $codes, $lc, $force ); |
||
| 119 | exit( 0 ); |
||
| 120 | } elseif ( $pid === -1 ) { |
||
| 121 | // Fork failed or one thread, do it serialized |
||
| 122 | $numRebuilt += $this->doRebuild( $codes, $lc, $force ); |
||
| 123 | } else { |
||
| 124 | // Main thread |
||
| 125 | $pids[] = $pid; |
||
| 126 | } |
||
| 127 | } |
||
| 128 | // Wait for all children |
||
| 129 | foreach ( $pids as $pid ) { |
||
| 130 | $status = 0; |
||
| 131 | pcntl_waitpid( $pid, $status ); |
||
| 132 | if ( pcntl_wexitstatus( $status ) ) { |
||
| 133 | // Pass a fatal error code through to the caller |
||
| 134 | $parentStatus = pcntl_wexitstatus( $status ); |
||
| 135 | } |
||
| 136 | } |
||
| 137 | |||
| 138 | if ( !$pids ) { |
||
| 139 | $this->output( "$numRebuilt languages rebuilt out of $total\n" ); |
||
| 140 | if ( $numRebuilt === 0 ) { |
||
| 141 | $this->output( "Use --force to rebuild the caches which are still fresh.\n" ); |
||
| 142 | } |
||
| 143 | } |
||
| 144 | if ( $parentStatus ) { |
||
| 145 | exit( $parentStatus ); |
||
| 146 | } |
||
| 147 | } |
||
| 148 | |||
| 182 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.