wikimedia /
mediawiki
| Conditions | 6 |
| Paths | 22 |
| Total Lines | 101 |
| Code Lines | 61 |
| Lines | 10 |
| Ratio | 9.9 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 38 | public function run() { |
||
| 39 | $scope = RequestContext::importScopedSession( $this->params['session'] ); |
||
| 40 | $this->addTeardownCallback( function () use ( &$scope ) { |
||
| 41 | ScopedCallback::consume( $scope ); // T126450 |
||
| 42 | } ); |
||
| 43 | |||
| 44 | $context = RequestContext::getMain(); |
||
| 45 | $user = $context->getUser(); |
||
| 46 | try { |
||
| 47 | if ( !$user->isLoggedIn() ) { |
||
| 48 | $this->setLastError( "Could not load the author user from session." ); |
||
| 49 | |||
| 50 | return false; |
||
| 51 | } |
||
| 52 | |||
| 53 | UploadBase::setSessionStatus( |
||
| 54 | $user, |
||
| 55 | $this->params['filekey'], |
||
| 56 | [ 'result' => 'Poll', 'stage' => 'publish', 'status' => Status::newGood() ] |
||
| 57 | ); |
||
| 58 | |||
| 59 | $upload = new UploadFromStash( $user ); |
||
| 60 | // @todo initialize() causes a GET, ideally we could frontload the antivirus |
||
| 61 | // checks and anything else to the stash stage (which includes concatenation and |
||
| 62 | // the local file is thus already there). That way, instead of GET+PUT, there could |
||
| 63 | // just be a COPY operation from the stash to the public zone. |
||
| 64 | $upload->initialize( $this->params['filekey'], $this->params['filename'] ); |
||
| 65 | |||
| 66 | // Check if the local file checks out (this is generally a no-op) |
||
| 67 | $verification = $upload->verifyUpload(); |
||
| 68 | if ( $verification['status'] !== UploadBase::OK ) { |
||
| 69 | $status = Status::newFatal( 'verification-error' ); |
||
| 70 | $status->value = [ 'verification' => $verification ]; |
||
| 71 | UploadBase::setSessionStatus( |
||
| 72 | $user, |
||
| 73 | $this->params['filekey'], |
||
| 74 | [ 'result' => 'Failure', 'stage' => 'publish', 'status' => $status ] |
||
| 75 | ); |
||
| 76 | $this->setLastError( "Could not verify upload." ); |
||
| 77 | |||
| 78 | return false; |
||
| 79 | } |
||
| 80 | |||
| 81 | // Upload the stashed file to a permanent location |
||
| 82 | $status = $upload->performUpload( |
||
| 83 | $this->params['comment'], |
||
| 84 | $this->params['text'], |
||
| 85 | $this->params['watch'], |
||
| 86 | $user, |
||
| 87 | isset( $this->params['tags'] ) ? $this->params['tags'] : [] |
||
| 88 | ); |
||
| 89 | View Code Duplication | if ( !$status->isGood() ) { |
|
| 90 | UploadBase::setSessionStatus( |
||
| 91 | $user, |
||
| 92 | $this->params['filekey'], |
||
| 93 | [ 'result' => 'Failure', 'stage' => 'publish', 'status' => $status ] |
||
| 94 | ); |
||
| 95 | $this->setLastError( $status->getWikiText( false, false, 'en' ) ); |
||
| 96 | |||
| 97 | return false; |
||
| 98 | } |
||
| 99 | |||
| 100 | // Build the image info array while we have the local reference handy |
||
| 101 | $apiMain = new ApiMain(); // dummy object (XXX) |
||
| 102 | $imageInfo = $upload->getImageInfo( $apiMain->getResult() ); |
||
| 103 | |||
| 104 | // Cleanup any temporary local file |
||
| 105 | $upload->cleanupTempFile(); |
||
| 106 | |||
| 107 | // Cache the info so the user doesn't have to wait forever to get the final info |
||
| 108 | UploadBase::setSessionStatus( |
||
| 109 | $user, |
||
| 110 | $this->params['filekey'], |
||
| 111 | [ |
||
| 112 | 'result' => 'Success', |
||
| 113 | 'stage' => 'publish', |
||
| 114 | 'filename' => $upload->getLocalFile()->getName(), |
||
| 115 | 'imageinfo' => $imageInfo, |
||
| 116 | 'status' => Status::newGood() |
||
| 117 | ] |
||
| 118 | ); |
||
| 119 | } catch ( Exception $e ) { |
||
| 120 | UploadBase::setSessionStatus( |
||
| 121 | $user, |
||
| 122 | $this->params['filekey'], |
||
| 123 | [ |
||
| 124 | 'result' => 'Failure', |
||
| 125 | 'stage' => 'publish', |
||
| 126 | 'status' => Status::newFatal( 'api-error-publishfailed' ) |
||
| 127 | ] |
||
| 128 | ); |
||
| 129 | $this->setLastError( get_class( $e ) . ": " . $e->getMessage() ); |
||
| 130 | // To prevent potential database referential integrity issues. |
||
| 131 | // See bug 32551. |
||
| 132 | MWExceptionHandler::rollbackMasterChangesAndLog( $e ); |
||
| 133 | |||
| 134 | return false; |
||
| 135 | } |
||
| 136 | |||
| 137 | return true; |
||
| 138 | } |
||
| 139 | |||
| 153 |
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: