wikimedia /
mediawiki
| Conditions | 9 |
| Paths | 10 |
| Total Lines | 79 |
| Code Lines | 53 |
| Lines | 6 |
| Ratio | 7.59 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 48 | protected function doDBUpdates() { |
||
| 49 | $db = $this->getDB( DB_MASTER ); |
||
| 50 | if ( !$db->tableExists( 'revision' ) ) { |
||
| 51 | $this->error( "revision table does not exist" ); |
||
| 52 | |||
| 53 | return false; |
||
| 54 | } |
||
| 55 | $this->output( "Populating rev_parent_id column\n" ); |
||
| 56 | $start = $db->selectField( 'revision', 'MIN(rev_id)', false, __FUNCTION__ ); |
||
| 57 | $end = $db->selectField( 'revision', 'MAX(rev_id)', false, __FUNCTION__ ); |
||
| 58 | if ( is_null( $start ) || is_null( $end ) ) { |
||
| 59 | $this->output( "...revision table seems to be empty, nothing to do.\n" ); |
||
| 60 | |||
| 61 | return true; |
||
| 62 | } |
||
| 63 | # Do remaining chunk |
||
| 64 | $blockStart = intval( $start ); |
||
| 65 | $blockEnd = intval( $start ) + $this->mBatchSize - 1; |
||
| 66 | $count = 0; |
||
| 67 | $changed = 0; |
||
| 68 | while ( $blockStart <= $end ) { |
||
| 69 | $this->output( "...doing rev_id from $blockStart to $blockEnd\n" ); |
||
| 70 | $cond = "rev_id BETWEEN $blockStart AND $blockEnd"; |
||
| 71 | $res = $db->select( 'revision', |
||
| 72 | [ 'rev_id', 'rev_page', 'rev_timestamp', 'rev_parent_id' ], |
||
| 73 | [ $cond, 'rev_parent_id' => null ], __METHOD__ ); |
||
| 74 | # Go through and update rev_parent_id from these rows. |
||
| 75 | # Assume that the previous revision of the title was |
||
| 76 | # the original previous revision of the title when the |
||
| 77 | # edit was made... |
||
| 78 | foreach ( $res as $row ) { |
||
| 79 | # First, check rows with the same timestamp other than this one |
||
| 80 | # with a smaller rev ID. The highest ID "wins". This avoids loops |
||
| 81 | # as timestamp can only decrease and never loops with IDs (from parent to parent) |
||
| 82 | $previousID = $db->selectField( 'revision', 'rev_id', |
||
| 83 | [ 'rev_page' => $row->rev_page, 'rev_timestamp' => $row->rev_timestamp, |
||
| 84 | "rev_id < " . intval( $row->rev_id ) ], |
||
| 85 | __METHOD__, |
||
| 86 | [ 'ORDER BY' => 'rev_id DESC' ] ); |
||
| 87 | # If there are none, check the highest ID with a lower timestamp |
||
| 88 | if ( !$previousID ) { |
||
| 89 | # Get the highest older timestamp |
||
| 90 | $lastTimestamp = $db->selectField( |
||
| 91 | 'revision', |
||
| 92 | 'rev_timestamp', |
||
| 93 | [ |
||
| 94 | 'rev_page' => $row->rev_page, |
||
| 95 | "rev_timestamp < " . $db->addQuotes( $row->rev_timestamp ) |
||
| 96 | ], |
||
| 97 | __METHOD__, |
||
| 98 | [ 'ORDER BY' => 'rev_timestamp DESC' ] |
||
| 99 | ); |
||
| 100 | # If there is one, let the highest rev ID win |
||
| 101 | View Code Duplication | if ( $lastTimestamp ) { |
|
| 102 | $previousID = $db->selectField( 'revision', 'rev_id', |
||
| 103 | [ 'rev_page' => $row->rev_page, 'rev_timestamp' => $lastTimestamp ], |
||
| 104 | __METHOD__, |
||
| 105 | [ 'ORDER BY' => 'rev_id DESC' ] ); |
||
| 106 | } |
||
| 107 | } |
||
| 108 | $previousID = intval( $previousID ); |
||
| 109 | if ( $previousID != $row->rev_parent_id ) { |
||
| 110 | $changed++; |
||
| 111 | } |
||
| 112 | # Update the row... |
||
| 113 | $db->update( 'revision', |
||
| 114 | [ 'rev_parent_id' => $previousID ], |
||
| 115 | [ 'rev_id' => $row->rev_id ], |
||
| 116 | __METHOD__ ); |
||
| 117 | $count++; |
||
| 118 | } |
||
| 119 | $blockStart += $this->mBatchSize; |
||
| 120 | $blockEnd += $this->mBatchSize; |
||
| 121 | wfWaitForSlaves(); |
||
| 122 | } |
||
| 123 | $this->output( "rev_parent_id population complete ... {$count} rows [{$changed} changed]\n" ); |
||
| 124 | |||
| 125 | return true; |
||
| 126 | } |
||
| 127 | } |
||
| 131 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.