wikimedia /
mediawiki
| Conditions | 10 |
| Paths | 30 |
| Total Lines | 44 |
| Code Lines | 34 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 60 | public function __call( $name, $args ) { |
||
| 61 | $this->init(); |
||
| 62 | $results = []; |
||
| 63 | $mismatch = false; |
||
| 64 | $lastResult = null; |
||
| 65 | $first = true; |
||
| 66 | foreach ( $this->parsers as $i => $parser ) { |
||
| 67 | $currentResult = call_user_func_array( [ &$this->parsers[$i], $name ], $args ); |
||
| 68 | if ( $first ) { |
||
| 69 | $first = false; |
||
| 70 | } else { |
||
| 71 | if ( is_object( $lastResult ) ) { |
||
| 72 | if ( $lastResult != $currentResult ) { |
||
| 73 | $mismatch = true; |
||
| 74 | } |
||
| 75 | } else { |
||
| 76 | if ( $lastResult !== $currentResult ) { |
||
| 77 | $mismatch = true; |
||
| 78 | } |
||
| 79 | } |
||
| 80 | } |
||
| 81 | $results[$i] = $currentResult; |
||
| 82 | $lastResult = $currentResult; |
||
| 83 | } |
||
| 84 | if ( $mismatch ) { |
||
| 85 | if ( count( $results ) == 2 ) { |
||
| 86 | $resultsList = []; |
||
| 87 | foreach ( $this->parsers as $i => $parser ) { |
||
| 88 | $resultsList[] = var_export( $results[$i], true ); |
||
| 89 | } |
||
| 90 | $diff = wfDiff( $resultsList[0], $resultsList[1] ); |
||
|
|
|||
| 91 | } else { |
||
| 92 | $diff = '[too many parsers]'; |
||
| 93 | } |
||
| 94 | $msg = "ParserDiffTest: results mismatch on call to $name\n"; |
||
| 95 | if ( !$this->shortOutput ) { |
||
| 96 | $msg .= 'Arguments: ' . $this->formatArray( $args ) . "\n"; |
||
| 97 | } |
||
| 98 | $msg .= 'Results: ' . $this->formatArray( $results ) . "\n" . |
||
| 99 | "Diff: $diff\n"; |
||
| 100 | throw new MWException( $msg ); |
||
| 101 | } |
||
| 102 | return $lastResult; |
||
| 103 | } |
||
| 104 | |||
| 123 |
This function has been deprecated. The supplier of the file has supplied an explanatory message.
The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead.