MinifyScript::__construct()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 14
Code Lines 12

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 1
eloc 12
nc 1
nop 0
dl 0
loc 14
rs 9.4285
c 0
b 0
f 0
1
<?php
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 31 and the first side effect is on line 24.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
/**
3
 * Minify a file or set of files
4
 *
5
 * This program is free software; you can redistribute it and/or modify
6
 * it under the terms of the GNU General Public License as published by
7
 * the Free Software Foundation; either version 2 of the License, or
8
 * (at your option) any later version.
9
 *
10
 * This program is distributed in the hope that it will be useful,
11
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
 * GNU General Public License for more details.
14
 *
15
 * You should have received a copy of the GNU General Public License along
16
 * with this program; if not, write to the Free Software Foundation, Inc.,
17
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18
 * http://www.gnu.org/copyleft/gpl.html
19
 *
20
 * @file
21
 * @ingroup Maintenance
22
 */
23
24
require_once __DIR__ . '/Maintenance.php';
25
26
/**
27
 * Maintenance script that minifies a file or set of files.
28
 *
29
 * @ingroup Maintenance
30
 */
31
class MinifyScript extends Maintenance {
32
	public $outDir;
33
34
	public function __construct() {
35
		parent::__construct();
36
		$this->addOption( 'outfile',
37
			'File for output. Only a single file may be specified for input.',
38
			false, true );
39
		$this->addOption( 'outdir',
40
			"Directory for output. If this is not specified, and neither is --outfile, then the\n" .
41
			"output files will be sent to the same directories as the input files.",
42
			false, true );
43
		$this->addDescription( "Minify a file or set of files.\n\n" .
44
			"If --outfile is not specified, then the output file names will have a .min extension\n" .
45
			"added, e.g. jquery.js -> jquery.min.js."
46
		);
47
	}
48
49
	public function execute() {
50
		if ( !count( $this->mArgs ) ) {
51
			$this->error( "minify.php: At least one input file must be specified." );
52
			exit( 1 );
0 ignored issues
show
Coding Style Compatibility introduced by
The method execute() contains an exit expression.

An exit expression should only be used in rare cases. For example, if you write a short command line script.

In most cases however, using an exit expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage.

Loading history...
53
		}
54
55
		if ( $this->hasOption( 'outfile' ) ) {
56
			if ( count( $this->mArgs ) > 1 ) {
57
				$this->error( '--outfile may only be used with a single input file.' );
58
				exit( 1 );
0 ignored issues
show
Coding Style Compatibility introduced by
The method execute() contains an exit expression.

An exit expression should only be used in rare cases. For example, if you write a short command line script.

In most cases however, using an exit expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage.

Loading history...
59
			}
60
61
			// Minify one file
62
			$this->minify( $this->getArg( 0 ), $this->getOption( 'outfile' ) );
63
64
			return;
65
		}
66
67
		$outDir = $this->getOption( 'outdir', false );
68
69
		foreach ( $this->mArgs as $arg ) {
70
			$inPath = realpath( $arg );
71
			$inName = basename( $inPath );
72
			$inDir = dirname( $inPath );
73
74
			if ( strpos( $inName, '.min.' ) !== false ) {
75
				$this->error( "Skipping $inName\n" );
76
				continue;
77
			}
78
79
			if ( !file_exists( $inPath ) ) {
80
				$this->error( "File does not exist: $arg", true );
81
			}
82
83
			$extension = $this->getExtension( $inName );
84
			$outName = substr( $inName, 0, -strlen( $extension ) ) . 'min.' . $extension;
85
			if ( $outDir === false ) {
86
				$outPath = $inDir . '/' . $outName;
87
			} else {
88
				$outPath = $outDir . '/' . $outName;
89
			}
90
91
			$this->minify( $inPath, $outPath );
92
		}
93
	}
94
95
	public function getExtension( $fileName ) {
96
		$dotPos = strrpos( $fileName, '.' );
97
		if ( $dotPos === false ) {
98
			$this->error( "No file extension, cannot determine type: $fileName" );
99
			exit( 1 );
0 ignored issues
show
Coding Style Compatibility introduced by
The method getExtension() contains an exit expression.

An exit expression should only be used in rare cases. For example, if you write a short command line script.

In most cases however, using an exit expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage.

Loading history...
100
		}
101
102
		return substr( $fileName, $dotPos + 1 );
103
	}
104
105
	public function minify( $inPath, $outPath ) {
106
		$extension = $this->getExtension( $inPath );
107
		$this->output( basename( $inPath ) . ' -> ' . basename( $outPath ) . '...' );
108
109
		$inText = file_get_contents( $inPath );
110
		if ( $inText === false ) {
111
			$this->error( "Unable to open file $inPath for reading." );
112
			exit( 1 );
0 ignored issues
show
Coding Style Compatibility introduced by
The method minify() contains an exit expression.

An exit expression should only be used in rare cases. For example, if you write a short command line script.

In most cases however, using an exit expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage.

Loading history...
113
		}
114
		$outFile = fopen( $outPath, 'w' );
115
		if ( !$outFile ) {
116
			$this->error( "Unable to open file $outPath for writing." );
117
			exit( 1 );
0 ignored issues
show
Coding Style Compatibility introduced by
The method minify() contains an exit expression.

An exit expression should only be used in rare cases. For example, if you write a short command line script.

In most cases however, using an exit expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage.

Loading history...
118
		}
119
120
		switch ( $extension ) {
121
			case 'js':
122
				$outText = JavaScriptMinifier::minify( $inText );
123
				break;
124
			case 'css':
125
				$outText = CSSMin::minify( $inText );
126
				break;
127
			default:
128
				$this->error( "No minifier defined for extension \"$extension\"" );
129
		}
130
131
		fwrite( $outFile, $outText );
0 ignored issues
show
Bug introduced by
The variable $outText does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
132
		fclose( $outFile );
133
		$this->output( " ok\n" );
134
	}
135
}
136
137
$maintClass = 'MinifyScript';
138
require_once RUN_MAINTENANCE_IF_MAIN;
139