wikimedia /
mediawiki
| Conditions | 6 |
| Paths | 8 |
| Total Lines | 66 |
| Code Lines | 45 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 40 | public function execute() { |
||
| 41 | $count = 0; |
||
| 42 | $oldGroup = $this->getArg( 0 ); |
||
| 43 | $newGroup = $this->getArg( 1 ); |
||
| 44 | $dbw = $this->getDB( DB_MASTER ); |
||
| 45 | $start = $dbw->selectField( 'user_groups', 'MIN(ug_user)', |
||
| 46 | [ 'ug_group' => $oldGroup ], __FUNCTION__ ); |
||
| 47 | $end = $dbw->selectField( 'user_groups', 'MAX(ug_user)', |
||
| 48 | [ 'ug_group' => $oldGroup ], __FUNCTION__ ); |
||
| 49 | if ( $start === null ) { |
||
| 50 | $this->error( "Nothing to do - no users in the '$oldGroup' group", true ); |
||
| 51 | } |
||
| 52 | # Do remaining chunk |
||
| 53 | $end += $this->mBatchSize - 1; |
||
| 54 | $blockStart = $start; |
||
| 55 | $blockEnd = $start + $this->mBatchSize - 1; |
||
| 56 | // Migrate users over in batches... |
||
| 57 | while ( $blockEnd <= $end ) { |
||
| 58 | $affected = 0; |
||
| 59 | $this->output( "Doing users $blockStart to $blockEnd\n" ); |
||
| 60 | |||
| 61 | $this->beginTransaction( $dbw, __METHOD__ ); |
||
| 62 | $dbw->update( 'user_groups', |
||
| 63 | [ 'ug_group' => $newGroup ], |
||
| 64 | [ 'ug_group' => $oldGroup, |
||
| 65 | "ug_user BETWEEN $blockStart AND $blockEnd" ], |
||
| 66 | __METHOD__, |
||
| 67 | [ 'IGNORE' ] |
||
| 68 | ); |
||
| 69 | $affected += $dbw->affectedRows(); |
||
| 70 | // Delete rows that the UPDATE operation above had to ignore. |
||
| 71 | // This happens when a user is in both the old and new group. |
||
| 72 | // Updating the row for the old group membership failed since |
||
| 73 | // user/group is UNIQUE. |
||
| 74 | $dbw->delete( 'user_groups', |
||
| 75 | [ 'ug_group' => $oldGroup, |
||
| 76 | "ug_user BETWEEN $blockStart AND $blockEnd" ], |
||
| 77 | __METHOD__ |
||
| 78 | ); |
||
| 79 | $affected += $dbw->affectedRows(); |
||
| 80 | $this->commitTransaction( $dbw, __METHOD__ ); |
||
| 81 | |||
| 82 | // Clear cache for the affected users (bug 40340) |
||
| 83 | if ( $affected > 0 ) { |
||
| 84 | // XXX: This also invalidates cache of unaffected users that |
||
| 85 | // were in the new group and not in the group. |
||
| 86 | $res = $dbw->select( 'user_groups', 'ug_user', |
||
| 87 | [ 'ug_group' => $newGroup, |
||
| 88 | "ug_user BETWEEN $blockStart AND $blockEnd" ], |
||
| 89 | __METHOD__ |
||
| 90 | ); |
||
| 91 | if ( $res !== false ) { |
||
| 92 | foreach ( $res as $row ) { |
||
| 93 | $user = User::newFromId( $row->ug_user ); |
||
| 94 | $user->invalidateCache(); |
||
| 95 | } |
||
| 96 | } |
||
| 97 | } |
||
| 98 | |||
| 99 | $count += $affected; |
||
| 100 | $blockStart += $this->mBatchSize; |
||
| 101 | $blockEnd += $this->mBatchSize; |
||
| 102 | wfWaitForSlaves(); |
||
| 103 | } |
||
| 104 | $this->output( "Done! $count users in group '$oldGroup' are now in '$newGroup' instead.\n" ); |
||
| 105 | } |
||
| 106 | } |
||
| 110 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.