Conditions | 20 |
Paths | 288 |
Total Lines | 184 |
Code Lines | 90 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
235 | protected function getDefaultText() { |
||
236 | if ( !$this->values['wgImageMagickConvertCommand'] ) { |
||
237 | $this->values['wgImageMagickConvertCommand'] = '/usr/bin/convert'; |
||
238 | $magic = '#'; |
||
239 | } else { |
||
240 | $magic = ''; |
||
241 | } |
||
242 | |||
243 | if ( !$this->values['wgShellLocale'] ) { |
||
244 | $this->values['wgShellLocale'] = 'en_US.UTF-8'; |
||
245 | $locale = '#'; |
||
246 | } else { |
||
247 | $locale = ''; |
||
248 | } |
||
249 | |||
250 | $metaNamespace = ''; |
||
251 | if ( $this->values['wgMetaNamespace'] !== $this->values['wgSitename'] ) { |
||
252 | $metaNamespace = "\$wgMetaNamespace = \"{$this->values['wgMetaNamespace']}\";\n"; |
||
253 | } |
||
254 | |||
255 | $groupRights = ''; |
||
256 | $noFollow = ''; |
||
257 | if ( $this->groupPermissions ) { |
||
258 | $groupRights .= "# The following permissions were set based on your choice in the installer\n"; |
||
259 | foreach ( $this->groupPermissions as $group => $rightArr ) { |
||
260 | $group = self::escapePhpString( $group ); |
||
261 | foreach ( $rightArr as $right => $perm ) { |
||
262 | $right = self::escapePhpString( $right ); |
||
263 | $groupRights .= "\$wgGroupPermissions['$group']['$right'] = " . |
||
264 | wfBoolToStr( $perm ) . ";\n"; |
||
265 | } |
||
266 | } |
||
267 | $groupRights .= "\n"; |
||
268 | |||
269 | if ( ( isset( $this->groupPermissions['*']['edit'] ) && |
||
270 | $this->groupPermissions['*']['edit'] === false ) |
||
271 | && ( isset( $this->groupPermissions['*']['createaccount'] ) && |
||
272 | $this->groupPermissions['*']['createaccount'] === false ) |
||
273 | && ( isset( $this->groupPermissions['*']['read'] ) && |
||
274 | $this->groupPermissions['*']['read'] !== false ) |
||
275 | ) { |
||
276 | $noFollow = "# Set \$wgNoFollowLinks to true if you open up your wiki to editing by\n" |
||
277 | . "# the general public and wish to apply nofollow to external links as a\n" |
||
278 | . "# deterrent to spammers. Nofollow is not a comprehensive anti-spam solution\n" |
||
279 | . "# and open wikis will generally require other anti-spam measures; for more\n" |
||
280 | . "# information, see https://www.mediawiki.org/wiki/Manual:Combating_spam\n" |
||
281 | . "\$wgNoFollowLinks = false;\n\n"; |
||
282 | } |
||
283 | } |
||
284 | |||
285 | $serverSetting = ""; |
||
286 | if ( array_key_exists( 'wgServer', $this->values ) && $this->values['wgServer'] !== null ) { |
||
287 | $serverSetting = "\n## The protocol and server name to use in fully-qualified URLs\n"; |
||
288 | $serverSetting .= "\$wgServer = \"{$this->values['wgServer']}\";"; |
||
289 | } |
||
290 | |||
291 | switch ( $this->values['_MainCacheType'] ) { |
||
292 | case 'anything': |
||
293 | case 'db': |
||
294 | case 'memcached': |
||
295 | case 'accel': |
||
296 | $cacheType = 'CACHE_' . strtoupper( $this->values['_MainCacheType'] ); |
||
297 | break; |
||
298 | case 'none': |
||
299 | default: |
||
300 | $cacheType = 'CACHE_NONE'; |
||
301 | } |
||
302 | |||
303 | $mcservers = $this->buildMemcachedServerList(); |
||
304 | |||
305 | return "<?php |
||
306 | # This file was automatically generated by the MediaWiki {$GLOBALS['wgVersion']} |
||
307 | # installer. If you make manual changes, please keep track in case you |
||
308 | # need to recreate them later. |
||
309 | # |
||
310 | # See includes/DefaultSettings.php for all configurable settings |
||
311 | # and their default values, but don't forget to make changes in _this_ |
||
312 | # file, not there. |
||
313 | # |
||
314 | # Further documentation for configuration settings may be found at: |
||
315 | # https://www.mediawiki.org/wiki/Manual:Configuration_settings |
||
316 | |||
317 | # Protect against web entry |
||
318 | if ( !defined( 'MEDIAWIKI' ) ) { |
||
319 | exit; |
||
320 | } |
||
321 | |||
322 | ## Uncomment this to disable output compression |
||
323 | # \$wgDisableOutputCompression = true; |
||
324 | |||
325 | \$wgSitename = \"{$this->values['wgSitename']}\"; |
||
326 | {$metaNamespace} |
||
327 | ## The URL base path to the directory containing the wiki; |
||
328 | ## defaults for all runtime URL paths are based off of this. |
||
329 | ## For more information on customizing the URLs |
||
330 | ## (like /w/index.php/Page_title to /wiki/Page_title) please see: |
||
331 | ## https://www.mediawiki.org/wiki/Manual:Short_URL |
||
332 | \$wgScriptPath = \"{$this->values['wgScriptPath']}\"; |
||
333 | ${serverSetting} |
||
334 | |||
335 | ## The URL path to static resources (images, scripts, etc.) |
||
336 | \$wgResourceBasePath = \$wgScriptPath; |
||
337 | |||
338 | ## The URL path to the logo. Make sure you change this from the default, |
||
339 | ## or else you'll overwrite your logo when you upgrade! |
||
340 | \$wgLogo = \"{$this->values['wgLogo']}\"; |
||
341 | |||
342 | ## UPO means: this is also a user preference option |
||
343 | |||
344 | \$wgEnableEmail = {$this->values['wgEnableEmail']}; |
||
345 | \$wgEnableUserEmail = {$this->values['wgEnableUserEmail']}; # UPO |
||
346 | |||
347 | \$wgEmergencyContact = \"{$this->values['wgEmergencyContact']}\"; |
||
348 | \$wgPasswordSender = \"{$this->values['wgPasswordSender']}\"; |
||
349 | |||
350 | \$wgEnotifUserTalk = {$this->values['wgEnotifUserTalk']}; # UPO |
||
351 | \$wgEnotifWatchlist = {$this->values['wgEnotifWatchlist']}; # UPO |
||
352 | \$wgEmailAuthentication = {$this->values['wgEmailAuthentication']}; |
||
353 | |||
354 | ## Database settings |
||
355 | \$wgDBtype = \"{$this->values['wgDBtype']}\"; |
||
356 | \$wgDBserver = \"{$this->values['wgDBserver']}\"; |
||
357 | \$wgDBname = \"{$this->values['wgDBname']}\"; |
||
358 | \$wgDBuser = \"{$this->values['wgDBuser']}\"; |
||
359 | \$wgDBpassword = \"{$this->values['wgDBpassword']}\"; |
||
360 | |||
361 | {$this->dbSettings} |
||
362 | |||
363 | ## Shared memory settings |
||
364 | \$wgMainCacheType = $cacheType; |
||
365 | \$wgMemCachedServers = $mcservers; |
||
366 | |||
367 | ## To enable image uploads, make sure the 'images' directory |
||
368 | ## is writable, then set this to true: |
||
369 | \$wgEnableUploads = {$this->values['wgEnableUploads']}; |
||
370 | {$magic}\$wgUseImageMagick = true; |
||
371 | {$magic}\$wgImageMagickConvertCommand = \"{$this->values['wgImageMagickConvertCommand']}\"; |
||
372 | |||
373 | # InstantCommons allows wiki to use images from https://commons.wikimedia.org |
||
374 | \$wgUseInstantCommons = {$this->values['wgUseInstantCommons']}; |
||
375 | |||
376 | # Periodically send a pingback to https://www.mediawiki.org/ with basic data |
||
377 | # about this MediaWiki instance. The Wikimedia Foundation shares this data |
||
378 | # with MediaWiki developers to help guide future development efforts. |
||
379 | \$wgPingback = {$this->values['wgPingback']}; |
||
380 | |||
381 | ## If you use ImageMagick (or any other shell command) on a |
||
382 | ## Linux server, this will need to be set to the name of an |
||
383 | ## available UTF-8 locale |
||
384 | {$locale}\$wgShellLocale = \"{$this->values['wgShellLocale']}\"; |
||
385 | |||
386 | ## Set \$wgCacheDirectory to a writable directory on the web server |
||
387 | ## to make your wiki go slightly faster. The directory should not |
||
388 | ## be publically accessible from the web. |
||
389 | #\$wgCacheDirectory = \"\$IP/cache\"; |
||
390 | |||
391 | # Site language code, should be one of the list in ./languages/data/Names.php |
||
392 | \$wgLanguageCode = \"{$this->values['wgLanguageCode']}\"; |
||
393 | |||
394 | \$wgSecretKey = \"{$this->values['wgSecretKey']}\"; |
||
395 | |||
396 | # Changing this will log out all existing sessions. |
||
397 | \$wgAuthenticationTokenVersion = \"{$this->values['wgAuthenticationTokenVersion']}\"; |
||
398 | |||
399 | # Site upgrade key. Must be set to a string (default provided) to turn on the |
||
400 | # web installer while LocalSettings.php is in place |
||
401 | \$wgUpgradeKey = \"{$this->values['wgUpgradeKey']}\"; |
||
402 | |||
403 | ## For attaching licensing metadata to pages, and displaying an |
||
404 | ## appropriate copyright notice / icon. GNU Free Documentation |
||
405 | ## License and Creative Commons licenses are supported so far. |
||
406 | \$wgRightsPage = \"\"; # Set to the title of a wiki page that describes your license/copyright |
||
407 | \$wgRightsUrl = \"{$this->values['wgRightsUrl']}\"; |
||
408 | \$wgRightsText = \"{$this->values['wgRightsText']}\"; |
||
409 | \$wgRightsIcon = \"{$this->values['wgRightsIcon']}\"; |
||
410 | |||
411 | # Path to the GNU diff3 utility. Used for conflict resolution. |
||
412 | \$wgDiff3 = \"{$this->values['wgDiff3']}\"; |
||
413 | |||
414 | {$groupRights}{$noFollow}## Default skin: you can change the default skin. Use the internal symbolic |
||
415 | ## names, ie 'vector', 'monobook': |
||
416 | \$wgDefaultSkin = \"{$this->values['wgDefaultSkin']}\"; |
||
417 | "; |
||
418 | } |
||
419 | } |
||
420 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..