InitSiteStats::execute() - Code Metrics - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

InitSiteStats::execute() B
last analyzed 2016-11-13 17:42 UTC

↳ Parent: InitSiteStats

Complexity

Conditions	3
Paths	4

Size

Total Lines	37
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	26
nc	4
nop	0
dl	0
loc	37
rs	8.8571
c	0
b	0
f	0

<?php

/**
 * Re-initialise or update the site statistics table.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 * @ingroup Maintenance
 * @author Brion Vibber
 * @author Rob Church <[email protected]>
 */

require_once __DIR__ . '/Maintenance.php';

/**
 * Maintenance script to re-initialise or update the site statistics table
 *
 * @ingroup Maintenance
 */
class InitSiteStats extends Maintenance {
	public function __construct() {
		parent::__construct();
		$this->addDescription( 'Re-initialise the site statistics tables' );
		$this->addOption( 'update', 'Update the existing statistics' );
		$this->addOption( 'active', 'Also update active users count' );
		$this->addOption( 'use-master', 'Count using the master database' );
	}

	public function execute() {
		$this->output( "Refresh Site Statistics\n\n" );
		$counter = new SiteStatsInit( $this->hasOption( 'use-master' ) );

		$this->output( "Counting total edits..." );
		$edits = $counter->edits();
		$this->output( "{$edits}\nCounting number of articles..." );

		$good = $counter->articles();
		$this->output( "{$good}\nCounting total pages..." );

		$pages = $counter->pages();
		$this->output( "{$pages}\nCounting number of users..." );

		$users = $counter->users();
		$this->output( "{$users}\nCounting number of images..." );

		$image = $counter->files();
		$this->output( "{$image}\n" );

		if ( $this->hasOption( 'update' ) ) {
			$this->output( "\nUpdating site statistics..." );
			$counter->refresh();
			$this->output( "done.\n" );
		} else {
			$this->output( "\nTo update the site statistics table, run the script "
				. "with the --update option.\n" );
		}

		if ( $this->hasOption( 'active' ) ) {
			$this->output( "\nCounting and updating active users..." );
			$active = SiteStatsUpdate::cacheUpdate( $this->getDB( DB_MASTER ) );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
			$this->output( "{$active}\n" );
		}

		$this->output( "\nDone.\n" );
	}
}

$maintClass = "InitSiteStats";
require_once RUN_MAINTENANCE_IF_MAIN;


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-23 18:14 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 33 and the first side effect is on line 26. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* Re-initialise or update the site statistics table.
4			*
5			* This program is free software; you can redistribute it and/or modify
6			* it under the terms of the GNU General Public License as published by
7			* the Free Software Foundation; either version 2 of the License, or
8			* (at your option) any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU General Public License for more details.
14			*
15			* You should have received a copy of the GNU General Public License along
16			* with this program; if not, write to the Free Software Foundation, Inc.,
17			* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18			* http://www.gnu.org/copyleft/gpl.html
19			*
20			* @file
21			* @ingroup Maintenance
22			* @author Brion Vibber
23			* @author Rob Church <[email protected]>
24			*/
25
26			require_once __DIR__ . '/Maintenance.php';
27
28			/**
29			* Maintenance script to re-initialise or update the site statistics table
30			*
31			* @ingroup Maintenance
32			*/
33			class InitSiteStats extends Maintenance {
34			public function __construct() {
35			parent::__construct();
36			$this->addDescription( 'Re-initialise the site statistics tables' );
37			$this->addOption( 'update', 'Update the existing statistics' );
38			$this->addOption( 'active', 'Also update active users count' );
39			$this->addOption( 'use-master', 'Count using the master database' );
40			}
41
42			public function execute() {
43			$this->output( "Refresh Site Statistics\n\n" );
44			$counter = new SiteStatsInit( $this->hasOption( 'use-master' ) );
45
46			$this->output( "Counting total edits..." );
47			$edits = $counter->edits();
48			$this->output( "{$edits}\nCounting number of articles..." );
49
50			$good = $counter->articles();
51			$this->output( "{$good}\nCounting total pages..." );
52
53			$pages = $counter->pages();
54			$this->output( "{$pages}\nCounting number of users..." );
55
56			$users = $counter->users();
57			$this->output( "{$users}\nCounting number of images..." );
58
59			$image = $counter->files();
60			$this->output( "{$image}\n" );
61
62			if ( $this->hasOption( 'update' ) ) {
63			$this->output( "\nUpdating site statistics..." );
64			$counter->refresh();
65			$this->output( "done.\n" );
66			} else {
67			$this->output( "\nTo update the site statistics table, run the script "
68			. "with the --update option.\n" );
69			}
70
71			if ( $this->hasOption( 'active' ) ) {
72			$this->output( "\nCounting and updating active users..." );
73			$active = SiteStatsUpdate::cacheUpdate( $this->getDB( DB_MASTER ) );
			0 ignored issues – show Bug introduced 2016-09-24 18:22 UTC by Report Bug Copy Issue Report It seems like `$this->getDB(DB_MASTER)` can be `null`; however, `cacheUpdate()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
74			$this->output( "{$active}\n" );
75			}
76
77			$this->output( "\nDone.\n" );
78			}
79			}
80
81			$maintClass = "InitSiteStats";
82			require_once RUN_MAINTENANCE_IF_MAIN;
83

wikimedia / mediawiki

InitSiteStats::execute() B last analyzed 2016-11-13 17:42 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

InitSiteStats::execute() B
last analyzed 2016-11-13 17:42 UTC