wikimedia /
mediawiki
| Conditions | 10 |
| Paths | 84 |
| Total Lines | 81 |
| Code Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 45 | public function execute() { |
||
| 46 | $offset = $this->getArg( 0 ) * 3600; |
||
| 47 | $start = $this->getArg( 1 ); |
||
| 48 | $end = $this->getArg( 2 ); |
||
| 49 | $grace = 60; // maximum normal clock offset |
||
| 50 | |||
| 51 | # Find bounding revision IDs |
||
| 52 | $dbw = $this->getDB( DB_MASTER ); |
||
| 53 | $revisionTable = $dbw->tableName( 'revision' ); |
||
| 54 | $res = $dbw->query( "SELECT MIN(rev_id) as minrev, MAX(rev_id) as maxrev FROM $revisionTable " . |
||
| 55 | "WHERE rev_timestamp BETWEEN '{$start}' AND '{$end}'", __METHOD__ ); |
||
| 56 | $row = $dbw->fetchObject( $res ); |
||
| 57 | |||
| 58 | if ( is_null( $row->minrev ) ) { |
||
| 59 | $this->error( "No revisions in search period.", true ); |
||
| 60 | } |
||
| 61 | |||
| 62 | $minRev = $row->minrev; |
||
| 63 | $maxRev = $row->maxrev; |
||
| 64 | |||
| 65 | # Select all timestamps and IDs |
||
| 66 | $sql = "SELECT rev_id, rev_timestamp FROM $revisionTable " . |
||
| 67 | "WHERE rev_id BETWEEN $minRev AND $maxRev"; |
||
| 68 | if ( $offset > 0 ) { |
||
| 69 | $sql .= " ORDER BY rev_id DESC"; |
||
| 70 | $expectedSign = -1; |
||
| 71 | } else { |
||
| 72 | $expectedSign = 1; |
||
| 73 | } |
||
| 74 | |||
| 75 | $res = $dbw->query( $sql, __METHOD__ ); |
||
| 76 | |||
| 77 | $lastNormal = 0; |
||
| 78 | $badRevs = []; |
||
| 79 | $numGoodRevs = 0; |
||
| 80 | |||
| 81 | foreach ( $res as $row ) { |
||
| 82 | $timestamp = wfTimestamp( TS_UNIX, $row->rev_timestamp ); |
||
| 83 | $delta = $timestamp - $lastNormal; |
||
| 84 | $sign = $delta == 0 ? 0 : $delta / abs( $delta ); |
||
| 85 | if ( $sign == 0 || $sign == $expectedSign ) { |
||
| 86 | // Monotonic change |
||
| 87 | $lastNormal = $timestamp; |
||
| 88 | ++$numGoodRevs; |
||
| 89 | continue; |
||
| 90 | } elseif ( abs( $delta ) <= $grace ) { |
||
| 91 | // Non-monotonic change within grace interval |
||
| 92 | ++$numGoodRevs; |
||
| 93 | continue; |
||
| 94 | } else { |
||
| 95 | // Non-monotonic change larger than grace interval |
||
| 96 | $badRevs[] = $row->rev_id; |
||
| 97 | } |
||
| 98 | } |
||
| 99 | |||
| 100 | $numBadRevs = count( $badRevs ); |
||
| 101 | if ( $numBadRevs > $numGoodRevs ) { |
||
| 102 | $this->error( |
||
| 103 | "The majority of revisions in the search interval are marked as bad. |
||
| 104 | |||
| 105 | Are you sure the offset ($offset) has the right sign? Positive means the clock |
||
| 106 | was incorrectly set forward, negative means the clock was incorrectly set back. |
||
| 107 | |||
| 108 | If the offset is right, then increase the search interval until there are enough |
||
| 109 | good revisions to provide a majority reference.", true ); |
||
| 110 | } elseif ( $numBadRevs == 0 ) { |
||
| 111 | $this->output( "No bad revisions found.\n" ); |
||
| 112 | exit( 0 ); |
||
| 113 | } |
||
| 114 | |||
| 115 | $this->output( sprintf( "Fixing %d revisions (%.2f%% of revisions in search interval)\n", |
||
| 116 | $numBadRevs, $numBadRevs / ( $numGoodRevs + $numBadRevs ) * 100 ) ); |
||
| 117 | |||
| 118 | $fixup = -$offset; |
||
| 119 | $sql = "UPDATE $revisionTable " . |
||
| 120 | "SET rev_timestamp=" |
||
| 121 | . "DATE_FORMAT(DATE_ADD(rev_timestamp, INTERVAL $fixup SECOND), '%Y%m%d%H%i%s') " . |
||
| 122 | "WHERE rev_id IN (" . $dbw->makeList( $badRevs ) . ')'; |
||
| 123 | $dbw->query( $sql, __METHOD__ ); |
||
| 124 | $this->output( "Done\n" ); |
||
| 125 | } |
||
| 126 | } |
||
| 130 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.