wikimedia /
mediawiki
| Conditions | 15 |
| Paths | 60 |
| Total Lines | 81 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 35 | function execute() { |
||
| 36 | $lastName = $this->getOption( 'start', '' ); |
||
| 37 | |||
| 38 | $repo = RepoGroup::singleton()->getLocalRepo(); |
||
| 39 | $dbr = $repo->getSlaveDB(); |
||
| 40 | $be = $repo->getBackend(); |
||
| 41 | |||
| 42 | $mtime1 = $dbr->timestampOrNull( $this->getOption( 'mtimeafter', null ) ); |
||
| 43 | $mtime2 = $dbr->timestampOrNull( $this->getOption( 'mtimebefore', null ) ); |
||
| 44 | |||
| 45 | $joinTables = []; |
||
| 46 | $joinConds = []; |
||
| 47 | if ( $mtime1 || $mtime2 ) { |
||
| 48 | $joinTables[] = 'page'; |
||
| 49 | $joinConds['page'] = [ 'INNER JOIN', |
||
| 50 | [ 'page_title = img_name', 'page_namespace' => NS_FILE ] ]; |
||
| 51 | $joinTables[] = 'logging'; |
||
| 52 | $on = [ 'log_page = page_id', 'log_type' => [ 'upload', 'move', 'delete' ] ]; |
||
| 53 | if ( $mtime1 ) { |
||
| 54 | $on[] = "log_timestamp > {$dbr->addQuotes($mtime1)}"; |
||
| 55 | } |
||
| 56 | if ( $mtime2 ) { |
||
| 57 | $on[] = "log_timestamp < {$dbr->addQuotes($mtime2)}"; |
||
| 58 | } |
||
| 59 | $joinConds['logging'] = [ 'INNER JOIN', $on ]; |
||
| 60 | } |
||
| 61 | |||
| 62 | do { |
||
| 63 | $res = $dbr->select( |
||
| 64 | array_merge( [ 'image' ], $joinTables ), |
||
| 65 | [ 'name' => 'img_name' ], |
||
| 66 | [ "img_name > " . $dbr->addQuotes( $lastName ) ], |
||
| 67 | __METHOD__, |
||
| 68 | // DISTINCT causes a pointless filesort |
||
| 69 | [ 'ORDER BY' => 'name', 'GROUP BY' => 'name', |
||
| 70 | 'LIMIT' => $this->mBatchSize ], |
||
| 71 | $joinConds |
||
| 72 | ); |
||
| 73 | |||
| 74 | // Check if any of these files are missing... |
||
| 75 | $pathsByName = []; |
||
| 76 | foreach ( $res as $row ) { |
||
| 77 | $file = $repo->newFile( $row->name ); |
||
| 78 | $pathsByName[$row->name] = $file->getPath(); |
||
| 79 | $lastName = $row->name; |
||
| 80 | } |
||
| 81 | $be->preloadFileStat( [ 'srcs' => $pathsByName ] ); |
||
| 82 | foreach ( $pathsByName as $path ) { |
||
| 83 | if ( $be->fileExists( [ 'src' => $path ] ) === false ) { |
||
| 84 | $this->output( "$path\n" ); |
||
| 85 | } |
||
| 86 | } |
||
| 87 | |||
| 88 | // Find all missing old versions of any of the files in this batch... |
||
| 89 | if ( count( $pathsByName ) ) { |
||
| 90 | $ores = $dbr->select( 'oldimage', |
||
| 91 | [ 'oi_name', 'oi_archive_name' ], |
||
| 92 | [ 'oi_name' => array_keys( $pathsByName ) ], |
||
| 93 | __METHOD__ |
||
| 94 | ); |
||
| 95 | |||
| 96 | $checkPaths = []; |
||
| 97 | foreach ( $ores as $row ) { |
||
| 98 | if ( !strlen( $row->oi_archive_name ) ) { |
||
| 99 | continue; // broken row |
||
| 100 | } |
||
| 101 | $file = $repo->newFromArchiveName( $row->oi_name, $row->oi_archive_name ); |
||
| 102 | $checkPaths[] = $file->getPath(); |
||
| 103 | } |
||
| 104 | |||
| 105 | foreach ( array_chunk( $checkPaths, $this->mBatchSize ) as $paths ) { |
||
| 106 | $be->preloadFileStat( [ 'srcs' => $paths ] ); |
||
| 107 | foreach ( $paths as $path ) { |
||
| 108 | if ( $be->fileExists( [ 'src' => $path ] ) === false ) { |
||
| 109 | $this->output( "$path\n" ); |
||
| 110 | } |
||
| 111 | } |
||
| 112 | } |
||
| 113 | } |
||
| 114 | } while ( $res->numRows() >= $this->mBatchSize ); |
||
| 115 | } |
||
| 116 | } |
||
| 120 |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.