EnotifNotifyJob::__construct()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 1
eloc 2
nc 1
nop 2
dl 0
loc 3
rs 10
c 0
b 0
f 0
1
<?php
2
/**
3
 * Job for notification emails.
4
 *
5
 * This program is free software; you can redistribute it and/or modify
6
 * it under the terms of the GNU General Public License as published by
7
 * the Free Software Foundation; either version 2 of the License, or
8
 * (at your option) any later version.
9
 *
10
 * This program is distributed in the hope that it will be useful,
11
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
 * GNU General Public License for more details.
14
 *
15
 * You should have received a copy of the GNU General Public License along
16
 * with this program; if not, write to the Free Software Foundation, Inc.,
17
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18
 * http://www.gnu.org/copyleft/gpl.html
19
 *
20
 * @file
21
 * @ingroup JobQueue
22
 */
23
24
/**
25
 * Job for email notification mails
26
 *
27
 * @ingroup JobQueue
28
 */
29
class EnotifNotifyJob extends Job {
30
	function __construct( Title $title, array $params ) {
31
		parent::__construct( 'enotifNotify', $title, $params );
32
	}
33
34
	function run() {
35
		$enotif = new EmailNotification();
36
		// Get the user from ID (rename safe). Anons are 0, so defer to name.
37
		if ( isset( $this->params['editorID'] ) && $this->params['editorID'] ) {
38
			$editor = User::newFromId( $this->params['editorID'] );
39
		// B/C, only the name might be given.
40
		} else {
41
			# @todo FIXME: newFromName could return false on a badly configured wiki.
42
			$editor = User::newFromName( $this->params['editor'], false );
43
		}
44
		$enotif->actuallyNotifyOnPageChange(
45
			$editor,
0 ignored issues
show
Security Bug introduced by
It seems like $editor defined by \User::newFromName($this...arams['editor'], false) on line 42 can also be of type false; however, EmailNotification::actuallyNotifyOnPageChange() does only seem to accept object<User>, did you maybe forget to handle an error condition?

This check looks for type mismatches where the missing type is false. This is usually indicative of an error condtion.

Consider the follow example

<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}

This function either returns a new DateTime object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned false before passing on the value to another function or method that may not be able to handle a false.

Loading history...
46
			$this->title,
47
			$this->params['timestamp'],
48
			$this->params['summary'],
49
			$this->params['minorEdit'],
50
			$this->params['oldid'],
51
			$this->params['watchers'],
52
			$this->params['pageStatus']
53
		);
54
55
		return true;
56
	}
57
}
58