DBQueryError::__construct() - Code Metrics - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

DBQueryError::__construct() A
last analyzed 2016-11-13 17:42 UTC

↳ Parent: DBQueryError

Complexity

Conditions	3
Paths	2

Size

Total Lines	21
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	17
nc	2
nop	5
dl	0
loc	21
rs	9.3142
c	0
b	0
f	0

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program; if not, write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 * http://www.gnu.org/copyleft/gpl.html
 *
 * @file
 * @ingroup Database
 */

/**
 * @ingroup Database
 */
class DBQueryError extends DBExpectedError {
	/** @var string */
	public $error;
	/** @var integer */
	public $errno;
	/** @var string */
	public $sql;
	/** @var string */
	public $fname;

	/**
	 * @param IDatabase $db
	 * @param string $error
	 * @param int|string $errno
	 * @param string $sql
	 * @param string $fname
	 */
	function __construct( IDatabase $db, $error, $errno, $sql, $fname ) {
		if ( $db instanceof Database && $db->wasConnectionError( $errno ) ) {
			$message = "A connection error occured. \n" .
				"Query: $sql\n" .
				"Function: $fname\n" .
				"Error: $errno $error\n";
		} else {
			$message = "A database query error has occurred. Did you forget to run " .
				"your application's database schema updater after upgrading? \n" .
				"Query: $sql\n" .
				"Function: $fname\n" .
				"Error: $errno $error\n";
		}

		parent::__construct( $db, $message );

		$this->error = $error;
		$this->errno = $errno;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		$this->sql = $sql;
		$this->fname = $fname;
	}
}


1			<?php
2			/**
3			* This program is free software; you can redistribute it and/or modify
4			* it under the terms of the GNU General Public License as published by
5			* the Free Software Foundation; either version 2 of the License, or
6			* (at your option) any later version.
7			*
8			* This program is distributed in the hope that it will be useful,
9			* but WITHOUT ANY WARRANTY; without even the implied warranty of
10			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11			* GNU General Public License for more details.
12			*
13			* You should have received a copy of the GNU General Public License along
14			* with this program; if not, write to the Free Software Foundation, Inc.,
15			* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16			* http://www.gnu.org/copyleft/gpl.html
17			*
18			* @file
19			* @ingroup Database
20			*/
21
22			/**
23			* @ingroup Database
24			*/
25			class DBQueryError extends DBExpectedError {
26			/** @var string */
27			public $error;
28			/** @var integer */
29			public $errno;
30			/** @var string */
31			public $sql;
32			/** @var string */
33			public $fname;
34
35			/**
36			* @param IDatabase $db
37			* @param string $error
38			* @param int\|string $errno
39			* @param string $sql
40			* @param string $fname
41			*/
42			function __construct( IDatabase $db, $error, $errno, $sql, $fname ) {
43			if ( $db instanceof Database && $db->wasConnectionError( $errno ) ) {
44			$message = "A connection error occured. \n" .
45			"Query: $sql\n" .
46			"Function: $fname\n" .
47			"Error: $errno $error\n";
48			} else {
49			$message = "A database query error has occurred. Did you forget to run " .
50			"your application's database schema updater after upgrading? \n" .
51			"Query: $sql\n" .
52			"Function: $fname\n" .
53			"Error: $errno $error\n";
54			}
55
56			parent::__construct( $db, $message );
57
58			$this->error = $error;
59			$this->errno = $errno;
			0 ignored issues – show Documentation Bug introduced 2016-09-15 18:30 UTC by Report Bug Copy Issue Report It seems like `$errno` can also be of type `string`. However, the property `$errno` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
60			$this->sql = $sql;
61			$this->fname = $fname;
62			}
63			}
64

wikimedia / mediawiki

DBQueryError::__construct() A last analyzed 2016-11-13 17:42 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DBQueryError::__construct() A
last analyzed 2016-11-13 17:42 UTC