wikimedia /
mediawiki
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 53 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 39 | function __construct() { |
||
| 40 | parent::__construct(); |
||
| 41 | global $IP; |
||
| 42 | |||
| 43 | $this->addDescription( "CLI-based MediaWiki installation and configuration.\n" . |
||
| 44 | "Default options are indicated in parentheses." ); |
||
| 45 | |||
| 46 | $this->addArg( 'name', 'The name of the wiki (MediaWiki)', false ); |
||
| 47 | |||
| 48 | $this->addArg( 'admin', 'The username of the wiki administrator.' ); |
||
| 49 | $this->addOption( 'pass', 'The password for the wiki administrator.', false, true ); |
||
| 50 | $this->addOption( |
||
| 51 | 'passfile', |
||
| 52 | 'An alternative way to provide pass option, as the contents of this file', |
||
| 53 | false, |
||
| 54 | true |
||
| 55 | ); |
||
| 56 | /* $this->addOption( 'email', 'The email for the wiki administrator', false, true ); */ |
||
| 57 | $this->addOption( |
||
| 58 | 'scriptpath', |
||
| 59 | 'The relative path of the wiki in the web server (/wiki)', |
||
| 60 | false, |
||
| 61 | true |
||
| 62 | ); |
||
| 63 | |||
| 64 | $this->addOption( 'lang', 'The language to use (en)', false, true ); |
||
| 65 | /* $this->addOption( 'cont-lang', 'The content language (en)', false, true ); */ |
||
| 66 | |||
| 67 | $this->addOption( 'dbtype', 'The type of database (mysql)', false, true ); |
||
| 68 | $this->addOption( 'dbserver', 'The database host (localhost)', false, true ); |
||
| 69 | $this->addOption( 'dbport', 'The database port; only for PostgreSQL (5432)', false, true ); |
||
| 70 | $this->addOption( 'dbname', 'The database name (my_wiki)', false, true ); |
||
| 71 | $this->addOption( 'dbpath', 'The path for the SQLite DB ($IP/data)', false, true ); |
||
| 72 | $this->addOption( 'dbprefix', 'Optional database table name prefix', false, true ); |
||
| 73 | $this->addOption( 'installdbuser', 'The user to use for installing (root)', false, true ); |
||
| 74 | $this->addOption( 'installdbpass', 'The password for the DB user to install as.', false, true ); |
||
| 75 | $this->addOption( 'dbuser', 'The user to use for normal operations (wikiuser)', false, true ); |
||
| 76 | $this->addOption( 'dbpass', 'The password for the DB user for normal operations', false, true ); |
||
| 77 | $this->addOption( |
||
| 78 | 'dbpassfile', |
||
| 79 | 'An alternative way to provide dbpass option, as the contents of this file', |
||
| 80 | false, |
||
| 81 | true |
||
| 82 | ); |
||
| 83 | $this->addOption( 'confpath', "Path to write LocalSettings.php to ($IP)", false, true ); |
||
| 84 | $this->addOption( 'dbschema', 'The schema for the MediaWiki DB in ' |
||
| 85 | . 'PostgreSQL/Microsoft SQL Server (mediawiki)', false, true ); |
||
| 86 | /* |
||
| 87 | $this->addOption( 'namespace', 'The project namespace (same as the "name" argument)', |
||
| 88 | false, true ); |
||
| 89 | */ |
||
| 90 | $this->addOption( 'env-checks', "Run environment checks only, don't change anything" ); |
||
| 91 | } |
||
| 92 | |||
| 157 |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.