Conditions | 34 |
Paths | > 20000 |
Total Lines | 198 |
Code Lines | 136 |
Lines | 26 |
Ratio | 13.13 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
43 | public function execute() { |
||
44 | $params = $this->extractRequestParams(); |
||
45 | $db = $this->getDB(); |
||
46 | $this->requireMaxOneParameter( $params, 'title', 'prefix', 'namespace' ); |
||
47 | |||
48 | $prop = array_flip( $params['prop'] ); |
||
49 | |||
50 | $this->fld_ids = isset( $prop['ids'] ); |
||
51 | $this->fld_title = isset( $prop['title'] ); |
||
52 | $this->fld_type = isset( $prop['type'] ); |
||
53 | $this->fld_user = isset( $prop['user'] ); |
||
54 | $this->fld_userid = isset( $prop['userid'] ); |
||
55 | $this->fld_timestamp = isset( $prop['timestamp'] ); |
||
56 | $this->fld_comment = isset( $prop['comment'] ); |
||
57 | $this->fld_parsedcomment = isset( $prop['parsedcomment'] ); |
||
58 | $this->fld_details = isset( $prop['details'] ); |
||
59 | $this->fld_tags = isset( $prop['tags'] ); |
||
60 | |||
61 | $hideLogs = LogEventsList::getExcludeClause( $db, 'user', $this->getUser() ); |
||
62 | if ( $hideLogs !== false ) { |
||
63 | $this->addWhere( $hideLogs ); |
||
64 | } |
||
65 | |||
66 | // Order is significant here |
||
67 | $this->addTables( [ 'logging', 'user', 'page' ] ); |
||
68 | $this->addJoinConds( [ |
||
69 | 'user' => [ 'LEFT JOIN', |
||
70 | 'user_id=log_user' ], |
||
71 | 'page' => [ 'LEFT JOIN', |
||
72 | [ 'log_namespace=page_namespace', |
||
73 | 'log_title=page_title' ] ] ] ); |
||
74 | |||
75 | $this->addFields( [ |
||
76 | 'log_id', |
||
77 | 'log_type', |
||
78 | 'log_action', |
||
79 | 'log_timestamp', |
||
80 | 'log_deleted', |
||
81 | ] ); |
||
82 | |||
83 | $this->addFieldsIf( 'page_id', $this->fld_ids ); |
||
84 | // log_page is the page_id saved at log time, whereas page_id is from a |
||
85 | // join at query time. This leads to different results in various |
||
86 | // scenarios, e.g. deletion, recreation. |
||
87 | $this->addFieldsIf( 'log_page', $this->fld_ids ); |
||
88 | $this->addFieldsIf( [ 'log_user', 'log_user_text', 'user_name' ], $this->fld_user ); |
||
89 | $this->addFieldsIf( 'log_user', $this->fld_userid ); |
||
90 | $this->addFieldsIf( |
||
91 | [ 'log_namespace', 'log_title' ], |
||
92 | $this->fld_title || $this->fld_parsedcomment |
||
93 | ); |
||
94 | $this->addFieldsIf( 'log_comment', $this->fld_comment || $this->fld_parsedcomment ); |
||
95 | $this->addFieldsIf( 'log_params', $this->fld_details ); |
||
96 | |||
97 | View Code Duplication | if ( $this->fld_tags ) { |
|
98 | $this->addTables( 'tag_summary' ); |
||
99 | $this->addJoinConds( [ 'tag_summary' => [ 'LEFT JOIN', 'log_id=ts_log_id' ] ] ); |
||
100 | $this->addFields( 'ts_tags' ); |
||
101 | } |
||
102 | |||
103 | View Code Duplication | if ( !is_null( $params['tag'] ) ) { |
|
104 | $this->addTables( 'change_tag' ); |
||
105 | $this->addJoinConds( [ 'change_tag' => [ 'INNER JOIN', |
||
106 | [ 'log_id=ct_log_id' ] ] ] ); |
||
107 | $this->addWhereFld( 'ct_tag', $params['tag'] ); |
||
108 | } |
||
109 | |||
110 | if ( !is_null( $params['action'] ) ) { |
||
111 | // Do validation of action param, list of allowed actions can contains wildcards |
||
112 | // Allow the param, when the actions is in the list or a wildcard version is listed. |
||
113 | $logAction = $params['action']; |
||
114 | if ( strpos( $logAction, '/' ) === false ) { |
||
115 | // all items in the list have a slash |
||
116 | $valid = false; |
||
117 | } else { |
||
118 | $logActions = array_flip( $this->getAllowedLogActions() ); |
||
119 | list( $type, $action ) = explode( '/', $logAction, 2 ); |
||
120 | $valid = isset( $logActions[$logAction] ) || isset( $logActions[$type . '/*'] ); |
||
121 | } |
||
122 | |||
123 | if ( !$valid ) { |
||
124 | $valueName = $this->encodeParamName( 'action' ); |
||
125 | $this->dieUsage( |
||
126 | "Unrecognized value for parameter '$valueName': {$logAction}", |
||
127 | "unknown_$valueName" |
||
128 | ); |
||
129 | } |
||
130 | |||
131 | $this->addWhereFld( 'log_type', $type ); |
||
132 | $this->addWhereFld( 'log_action', $action ); |
||
133 | } elseif ( !is_null( $params['type'] ) ) { |
||
134 | $this->addWhereFld( 'log_type', $params['type'] ); |
||
135 | } |
||
136 | |||
137 | $this->addTimestampWhereRange( |
||
138 | 'log_timestamp', |
||
139 | $params['dir'], |
||
140 | $params['start'], |
||
141 | $params['end'] |
||
142 | ); |
||
143 | // Include in ORDER BY for uniqueness |
||
144 | $this->addWhereRange( 'log_id', $params['dir'], null, null ); |
||
145 | |||
146 | if ( !is_null( $params['continue'] ) ) { |
||
147 | $cont = explode( '|', $params['continue'] ); |
||
148 | $this->dieContinueUsageIf( count( $cont ) != 2 ); |
||
149 | $op = ( $params['dir'] === 'newer' ? '>' : '<' ); |
||
150 | $continueTimestamp = $db->addQuotes( $db->timestamp( $cont[0] ) ); |
||
151 | $continueId = (int)$cont[1]; |
||
152 | $this->dieContinueUsageIf( $continueId != $cont[1] ); |
||
153 | $this->addWhere( "log_timestamp $op $continueTimestamp OR " . |
||
154 | "(log_timestamp = $continueTimestamp AND " . |
||
155 | "log_id $op= $continueId)" |
||
156 | ); |
||
157 | } |
||
158 | |||
159 | $limit = $params['limit']; |
||
160 | $this->addOption( 'LIMIT', $limit + 1 ); |
||
161 | |||
162 | $user = $params['user']; |
||
163 | if ( !is_null( $user ) ) { |
||
164 | $userid = User::idFromName( $user ); |
||
165 | if ( $userid ) { |
||
166 | $this->addWhereFld( 'log_user', $userid ); |
||
167 | } else { |
||
168 | $this->addWhereFld( 'log_user_text', $user ); |
||
169 | } |
||
170 | } |
||
171 | |||
172 | $title = $params['title']; |
||
173 | if ( !is_null( $title ) ) { |
||
174 | $titleObj = Title::newFromText( $title ); |
||
175 | if ( is_null( $titleObj ) ) { |
||
176 | $this->dieUsage( "Bad title value '$title'", 'param_title' ); |
||
177 | } |
||
178 | $this->addWhereFld( 'log_namespace', $titleObj->getNamespace() ); |
||
179 | $this->addWhereFld( 'log_title', $titleObj->getDBkey() ); |
||
180 | } |
||
181 | |||
182 | if ( $params['namespace'] !== null ) { |
||
183 | $this->addWhereFld( 'log_namespace', $params['namespace'] ); |
||
184 | } |
||
185 | |||
186 | $prefix = $params['prefix']; |
||
187 | |||
188 | if ( !is_null( $prefix ) ) { |
||
189 | if ( $this->getConfig()->get( 'MiserMode' ) ) { |
||
190 | $this->dieUsage( 'Prefix search disabled in Miser Mode', 'prefixsearchdisabled' ); |
||
191 | } |
||
192 | |||
193 | $title = Title::newFromText( $prefix ); |
||
194 | if ( is_null( $title ) ) { |
||
195 | $this->dieUsage( "Bad title value '$prefix'", 'param_prefix' ); |
||
196 | } |
||
197 | $this->addWhereFld( 'log_namespace', $title->getNamespace() ); |
||
198 | $this->addWhere( 'log_title ' . $db->buildLike( $title->getDBkey(), $db->anyString() ) ); |
||
199 | } |
||
200 | |||
201 | // Paranoia: avoid brute force searches (bug 17342) |
||
202 | if ( $params['namespace'] !== null || !is_null( $title ) || !is_null( $user ) ) { |
||
203 | if ( !$this->getUser()->isAllowed( 'deletedhistory' ) ) { |
||
204 | $titleBits = LogPage::DELETED_ACTION; |
||
205 | $userBits = LogPage::DELETED_USER; |
||
206 | } elseif ( !$this->getUser()->isAllowedAny( 'suppressrevision', 'viewsuppressed' ) ) { |
||
207 | $titleBits = LogPage::DELETED_ACTION | LogPage::DELETED_RESTRICTED; |
||
208 | $userBits = LogPage::DELETED_USER | LogPage::DELETED_RESTRICTED; |
||
209 | } else { |
||
210 | $titleBits = 0; |
||
211 | $userBits = 0; |
||
212 | } |
||
213 | if ( ( $params['namespace'] !== null || !is_null( $title ) ) && $titleBits ) { |
||
214 | $this->addWhere( $db->bitAnd( 'log_deleted', $titleBits ) . " != $titleBits" ); |
||
215 | } |
||
216 | if ( !is_null( $user ) && $userBits ) { |
||
217 | $this->addWhere( $db->bitAnd( 'log_deleted', $userBits ) . " != $userBits" ); |
||
218 | } |
||
219 | } |
||
220 | |||
221 | $count = 0; |
||
222 | $res = $this->select( __METHOD__ ); |
||
223 | $result = $this->getResult(); |
||
224 | View Code Duplication | foreach ( $res as $row ) { |
|
225 | if ( ++$count > $limit ) { |
||
226 | // We've reached the one extra which shows that there are |
||
227 | // additional pages to be had. Stop here... |
||
228 | $this->setContinueEnumParameter( 'continue', "$row->log_timestamp|$row->log_id" ); |
||
229 | break; |
||
230 | } |
||
231 | |||
232 | $vals = $this->extractRowInfo( $row ); |
||
233 | $fit = $result->addValue( [ 'query', $this->getModuleName() ], null, $vals ); |
||
234 | if ( !$fit ) { |
||
235 | $this->setContinueEnumParameter( 'continue', "$row->log_timestamp|$row->log_id" ); |
||
236 | break; |
||
237 | } |
||
238 | } |
||
239 | $result->addIndexedTagName( [ 'query', $this->getModuleName() ], 'item' ); |
||
240 | } |
||
241 | |||
472 |
Only declaring a single property per statement allows you to later on add doc comments more easily.
It is also recommended by PSR2, so it is a common style that many people expect.