Conditions | 23 |
Paths | 1958 |
Total Lines | 159 |
Code Lines | 99 |
Lines | 7 |
Ratio | 4.4 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
47 | public function execute() { |
||
48 | $db = $this->getDB(); |
||
49 | $params = $this->extractRequestParams(); |
||
50 | $this->requireMaxOneParameter( $params, 'group', 'excludegroup', 'rights', 'excluderights' ); |
||
51 | |||
52 | // Only operate on existing pages |
||
53 | $pages = array_keys( $this->getPageSet()->getGoodTitles() ); |
||
54 | |||
55 | // Filter out already-processed pages |
||
56 | if ( $params['continue'] !== null ) { |
||
57 | $cont = explode( '|', $params['continue'] ); |
||
58 | $this->dieContinueUsageIf( count( $cont ) != 2 ); |
||
59 | $cont_page = (int)$cont[0]; |
||
60 | $pages = array_filter( $pages, function ( $v ) use ( $cont_page ) { |
||
61 | return $v >= $cont_page; |
||
62 | } ); |
||
63 | } |
||
64 | if ( !count( $pages ) ) { |
||
65 | // Nothing to do |
||
66 | return; |
||
67 | } |
||
68 | |||
69 | // Apply MAX_PAGES, leaving any over the limit for a continue. |
||
70 | sort( $pages ); |
||
71 | $continuePages = null; |
||
72 | if ( count( $pages ) > self::MAX_PAGES ) { |
||
73 | $continuePages = $pages[self::MAX_PAGES] . '|0'; |
||
74 | $pages = array_slice( $pages, 0, self::MAX_PAGES ); |
||
75 | } |
||
76 | |||
77 | $result = $this->getResult(); |
||
78 | |||
79 | // First, count anons |
||
80 | $this->addTables( 'revision' ); |
||
81 | $this->addFields( [ |
||
82 | 'page' => 'rev_page', |
||
83 | 'anons' => 'COUNT(DISTINCT rev_user_text)', |
||
84 | ] ); |
||
85 | $this->addWhereFld( 'rev_page', $pages ); |
||
86 | $this->addWhere( 'rev_user = 0' ); |
||
87 | $this->addWhere( $db->bitAnd( 'rev_deleted', Revision::DELETED_USER ) . ' = 0' ); |
||
88 | $this->addOption( 'GROUP BY', 'rev_page' ); |
||
89 | $res = $this->select( __METHOD__ ); |
||
90 | foreach ( $res as $row ) { |
||
91 | $fit = $result->addValue( [ 'query', 'pages', $row->page ], |
||
92 | 'anoncontributors', (int)$row->anons |
||
93 | ); |
||
94 | if ( !$fit ) { |
||
95 | // This not fitting isn't reasonable, so it probably means that |
||
96 | // some other module used up all the space. Just set a dummy |
||
97 | // continue and hope it works next time. |
||
98 | $this->setContinueEnumParameter( 'continue', |
||
99 | $params['continue'] !== null ? $params['continue'] : '0|0' |
||
100 | ); |
||
101 | |||
102 | return; |
||
103 | } |
||
104 | } |
||
105 | |||
106 | // Next, add logged-in users |
||
107 | $this->resetQueryParams(); |
||
108 | $this->addTables( 'revision' ); |
||
109 | $this->addFields( [ |
||
110 | 'page' => 'rev_page', |
||
111 | 'user' => 'rev_user', |
||
112 | 'username' => 'MAX(rev_user_text)', // Non-MySQL databases don't like partial group-by |
||
113 | ] ); |
||
114 | $this->addWhereFld( 'rev_page', $pages ); |
||
115 | $this->addWhere( 'rev_user != 0' ); |
||
116 | $this->addWhere( $db->bitAnd( 'rev_deleted', Revision::DELETED_USER ) . ' = 0' ); |
||
117 | $this->addOption( 'GROUP BY', 'rev_page, rev_user' ); |
||
118 | $this->addOption( 'LIMIT', $params['limit'] + 1 ); |
||
119 | |||
120 | // Force a sort order to ensure that properties are grouped by page |
||
121 | // But only if pp_page is not constant in the WHERE clause. |
||
122 | if ( count( $pages ) > 1 ) { |
||
123 | $this->addOption( 'ORDER BY', 'rev_page, rev_user' ); |
||
124 | } else { |
||
125 | $this->addOption( 'ORDER BY', 'rev_user' ); |
||
126 | } |
||
127 | |||
128 | $limitGroups = []; |
||
129 | if ( $params['group'] ) { |
||
130 | $excludeGroups = false; |
||
131 | $limitGroups = $params['group']; |
||
132 | } elseif ( $params['excludegroup'] ) { |
||
133 | $excludeGroups = true; |
||
134 | $limitGroups = $params['excludegroup']; |
||
135 | } elseif ( $params['rights'] ) { |
||
136 | $excludeGroups = false; |
||
137 | foreach ( $params['rights'] as $r ) { |
||
138 | $limitGroups = array_merge( $limitGroups, User::getGroupsWithPermission( $r ) ); |
||
139 | } |
||
140 | |||
141 | // If no group has the rights requested, no need to query |
||
142 | if ( !$limitGroups ) { |
||
143 | if ( $continuePages !== null ) { |
||
144 | // But we still need to continue for the next page's worth |
||
145 | // of anoncontributors |
||
146 | $this->setContinueEnumParameter( 'continue', $continuePages ); |
||
147 | } |
||
148 | |||
149 | return; |
||
150 | } |
||
151 | } elseif ( $params['excluderights'] ) { |
||
152 | $excludeGroups = true; |
||
153 | foreach ( $params['excluderights'] as $r ) { |
||
154 | $limitGroups = array_merge( $limitGroups, User::getGroupsWithPermission( $r ) ); |
||
155 | } |
||
156 | } |
||
157 | |||
158 | if ( $limitGroups ) { |
||
159 | $limitGroups = array_unique( $limitGroups ); |
||
160 | $this->addTables( 'user_groups' ); |
||
161 | $this->addJoinConds( [ 'user_groups' => [ |
||
162 | $excludeGroups ? 'LEFT OUTER JOIN' : 'INNER JOIN', |
||
|
|||
163 | [ 'ug_user=rev_user', 'ug_group' => $limitGroups ] |
||
164 | ] ] ); |
||
165 | $this->addWhereIf( 'ug_user IS NULL', $excludeGroups ); |
||
166 | } |
||
167 | |||
168 | if ( $params['continue'] !== null ) { |
||
169 | $cont = explode( '|', $params['continue'] ); |
||
170 | $this->dieContinueUsageIf( count( $cont ) != 2 ); |
||
171 | $cont_page = (int)$cont[0]; |
||
172 | $cont_user = (int)$cont[1]; |
||
173 | $this->addWhere( |
||
174 | "rev_page > $cont_page OR " . |
||
175 | "(rev_page = $cont_page AND " . |
||
176 | "rev_user >= $cont_user)" |
||
177 | ); |
||
178 | } |
||
179 | |||
180 | $res = $this->select( __METHOD__ ); |
||
181 | $count = 0; |
||
182 | foreach ( $res as $row ) { |
||
183 | View Code Duplication | if ( ++$count > $params['limit'] ) { |
|
184 | // We've reached the one extra which shows that |
||
185 | // there are additional pages to be had. Stop here... |
||
186 | $this->setContinueEnumParameter( 'continue', $row->page . '|' . $row->user ); |
||
187 | |||
188 | return; |
||
189 | } |
||
190 | |||
191 | $fit = $this->addPageSubItem( $row->page, |
||
192 | [ 'userid' => (int)$row->user, 'name' => $row->username ], |
||
193 | 'user' |
||
194 | ); |
||
195 | if ( !$fit ) { |
||
196 | $this->setContinueEnumParameter( 'continue', $row->page . '|' . $row->user ); |
||
197 | |||
198 | return; |
||
199 | } |
||
200 | } |
||
201 | |||
202 | if ( $continuePages !== null ) { |
||
203 | $this->setContinueEnumParameter( 'continue', $continuePages ); |
||
204 | } |
||
205 | } |
||
206 | |||
256 |
If you define a variable conditionally, it can happen that it is not defined for all execution paths.
Let’s take a look at an example:
In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.
Available Fixes
Check for existence of the variable explicitly:
Define a default value for the variable:
Add a value for the missing path: