Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
30 | class AuthManagerAuthPlugin extends \AuthPlugin { |
||
|
|||
31 | /** @var string|null */ |
||
32 | protected $domain = null; |
||
33 | |||
34 | /** @var \\Psr\\Log\\LoggerInterface */ |
||
35 | protected $logger = null; |
||
36 | |||
37 | public function __construct() { |
||
40 | |||
41 | public function userExists( $name ) { |
||
44 | |||
45 | public function authenticate( $username, $password ) { |
||
46 | $data = [ |
||
47 | 'username' => $username, |
||
48 | 'password' => $password, |
||
49 | ]; |
||
50 | View Code Duplication | if ( $this->domain !== null && $this->domain !== '' ) { |
|
51 | $data['domain'] = $this->domain; |
||
52 | } |
||
53 | $reqs = AuthManager::singleton()->getAuthenticationRequests( AuthManager::ACTION_LOGIN ); |
||
54 | $reqs = AuthenticationRequest::loadRequestsFromSubmission( $reqs, $data ); |
||
55 | |||
56 | $res = AuthManager::singleton()->beginAuthentication( $reqs, 'null:' ); |
||
57 | switch ( $res->status ) { |
||
58 | case AuthenticationResponse::PASS: |
||
59 | return true; |
||
60 | case AuthenticationResponse::FAIL: |
||
61 | // Hope it's not a PreAuthenticationProvider that failed... |
||
62 | $msg = $res->message instanceof \Message ? $res->message : new \Message( $res->message ); |
||
63 | $this->logger->info( __METHOD__ . ': Authentication failed: ' . $msg->plain() ); |
||
64 | return false; |
||
65 | default: |
||
66 | throw new \BadMethodCallException( |
||
67 | 'AuthManager does not support such simplified authentication' |
||
68 | ); |
||
69 | } |
||
70 | } |
||
71 | |||
72 | public function modifyUITemplate( &$template, &$type ) { |
||
75 | |||
76 | public function setDomain( $domain ) { |
||
79 | |||
80 | public function getDomain() { |
||
87 | |||
88 | public function validDomain( $domain ) { |
||
92 | |||
93 | public function updateUser( &$user ) { |
||
97 | |||
98 | public function autoCreate() { |
||
101 | |||
102 | public function allowPropChange( $prop = '' ) { |
||
105 | |||
106 | public function allowPasswordChange() { |
||
116 | |||
117 | public function allowSetLocalPassword() { |
||
121 | |||
122 | public function setPassword( $user, $password ) { |
||
123 | $data = [ |
||
124 | 'username' => $user->getName(), |
||
125 | 'password' => $password, |
||
126 | ]; |
||
127 | View Code Duplication | if ( $this->domain !== null && $this->domain !== '' ) { |
|
128 | $data['domain'] = $this->domain; |
||
129 | } |
||
130 | $reqs = AuthManager::singleton()->getAuthenticationRequests( AuthManager::ACTION_CHANGE ); |
||
131 | $reqs = AuthenticationRequest::loadRequestsFromSubmission( $reqs, $data ); |
||
132 | foreach ( $reqs as $req ) { |
||
133 | $status = AuthManager::singleton()->allowsAuthenticationDataChange( $req ); |
||
134 | if ( !$status->isGood() ) { |
||
135 | $this->logger->info( __METHOD__ . ': Password change rejected: {reason}', [ |
||
136 | 'username' => $data['username'], |
||
137 | 'reason' => $status->getWikiText( null, null, 'en' ), |
||
138 | ] ); |
||
139 | return false; |
||
140 | } |
||
141 | } |
||
142 | foreach ( $reqs as $req ) { |
||
143 | AuthManager::singleton()->changeAuthenticationData( $req ); |
||
144 | } |
||
145 | return true; |
||
146 | } |
||
147 | |||
148 | public function updateExternalDB( $user ) { |
||
153 | |||
154 | public function updateExternalDBGroups( $user, $addgroups, $delgroups = [] ) { |
||
158 | |||
159 | public function canCreateAccounts() { |
||
162 | |||
163 | public function addUser( $user, $password, $email = '', $realname = '' ) { |
||
164 | throw new \BadMethodCallException( |
||
165 | 'Creation of users via AuthPlugin is not supported with ' |
||
166 | . 'AuthManager. Generally, user creation should be left to either ' |
||
167 | . 'Special:CreateAccount, auto-creation when triggered by a ' |
||
168 | . 'SessionProvider or PrimaryAuthenticationProvider, or ' |
||
169 | . 'User::newSystemUser().' |
||
170 | ); |
||
171 | } |
||
172 | |||
173 | public function strict() { |
||
174 | // There should be a PrimaryAuthenticationProvider that does this, if necessary |
||
175 | return true; |
||
176 | } |
||
177 | |||
178 | public function strictUserAuth( $username ) { |
||
179 | // There should be a PrimaryAuthenticationProvider that does this, if necessary |
||
180 | return true; |
||
181 | } |
||
182 | |||
183 | public function initUser( &$user, $autocreate = false ) { |
||
184 | \Hooks::run( 'LocalUserCreated', [ $user, $autocreate ] ); |
||
185 | } |
||
186 | |||
187 | public function getCanonicalName( $username ) { |
||
188 | // AuthManager doesn't support restrictions beyond MediaWiki's |
||
189 | return $username; |
||
190 | } |
||
191 | |||
192 | public function getUserInstance( User &$user ) { |
||
193 | return new AuthManagerAuthPluginUser( $user ); |
||
194 | } |
||
195 | |||
196 | public function domainList() { |
||
199 | } |
||
200 | |||
201 | /** |
||
202 | * @since 1.27 |
||
203 | * @deprecated since 1.27 |
||
204 | */ |
||
205 | class AuthManagerAuthPluginUser extends \AuthPluginUser { |
||
206 | /** @var User */ |
||
230 |
This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message.
The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead.