Undelete   A
last analyzed

Complexity

Total Complexity 5

Size/Duplication

Total Lines 34
Duplicated Lines 14.71 %

Coupling/Cohesion

Components 1
Dependencies 5

Importance

Changes 0
Metric Value
dl 5
loc 34
rs 10
c 0
b 0
f 0
wmc 5
lcom 1
cbo 5

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 7 1
B execute() 5 24 4

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 26 and the first side effect is on line 24.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
/**
3
 * Undelete a page by fetching it from the archive table
4
 *
5
 * This program is free software; you can redistribute it and/or modify
6
 * it under the terms of the GNU General Public License as published by
7
 * the Free Software Foundation; either version 2 of the License, or
8
 * (at your option) any later version.
9
 *
10
 * This program is distributed in the hope that it will be useful,
11
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
 * GNU General Public License for more details.
14
 *
15
 * You should have received a copy of the GNU General Public License along
16
 * with this program; if not, write to the Free Software Foundation, Inc.,
17
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18
 * http://www.gnu.org/copyleft/gpl.html
19
 *
20
 * @file
21
 * @ingroup Maintenance
22
 */
23
24
require_once __DIR__ . '/Maintenance.php';
25
26
class Undelete extends Maintenance {
27
	public function __construct() {
28
		parent::__construct();
29
		$this->addDescription( 'Undelete a page' );
30
		$this->addOption( 'user', 'The user to perform the undeletion', false, true, 'u' );
31
		$this->addOption( 'reason', 'The reason to undelete', false, true, 'r' );
32
		$this->addArg( 'pagename', 'Page to undelete' );
33
	}
34
35
	public function execute() {
36
		global $wgUser;
37
38
		$user = $this->getOption( 'user', false );
39
		$reason = $this->getOption( 'reason', '' );
40
		$pageName = $this->getArg();
41
42
		$title = Title::newFromText( $pageName );
43
		if ( !$title ) {
44
			$this->error( "Invalid title", true );
45
		}
46 View Code Duplication
		if ( $user === false ) {
47
			$wgUser = User::newSystemUser( 'Command line script', [ 'steal' => true ] );
48
		} else {
49
			$wgUser = User::newFromName( $user );
50
		}
51
		if ( !$wgUser ) {
52
			$this->error( "Invalid username", true );
53
		}
54
		$archive = new PageArchive( $title, RequestContext::getMain()->getConfig() );
55
		$this->output( "Undeleting " . $title->getPrefixedDBkey() . '...' );
56
		$archive->undelete( [], $reason );
57
		$this->output( "done\n" );
58
	}
59
}
60
61
$maintClass = "Undelete";
62
require_once RUN_MAINTENANCE_IF_MAIN;
63