Complex classes like ResourceLoaderFileModule often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ResourceLoaderFileModule, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class ResourceLoaderFileModule extends ResourceLoaderModule { |
||
| 29 | /* Protected Members */ |
||
| 30 | |||
| 31 | /** @var string Local base path, see __construct() */ |
||
| 32 | protected $localBasePath = ''; |
||
| 33 | |||
| 34 | /** @var string Remote base path, see __construct() */ |
||
| 35 | protected $remoteBasePath = ''; |
||
| 36 | |||
| 37 | /** @var array Saves a list of the templates named by the modules. */ |
||
| 38 | protected $templates = []; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @var array List of paths to JavaScript files to always include |
||
| 42 | * @par Usage: |
||
| 43 | * @code |
||
| 44 | * [ [file-path], [file-path], ... ] |
||
| 45 | * @endcode |
||
| 46 | */ |
||
| 47 | protected $scripts = []; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var array List of JavaScript files to include when using a specific language |
||
| 51 | * @par Usage: |
||
| 52 | * @code |
||
| 53 | * [ [language-code] => [ [file-path], [file-path], ... ], ... ] |
||
| 54 | * @endcode |
||
| 55 | */ |
||
| 56 | protected $languageScripts = []; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @var array List of JavaScript files to include when using a specific skin |
||
| 60 | * @par Usage: |
||
| 61 | * @code |
||
| 62 | * [ [skin-name] => [ [file-path], [file-path], ... ], ... ] |
||
| 63 | * @endcode |
||
| 64 | */ |
||
| 65 | protected $skinScripts = []; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var array List of paths to JavaScript files to include in debug mode |
||
| 69 | * @par Usage: |
||
| 70 | * @code |
||
| 71 | * [ [skin-name] => [ [file-path], [file-path], ... ], ... ] |
||
| 72 | * @endcode |
||
| 73 | */ |
||
| 74 | protected $debugScripts = []; |
||
| 75 | |||
| 76 | /** |
||
| 77 | * @var array List of paths to CSS files to always include |
||
| 78 | * @par Usage: |
||
| 79 | * @code |
||
| 80 | * [ [file-path], [file-path], ... ] |
||
| 81 | * @endcode |
||
| 82 | */ |
||
| 83 | protected $styles = []; |
||
| 84 | |||
| 85 | /** |
||
| 86 | * @var array List of paths to CSS files to include when using specific skins |
||
| 87 | * @par Usage: |
||
| 88 | * @code |
||
| 89 | * [ [file-path], [file-path], ... ] |
||
| 90 | * @endcode |
||
| 91 | */ |
||
| 92 | protected $skinStyles = []; |
||
| 93 | |||
| 94 | /** |
||
| 95 | * @var array List of modules this module depends on |
||
| 96 | * @par Usage: |
||
| 97 | * @code |
||
| 98 | * [ [file-path], [file-path], ... ] |
||
| 99 | * @endcode |
||
| 100 | */ |
||
| 101 | protected $dependencies = []; |
||
| 102 | |||
| 103 | /** |
||
| 104 | * @var string File name containing the body of the skip function |
||
| 105 | */ |
||
| 106 | protected $skipFunction = null; |
||
| 107 | |||
| 108 | /** |
||
| 109 | * @var array List of message keys used by this module |
||
| 110 | * @par Usage: |
||
| 111 | * @code |
||
| 112 | * [ [message-key], [message-key], ... ] |
||
| 113 | * @endcode |
||
| 114 | */ |
||
| 115 | protected $messages = []; |
||
| 116 | |||
| 117 | /** @var string Name of group to load this module in */ |
||
| 118 | protected $group; |
||
| 119 | |||
| 120 | /** @var string Position on the page to load this module at */ |
||
| 121 | protected $position = 'bottom'; |
||
| 122 | |||
| 123 | /** @var bool Link to raw files in debug mode */ |
||
| 124 | protected $debugRaw = true; |
||
| 125 | |||
| 126 | /** @var bool Whether mw.loader.state() call should be omitted */ |
||
| 127 | protected $raw = false; |
||
| 128 | |||
| 129 | protected $targets = [ 'desktop' ]; |
||
| 130 | |||
| 131 | /** @var bool Whether CSSJanus flipping should be skipped for this module */ |
||
| 132 | protected $noflip = false; |
||
| 133 | |||
| 134 | /** |
||
| 135 | * @var bool Whether getStyleURLsForDebug should return raw file paths, |
||
| 136 | * or return load.php urls |
||
| 137 | */ |
||
| 138 | protected $hasGeneratedStyles = false; |
||
| 139 | |||
| 140 | /** |
||
| 141 | * @var array Place where readStyleFile() tracks file dependencies |
||
| 142 | * @par Usage: |
||
| 143 | * @code |
||
| 144 | * [ [file-path], [file-path], ... ] |
||
| 145 | * @endcode |
||
| 146 | */ |
||
| 147 | protected $localFileRefs = []; |
||
| 148 | |||
| 149 | /** |
||
| 150 | * @var array Place where readStyleFile() tracks file dependencies for non-existent files. |
||
| 151 | * Used in tests to detect missing dependencies. |
||
| 152 | */ |
||
| 153 | protected $missingLocalFileRefs = []; |
||
| 154 | |||
| 155 | /* Methods */ |
||
| 156 | |||
| 157 | /** |
||
| 158 | * Constructs a new module from an options array. |
||
| 159 | * |
||
| 160 | * @param array $options List of options; if not given or empty, an empty module will be |
||
| 161 | * constructed |
||
| 162 | * @param string $localBasePath Base path to prepend to all local paths in $options. Defaults |
||
| 163 | * to $IP |
||
| 164 | * @param string $remoteBasePath Base path to prepend to all remote paths in $options. Defaults |
||
| 165 | * to $wgResourceBasePath |
||
| 166 | * |
||
| 167 | * Below is a description for the $options array: |
||
| 168 | * @throws InvalidArgumentException |
||
| 169 | * @par Construction options: |
||
| 170 | * @code |
||
| 171 | * [ |
||
| 172 | * // Base path to prepend to all local paths in $options. Defaults to $IP |
||
| 173 | * 'localBasePath' => [base path], |
||
| 174 | * // Base path to prepend to all remote paths in $options. Defaults to $wgResourceBasePath |
||
| 175 | * 'remoteBasePath' => [base path], |
||
| 176 | * // Equivalent of remoteBasePath, but relative to $wgExtensionAssetsPath |
||
| 177 | * 'remoteExtPath' => [base path], |
||
| 178 | * // Equivalent of remoteBasePath, but relative to $wgStylePath |
||
| 179 | * 'remoteSkinPath' => [base path], |
||
| 180 | * // Scripts to always include |
||
| 181 | * 'scripts' => [file path string or array of file path strings], |
||
| 182 | * // Scripts to include in specific language contexts |
||
| 183 | * 'languageScripts' => [ |
||
| 184 | * [language code] => [file path string or array of file path strings], |
||
| 185 | * ], |
||
| 186 | * // Scripts to include in specific skin contexts |
||
| 187 | * 'skinScripts' => [ |
||
| 188 | * [skin name] => [file path string or array of file path strings], |
||
| 189 | * ], |
||
| 190 | * // Scripts to include in debug contexts |
||
| 191 | * 'debugScripts' => [file path string or array of file path strings], |
||
| 192 | * // Modules which must be loaded before this module |
||
| 193 | * 'dependencies' => [module name string or array of module name strings], |
||
| 194 | * 'templates' => [ |
||
| 195 | * [template alias with file.ext] => [file path to a template file], |
||
| 196 | * ], |
||
| 197 | * // Styles to always load |
||
| 198 | * 'styles' => [file path string or array of file path strings], |
||
| 199 | * // Styles to include in specific skin contexts |
||
| 200 | * 'skinStyles' => [ |
||
| 201 | * [skin name] => [file path string or array of file path strings], |
||
| 202 | * ], |
||
| 203 | * // Messages to always load |
||
| 204 | * 'messages' => [array of message key strings], |
||
| 205 | * // Group which this module should be loaded together with |
||
| 206 | * 'group' => [group name string], |
||
| 207 | * // Position on the page to load this module at |
||
| 208 | * 'position' => ['bottom' (default) or 'top'] |
||
| 209 | * // Function that, if it returns true, makes the loader skip this module. |
||
| 210 | * // The file must contain valid JavaScript for execution in a private function. |
||
| 211 | * // The file must not contain the "function () {" and "}" wrapper though. |
||
| 212 | * 'skipFunction' => [file path] |
||
| 213 | * ] |
||
| 214 | * @endcode |
||
| 215 | */ |
||
| 216 | public function __construct( |
||
| 304 | |||
| 305 | /** |
||
| 306 | * Extract a pair of local and remote base paths from module definition information. |
||
| 307 | * Implementation note: the amount of global state used in this function is staggering. |
||
| 308 | * |
||
| 309 | * @param array $options Module definition |
||
| 310 | * @param string $localBasePath Path to use if not provided in module definition. Defaults |
||
| 311 | * to $IP |
||
| 312 | * @param string $remoteBasePath Path to use if not provided in module definition. Defaults |
||
| 313 | * to $wgResourceBasePath |
||
| 314 | * @return array Array( localBasePath, remoteBasePath ) |
||
| 315 | */ |
||
| 316 | public static function extractBasePaths( |
||
| 353 | |||
| 354 | /** |
||
| 355 | * Gets all scripts for a given context concatenated together. |
||
| 356 | * |
||
| 357 | * @param ResourceLoaderContext $context Context in which to generate script |
||
| 358 | * @return string JavaScript code for $context |
||
| 359 | */ |
||
| 360 | public function getScript( ResourceLoaderContext $context ) { |
||
| 364 | |||
| 365 | /** |
||
| 366 | * @param ResourceLoaderContext $context |
||
| 367 | * @return array |
||
| 368 | */ |
||
| 369 | public function getScriptURLsForDebug( ResourceLoaderContext $context ) { |
||
| 379 | |||
| 380 | /** |
||
| 381 | * @return bool |
||
| 382 | */ |
||
| 383 | public function supportsURLLoading() { |
||
| 386 | |||
| 387 | /** |
||
| 388 | * Get all styles for a given context. |
||
| 389 | * |
||
| 390 | * @param ResourceLoaderContext $context |
||
| 391 | * @return array CSS code for $context as an associative array mapping media type to CSS text. |
||
| 392 | */ |
||
| 393 | public function getStyles( ResourceLoaderContext $context ) { |
||
| 404 | |||
| 405 | /** |
||
| 406 | * @param ResourceLoaderContext $context |
||
| 407 | * @return array |
||
| 408 | */ |
||
| 409 | public function getStyleURLsForDebug( ResourceLoaderContext $context ) { |
||
| 429 | |||
| 430 | /** |
||
| 431 | * Gets list of message keys used by this module. |
||
| 432 | * |
||
| 433 | * @return array List of message keys |
||
| 434 | */ |
||
| 435 | public function getMessages() { |
||
| 438 | |||
| 439 | /** |
||
| 440 | * Gets the name of the group this module should be loaded in. |
||
| 441 | * |
||
| 442 | * @return string Group name |
||
| 443 | */ |
||
| 444 | public function getGroup() { |
||
| 447 | |||
| 448 | /** |
||
| 449 | * @return string |
||
| 450 | */ |
||
| 451 | public function getPosition() { |
||
| 454 | |||
| 455 | /** |
||
| 456 | * Gets list of names of modules this module depends on. |
||
| 457 | * @param ResourceLoaderContext|null $context |
||
| 458 | * @return array List of module names |
||
| 459 | */ |
||
| 460 | public function getDependencies( ResourceLoaderContext $context = null ) { |
||
| 463 | |||
| 464 | /** |
||
| 465 | * Get the skip function. |
||
| 466 | * @return null|string |
||
| 467 | * @throws MWException |
||
| 468 | */ |
||
| 469 | public function getSkipFunction() { |
||
| 484 | |||
| 485 | /** |
||
| 486 | * @return bool |
||
| 487 | */ |
||
| 488 | public function isRaw() { |
||
| 491 | |||
| 492 | /** |
||
| 493 | * Disable module content versioning. |
||
| 494 | * |
||
| 495 | * This class uses getDefinitionSummary() instead, to avoid filesystem overhead |
||
| 496 | * involved with building the full module content inside a startup request. |
||
| 497 | * |
||
| 498 | * @return bool |
||
| 499 | */ |
||
| 500 | public function enableModuleContentVersion() { |
||
| 503 | |||
| 504 | /** |
||
| 505 | * Helper method to gather file hashes for getDefinitionSummary. |
||
| 506 | * |
||
| 507 | * This function is context-sensitive, only computing hashes of files relevant to the |
||
| 508 | * given language, skin, etc. |
||
| 509 | * |
||
| 510 | * @see ResourceLoaderModule::getFileDependencies |
||
| 511 | * @param ResourceLoaderContext $context |
||
| 512 | * @return array |
||
| 513 | */ |
||
| 514 | protected function getFileHashes( ResourceLoaderContext $context ) { |
||
| 557 | |||
| 558 | /** |
||
| 559 | * Get the definition summary for this module. |
||
| 560 | * |
||
| 561 | * @param ResourceLoaderContext $context |
||
| 562 | * @return array |
||
| 563 | */ |
||
| 564 | public function getDefinitionSummary( ResourceLoaderContext $context ) { |
||
| 599 | |||
| 600 | /** |
||
| 601 | * @param string|ResourceLoaderFilePath $path |
||
| 602 | * @return string |
||
| 603 | */ |
||
| 604 | protected function getLocalPath( $path ) { |
||
| 611 | |||
| 612 | /** |
||
| 613 | * @param string|ResourceLoaderFilePath $path |
||
| 614 | * @return string |
||
| 615 | */ |
||
| 616 | protected function getRemotePath( $path ) { |
||
| 623 | |||
| 624 | /** |
||
| 625 | * Infer the stylesheet language from a stylesheet file path. |
||
| 626 | * |
||
| 627 | * @since 1.22 |
||
| 628 | * @param string $path |
||
| 629 | * @return string The stylesheet language name |
||
| 630 | */ |
||
| 631 | public function getStyleSheetLang( $path ) { |
||
| 634 | |||
| 635 | /** |
||
| 636 | * Collates file paths by option (where provided). |
||
| 637 | * |
||
| 638 | * @param array $list List of file paths in any combination of index/path |
||
| 639 | * or path/options pairs |
||
| 640 | * @param string $option Option name |
||
| 641 | * @param mixed $default Default value if the option isn't set |
||
| 642 | * @return array List of file paths, collated by $option |
||
| 643 | */ |
||
| 644 | protected static function collateFilePathListByOption( array $list, $option, $default ) { |
||
| 664 | |||
| 665 | /** |
||
| 666 | * Get a list of element that match a key, optionally using a fallback key. |
||
| 667 | * |
||
| 668 | * @param array $list List of lists to select from |
||
| 669 | * @param string $key Key to look for in $map |
||
| 670 | * @param string $fallback Key to look for in $list if $key doesn't exist |
||
| 671 | * @return array List of elements from $map which matched $key or $fallback, |
||
| 672 | * or an empty list in case of no match |
||
| 673 | */ |
||
| 674 | protected static function tryForKey( array $list, $key, $fallback = null ) { |
||
| 685 | |||
| 686 | /** |
||
| 687 | * Get a list of file paths for all scripts in this module, in order of proper execution. |
||
| 688 | * |
||
| 689 | * @param ResourceLoaderContext $context |
||
| 690 | * @return array List of file paths |
||
| 691 | */ |
||
| 692 | protected function getScriptFiles( ResourceLoaderContext $context ) { |
||
| 704 | |||
| 705 | /** |
||
| 706 | * Get the set of language scripts for the given language, |
||
| 707 | * possibly using a fallback language. |
||
| 708 | * |
||
| 709 | * @param string $lang |
||
| 710 | * @return array |
||
| 711 | */ |
||
| 712 | private function getLanguageScripts( $lang ) { |
||
| 727 | |||
| 728 | /** |
||
| 729 | * Get a list of file paths for all styles in this module, in order of proper inclusion. |
||
| 730 | * |
||
| 731 | * @param ResourceLoaderContext $context |
||
| 732 | * @return array List of file paths |
||
| 733 | */ |
||
| 734 | public function getStyleFiles( ResourceLoaderContext $context ) { |
||
| 744 | |||
| 745 | /** |
||
| 746 | * Gets a list of file paths for all skin styles in the module used by |
||
| 747 | * the skin. |
||
| 748 | * |
||
| 749 | * @param string $skinName The name of the skin |
||
| 750 | * @return array A list of file paths collated by media type |
||
| 751 | */ |
||
| 752 | protected function getSkinStyleFiles( $skinName ) { |
||
| 759 | |||
| 760 | /** |
||
| 761 | * Gets a list of file paths for all skin style files in the module, |
||
| 762 | * for all available skins. |
||
| 763 | * |
||
| 764 | * @return array A list of file paths collated by media type |
||
| 765 | */ |
||
| 766 | protected function getAllSkinStyleFiles() { |
||
| 780 | |||
| 781 | /** |
||
| 782 | * Returns all style files and all skin style files used by this module. |
||
| 783 | * |
||
| 784 | * @return array |
||
| 785 | */ |
||
| 786 | public function getAllStyleFiles() { |
||
| 802 | |||
| 803 | /** |
||
| 804 | * Gets the contents of a list of JavaScript files. |
||
| 805 | * |
||
| 806 | * @param array $scripts List of file paths to scripts to read, remap and concetenate |
||
| 807 | * @throws MWException |
||
| 808 | * @return string Concatenated and remapped JavaScript data from $scripts |
||
| 809 | */ |
||
| 810 | protected function readScriptFiles( array $scripts ) { |
||
| 831 | |||
| 832 | /** |
||
| 833 | * Gets the contents of a list of CSS files. |
||
| 834 | * |
||
| 835 | * @param array $styles List of media type/list of file paths pairs, to read, remap and |
||
| 836 | * concetenate |
||
| 837 | * @param bool $flip |
||
| 838 | * @param ResourceLoaderContext $context |
||
| 839 | * |
||
| 840 | * @throws MWException |
||
| 841 | * @return array List of concatenated and remapped CSS data from $styles, |
||
| 842 | * keyed by media type |
||
| 843 | * |
||
| 844 | * @since 1.27 Calling this method without a ResourceLoaderContext instance |
||
| 845 | * is deprecated. |
||
| 846 | */ |
||
| 847 | public function readStyleFiles( array $styles, $flip, $context = null ) { |
||
| 866 | |||
| 867 | /** |
||
| 868 | * Reads a style file. |
||
| 869 | * |
||
| 870 | * This method can be used as a callback for array_map() |
||
| 871 | * |
||
| 872 | * @param string $path File path of style file to read |
||
| 873 | * @param bool $flip |
||
| 874 | * @param ResourceLoaderContext $context |
||
| 875 | * |
||
| 876 | * @return string CSS data in script file |
||
| 877 | * @throws MWException If the file doesn't exist |
||
| 878 | */ |
||
| 879 | protected function readStyleFile( $path, $flip, $context ) { |
||
| 913 | |||
| 914 | /** |
||
| 915 | * Get whether CSS for this module should be flipped |
||
| 916 | * @param ResourceLoaderContext $context |
||
| 917 | * @return bool |
||
| 918 | */ |
||
| 919 | public function getFlip( $context ) { |
||
| 922 | |||
| 923 | /** |
||
| 924 | * Get target(s) for the module, eg ['desktop'] or ['desktop', 'mobile'] |
||
| 925 | * |
||
| 926 | * @return array Array of strings |
||
| 927 | */ |
||
| 928 | public function getTargets() { |
||
| 931 | |||
| 932 | /** |
||
| 933 | * Get the module's load type. |
||
| 934 | * |
||
| 935 | * @since 1.28 |
||
| 936 | * @return string |
||
| 937 | */ |
||
| 938 | public function getType() { |
||
| 953 | |||
| 954 | /** |
||
| 955 | * Compile a LESS file into CSS. |
||
| 956 | * |
||
| 957 | * Keeps track of all used files and adds them to localFileRefs. |
||
| 958 | * |
||
| 959 | * @since 1.22 |
||
| 960 | * @since 1.27 Added $context paramter. |
||
| 961 | * @throws Exception If less.php encounters a parse error |
||
| 962 | * @param string $fileName File path of LESS source |
||
| 963 | * @param ResourceLoaderContext $context Context in which to generate script |
||
| 964 | * @return string CSS source |
||
| 965 | */ |
||
| 966 | protected function compileLessFile( $fileName, ResourceLoaderContext $context ) { |
||
| 1005 | |||
| 1006 | /** |
||
| 1007 | * Takes named templates by the module and returns an array mapping. |
||
| 1008 | * @return array of templates mapping template alias to content |
||
| 1009 | * @throws MWException |
||
| 1010 | */ |
||
| 1011 | public function getTemplates() { |
||
| 1031 | |||
| 1032 | /** |
||
| 1033 | * Takes an input string and removes the UTF-8 BOM character if present |
||
| 1034 | * |
||
| 1035 | * We need to remove these after reading a file, because we concatenate our files and |
||
| 1036 | * the BOM character is not valid in the middle of a string. |
||
| 1037 | * We already assume UTF-8 everywhere, so this should be safe. |
||
| 1038 | * |
||
| 1039 | * @return string input minus the intial BOM char |
||
| 1040 | */ |
||
| 1041 | protected function stripBom( $input ) { |
||
| 1047 | } |
||
| 1048 |
It seems like the method you are trying to call exists only in some of the possible types.
Let’s take a look at an example:
Available Fixes
Add an additional type-check:
Only allow a single type to be passed if the variable comes from a parameter: