Complex classes like MWDebug often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MWDebug, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 33 | class MWDebug { |
||
| 34 | /** |
||
| 35 | * Log lines |
||
| 36 | * |
||
| 37 | * @var array $log |
||
| 38 | */ |
||
| 39 | protected static $log = []; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Debug messages from wfDebug(). |
||
| 43 | * |
||
| 44 | * @var array $debug |
||
| 45 | */ |
||
| 46 | protected static $debug = []; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * SQL statements of the database queries. |
||
| 50 | * |
||
| 51 | * @var array $query |
||
| 52 | */ |
||
| 53 | protected static $query = []; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * Is the debugger enabled? |
||
| 57 | * |
||
| 58 | * @var bool $enabled |
||
| 59 | */ |
||
| 60 | protected static $enabled = false; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * Array of functions that have already been warned, formatted |
||
| 64 | * function-caller to prevent a buttload of warnings |
||
| 65 | * |
||
| 66 | * @var array $deprecationWarnings |
||
| 67 | */ |
||
| 68 | protected static $deprecationWarnings = []; |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Enabled the debugger and load resource module. |
||
| 72 | * This is called by Setup.php when $wgDebugToolbar is true. |
||
| 73 | * |
||
| 74 | * @since 1.19 |
||
| 75 | */ |
||
| 76 | public static function init() { |
||
| 79 | |||
| 80 | /** |
||
| 81 | * Disable the debugger. |
||
| 82 | * |
||
| 83 | * @since 1.28 |
||
| 84 | */ |
||
| 85 | public static function deinit() { |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Add ResourceLoader modules to the OutputPage object if debugging is |
||
| 91 | * enabled. |
||
| 92 | * |
||
| 93 | * @since 1.19 |
||
| 94 | * @param OutputPage $out |
||
| 95 | */ |
||
| 96 | public static function addModules( OutputPage $out ) { |
||
| 101 | |||
| 102 | /** |
||
| 103 | * Adds a line to the log |
||
| 104 | * |
||
| 105 | * @since 1.19 |
||
| 106 | * @param mixed $str |
||
| 107 | */ |
||
| 108 | public static function log( $str ) { |
||
| 121 | |||
| 122 | /** |
||
| 123 | * Returns internal log array |
||
| 124 | * @since 1.19 |
||
| 125 | * @return array |
||
| 126 | */ |
||
| 127 | public static function getLog() { |
||
| 130 | |||
| 131 | /** |
||
| 132 | * Clears internal log array and deprecation tracking |
||
| 133 | * @since 1.19 |
||
| 134 | */ |
||
| 135 | public static function clearLog() { |
||
| 139 | |||
| 140 | /** |
||
| 141 | * Adds a warning entry to the log |
||
| 142 | * |
||
| 143 | * @since 1.19 |
||
| 144 | * @param string $msg |
||
| 145 | * @param int $callerOffset |
||
| 146 | * @param int $level A PHP error level. See sendMessage() |
||
| 147 | * @param string $log 'production' will always trigger a php error, 'auto' |
||
| 148 | * will trigger an error if $wgDevelopmentWarnings is true, and 'debug' |
||
| 149 | * will only write to the debug log(s). |
||
| 150 | * |
||
| 151 | * @return mixed |
||
| 152 | */ |
||
| 153 | public static function warning( $msg, $callerOffset = 1, $level = E_USER_NOTICE, $log = 'auto' ) { |
||
| 176 | |||
| 177 | /** |
||
| 178 | * Show a warning that $function is deprecated. |
||
| 179 | * This will send it to the following locations: |
||
| 180 | * - Debug toolbar, with one item per function and caller, if $wgDebugToolbar |
||
| 181 | * is set to true. |
||
| 182 | * - PHP's error log, with level E_USER_DEPRECATED, if $wgDevelopmentWarnings |
||
| 183 | * is set to true. |
||
| 184 | * - MediaWiki's debug log, if $wgDevelopmentWarnings is set to false. |
||
| 185 | * |
||
| 186 | * @since 1.19 |
||
| 187 | * @param string $function Function that is deprecated. |
||
| 188 | * @param string|bool $version Version in which the function was deprecated. |
||
| 189 | * @param string|bool $component Component to which the function belongs. |
||
| 190 | * If false, it is assumbed the function is in MediaWiki core. |
||
| 191 | * @param int $callerOffset How far up the callstack is the original |
||
| 192 | * caller. 2 = function that called the function that called |
||
| 193 | * MWDebug::deprecated() (Added in 1.20). |
||
| 194 | */ |
||
| 195 | public static function deprecated( $function, $version = false, |
||
| 260 | |||
| 261 | /** |
||
| 262 | * Get an array describing the calling function at a specified offset. |
||
| 263 | * |
||
| 264 | * @param int $callerOffset How far up the callstack is the original |
||
| 265 | * caller. 0 = function that called getCallerDescription() |
||
| 266 | * @return array Array with two keys: 'file' and 'func' |
||
| 267 | */ |
||
| 268 | private static function getCallerDescription( $callerOffset ) { |
||
| 297 | |||
| 298 | /** |
||
| 299 | * Send a message to the debug log and optionally also trigger a PHP |
||
| 300 | * error, depending on the $level argument. |
||
| 301 | * |
||
| 302 | * @param string $msg Message to send |
||
| 303 | * @param array $caller Caller description get from getCallerDescription() |
||
| 304 | * @param string $group Log group on which to send the message |
||
| 305 | * @param int|bool $level Error level to use; set to false to not trigger an error |
||
| 306 | */ |
||
| 307 | private static function sendMessage( $msg, $caller, $group, $level ) { |
||
| 316 | |||
| 317 | /** |
||
| 318 | * This is a method to pass messages from wfDebug to the pretty debugger. |
||
| 319 | * Do NOT use this method, use MWDebug::log or wfDebug() |
||
| 320 | * |
||
| 321 | * @since 1.19 |
||
| 322 | * @param string $str |
||
| 323 | * @param array $context |
||
| 324 | */ |
||
| 325 | public static function debugMsg( $str, $context = [] ) { |
||
| 326 | global $wgDebugComments, $wgShowDebug; |
||
| 327 | |||
| 328 | if ( self::$enabled || $wgDebugComments || $wgShowDebug ) { |
||
| 329 | if ( $context ) { |
||
| 330 | $prefix = ''; |
||
| 331 | if ( isset( $context['prefix'] ) ) { |
||
| 332 | $prefix = $context['prefix']; |
||
| 333 | } elseif ( isset( $context['channel'] ) && $context['channel'] !== 'wfDebug' ) { |
||
| 334 | $prefix = "[{$context['channel']}] "; |
||
| 335 | } |
||
| 336 | if ( isset( $context['seconds_elapsed'] ) && isset( $context['memory_used'] ) ) { |
||
| 337 | $prefix .= "{$context['seconds_elapsed']} {$context['memory_used']} "; |
||
| 338 | } |
||
| 339 | $str = LegacyLogger::interpolate( $str, $context ); |
||
| 340 | $str = $prefix . $str; |
||
| 341 | } |
||
| 342 | self::$debug[] = rtrim( UtfNormal\Validator::cleanUp( $str ) ); |
||
| 343 | } |
||
| 344 | } |
||
| 345 | |||
| 346 | /** |
||
| 347 | * Begins profiling on a database query |
||
| 348 | * |
||
| 349 | * @since 1.19 |
||
| 350 | * @param string $sql |
||
| 351 | * @param string $function |
||
| 352 | * @param bool $isMaster |
||
| 353 | * @param float $runTime Query run time |
||
| 354 | * @return int ID number of the query to pass to queryTime or -1 if the |
||
| 355 | * debugger is disabled |
||
| 356 | */ |
||
| 357 | public static function query( $sql, $function, $isMaster, $runTime ) { |
||
| 358 | if ( !self::$enabled ) { |
||
| 359 | return -1; |
||
| 360 | } |
||
| 361 | |||
| 362 | // Replace invalid UTF-8 chars with a square UTF-8 character |
||
| 363 | // This prevents json_encode from erroring out due to binary SQL data |
||
| 364 | $sql = preg_replace( |
||
| 365 | '/( |
||
| 366 | [\xC0-\xC1] # Invalid UTF-8 Bytes |
||
| 367 | | [\xF5-\xFF] # Invalid UTF-8 Bytes |
||
| 368 | | \xE0[\x80-\x9F] # Overlong encoding of prior code point |
||
| 369 | | \xF0[\x80-\x8F] # Overlong encoding of prior code point |
||
| 370 | | [\xC2-\xDF](?![\x80-\xBF]) # Invalid UTF-8 Sequence Start |
||
| 371 | | [\xE0-\xEF](?![\x80-\xBF]{2}) # Invalid UTF-8 Sequence Start |
||
| 372 | | [\xF0-\xF4](?![\x80-\xBF]{3}) # Invalid UTF-8 Sequence Start |
||
| 373 | | (?<=[\x0-\x7F\xF5-\xFF])[\x80-\xBF] # Invalid UTF-8 Sequence Middle |
||
| 374 | | (?<![\xC2-\xDF]|[\xE0-\xEF]|[\xE0-\xEF][\x80-\xBF]|[\xF0-\xF4] |
||
| 375 | |[\xF0-\xF4][\x80-\xBF]|[\xF0-\xF4][\x80-\xBF]{2})[\x80-\xBF] # Overlong Sequence |
||
| 376 | | (?<=[\xE0-\xEF])[\x80-\xBF](?![\x80-\xBF]) # Short 3 byte sequence |
||
| 377 | | (?<=[\xF0-\xF4])[\x80-\xBF](?![\x80-\xBF]{2}) # Short 4 byte sequence |
||
| 378 | | (?<=[\xF0-\xF4][\x80-\xBF])[\x80-\xBF](?![\x80-\xBF]) # Short 4 byte sequence (2) |
||
| 379 | )/x', |
||
| 380 | '■', |
||
| 381 | $sql |
||
| 382 | ); |
||
| 383 | |||
| 384 | // last check for invalid utf8 |
||
| 385 | $sql = UtfNormal\Validator::cleanUp( $sql ); |
||
| 386 | |||
| 387 | self::$query[] = [ |
||
| 388 | 'sql' => $sql, |
||
| 389 | 'function' => $function, |
||
| 390 | 'master' => (bool)$isMaster, |
||
| 391 | 'time' => $runTime, |
||
| 392 | ]; |
||
| 393 | |||
| 394 | return count( self::$query ) - 1; |
||
| 395 | } |
||
| 396 | |||
| 397 | /** |
||
| 398 | * Returns a list of files included, along with their size |
||
| 399 | * |
||
| 400 | * @param IContextSource $context |
||
| 401 | * @return array |
||
| 402 | */ |
||
| 403 | protected static function getFilesIncluded( IContextSource $context ) { |
||
| 404 | $files = get_included_files(); |
||
| 405 | $fileList = []; |
||
| 406 | foreach ( $files as $file ) { |
||
| 407 | $size = filesize( $file ); |
||
| 408 | $fileList[] = [ |
||
| 409 | 'name' => $file, |
||
| 410 | 'size' => $context->getLanguage()->formatSize( $size ), |
||
| 411 | ]; |
||
| 412 | } |
||
| 413 | |||
| 414 | return $fileList; |
||
| 415 | } |
||
| 416 | |||
| 417 | /** |
||
| 418 | * Returns the HTML to add to the page for the toolbar |
||
| 419 | * |
||
| 420 | * @since 1.19 |
||
| 421 | * @param IContextSource $context |
||
| 422 | * @return string |
||
| 423 | */ |
||
| 424 | public static function getDebugHTML( IContextSource $context ) { |
||
| 448 | |||
| 449 | /** |
||
| 450 | * Generate debug log in HTML for displaying at the bottom of the main |
||
| 451 | * content area. |
||
| 452 | * If $wgShowDebug is false, an empty string is always returned. |
||
| 453 | * |
||
| 454 | * @since 1.20 |
||
| 455 | * @return string HTML fragment |
||
| 456 | */ |
||
| 457 | public static function getHTMLDebugLog() { |
||
| 476 | |||
| 477 | /** |
||
| 478 | * Append the debug info to given ApiResult |
||
| 479 | * |
||
| 480 | * @param IContextSource $context |
||
| 481 | * @param ApiResult $result |
||
| 482 | */ |
||
| 483 | public static function appendDebugInfoToApiResult( IContextSource $context, ApiResult $result ) { |
||
| 510 | |||
| 511 | /** |
||
| 512 | * Returns the HTML to add to the page for the toolbar |
||
| 513 | * |
||
| 514 | * @param IContextSource $context |
||
| 515 | * @return array |
||
| 516 | */ |
||
| 517 | public static function getDebugInfo( IContextSource $context ) { |
||
| 560 | } |
||
| 561 |