Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 29 | View Code Duplication | class LanguageMl extends Language { |
|
|
|
|||
| 30 | /** |
||
| 31 | * Temporary hack for the issue described at |
||
| 32 | * http://permalink.gmane.org/gmane.science.linguistics.wikipedia.technical/46396 |
||
| 33 | * Convert Unicode 5.0 style Malayalam input to Unicode 5.1. Similar to |
||
| 34 | * bug 9413. Also fixes miscellaneous problems due to mishandling of ZWJ, |
||
| 35 | * e.g. bug 11162. |
||
| 36 | * |
||
| 37 | * @todo FIXME: This is language-specific for now only to avoid the negative |
||
| 38 | * performance impact of enabling it for all languages. |
||
| 39 | * |
||
| 40 | * @param string $s |
||
| 41 | * |
||
| 42 | * @return string |
||
| 43 | */ |
||
| 44 | function normalize( $s ) { |
||
| 52 | } |
||
| 53 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.