Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like FileRepo often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FileRepo, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 37 | class FileRepo { |
||
| 38 | const DELETE_SOURCE = 1; |
||
| 39 | const OVERWRITE = 2; |
||
| 40 | const OVERWRITE_SAME = 4; |
||
| 41 | const SKIP_LOCKING = 8; |
||
| 42 | |||
| 43 | const NAME_AND_TIME_ONLY = 1; |
||
| 44 | |||
| 45 | /** @var bool Whether to fetch commons image description pages and display |
||
| 46 | * them on the local wiki */ |
||
| 47 | public $fetchDescription; |
||
| 48 | |||
| 49 | /** @var int */ |
||
| 50 | public $descriptionCacheExpiry; |
||
| 51 | |||
| 52 | /** @var bool */ |
||
| 53 | protected $hasSha1Storage = false; |
||
| 54 | |||
| 55 | /** @var bool */ |
||
| 56 | protected $supportsSha1URLs = false; |
||
| 57 | |||
| 58 | /** @var FileBackend */ |
||
| 59 | protected $backend; |
||
| 60 | |||
| 61 | /** @var array Map of zones to config */ |
||
| 62 | protected $zones = []; |
||
| 63 | |||
| 64 | /** @var string URL of thumb.php */ |
||
| 65 | protected $thumbScriptUrl; |
||
| 66 | |||
| 67 | /** @var bool Whether to skip media file transformation on parse and rely |
||
| 68 | * on a 404 handler instead. */ |
||
| 69 | protected $transformVia404; |
||
| 70 | |||
| 71 | /** @var string URL of image description pages, e.g. |
||
| 72 | * https://en.wikipedia.org/wiki/File: |
||
| 73 | */ |
||
| 74 | protected $descBaseUrl; |
||
| 75 | |||
| 76 | /** @var string URL of the MediaWiki installation, equivalent to |
||
| 77 | * $wgScriptPath, e.g. https://en.wikipedia.org/w |
||
| 78 | */ |
||
| 79 | protected $scriptDirUrl; |
||
| 80 | |||
| 81 | /** @var string Script extension of the MediaWiki installation, equivalent |
||
| 82 | * to the old $wgScriptExtension, e.g. .php5 defaults to .php */ |
||
| 83 | protected $scriptExtension; |
||
| 84 | |||
| 85 | /** @var string Equivalent to $wgArticlePath, e.g. https://en.wikipedia.org/wiki/$1 */ |
||
| 86 | protected $articleUrl; |
||
| 87 | |||
| 88 | /** @var bool Equivalent to $wgCapitalLinks (or $wgCapitalLinkOverrides[NS_FILE], |
||
| 89 | * determines whether filenames implicitly start with a capital letter. |
||
| 90 | * The current implementation may give incorrect description page links |
||
| 91 | * when the local $wgCapitalLinks and initialCapital are mismatched. |
||
| 92 | */ |
||
| 93 | protected $initialCapital; |
||
| 94 | |||
| 95 | /** @var string May be 'paranoid' to remove all parameters from error |
||
| 96 | * messages, 'none' to leave the paths in unchanged, or 'simple' to |
||
| 97 | * replace paths with placeholders. Default for LocalRepo is |
||
| 98 | * 'simple'. |
||
| 99 | */ |
||
| 100 | protected $pathDisclosureProtection = 'simple'; |
||
| 101 | |||
| 102 | /** @var bool Public zone URL. */ |
||
| 103 | protected $url; |
||
| 104 | |||
| 105 | /** @var string The base thumbnail URL. Defaults to "<url>/thumb". */ |
||
| 106 | protected $thumbUrl; |
||
| 107 | |||
| 108 | /** @var int The number of directory levels for hash-based division of files */ |
||
| 109 | protected $hashLevels; |
||
| 110 | |||
| 111 | /** @var int The number of directory levels for hash-based division of deleted files */ |
||
| 112 | protected $deletedHashLevels; |
||
| 113 | |||
| 114 | /** @var int File names over this size will use the short form of thumbnail |
||
| 115 | * names. Short thumbnail names only have the width, parameters, and the |
||
| 116 | * extension. |
||
| 117 | */ |
||
| 118 | protected $abbrvThreshold; |
||
| 119 | |||
| 120 | /** @var string The URL of the repo's favicon, if any */ |
||
| 121 | protected $favicon; |
||
| 122 | |||
| 123 | /** @var bool Whether all zones should be private (e.g. private wiki repo) */ |
||
| 124 | protected $isPrivate; |
||
| 125 | |||
| 126 | /** @var array callable Override these in the base class */ |
||
| 127 | protected $fileFactory = [ 'UnregisteredLocalFile', 'newFromTitle' ]; |
||
| 128 | /** @var array callable|bool Override these in the base class */ |
||
| 129 | protected $oldFileFactory = false; |
||
| 130 | /** @var array callable|bool Override these in the base class */ |
||
| 131 | protected $fileFactoryKey = false; |
||
| 132 | /** @var array callable|bool Override these in the base class */ |
||
| 133 | protected $oldFileFactoryKey = false; |
||
| 134 | |||
| 135 | /** |
||
| 136 | * @param array|null $info |
||
| 137 | * @throws MWException |
||
| 138 | */ |
||
| 139 | public function __construct( array $info = null ) { |
||
| 209 | |||
| 210 | /** |
||
| 211 | * Get the file backend instance. Use this function wisely. |
||
| 212 | * |
||
| 213 | * @return FileBackend |
||
| 214 | */ |
||
| 215 | public function getBackend() { |
||
| 218 | |||
| 219 | /** |
||
| 220 | * Get an explanatory message if this repo is read-only. |
||
| 221 | * This checks if an administrator disabled writes to the backend. |
||
| 222 | * |
||
| 223 | * @return string|bool Returns false if the repo is not read-only |
||
| 224 | */ |
||
| 225 | public function getReadOnlyReason() { |
||
| 228 | |||
| 229 | /** |
||
| 230 | * Check if a single zone or list of zones is defined for usage |
||
| 231 | * |
||
| 232 | * @param array $doZones Only do a particular zones |
||
| 233 | * @throws MWException |
||
| 234 | * @return Status |
||
| 235 | */ |
||
| 236 | protected function initZones( $doZones = [] ) { |
||
| 247 | |||
| 248 | /** |
||
| 249 | * Determine if a string is an mwrepo:// URL |
||
| 250 | * |
||
| 251 | * @param string $url |
||
| 252 | * @return bool |
||
| 253 | */ |
||
| 254 | public static function isVirtualUrl( $url ) { |
||
| 257 | |||
| 258 | /** |
||
| 259 | * Get a URL referring to this repository, with the private mwrepo protocol. |
||
| 260 | * The suffix, if supplied, is considered to be unencoded, and will be |
||
| 261 | * URL-encoded before being returned. |
||
| 262 | * |
||
| 263 | * @param string|bool $suffix |
||
| 264 | * @return string |
||
| 265 | */ |
||
| 266 | public function getVirtualUrl( $suffix = false ) { |
||
| 274 | |||
| 275 | /** |
||
| 276 | * Get the URL corresponding to one of the four basic zones |
||
| 277 | * |
||
| 278 | * @param string $zone One of: public, deleted, temp, thumb |
||
| 279 | * @param string|null $ext Optional file extension |
||
| 280 | * @return string|bool |
||
| 281 | */ |
||
| 282 | public function getZoneUrl( $zone, $ext = null ) { |
||
| 307 | |||
| 308 | /** |
||
| 309 | * @return bool Whether non-ASCII path characters are allowed |
||
| 310 | */ |
||
| 311 | public function backendSupportsUnicodePaths() { |
||
| 314 | |||
| 315 | /** |
||
| 316 | * Get the backend storage path corresponding to a virtual URL. |
||
| 317 | * Use this function wisely. |
||
| 318 | * |
||
| 319 | * @param string $url |
||
| 320 | * @throws MWException |
||
| 321 | * @return string |
||
| 322 | */ |
||
| 323 | public function resolveVirtualUrl( $url ) { |
||
| 342 | |||
| 343 | /** |
||
| 344 | * The the storage container and base path of a zone |
||
| 345 | * |
||
| 346 | * @param string $zone |
||
| 347 | * @return array (container, base path) or (null, null) |
||
| 348 | */ |
||
| 349 | protected function getZoneLocation( $zone ) { |
||
| 356 | |||
| 357 | /** |
||
| 358 | * Get the storage path corresponding to one of the zones |
||
| 359 | * |
||
| 360 | * @param string $zone |
||
| 361 | * @return string|null Returns null if the zone is not defined |
||
| 362 | */ |
||
| 363 | public function getZonePath( $zone ) { |
||
| 375 | |||
| 376 | /** |
||
| 377 | * Create a new File object from the local repository |
||
| 378 | * |
||
| 379 | * @param Title|string $title Title object or string |
||
| 380 | * @param bool|string $time Time at which the image was uploaded. If this |
||
| 381 | * is specified, the returned object will be an instance of the |
||
| 382 | * repository's old file class instead of a current file. Repositories |
||
| 383 | * not supporting version control should return false if this parameter |
||
| 384 | * is set. |
||
| 385 | * @return File|null A File, or null if passed an invalid Title |
||
| 386 | */ |
||
| 387 | public function newFile( $title, $time = false ) { |
||
| 402 | |||
| 403 | /** |
||
| 404 | * Find an instance of the named file created at the specified time |
||
| 405 | * Returns false if the file does not exist. Repositories not supporting |
||
| 406 | * version control should return false if the time is specified. |
||
| 407 | * |
||
| 408 | * @param Title|string $title Title object or string |
||
| 409 | * @param array $options Associative array of options: |
||
| 410 | * time: requested time for a specific file version, or false for the |
||
| 411 | * current version. An image object will be returned which was |
||
| 412 | * created at the specified time (which may be archived or current). |
||
| 413 | * ignoreRedirect: If true, do not follow file redirects |
||
| 414 | * private: If true, return restricted (deleted) files if the current |
||
| 415 | * user is allowed to view them. Otherwise, such files will not |
||
| 416 | * be found. If a User object, use that user instead of the current. |
||
| 417 | * latest: If true, load from the latest available data into File objects |
||
| 418 | * @return File|bool False on failure |
||
| 419 | */ |
||
| 420 | public function findFile( $title, $options = [] ) { |
||
| 478 | |||
| 479 | /** |
||
| 480 | * Find many files at once. |
||
| 481 | * |
||
| 482 | * @param array $items An array of titles, or an array of findFile() options with |
||
| 483 | * the "title" option giving the title. Example: |
||
| 484 | * |
||
| 485 | * $findItem = [ 'title' => $title, 'private' => true ]; |
||
| 486 | * $findBatch = [ $findItem ]; |
||
| 487 | * $repo->findFiles( $findBatch ); |
||
| 488 | * |
||
| 489 | * No title should appear in $items twice, as the result use titles as keys |
||
| 490 | * @param int $flags Supports: |
||
| 491 | * - FileRepo::NAME_AND_TIME_ONLY : return a (search title => (title,timestamp)) map. |
||
| 492 | * The search title uses the input titles; the other is the final post-redirect title. |
||
| 493 | * All titles are returned as string DB keys and the inner array is associative. |
||
| 494 | * @return array Map of (file name => File objects) for matches |
||
| 495 | */ |
||
| 496 | public function findFiles( array $items, $flags = 0 ) { |
||
| 523 | |||
| 524 | /** |
||
| 525 | * Find an instance of the file with this key, created at the specified time |
||
| 526 | * Returns false if the file does not exist. Repositories not supporting |
||
| 527 | * version control should return false if the time is specified. |
||
| 528 | * |
||
| 529 | * @param string $sha1 Base 36 SHA-1 hash |
||
| 530 | * @param array $options Option array, same as findFile(). |
||
| 531 | * @return File|bool False on failure |
||
| 532 | */ |
||
| 533 | public function findFileFromKey( $sha1, $options = [] ) { |
||
| 534 | $time = isset( $options['time'] ) ? $options['time'] : false; |
||
| 535 | # First try to find a matching current version of a file... |
||
| 536 | if ( !$this->fileFactoryKey ) { |
||
| 537 | return false; // find-by-sha1 not supported |
||
| 538 | } |
||
| 539 | $img = call_user_func( $this->fileFactoryKey, $sha1, $this, $time ); |
||
| 540 | if ( $img && $img->exists() ) { |
||
| 541 | return $img; |
||
| 542 | } |
||
| 543 | # Now try to find a matching old version of a file... |
||
| 544 | if ( $time !== false && $this->oldFileFactoryKey ) { // find-by-sha1 supported? |
||
| 545 | $img = call_user_func( $this->oldFileFactoryKey, $sha1, $this, $time ); |
||
| 546 | View Code Duplication | if ( $img && $img->exists() ) { |
|
| 547 | if ( !$img->isDeleted( File::DELETED_FILE ) ) { |
||
| 548 | return $img; // always OK |
||
| 549 | } elseif ( !empty( $options['private'] ) && |
||
| 550 | $img->userCan( File::DELETED_FILE, |
||
| 551 | $options['private'] instanceof User ? $options['private'] : null |
||
| 552 | ) |
||
| 553 | ) { |
||
| 554 | return $img; |
||
| 555 | } |
||
| 556 | } |
||
| 557 | } |
||
| 558 | |||
| 559 | return false; |
||
| 560 | } |
||
| 561 | |||
| 562 | /** |
||
| 563 | * Get an array or iterator of file objects for files that have a given |
||
| 564 | * SHA-1 content hash. |
||
| 565 | * |
||
| 566 | * STUB |
||
| 567 | * @param string $hash SHA-1 hash |
||
| 568 | * @return File[] |
||
| 569 | */ |
||
| 570 | public function findBySha1( $hash ) { |
||
| 573 | |||
| 574 | /** |
||
| 575 | * Get an array of arrays or iterators of file objects for files that |
||
| 576 | * have the given SHA-1 content hashes. |
||
| 577 | * |
||
| 578 | * @param array $hashes An array of hashes |
||
| 579 | * @return array An Array of arrays or iterators of file objects and the hash as key |
||
| 580 | */ |
||
| 581 | public function findBySha1s( array $hashes ) { |
||
| 592 | |||
| 593 | /** |
||
| 594 | * Return an array of files where the name starts with $prefix. |
||
| 595 | * |
||
| 596 | * STUB |
||
| 597 | * @param string $prefix The prefix to search for |
||
| 598 | * @param int $limit The maximum amount of files to return |
||
| 599 | * @return array |
||
| 600 | */ |
||
| 601 | public function findFilesByPrefix( $prefix, $limit ) { |
||
| 604 | |||
| 605 | /** |
||
| 606 | * Get the URL of thumb.php |
||
| 607 | * |
||
| 608 | * @return string |
||
| 609 | */ |
||
| 610 | public function getThumbScriptUrl() { |
||
| 613 | |||
| 614 | /** |
||
| 615 | * Returns true if the repository can transform files via a 404 handler |
||
| 616 | * |
||
| 617 | * @return bool |
||
| 618 | */ |
||
| 619 | public function canTransformVia404() { |
||
| 622 | |||
| 623 | /** |
||
| 624 | * Get the name of a file from its title object |
||
| 625 | * |
||
| 626 | * @param Title $title |
||
| 627 | * @return string |
||
| 628 | */ |
||
| 629 | public function getNameFromTitle( Title $title ) { |
||
| 642 | |||
| 643 | /** |
||
| 644 | * Get the public zone root storage directory of the repository |
||
| 645 | * |
||
| 646 | * @return string |
||
| 647 | */ |
||
| 648 | public function getRootDirectory() { |
||
| 651 | |||
| 652 | /** |
||
| 653 | * Get a relative path including trailing slash, e.g. f/fa/ |
||
| 654 | * If the repo is not hashed, returns an empty string |
||
| 655 | * |
||
| 656 | * @param string $name Name of file |
||
| 657 | * @return string |
||
| 658 | */ |
||
| 659 | public function getHashPath( $name ) { |
||
| 662 | |||
| 663 | /** |
||
| 664 | * Get a relative path including trailing slash, e.g. f/fa/ |
||
| 665 | * If the repo is not hashed, returns an empty string |
||
| 666 | * |
||
| 667 | * @param string $suffix Basename of file from FileRepo::storeTemp() |
||
| 668 | * @return string |
||
| 669 | */ |
||
| 670 | public function getTempHashPath( $suffix ) { |
||
| 675 | |||
| 676 | /** |
||
| 677 | * @param string $name |
||
| 678 | * @param int $levels |
||
| 679 | * @return string |
||
| 680 | */ |
||
| 681 | View Code Duplication | protected static function getHashPathForLevel( $name, $levels ) { |
|
| 694 | |||
| 695 | /** |
||
| 696 | * Get the number of hash directory levels |
||
| 697 | * |
||
| 698 | * @return int |
||
| 699 | */ |
||
| 700 | public function getHashLevels() { |
||
| 703 | |||
| 704 | /** |
||
| 705 | * Get the name of this repository, as specified by $info['name]' to the constructor |
||
| 706 | * |
||
| 707 | * @return string |
||
| 708 | */ |
||
| 709 | public function getName() { |
||
| 712 | |||
| 713 | /** |
||
| 714 | * Make an url to this repo |
||
| 715 | * |
||
| 716 | * @param string $query Query string to append |
||
| 717 | * @param string $entry Entry point; defaults to index |
||
| 718 | * @return string|bool False on failure |
||
| 719 | */ |
||
| 720 | public function makeUrl( $query = '', $entry = 'index' ) { |
||
| 729 | |||
| 730 | /** |
||
| 731 | * Get the URL of an image description page. May return false if it is |
||
| 732 | * unknown or not applicable. In general this should only be called by the |
||
| 733 | * File class, since it may return invalid results for certain kinds of |
||
| 734 | * repositories. Use File::getDescriptionUrl() in user code. |
||
| 735 | * |
||
| 736 | * In particular, it uses the article paths as specified to the repository |
||
| 737 | * constructor, whereas local repositories use the local Title functions. |
||
| 738 | * |
||
| 739 | * @param string $name |
||
| 740 | * @return string |
||
| 741 | */ |
||
| 742 | public function getDescriptionUrl( $name ) { |
||
| 765 | |||
| 766 | /** |
||
| 767 | * Get the URL of the content-only fragment of the description page. For |
||
| 768 | * MediaWiki this means action=render. This should only be called by the |
||
| 769 | * repository's file class, since it may return invalid results. User code |
||
| 770 | * should use File::getDescriptionText(). |
||
| 771 | * |
||
| 772 | * @param string $name Name of image to fetch |
||
| 773 | * @param string $lang Language to fetch it in, if any. |
||
| 774 | * @return string |
||
| 775 | */ |
||
| 776 | public function getDescriptionRenderUrl( $name, $lang = null ) { |
||
| 795 | |||
| 796 | /** |
||
| 797 | * Get the URL of the stylesheet to apply to description pages |
||
| 798 | * |
||
| 799 | * @return string|bool False on failure |
||
| 800 | */ |
||
| 801 | public function getDescriptionStylesheetUrl() { |
||
| 809 | |||
| 810 | /** |
||
| 811 | * Store a file to a given destination. |
||
| 812 | * |
||
| 813 | * @param string $srcPath Source file system path, storage path, or virtual URL |
||
| 814 | * @param string $dstZone Destination zone |
||
| 815 | * @param string $dstRel Destination relative path |
||
| 816 | * @param int $flags Bitwise combination of the following flags: |
||
| 817 | * self::OVERWRITE Overwrite an existing destination file instead of failing |
||
| 818 | * self::OVERWRITE_SAME Overwrite the file if the destination exists and has the |
||
| 819 | * same contents as the source |
||
| 820 | * self::SKIP_LOCKING Skip any file locking when doing the store |
||
| 821 | * @return Status |
||
| 822 | */ |
||
| 823 | public function store( $srcPath, $dstZone, $dstRel, $flags = 0 ) { |
||
| 833 | |||
| 834 | /** |
||
| 835 | * Store a batch of files |
||
| 836 | * |
||
| 837 | * @param array $triplets (src, dest zone, dest rel) triplets as per store() |
||
| 838 | * @param int $flags Bitwise combination of the following flags: |
||
| 839 | * self::OVERWRITE Overwrite an existing destination file instead of failing |
||
| 840 | * self::OVERWRITE_SAME Overwrite the file if the destination exists and has the |
||
| 841 | * same contents as the source |
||
| 842 | * self::SKIP_LOCKING Skip any file locking when doing the store |
||
| 843 | * @throws MWException |
||
| 844 | * @return Status |
||
| 845 | */ |
||
| 846 | public function storeBatch( array $triplets, $flags = 0 ) { |
||
| 906 | |||
| 907 | /** |
||
| 908 | * Deletes a batch of files. |
||
| 909 | * Each file can be a (zone, rel) pair, virtual url, storage path. |
||
| 910 | * It will try to delete each file, but ignores any errors that may occur. |
||
| 911 | * |
||
| 912 | * @param array $files List of files to delete |
||
| 913 | * @param int $flags Bitwise combination of the following flags: |
||
| 914 | * self::SKIP_LOCKING Skip any file locking when doing the deletions |
||
| 915 | * @return Status |
||
| 916 | */ |
||
| 917 | public function cleanupBatch( array $files, $flags = 0 ) { |
||
| 943 | |||
| 944 | /** |
||
| 945 | * Import a file from the local file system into the repo. |
||
| 946 | * This does no locking nor journaling and overrides existing files. |
||
| 947 | * This function can be used to write to otherwise read-only foreign repos. |
||
| 948 | * This is intended for copying generated thumbnails into the repo. |
||
| 949 | * |
||
| 950 | * @param string|FSFile $src Source file system path, storage path, or virtual URL |
||
| 951 | * @param string $dst Virtual URL or storage path |
||
| 952 | * @param array|string|null $options An array consisting of a key named headers |
||
| 953 | * listing extra headers. If a string, taken as content-disposition header. |
||
| 954 | * (Support for array of options new in 1.23) |
||
| 955 | * @return Status |
||
| 956 | */ |
||
| 957 | final public function quickImport( $src, $dst, $options = null ) { |
||
| 960 | |||
| 961 | /** |
||
| 962 | * Purge a file from the repo. This does no locking nor journaling. |
||
| 963 | * This function can be used to write to otherwise read-only foreign repos. |
||
| 964 | * This is intended for purging thumbnails. |
||
| 965 | * |
||
| 966 | * @param string $path Virtual URL or storage path |
||
| 967 | * @return Status |
||
| 968 | */ |
||
| 969 | final public function quickPurge( $path ) { |
||
| 972 | |||
| 973 | /** |
||
| 974 | * Deletes a directory if empty. |
||
| 975 | * This function can be used to write to otherwise read-only foreign repos. |
||
| 976 | * |
||
| 977 | * @param string $dir Virtual URL (or storage path) of directory to clean |
||
| 978 | * @return Status |
||
| 979 | */ |
||
| 980 | View Code Duplication | public function quickCleanDir( $dir ) { |
|
| 987 | |||
| 988 | /** |
||
| 989 | * Import a batch of files from the local file system into the repo. |
||
| 990 | * This does no locking nor journaling and overrides existing files. |
||
| 991 | * This function can be used to write to otherwise read-only foreign repos. |
||
| 992 | * This is intended for copying generated thumbnails into the repo. |
||
| 993 | * |
||
| 994 | * All path parameters may be a file system path, storage path, or virtual URL. |
||
| 995 | * When "headers" are given they are used as HTTP headers if supported. |
||
| 996 | * |
||
| 997 | * @param array $triples List of (source path or FSFile, destination path, disposition) |
||
| 998 | * @return Status |
||
| 999 | */ |
||
| 1000 | public function quickImportBatch( array $triples ) { |
||
| 1036 | |||
| 1037 | /** |
||
| 1038 | * Purge a batch of files from the repo. |
||
| 1039 | * This function can be used to write to otherwise read-only foreign repos. |
||
| 1040 | * This does no locking nor journaling and is intended for purging thumbnails. |
||
| 1041 | * |
||
| 1042 | * @param array $paths List of virtual URLs or storage paths |
||
| 1043 | * @return Status |
||
| 1044 | */ |
||
| 1045 | View Code Duplication | public function quickPurgeBatch( array $paths ) { |
|
| 1046 | $status = $this->newGood(); |
||
| 1047 | $operations = []; |
||
| 1048 | foreach ( $paths as $path ) { |
||
| 1049 | $operations[] = [ |
||
| 1050 | 'op' => 'delete', |
||
| 1051 | 'src' => $this->resolveToStoragePath( $path ), |
||
| 1052 | 'ignoreMissingSource' => true |
||
| 1053 | ]; |
||
| 1054 | } |
||
| 1055 | $status->merge( $this->backend->doQuickOperations( $operations ) ); |
||
| 1056 | |||
| 1057 | return $status; |
||
| 1058 | } |
||
| 1059 | |||
| 1060 | /** |
||
| 1061 | * Pick a random name in the temp zone and store a file to it. |
||
| 1062 | * Returns a FileRepoStatus object with the file Virtual URL in the value, |
||
| 1063 | * file can later be disposed using FileRepo::freeTemp(). |
||
| 1064 | * |
||
| 1065 | * @param string $originalName The base name of the file as specified |
||
| 1066 | * by the user. The file extension will be maintained. |
||
| 1067 | * @param string $srcPath The current location of the file. |
||
| 1068 | * @return Status Object with the URL in the value. |
||
| 1069 | */ |
||
| 1070 | public function storeTemp( $originalName, $srcPath ) { |
||
| 1083 | |||
| 1084 | /** |
||
| 1085 | * Remove a temporary file or mark it for garbage collection |
||
| 1086 | * |
||
| 1087 | * @param string $virtualUrl The virtual URL returned by FileRepo::storeTemp() |
||
| 1088 | * @return bool True on success, false on failure |
||
| 1089 | */ |
||
| 1090 | public function freeTemp( $virtualUrl ) { |
||
| 1102 | |||
| 1103 | /** |
||
| 1104 | * Concatenate a list of temporary files into a target file location. |
||
| 1105 | * |
||
| 1106 | * @param array $srcPaths Ordered list of source virtual URLs/storage paths |
||
| 1107 | * @param string $dstPath Target file system path |
||
| 1108 | * @param int $flags Bitwise combination of the following flags: |
||
| 1109 | * self::DELETE_SOURCE Delete the source files on success |
||
| 1110 | * @return Status |
||
| 1111 | */ |
||
| 1112 | public function concatenate( array $srcPaths, $dstPath, $flags = 0 ) { |
||
| 1141 | |||
| 1142 | /** |
||
| 1143 | * Copy or move a file either from a storage path, virtual URL, |
||
| 1144 | * or file system path, into this repository at the specified destination location. |
||
| 1145 | * |
||
| 1146 | * Returns a FileRepoStatus object. On success, the value contains "new" or |
||
| 1147 | * "archived", to indicate whether the file was new with that name. |
||
| 1148 | * |
||
| 1149 | * Options to $options include: |
||
| 1150 | * - headers : name/value map of HTTP headers to use in response to GET/HEAD requests |
||
| 1151 | * |
||
| 1152 | * @param string|FSFile $src The source file system path, storage path, or URL |
||
| 1153 | * @param string $dstRel The destination relative path |
||
| 1154 | * @param string $archiveRel The relative path where the existing file is to |
||
| 1155 | * be archived, if there is one. Relative to the public zone root. |
||
| 1156 | * @param int $flags Bitfield, may be FileRepo::DELETE_SOURCE to indicate |
||
| 1157 | * that the source file should be deleted if possible |
||
| 1158 | * @param array $options Optional additional parameters |
||
| 1159 | * @return Status |
||
| 1160 | */ |
||
| 1161 | public function publish( |
||
| 1179 | |||
| 1180 | /** |
||
| 1181 | * Publish a batch of files |
||
| 1182 | * |
||
| 1183 | * @param array $ntuples (source, dest, archive) triplets or |
||
| 1184 | * (source, dest, archive, options) 4-tuples as per publish(). |
||
| 1185 | * @param int $flags Bitfield, may be FileRepo::DELETE_SOURCE to indicate |
||
| 1186 | * that the source files should be deleted if possible |
||
| 1187 | * @throws MWException |
||
| 1188 | * @return Status |
||
| 1189 | */ |
||
| 1190 | public function publishBatch( array $ntuples, $flags = 0 ) { |
||
| 1303 | |||
| 1304 | /** |
||
| 1305 | * Creates a directory with the appropriate zone permissions. |
||
| 1306 | * Callers are responsible for doing read-only and "writable repo" checks. |
||
| 1307 | * |
||
| 1308 | * @param string $dir Virtual URL (or storage path) of directory to clean |
||
| 1309 | * @return Status |
||
| 1310 | */ |
||
| 1311 | protected function initDirectory( $dir ) { |
||
| 1330 | |||
| 1331 | /** |
||
| 1332 | * Deletes a directory if empty. |
||
| 1333 | * |
||
| 1334 | * @param string $dir Virtual URL (or storage path) of directory to clean |
||
| 1335 | * @return Status |
||
| 1336 | */ |
||
| 1337 | View Code Duplication | public function cleanDir( $dir ) { |
|
| 1346 | |||
| 1347 | /** |
||
| 1348 | * Checks existence of a a file |
||
| 1349 | * |
||
| 1350 | * @param string $file Virtual URL (or storage path) of file to check |
||
| 1351 | * @return bool |
||
| 1352 | */ |
||
| 1353 | public function fileExists( $file ) { |
||
| 1358 | |||
| 1359 | /** |
||
| 1360 | * Checks existence of an array of files. |
||
| 1361 | * |
||
| 1362 | * @param array $files Virtual URLs (or storage paths) of files to check |
||
| 1363 | * @return array Map of files and existence flags, or false |
||
| 1364 | */ |
||
| 1365 | public function fileExistsBatch( array $files ) { |
||
| 1377 | |||
| 1378 | /** |
||
| 1379 | * Move a file to the deletion archive. |
||
| 1380 | * If no valid deletion archive exists, this may either delete the file |
||
| 1381 | * or throw an exception, depending on the preference of the repository |
||
| 1382 | * |
||
| 1383 | * @param mixed $srcRel Relative path for the file to be deleted |
||
| 1384 | * @param mixed $archiveRel Relative path for the archive location. |
||
| 1385 | * Relative to a private archive directory. |
||
| 1386 | * @return Status |
||
| 1387 | */ |
||
| 1388 | public function delete( $srcRel, $archiveRel ) { |
||
| 1393 | |||
| 1394 | /** |
||
| 1395 | * Move a group of files to the deletion archive. |
||
| 1396 | * |
||
| 1397 | * If no valid deletion archive is configured, this may either delete the |
||
| 1398 | * file or throw an exception, depending on the preference of the repository. |
||
| 1399 | * |
||
| 1400 | * The overwrite policy is determined by the repository -- currently LocalRepo |
||
| 1401 | * assumes a naming scheme in the deleted zone based on content hash, as |
||
| 1402 | * opposed to the public zone which is assumed to be unique. |
||
| 1403 | * |
||
| 1404 | * @param array $sourceDestPairs Array of source/destination pairs. Each element |
||
| 1405 | * is a two-element array containing the source file path relative to the |
||
| 1406 | * public root in the first element, and the archive file path relative |
||
| 1407 | * to the deleted zone root in the second element. |
||
| 1408 | * @throws MWException |
||
| 1409 | * @return Status |
||
| 1410 | */ |
||
| 1411 | public function deleteBatch( array $sourceDestPairs ) { |
||
| 1463 | |||
| 1464 | /** |
||
| 1465 | * Delete files in the deleted directory if they are not referenced in the filearchive table |
||
| 1466 | * |
||
| 1467 | * STUB |
||
| 1468 | * @param array $storageKeys |
||
| 1469 | */ |
||
| 1470 | public function cleanupDeletedBatch( array $storageKeys ) { |
||
| 1473 | |||
| 1474 | /** |
||
| 1475 | * Get a relative path for a deletion archive key, |
||
| 1476 | * e.g. s/z/a/ for sza251lrxrc1jad41h5mgilp8nysje52.jpg |
||
| 1477 | * |
||
| 1478 | * @param string $key |
||
| 1479 | * @throws MWException |
||
| 1480 | * @return string |
||
| 1481 | */ |
||
| 1482 | public function getDeletedHashPath( $key ) { |
||
| 1493 | |||
| 1494 | /** |
||
| 1495 | * If a path is a virtual URL, resolve it to a storage path. |
||
| 1496 | * Otherwise, just return the path as it is. |
||
| 1497 | * |
||
| 1498 | * @param string $path |
||
| 1499 | * @return string |
||
| 1500 | * @throws MWException |
||
| 1501 | */ |
||
| 1502 | protected function resolveToStoragePath( $path ) { |
||
| 1509 | |||
| 1510 | /** |
||
| 1511 | * Get a local FS copy of a file with a given virtual URL/storage path. |
||
| 1512 | * Temporary files may be purged when the file object falls out of scope. |
||
| 1513 | * |
||
| 1514 | * @param string $virtualUrl |
||
| 1515 | * @return TempFSFile|null Returns null on failure |
||
| 1516 | */ |
||
| 1517 | public function getLocalCopy( $virtualUrl ) { |
||
| 1522 | |||
| 1523 | /** |
||
| 1524 | * Get a local FS file with a given virtual URL/storage path. |
||
| 1525 | * The file is either an original or a copy. It should not be changed. |
||
| 1526 | * Temporary files may be purged when the file object falls out of scope. |
||
| 1527 | * |
||
| 1528 | * @param string $virtualUrl |
||
| 1529 | * @return FSFile|null Returns null on failure. |
||
| 1530 | */ |
||
| 1531 | public function getLocalReference( $virtualUrl ) { |
||
| 1536 | |||
| 1537 | /** |
||
| 1538 | * Get properties of a file with a given virtual URL/storage path. |
||
| 1539 | * Properties should ultimately be obtained via FSFile::getProps(). |
||
| 1540 | * |
||
| 1541 | * @param string $virtualUrl |
||
| 1542 | * @return array |
||
| 1543 | */ |
||
| 1544 | public function getFileProps( $virtualUrl ) { |
||
| 1555 | |||
| 1556 | /** |
||
| 1557 | * Get the timestamp of a file with a given virtual URL/storage path |
||
| 1558 | * |
||
| 1559 | * @param string $virtualUrl |
||
| 1560 | * @return string|bool False on failure |
||
| 1561 | */ |
||
| 1562 | public function getFileTimestamp( $virtualUrl ) { |
||
| 1567 | |||
| 1568 | /** |
||
| 1569 | * Get the size of a file with a given virtual URL/storage path |
||
| 1570 | * |
||
| 1571 | * @param string $virtualUrl |
||
| 1572 | * @return int|bool False on failure |
||
| 1573 | */ |
||
| 1574 | public function getFileSize( $virtualUrl ) { |
||
| 1579 | |||
| 1580 | /** |
||
| 1581 | * Get the sha1 (base 36) of a file with a given virtual URL/storage path |
||
| 1582 | * |
||
| 1583 | * @param string $virtualUrl |
||
| 1584 | * @return string|bool |
||
| 1585 | */ |
||
| 1586 | public function getFileSha1( $virtualUrl ) { |
||
| 1591 | |||
| 1592 | /** |
||
| 1593 | * Attempt to stream a file with the given virtual URL/storage path |
||
| 1594 | * |
||
| 1595 | * @param string $virtualUrl |
||
| 1596 | * @param array $headers Additional HTTP headers to send on success |
||
| 1597 | * @param array $optHeaders HTTP request headers (if-modified-since, range, ...) |
||
| 1598 | * @return Status |
||
| 1599 | * @since 1.27 |
||
| 1600 | */ |
||
| 1601 | View Code Duplication | public function streamFileWithStatus( $virtualUrl, $headers = [], $optHeaders = [] ) { |
|
| 1610 | |||
| 1611 | /** |
||
| 1612 | * Attempt to stream a file with the given virtual URL/storage path |
||
| 1613 | * |
||
| 1614 | * @deprecated since 1.26, use streamFileWithStatus |
||
| 1615 | * @param string $virtualUrl |
||
| 1616 | * @param array $headers Additional HTTP headers to send on success |
||
| 1617 | * @return bool Success |
||
| 1618 | */ |
||
| 1619 | public function streamFile( $virtualUrl, $headers = [] ) { |
||
| 1622 | |||
| 1623 | /** |
||
| 1624 | * Call a callback function for every public regular file in the repository. |
||
| 1625 | * This only acts on the current version of files, not any old versions. |
||
| 1626 | * May use either the database or the filesystem. |
||
| 1627 | * |
||
| 1628 | * @param callable $callback |
||
| 1629 | * @return void |
||
| 1630 | */ |
||
| 1631 | public function enumFiles( $callback ) { |
||
| 1634 | |||
| 1635 | /** |
||
| 1636 | * Call a callback function for every public file in the repository. |
||
| 1637 | * May use either the database or the filesystem. |
||
| 1638 | * |
||
| 1639 | * @param callable $callback |
||
| 1640 | * @return void |
||
| 1641 | */ |
||
| 1642 | protected function enumFilesInStorage( $callback ) { |
||
| 1660 | |||
| 1661 | /** |
||
| 1662 | * Determine if a relative path is valid, i.e. not blank or involving directory traveral |
||
| 1663 | * |
||
| 1664 | * @param string $filename |
||
| 1665 | * @return bool |
||
| 1666 | */ |
||
| 1667 | public function validateFilename( $filename ) { |
||
| 1674 | |||
| 1675 | /** |
||
| 1676 | * Get a callback function to use for cleaning error message parameters |
||
| 1677 | * |
||
| 1678 | * @return array |
||
| 1679 | */ |
||
| 1680 | function getErrorCleanupFunction() { |
||
| 1691 | |||
| 1692 | /** |
||
| 1693 | * Path disclosure protection function |
||
| 1694 | * |
||
| 1695 | * @param string $param |
||
| 1696 | * @return string |
||
| 1697 | */ |
||
| 1698 | function paranoidClean( $param ) { |
||
| 1701 | |||
| 1702 | /** |
||
| 1703 | * Path disclosure protection function |
||
| 1704 | * |
||
| 1705 | * @param string $param |
||
| 1706 | * @return string |
||
| 1707 | */ |
||
| 1708 | function passThrough( $param ) { |
||
| 1711 | |||
| 1712 | /** |
||
| 1713 | * Create a new fatal error |
||
| 1714 | * |
||
| 1715 | * @param string $message |
||
| 1716 | * @return Status |
||
| 1717 | */ |
||
| 1718 | public function newFatal( $message /*, parameters...*/ ) { |
||
| 1724 | |||
| 1725 | /** |
||
| 1726 | * Create a new good result |
||
| 1727 | * |
||
| 1728 | * @param null|string $value |
||
| 1729 | * @return Status |
||
| 1730 | */ |
||
| 1731 | public function newGood( $value = null ) { |
||
| 1737 | |||
| 1738 | /** |
||
| 1739 | * Checks if there is a redirect named as $title. If there is, return the |
||
| 1740 | * title object. If not, return false. |
||
| 1741 | * STUB |
||
| 1742 | * |
||
| 1743 | * @param Title $title Title of image |
||
| 1744 | * @return bool |
||
| 1745 | */ |
||
| 1746 | public function checkRedirect( Title $title ) { |
||
| 1749 | |||
| 1750 | /** |
||
| 1751 | * Invalidates image redirect cache related to that image |
||
| 1752 | * Doesn't do anything for repositories that don't support image redirects. |
||
| 1753 | * |
||
| 1754 | * STUB |
||
| 1755 | * @param Title $title Title of image |
||
| 1756 | */ |
||
| 1757 | public function invalidateImageRedirect( Title $title ) { |
||
| 1759 | |||
| 1760 | /** |
||
| 1761 | * Get the human-readable name of the repo |
||
| 1762 | * |
||
| 1763 | * @return string |
||
| 1764 | */ |
||
| 1765 | public function getDisplayName() { |
||
| 1775 | |||
| 1776 | /** |
||
| 1777 | * Get the portion of the file that contains the origin file name. |
||
| 1778 | * If that name is too long, then the name "thumbnail.<ext>" will be given. |
||
| 1779 | * |
||
| 1780 | * @param string $name |
||
| 1781 | * @return string |
||
| 1782 | */ |
||
| 1783 | public function nameForThumb( $name ) { |
||
| 1791 | |||
| 1792 | /** |
||
| 1793 | * Returns true if this the local file repository. |
||
| 1794 | * |
||
| 1795 | * @return bool |
||
| 1796 | */ |
||
| 1797 | public function isLocal() { |
||
| 1800 | |||
| 1801 | /** |
||
| 1802 | * Get a key on the primary cache for this repository. |
||
| 1803 | * Returns false if the repository's cache is not accessible at this site. |
||
| 1804 | * The parameters are the parts of the key, as for wfMemcKey(). |
||
| 1805 | * |
||
| 1806 | * STUB |
||
| 1807 | * @return bool |
||
| 1808 | */ |
||
| 1809 | public function getSharedCacheKey( /*...*/ ) { |
||
| 1812 | |||
| 1813 | /** |
||
| 1814 | * Get a key for this repo in the local cache domain. These cache keys are |
||
| 1815 | * not shared with remote instances of the repo. |
||
| 1816 | * The parameters are the parts of the key, as for wfMemcKey(). |
||
| 1817 | * |
||
| 1818 | * @return string |
||
| 1819 | */ |
||
| 1820 | public function getLocalCacheKey( /*...*/ ) { |
||
| 1826 | |||
| 1827 | /** |
||
| 1828 | * Get a temporary private FileRepo associated with this repo. |
||
| 1829 | * |
||
| 1830 | * Files will be created in the temp zone of this repo. |
||
| 1831 | * It will have the same backend as this repo. |
||
| 1832 | * |
||
| 1833 | * @return TempFileRepo |
||
| 1834 | */ |
||
| 1835 | public function getTempRepo() { |
||
| 1863 | |||
| 1864 | /** |
||
| 1865 | * Get an UploadStash associated with this repo. |
||
| 1866 | * |
||
| 1867 | * @param User $user |
||
| 1868 | * @return UploadStash |
||
| 1869 | */ |
||
| 1870 | public function getUploadStash( User $user = null ) { |
||
| 1873 | |||
| 1874 | /** |
||
| 1875 | * Throw an exception if this repo is read-only by design. |
||
| 1876 | * This does not and should not check getReadOnlyReason(). |
||
| 1877 | * |
||
| 1878 | * @return void |
||
| 1879 | * @throws MWException |
||
| 1880 | */ |
||
| 1881 | protected function assertWritableRepo() { |
||
| 1883 | |||
| 1884 | /** |
||
| 1885 | * Return information about the repository. |
||
| 1886 | * |
||
| 1887 | * @return array |
||
| 1888 | * @since 1.22 |
||
| 1889 | */ |
||
| 1890 | public function getInfo() { |
||
| 1910 | |||
| 1911 | /** |
||
| 1912 | * Returns whether or not storage is SHA-1 based |
||
| 1913 | * @return bool |
||
| 1914 | */ |
||
| 1915 | public function hasSha1Storage() { |
||
| 1918 | |||
| 1919 | /** |
||
| 1920 | * Returns whether or not repo supports having originals SHA-1s in the thumb URLs |
||
| 1921 | * @return bool |
||
| 1922 | */ |
||
| 1923 | public function supportsSha1URLs() { |
||
| 1926 | } |
||
| 1927 | |||
| 1936 |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: