ComposerVersionNormalizer - Code Metrics - wikimedia/mediawiki - Measure and Improve Code Quality continuously with Scrutinizer

ComposerVersionNormalizer A
last analyzed 2016-11-13 17:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	60
rs	10
c	0
b	0
f	0
wmc	6
lcom	0
cbo	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	normalizeSuffix()	0	7	2
A	normalizeLevelCount()	0	20	4

<?php

/**
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class ComposerVersionNormalizer {

	/**
	 * Ensures there is a dash in between the version and the stability suffix.
	 *
	 * Examples:
	 * - 1.23RC => 1.23-RC
	 * - 1.23alpha => 1.23-alpha
	 * - 1.23alpha3 => 1.23-alpha3
	 * - 1.23-beta => 1.23-beta
	 *
	 * @param string $version
	 *
	 * @return string
	 * @throws InvalidArgumentException
	 */
	public function normalizeSuffix( $version ) {
		if ( !is_string( $version ) ) {
			throw new InvalidArgumentException( '$version must be a string' );
		}

		return preg_replace( '/^(\d[\d\.]*)([a-zA-Z]+)(\d*)$/', '$1-$2$3', $version, 1 );
	}

	/**
	 * Ensures the version has four levels.
	 * Version suffixes are supported, as long as they start with a dash.
	 *
	 * Examples:
	 * - 1.19 => 1.19.0.0
	 * - 1.19.2.3 => 1.19.2.3
	 * - 1.19-alpha => 1.19.0.0-alpha
	 * - 1337 => 1337.0.0.0
	 *
	 * @param string $version
	 *
	 * @return string
	 * @throws InvalidArgumentException
	 */
	public function normalizeLevelCount( $version ) {
		if ( !is_string( $version ) ) {
			throw new InvalidArgumentException( '$version must be a string' );
		}

		$dashPosition = strpos( $version, '-' );

		if ( $dashPosition !== false ) {
			$suffix = substr( $version, $dashPosition );
			$version = substr( $version, 0, $dashPosition );
		}

		$version = implode( '.', array_pad( explode( '.', $version ), 4, '0' ) );

		if ( $dashPosition !== false ) {
			$version .= $suffix;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}

		return $version;
	}
}


1			<?php
2
3			/**
4			* @licence GNU GPL v2+
5			* @author Jeroen De Dauw < [email protected] >
6			*/
7			class ComposerVersionNormalizer {
8
9			/**
10			* Ensures there is a dash in between the version and the stability suffix.
11			*
12			* Examples:
13			* - 1.23RC => 1.23-RC
14			* - 1.23alpha => 1.23-alpha
15			* - 1.23alpha3 => 1.23-alpha3
16			* - 1.23-beta => 1.23-beta
17			*
18			* @param string $version
19			*
20			* @return string
21			* @throws InvalidArgumentException
22			*/
23			public function normalizeSuffix( $version ) {
24			if ( !is_string( $version ) ) {
25			throw new InvalidArgumentException( '$version must be a string' );
26			}
27
28			return preg_replace( '/^(\d[\d\.])([a-zA-Z]+)(\d)$/', '$1-$2$3', $version, 1 );
29			}
30
31			/**
32			* Ensures the version has four levels.
33			* Version suffixes are supported, as long as they start with a dash.
34			*
35			* Examples:
36			* - 1.19 => 1.19.0.0
37			* - 1.19.2.3 => 1.19.2.3
38			* - 1.19-alpha => 1.19.0.0-alpha
39			* - 1337 => 1337.0.0.0
40			*
41			* @param string $version
42			*
43			* @return string
44			* @throws InvalidArgumentException
45			*/
46			public function normalizeLevelCount( $version ) {
47			if ( !is_string( $version ) ) {
48			throw new InvalidArgumentException( '$version must be a string' );
49			}
50
51			$dashPosition = strpos( $version, '-' );
52
53			if ( $dashPosition !== false ) {
54			$suffix = substr( $version, $dashPosition );
55			$version = substr( $version, 0, $dashPosition );
56			}
57
58			$version = implode( '.', array_pad( explode( '.', $version ), 4, '0' ) );
59
60			if ( $dashPosition !== false ) {
61			$version .= $suffix;
			0 ignored issues – show Bug introduced 2016-01-16 18:00 UTC by Report Bug Copy Issue Report The variable `$suffix` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
62			}
63
64			return $version;
65			}
66			}
67

wikimedia / mediawiki

ComposerVersionNormalizer A last analyzed 2016-11-13 17:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

ComposerVersionNormalizer A
last analyzed 2016-11-13 17:42 UTC