wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/ExternalValidationServices.php

Spacing +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
 	 *
 	 * @fixme inject specific things needed here instead of the WikibaseRepo factory. (T112105)
 	 */
-	public function __construct( WikibaseRepo $wikibaseRepo ) {
+	public function __construct(WikibaseRepo $wikibaseRepo) {
 		$this->wikibaseRepo = $wikibaseRepo;
 	}
 
@@ -88,7 +88,7 @@ 
 		if ($instance === null) {
 			$wikibaseRepo = WikibaseRepo::getDefaultInstance();
 
-			$instance = new self( $wikibaseRepo );
+			$instance = new self($wikibaseRepo);
 		}
 
 		return $instance;

includes/Serializer/ComparisonResultSerializer.php

Spacing +10 added lines, -10 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param Serializer $dataValueSerializer
 	 */
-	public function __construct( Serializer $dataValueSerializer ) {
+	public function __construct(Serializer $dataValueSerializer) {
 		$this->dataValueSerializer = $dataValueSerializer;
 	}
 
@@ -33,7 +33,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof ComparisonResult;
 	}
 
@@ -45,29 +45,29 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'ComparisonResultSerializer can only serialize ComparisonResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( ComparisonResult $comparisonResult ) {
+	private function getSerialized(ComparisonResult $comparisonResult) {
 		$dataValueSerializer = $this->dataValueSerializer;
 		$externalValues = array_map(
-			function ( $dataValue ) use ( $dataValueSerializer ) {
-				return $dataValueSerializer->serialize( $dataValue );
+			function($dataValue) use ($dataValueSerializer) {
+				return $dataValueSerializer->serialize($dataValue);
 			},
 			$comparisonResult->getExternalValues()
 		);
-		$this->setIndexedTagName( $externalValues, 'dataValue' );
+		$this->setIndexedTagName($externalValues, 'dataValue');
 
 		return array(
-			'localValue' => $this->dataValueSerializer->serialize( $comparisonResult->getLocalValue() ),
+			'localValue' => $this->dataValueSerializer->serialize($comparisonResult->getLocalValue()),
 			'externalValues' => $externalValues,
 			'result' => $comparisonResult->getStatus()
 		);

includes/Serializer/CrossCheckResultListSerializer.php

Spacing +11 added lines, -11 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param Serializer $crossCheckResultSerializer
 	 */
-	public function __construct( Serializer $crossCheckResultSerializer ) {
+	public function __construct(Serializer $crossCheckResultSerializer) {
 		$this->crossCheckResultSerializer = $crossCheckResultSerializer;
 	}
 
@@ -33,7 +33,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof CrossCheckResultList;
 	}
 
@@ -45,29 +45,29 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( CrossCheckResultList $resultList ) {
+	private function getSerialized(CrossCheckResultList $resultList) {
 		$serialization = array();
-		$this->setKeyAttributeName( $serialization, 'property', 'id' );
+		$this->setKeyAttributeName($serialization, 'property', 'id');
 
-		foreach ( $resultList->getPropertyIds() as $propertyId ) {
+		foreach ($resultList->getPropertyIds() as $propertyId) {
 			$id = $propertyId->getSerialization();
 			$resultSerialization = array();
 
-			$this->setIndexedTagName( $resultSerialization, 'result' );
+			$this->setIndexedTagName($resultSerialization, 'result');
 
-			foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) {
-				$resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result );
+			foreach ($resultList->getByPropertyId($propertyId) as $result) {
+				$resultSerialization[] = $this->crossCheckResultSerializer->serialize($result);
 			}
 
 			$serialization[$id] = $resultSerialization;

includes/Serializer/CrossCheckResultSerializer.php

Spacing +9 added lines, -9 removed lines

@@ -34,7 +34,7 @@ 
 	 * @param Serializer $comparisonResultSerializer
 	 * @param Serializer $referenceResultSerializer
 	 */
-	public function __construct( Serializer $dumpMetaInformationSerializer, Serializer $comparisonResultSerializer, Serializer $referenceResultSerializer ) {
+	public function __construct(Serializer $dumpMetaInformationSerializer, Serializer $comparisonResultSerializer, Serializer $referenceResultSerializer) {
 		$this->dumpMetaInformationSerializer = $dumpMetaInformationSerializer;
 		$this->comparisonResultSerializer = $comparisonResultSerializer;
 		$this->referenceResultSerializer = $referenceResultSerializer;
@@ -47,7 +47,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof CrossCheckResult;
 	}
 
@@ -59,25 +59,25 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'CrossCheckResultSerializer can only serialize CrossCheckResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( CrossCheckResult $crossCheckResult ) {
+	private function getSerialized(CrossCheckResult $crossCheckResult) {
 		return array(
 			'propertyId' => $crossCheckResult->getPropertyId()->getSerialization(),
 			'claimGuid' => $crossCheckResult->getClaimGuid(),
 			'externalId' => $crossCheckResult->getExternalId(),
-			'dataSource' => $this->dumpMetaInformationSerializer->serialize( $crossCheckResult->getDumpMetaInformation() ),
-			'comparisonResult' => $this->comparisonResultSerializer->serialize( $crossCheckResult->getComparisonResult() ),
-			'referenceResult' => $this->referenceResultSerializer->serialize( $crossCheckResult->getReferenceResult() )
+			'dataSource' => $this->dumpMetaInformationSerializer->serialize($crossCheckResult->getDumpMetaInformation()),
+			'comparisonResult' => $this->comparisonResultSerializer->serialize($crossCheckResult->getComparisonResult()),
+			'referenceResult' => $this->referenceResultSerializer->serialize($crossCheckResult->getReferenceResult())
 		);
 	}
 

includes/Serializer/IndexedTagsSerializer.php

Spacing +5 added lines, -5 removed lines

@@ -20,8 +20,8 @@ 
 	 * @param array &$arr
 	 * @param string $tag
 	 */
-	protected function setIndexedTagName( array &$arr, $tag ) {
-		ApiResult::setIndexedTagName( $arr, $tag );
+	protected function setIndexedTagName(array &$arr, $tag) {
+		ApiResult::setIndexedTagName($arr, $tag);
 	}
 
 	/**
@@ -33,9 +33,9 @@ 
 	 * @param string $tagName
 	 * @param string $idAttribute
 	 */
-	protected function setKeyAttributeName( array &$arr, $tagName, $idAttribute ) {
-		ApiResult::setArrayType( $arr, 'kvp', $idAttribute );
-		ApiResult::setIndexedTagName( $arr, $tagName );
+	protected function setKeyAttributeName(array &$arr, $tagName, $idAttribute) {
+		ApiResult::setArrayType($arr, 'kvp', $idAttribute);
+		ApiResult::setIndexedTagName($arr, $tagName);
 	}
 
 }

includes/Serializer/ReferenceResultSerializer.php

Spacing +7 added lines, -7 removed lines

@@ -22,7 +22,7 @@ 
 	/**
 	 * @param Serializer $referenceSerializer
 	 */
-	public function __construct( Serializer $referenceSerializer ) {
+	public function __construct(Serializer $referenceSerializer) {
 		$this->referenceSerializer = $referenceSerializer;
 	}
 
@@ -33,7 +33,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof ReferenceResult;
 	}
 
@@ -45,20 +45,20 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'ReferenceResultSerializer can only serialize ReferenceResult objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( ReferenceResult $referenceResult ) {
+	private function getSerialized(ReferenceResult $referenceResult) {
 		return array(
-			'reference' => $this->referenceSerializer->serialize( $referenceResult->getReference() ),
+			'reference' => $this->referenceSerializer->serialize($referenceResult->getReference()),
 			'status' => $referenceResult->getStatus()
 		);
 	}

includes/Serializer/SerializerFactory.php

Spacing +3 added lines, -3 removed lines

@@ -25,7 +25,7 @@ 
 	 * @param Serializer $dataValueSerializer
 	 * @param Serializer $referenceSerializer
 	 */
-	public function __construct( Serializer $dataValueSerializer, Serializer $referenceSerializer ) {
+	public function __construct(Serializer $dataValueSerializer, Serializer $referenceSerializer) {
 		$this->dataValueSerializer = $dataValueSerializer;
 		$this->referenceSerializer = $referenceSerializer;
 	}
@@ -47,7 +47,7 @@ 
 	 * @return Serializer
 	 */
 	public function newComparisonResultSerializer() {
-		return new ComparisonResultSerializer( $this->dataValueSerializer );
+		return new ComparisonResultSerializer($this->dataValueSerializer);
 	}
 
 	/**
@@ -78,7 +78,7 @@ 
 	 * @return Serializer
 	 */
 	public function newReferenceResultSerializer() {
-		return new ReferenceResultSerializer( $this->referenceSerializer );
+		return new ReferenceResultSerializer($this->referenceSerializer);
 	}
 
 }

includes/UpdateExternalData/CsvImportSettings.php

Spacing +5 added lines, -5 removed lines

@@ -43,11 +43,11 @@
 	 * @param int $batchSize
 	 * @param bool $quiet
 	 */
-	public function __construct( $externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false ) {
-		Assert::parameterType( 'string', $externalValuesFilePath, '$externalValuesFilePath' );
-		Assert::parameterType( 'string', $dumpInformationFilePath, '$dumpInformationFilePath' );
-		Assert::parameterType( 'integer', $batchSize, '$batchSize' );
-		Assert::parameterType( 'boolean', $quiet, '$quiet' );
+	public function __construct($externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false) {
+		Assert::parameterType('string', $externalValuesFilePath, '$externalValuesFilePath');
+		Assert::parameterType('string', $dumpInformationFilePath, '$dumpInformationFilePath');
+		Assert::parameterType('integer', $batchSize, '$batchSize');
+		Assert::parameterType('boolean', $quiet, '$quiet');
 
 		$this->externalValuesFilePath = $externalValuesFilePath;
 		$this->dumpInformationFilePath = $dumpInformationFilePath;

includes/Serializer/DumpMetaInformationSerializer.php

Spacing +8 added lines, -8 removed lines

@@ -21,7 +21,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isSerializerFor( $object ) {
+	public function isSerializerFor($object) {
 		return $object instanceof DumpMetaInformation;
 	}
 
@@ -33,32 +33,32 @@ 
 	 * @return array
 	 * @throws UnsupportedObjectException
 	 */
-	public function serialize( $object ) {
-		if ( !$this->isSerializerFor( $object ) ) {
+	public function serialize($object) {
+		if (!$this->isSerializerFor($object)) {
 			throw new UnsupportedObjectException(
 				$object,
 				'DumpMetaInformationSerializer can only serialize DumpMetaInformation objects.'
 			);
 		}
 
-		return $this->getSerialized( $object );
+		return $this->getSerialized($object);
 	}
 
-	private function getSerialized( DumpMetaInformation $dumpMetaInformation ) {
+	private function getSerialized(DumpMetaInformation $dumpMetaInformation) {
 		$identifierPropertyIds = array_map(
-			function( PropertyId $id ) {
+			function(PropertyId $id) {
 				return $id->getSerialization();
 			},
 			$dumpMetaInformation->getIdentifierPropertyIds()
 		);
 
-		$this->setIndexedTagName( $identifierPropertyIds, 'propertyId' );
+		$this->setIndexedTagName($identifierPropertyIds, 'propertyId');
 
 		return array(
 			'dumpId' => $dumpMetaInformation->getDumpId(),
 			'sourceItemId' => $dumpMetaInformation->getSourceItemId()->getSerialization(),
 			'identifierPropertyIds' => $identifierPropertyIds,
-			'importDate' => wfTimestamp( TS_ISO_8601, $dumpMetaInformation->getImportDate() ),
+			'importDate' => wfTimestamp(TS_ISO_8601, $dumpMetaInformation->getImportDate()),
 			'language' => $dumpMetaInformation->getLanguageCode(),
 			'sourceUrl' => $dumpMetaInformation->getSourceUrl(),
 			'size' => $dumpMetaInformation->getSize(),