Completed
Push — master ( a187dc...dcf65c )
by
unknown
24:50
created
includes/CrossCheck/ValueParser/ComparativeValueParserFactory.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	) {
44 44
 		$dataTypeIds = $dataTypeDefinitions->getTypeIds();
45 45
 
46
-		if ( !in_array( 'monolingualtext', $dataTypeIds ) ) {
46
+		if (!in_array('monolingualtext', $dataTypeIds)) {
47 47
 			throw new InvalidArgumentException(
48 48
 				'monolingualtext must be defined in the DataTypeDefinitions.'
49 49
 			);
@@ -58,21 +58,21 @@  discard block
 block discarded – undo
58 58
 	 *
59 59
 	 * @return MultilingualTextValueParser
60 60
 	 */
61
-	public function newMultilingualTextValueParser( ParserOptions $options = null ) {
61
+	public function newMultilingualTextValueParser(ParserOptions $options = null) {
62 62
 		$options = $options ?: new ParserOptions();
63 63
 		$monolingualTextValueParser = $this->getValueParserFactory()->newParser(
64 64
 			'monolingualtext',
65 65
 			$options
66 66
 		);
67 67
 
68
-		return new MultilingualTextValueParser( $monolingualTextValueParser );
68
+		return new MultilingualTextValueParser($monolingualTextValueParser);
69 69
 	}
70 70
 
71 71
 	/**
72 72
 	 * @return StringValueParser
73 73
 	 */
74 74
 	public function newStringValueParser() {
75
-		return new StringValueParser( $this->stringNormalizer );
75
+		return new StringValueParser($this->stringNormalizer);
76 76
 	}
77 77
 
78 78
 	/**
@@ -80,8 +80,8 @@  discard block
 block discarded – undo
80 80
 	 *
81 81
 	 * @return ComparativeValueParser
82 82
 	 */
83
-	public function newComparativeValueParser( $languageCode ) {
84
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
83
+	public function newComparativeValueParser($languageCode) {
84
+		Assert::parameterType('string', $languageCode, '$languageCode');
85 85
 
86 86
 		return new ComparativeValueParser(
87 87
 			$this->getValueParserFactory(),
@@ -100,14 +100,14 @@  discard block
 block discarded – undo
100 100
 	 * @return ValueParserFactory
101 101
 	 */
102 102
 	private function getValueParserFactory() {
103
-		if ( $this->valueParserFactory === null ) {
103
+		if ($this->valueParserFactory === null) {
104 104
 			$callbacks = $this->dataTypeDefinitions->getParserFactoryCallbacks();
105 105
 
106
-			$callbacks['string'] = [ $this, 'newStringValueParser' ];
107
-			$callbacks['multilingualtext'] = [ $this, 'newMultilingualTextValueParser' ];
106
+			$callbacks['string'] = [$this, 'newStringValueParser'];
107
+			$callbacks['multilingualtext'] = [$this, 'newMultilingualTextValueParser'];
108 108
 			$callbacks['wikibase-entityid'] = $callbacks['monolingualtext'];
109 109
 
110
-			$this->valueParserFactory = new ValueParserFactory( $callbacks );
110
+			$this->valueParserFactory = new ValueParserFactory($callbacks);
111 111
 		}
112 112
 
113 113
 		return $this->valueParserFactory;
Please login to merge, or discard this patch.
includes/CrossCheck/Result/ComparisonResult.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -45,12 +45,12 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @throws InvalidArgumentException
47 47
 	 */
48
-	public function __construct( DataValue $localValue, array $externalValues, $status ) {
49
-		Assert::parameterElementType( DataValue::class, $externalValues, '$externalValues' );
48
+	public function __construct(DataValue $localValue, array $externalValues, $status) {
49
+		Assert::parameterElementType(DataValue::class, $externalValues, '$externalValues');
50 50
 
51 51
 		$this->localValue = $localValue;
52 52
 		$this->externalValues = $externalValues;
53
-		$this->setStatus( $status );
53
+		$this->setStatus($status);
54 54
 	}
55 55
 
56 56
 	/**
@@ -79,14 +79,14 @@  discard block
 block discarded – undo
79 79
 	 *
80 80
 	 * @throws InvalidArgumentException
81 81
 	 */
82
-	private function setStatus( $status ) {
83
-		Assert::parameterType( 'string', $status, '$status' );
84
-		if ( !in_array(
82
+	private function setStatus($status) {
83
+		Assert::parameterType('string', $status, '$status');
84
+		if (!in_array(
85 85
 			$status,
86
-			[ self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH ]
86
+			[self::STATUS_MATCH, self::STATUS_PARTIAL_MATCH, self::STATUS_MISMATCH]
87 87
 		)
88 88
 		) {
89
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
89
+			throw new InvalidArgumentException('$status must be one of the status constants.');
90 90
 		}
91 91
 
92 92
 		$this->status = $status;
Please login to merge, or discard this patch.
includes/CrossCheck/Result/ReferenceResult.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -36,10 +36,10 @@  discard block
 block discarded – undo
36 36
 	 *
37 37
 	 * @throws InvalidArgumentException
38 38
 	 */
39
-	public function __construct( $status, Reference $reference ) {
39
+	public function __construct($status, Reference $reference) {
40 40
 
41 41
 		$this->reference = $reference;
42
-		$this->setStatus( $status );
42
+		$this->setStatus($status);
43 43
 	}
44 44
 
45 45
 	/**
@@ -61,14 +61,14 @@  discard block
 block discarded – undo
61 61
 	 *
62 62
 	 * @throws InvalidArgumentException
63 63
 	 */
64
-	private function setStatus( $status ) {
65
-		Assert::parameterType( 'string', $status, '$status' );
66
-		if ( !in_array(
64
+	private function setStatus($status) {
65
+		Assert::parameterType('string', $status, '$status');
66
+		if (!in_array(
67 67
 			$status,
68
-			[ self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED ]
68
+			[self::STATUS_REFERENCES_MISSING, self::STATUS_REFERENCES_STATED]
69 69
 		)
70 70
 		) {
71
-			throw new InvalidArgumentException( '$status must be one of the status constants.' );
71
+			throw new InvalidArgumentException('$status must be one of the status constants.');
72 72
 		}
73 73
 
74 74
 		$this->status = $status;
Please login to merge, or discard this patch.
includes/CrossCheck/Result/CrossCheckResultList.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
26 26
 	 *
27 27
 	 * @throws InvalidArgumentException
28 28
 	 */
29
-	public function __construct( array $results = [] ) {
30
-		Assert::parameterElementType( CrossCheckResult::class, $results, '$results' );
29
+	public function __construct(array $results = []) {
30
+		Assert::parameterElementType(CrossCheckResult::class, $results, '$results');
31 31
 
32 32
 		$this->results = $results;
33 33
 	}
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 	 *
38 38
 	 * @param CrossCheckResult $result
39 39
 	 */
40
-	public function add( CrossCheckResult $result ) {
40
+	public function add(CrossCheckResult $result) {
41 41
 		$this->results[] = $result;
42 42
 	}
43 43
 
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
 	 *
47 47
 	 * @param self $resultList
48 48
 	 */
49
-	public function merge( self $resultList ) {
50
-		$this->results = array_merge( $this->results, $resultList->results );
49
+	public function merge(self $resultList) {
50
+		$this->results = array_merge($this->results, $resultList->results);
51 51
 	}
52 52
 
53 53
 	/**
@@ -58,9 +58,9 @@  discard block
 block discarded – undo
58 58
 	public function getPropertyIds() {
59 59
 		$propertyIds = [];
60 60
 
61
-		foreach ( $this->results as $result ) {
61
+		foreach ($this->results as $result) {
62 62
 			$propertyId = $result->getPropertyId();
63
-			if ( !in_array( $propertyId, $propertyIds ) ) {
63
+			if (!in_array($propertyId, $propertyIds)) {
64 64
 				$propertyIds[] = $propertyId;
65 65
 			}
66 66
 		}
@@ -75,16 +75,16 @@  discard block
 block discarded – undo
75 75
 	 *
76 76
 	 * @return self
77 77
 	 */
78
-	public function getByPropertyId( PropertyId $propertyId ) {
78
+	public function getByPropertyId(PropertyId $propertyId) {
79 79
 		$results = [];
80 80
 
81
-		foreach ( $this->results as $result ) {
82
-			if ( $result->getPropertyId()->equals( $propertyId ) ) {
81
+		foreach ($this->results as $result) {
82
+			if ($result->getPropertyId()->equals($propertyId)) {
83 83
 				$results[] = $result;
84 84
 			}
85 85
 		}
86 86
 
87
-		return new self( $results );
87
+		return new self($results);
88 88
 	}
89 89
 
90 90
 	/**
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 	 * @codeCoverageIgnore
104 104
 	 */
105 105
 	public function getIterator() {
106
-		return new ArrayIterator( $this->results );
106
+		return new ArrayIterator($this->results);
107 107
 	}
108 108
 
109 109
 	/**
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	 * @return int
113 113
 	 */
114 114
 	public function count() {
115
-		return count( $this->results );
115
+		return count($this->results);
116 116
 	}
117 117
 
118 118
 }
Please login to merge, or discard this patch.
includes/CrossCheck/Comparer/DispatchingDataValueComparer.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -20,8 +20,8 @@  discard block
 block discarded – undo
20 20
 	/**
21 21
 	 * @param DataValueComparer[] $dataValueComparers
22 22
 	 */
23
-	public function __construct( array $dataValueComparers = [] ) {
24
-		$this->assertAreDataValueComparer( $dataValueComparers );
23
+	public function __construct(array $dataValueComparers = []) {
24
+		$this->assertAreDataValueComparer($dataValueComparers);
25 25
 		$this->dataValueComparers = $dataValueComparers;
26 26
 	}
27 27
 
@@ -30,9 +30,9 @@  discard block
 block discarded – undo
30 30
 	 *
31 31
 	 * @throws InvalidArgumentException
32 32
 	 */
33
-	protected function assertAreDataValueComparer( array $dataValueComparers ) {
34
-		foreach ( $dataValueComparers as $dataValueComparer ) {
35
-			if ( !is_object( $dataValueComparer ) || !( $dataValueComparer instanceof DataValueComparer ) ) {
33
+	protected function assertAreDataValueComparer(array $dataValueComparers) {
34
+		foreach ($dataValueComparers as $dataValueComparer) {
35
+			if (!is_object($dataValueComparer) || !($dataValueComparer instanceof DataValueComparer)) {
36 36
 				throw new InvalidArgumentException(
37 37
 					'All $dataValueComparers need to implement the DataValueComparer interface'
38 38
 				);
@@ -48,9 +48,9 @@  discard block
 block discarded – undo
48 48
 	 *
49 49
 	 * @return bool
50 50
 	 */
51
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
52
-		foreach ( $this->dataValueComparers as $dataValueComparer ) {
53
-			if ( $dataValueComparer->canCompare( $value, $comparativeValue ) ) {
51
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
52
+		foreach ($this->dataValueComparers as $dataValueComparer) {
53
+			if ($dataValueComparer->canCompare($value, $comparativeValue)) {
54 54
 				return true;
55 55
 			}
56 56
 		}
@@ -67,10 +67,10 @@  discard block
 block discarded – undo
67 67
 	 * @throws InvalidArgumentException
68 68
 	 * @return string One of the ComparisonResult::STATUS_... constants.
69 69
 	 */
70
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
71
-		foreach ( $this->dataValueComparers as $dataValueComparer ) {
72
-			if ( $dataValueComparer->canCompare( $value, $comparativeValue ) ) {
73
-				return $dataValueComparer->compare( $value, $comparativeValue );
70
+	public function compare(DataValue $value, DataValue $comparativeValue) {
71
+		foreach ($this->dataValueComparers as $dataValueComparer) {
72
+			if ($dataValueComparer->canCompare($value, $comparativeValue)) {
73
+				return $dataValueComparer->compare($value, $comparativeValue);
74 74
 			}
75 75
 		}
76 76
 
Please login to merge, or discard this patch.
includes/CrossCheck/Comparer/StringComparer.php 1 patch
Spacing   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 	/**
27 27
 	 * @param StringNormalizer $stringNormalizer
28 28
 	 */
29
-	public function __construct( StringNormalizer $stringNormalizer ) {
29
+	public function __construct(StringNormalizer $stringNormalizer) {
30 30
 		$this->stringNormalizer = $stringNormalizer;
31 31
 	}
32 32
 
@@ -37,16 +37,16 @@  discard block
 block discarded – undo
37 37
 	 * @param string $comparativeValue
38 38
 	 * @return string
39 39
 	 */
40
-	public function compare( $value, $comparativeValue ) {
41
-		Assert::parameterType( 'string', $value, '$value' );
42
-		Assert::parameterType( 'string', $comparativeValue, '$comparativeValue' );
40
+	public function compare($value, $comparativeValue) {
41
+		Assert::parameterType('string', $value, '$value');
42
+		Assert::parameterType('string', $comparativeValue, '$comparativeValue');
43 43
 
44
-		$value = $this->cleanDataString( $value );
45
-		$comparativeValue = $this->cleanDataString( $comparativeValue );
44
+		$value = $this->cleanDataString($value);
45
+		$comparativeValue = $this->cleanDataString($comparativeValue);
46 46
 
47
-		if ( $value === $comparativeValue ) {
47
+		if ($value === $comparativeValue) {
48 48
 			return ComparisonResult::STATUS_MATCH;
49
-		} elseif ( $this->checkSimilarity( $value, $comparativeValue ) ) {
49
+		} elseif ($this->checkSimilarity($value, $comparativeValue)) {
50 50
 			return ComparisonResult::STATUS_PARTIAL_MATCH;
51 51
 		} else {
52 52
 			return ComparisonResult::STATUS_MISMATCH;
@@ -60,19 +60,19 @@  discard block
 block discarded – undo
60 60
 	 * @param array $comparativeValues
61 61
 	 * @return string
62 62
 	 */
63
-	public function compareWithArray( $value, array $comparativeValues ) {
64
-		Assert::parameterType( 'string', $value, '$value' );
65
-		Assert::parameterElementType( 'string', $comparativeValues, '$comparativeValues' );
63
+	public function compareWithArray($value, array $comparativeValues) {
64
+		Assert::parameterType('string', $value, '$value');
65
+		Assert::parameterElementType('string', $comparativeValues, '$comparativeValues');
66 66
 
67
-		$value = $this->cleanDataString( $value );
68
-		$comparativeValues = $this->cleanDataArray( $comparativeValues );
67
+		$value = $this->cleanDataString($value);
68
+		$comparativeValues = $this->cleanDataArray($comparativeValues);
69 69
 
70
-		if ( in_array( $value, $comparativeValues ) ) {
70
+		if (in_array($value, $comparativeValues)) {
71 71
 			return ComparisonResult::STATUS_MATCH;
72 72
 		}
73 73
 
74
-		foreach ( $comparativeValues as $comparativeValue ) {
75
-			if ( $this->checkSimilarity( $comparativeValue, $value ) ) {
74
+		foreach ($comparativeValues as $comparativeValue) {
75
+			if ($this->checkSimilarity($comparativeValue, $value)) {
76 76
 				return ComparisonResult::STATUS_PARTIAL_MATCH;
77 77
 			}
78 78
 		}
@@ -87,11 +87,11 @@  discard block
 block discarded – undo
87 87
 	 * @param string $comparativeValue
88 88
 	 * @return bool
89 89
 	 */
90
-	private function checkSimilarity( $value, $comparativeValue ) {
90
+	private function checkSimilarity($value, $comparativeValue) {
91 91
 		return
92
-			$this->percentagePrefixSimilarity( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD ||
93
-			$this->percentageSuffixSimilarity( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD ||
94
-			$this->percentageLevenshteinDistance( $value, $comparativeValue ) > self::SIMILARITY_THRESHOLD;
92
+			$this->percentagePrefixSimilarity($value, $comparativeValue) > self::SIMILARITY_THRESHOLD ||
93
+			$this->percentageSuffixSimilarity($value, $comparativeValue) > self::SIMILARITY_THRESHOLD ||
94
+			$this->percentageLevenshteinDistance($value, $comparativeValue) > self::SIMILARITY_THRESHOLD;
95 95
 	}
96 96
 
97 97
 	/**
@@ -101,10 +101,10 @@  discard block
 block discarded – undo
101 101
 	 *
102 102
 	 * @return string
103 103
 	 */
104
-	private function cleanDataString( $value ) {
105
-		$value = $this->stringNormalizer->trimToNFC( $value );
104
+	private function cleanDataString($value) {
105
+		$value = $this->stringNormalizer->trimToNFC($value);
106 106
 
107
-		return mb_strtolower( $value );
107
+		return mb_strtolower($value);
108 108
 	}
109 109
 
110 110
 	/**
@@ -114,10 +114,10 @@  discard block
 block discarded – undo
114 114
 	 *
115 115
 	 * @return array
116 116
 	 */
117
-	private function cleanDataArray( array $array ) {
117
+	private function cleanDataArray(array $array) {
118 118
 
119 119
 		return array_map(
120
-			[ $this, 'cleanDataString' ],
120
+			[$this, 'cleanDataString'],
121 121
 			$array );
122 122
 	}
123 123
 
@@ -129,19 +129,19 @@  discard block
 block discarded – undo
129 129
 	 *
130 130
 	 * @return float
131 131
 	 */
132
-	private function percentagePrefixSimilarity( $value, $comparativeValue ) {
132
+	private function percentagePrefixSimilarity($value, $comparativeValue) {
133 133
 		$prefixLength = 0; // common prefix length
134
-		$localLength = strlen( $value );
135
-		$externalLength = strlen( $comparativeValue );
136
-		while ( $prefixLength < min( $localLength, $externalLength ) ) {
134
+		$localLength = strlen($value);
135
+		$externalLength = strlen($comparativeValue);
136
+		while ($prefixLength < min($localLength, $externalLength)) {
137 137
 			$c = $value[$prefixLength];
138
-			if ( $externalLength > $prefixLength && $comparativeValue[$prefixLength] !== $c ) {
138
+			if ($externalLength > $prefixLength && $comparativeValue[$prefixLength] !== $c) {
139 139
 				break;
140 140
 			}
141 141
 			$prefixLength++;
142 142
 		}
143 143
 
144
-		return $prefixLength / max( $localLength, $externalLength );
144
+		return $prefixLength / max($localLength, $externalLength);
145 145
 	}
146 146
 
147 147
 	/**
@@ -152,19 +152,19 @@  discard block
 block discarded – undo
152 152
 	 *
153 153
 	 * @return float
154 154
 	 */
155
-	private function percentageSuffixSimilarity( $value, $comparativeValue ) {
155
+	private function percentageSuffixSimilarity($value, $comparativeValue) {
156 156
 		$suffixLength = 0; // common suffix length
157
-		$localLength = strlen( $value );
158
-		$externalLength = strlen( $comparativeValue );
159
-		while ( $suffixLength < min( $localLength, $externalLength ) ) {
157
+		$localLength = strlen($value);
158
+		$externalLength = strlen($comparativeValue);
159
+		while ($suffixLength < min($localLength, $externalLength)) {
160 160
 			$c = $value[$localLength - 1 - $suffixLength];
161
-			if ( $externalLength > $suffixLength && $comparativeValue[$externalLength - 1 - $suffixLength] !== $c ) {
161
+			if ($externalLength > $suffixLength && $comparativeValue[$externalLength - 1 - $suffixLength] !== $c) {
162 162
 				break;
163 163
 			}
164 164
 			$suffixLength++;
165 165
 		}
166 166
 
167
-		return $suffixLength / max( $localLength, $externalLength );
167
+		return $suffixLength / max($localLength, $externalLength);
168 168
 	}
169 169
 
170 170
 	/**
@@ -175,9 +175,9 @@  discard block
 block discarded – undo
175 175
 	 *
176 176
 	 * @return float
177 177
 	 */
178
-	private function percentageLevenshteinDistance( $value, $comparativeValue ) {
179
-		$distance = levenshtein( $value, $comparativeValue );
180
-		$percentage = 1.0 - $distance / max( strlen( $value ), strlen( $comparativeValue ) );
178
+	private function percentageLevenshteinDistance($value, $comparativeValue) {
179
+		$distance = levenshtein($value, $comparativeValue);
180
+		$percentage = 1.0 - $distance / max(strlen($value), strlen($comparativeValue));
181 181
 
182 182
 		return $percentage;
183 183
 	}
Please login to merge, or discard this patch.
includes/CrossCheck/Comparer/EntityIdValueComparer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	 * @param TermIndex $termIndex
33 33
 	 * @param StringComparer $stringComparer
34 34
 	 */
35
-	public function __construct( TermIndex $termIndex, StringComparer $stringComparer ) {
35
+	public function __construct(TermIndex $termIndex, StringComparer $stringComparer) {
36 36
 		$this->termIndex = $termIndex;
37 37
 		$this->stringComparer = $stringComparer;
38 38
 	}
@@ -45,9 +45,9 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @return string|null One of the ComparisonResult::STATUS_... constants.
47 47
 	 */
48
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
49
-		Assert::parameterType( EntityIdValue::class, $value, '$value' );
50
-		Assert::parameterType( MonolingualTextValue::class, $comparativeValue, '$comparativeValue' );
48
+	public function compare(DataValue $value, DataValue $comparativeValue) {
49
+		Assert::parameterType(EntityIdValue::class, $value, '$value');
50
+		Assert::parameterType(MonolingualTextValue::class, $comparativeValue, '$comparativeValue');
51 51
 
52 52
 		/**
53 53
 		 * @var EntityIdValue $value
@@ -56,10 +56,10 @@  discard block
 block discarded – undo
56 56
 
57 57
 		$entityId = $value->getEntityId();
58 58
 		$language = $comparativeValue->getLanguageCode();
59
-		$terms = $this->getTerms( $entityId, $language );
59
+		$terms = $this->getTerms($entityId, $language);
60 60
 
61
-		if ( $terms ) {
62
-			return $this->stringComparer->compareWithArray( $comparativeValue->getText(), $terms );
61
+		if ($terms) {
62
+			return $this->stringComparer->compareWithArray($comparativeValue->getText(), $terms);
63 63
 		}
64 64
 
65 65
 		return null;
@@ -73,18 +73,18 @@  discard block
 block discarded – undo
73 73
 	 *
74 74
 	 * @return array
75 75
 	 */
76
-	private function getTerms( EntityId $entityId, $language ) {
76
+	private function getTerms(EntityId $entityId, $language) {
77 77
 		$terms = $this->termIndex->getTermsOfEntity(
78 78
 			$entityId,
79 79
 			[
80 80
 				TermIndexEntry::TYPE_LABEL,
81 81
 				TermIndexEntry::TYPE_ALIAS
82 82
 			],
83
-			[ $language ]
83
+			[$language]
84 84
 		);
85 85
 
86 86
 		return array_map(
87
-			function( TermIndexEntry $term ) {
87
+			function(TermIndexEntry $term) {
88 88
 				return $term->getText();
89 89
 			},
90 90
 			$terms
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 	 * @param DataValue $comparativeValue
99 99
 	 * @return bool
100 100
 	 */
101
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
101
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
102 102
 		return $value instanceof EntityIdValue && $comparativeValue instanceof MonolingualTextValue;
103 103
 	}
104 104
 
Please login to merge, or discard this patch.
includes/DumpMetaInformation/DumpMetaInformation.php 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -99,13 +99,13 @@  discard block
 block discarded – undo
99 99
 			'$identifierPropertyIds'
100 100
 		);
101 101
 
102
-		$this->setDumpId( $dumpId );
102
+		$this->setDumpId($dumpId);
103 103
 		$this->sourceItemId = $sourceItemId;
104 104
 		$this->identifierPropertyIds = $identifierPropertyIds;
105
-		$this->setImportDate( $importDate );
106
-		$this->setLanguageCode( $languageCode );
107
-		$this->setSourceUrl( $sourceUrl );
108
-		$this->setSize( $size );
105
+		$this->setImportDate($importDate);
106
+		$this->setLanguageCode($languageCode);
107
+		$this->setSourceUrl($sourceUrl);
108
+		$this->setSize($size);
109 109
 		$this->licenseItemId = $licenseItemId;
110 110
 	}
111 111
 
@@ -170,11 +170,11 @@  discard block
 block discarded – undo
170 170
 	 *
171 171
 	 * @throws InvalidArgumentException
172 172
 	 */
173
-	private function setDumpId( $dumpId ) {
174
-		Assert::parameterType( 'string', $dumpId, '$dumpId' );
175
-		$length = strlen( $dumpId );
176
-		if ( $length < 1 || $length > 25 ) {
177
-			throw new InvalidArgumentException( '$dumpId must be between 1 and 25 characters.' );
173
+	private function setDumpId($dumpId) {
174
+		Assert::parameterType('string', $dumpId, '$dumpId');
175
+		$length = strlen($dumpId);
176
+		if ($length < 1 || $length > 25) {
177
+			throw new InvalidArgumentException('$dumpId must be between 1 and 25 characters.');
178 178
 		}
179 179
 
180 180
 		$this->dumpId = $dumpId;
@@ -185,10 +185,10 @@  discard block
 block discarded – undo
185 185
 	 *
186 186
 	 * @throws InvalidArgumentException
187 187
 	 */
188
-	private function setLanguageCode( $languageCode ) {
189
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
190
-		if ( !Language::isValidCode( $languageCode ) ) {
191
-			throw new InvalidArgumentException( '$languageCode is not valid.' );
188
+	private function setLanguageCode($languageCode) {
189
+		Assert::parameterType('string', $languageCode, '$languageCode');
190
+		if (!Language::isValidCode($languageCode)) {
191
+			throw new InvalidArgumentException('$languageCode is not valid.');
192 192
 		}
193 193
 
194 194
 		$this->languageCode = $languageCode;
@@ -199,12 +199,12 @@  discard block
 block discarded – undo
199 199
 	 *
200 200
 	 * @throws InvalidArgumentException
201 201
 	 */
202
-	private function setImportDate( $importDate ) {
203
-		Assert::parameterType( 'string', $importDate, '$importDate' );
202
+	private function setImportDate($importDate) {
203
+		Assert::parameterType('string', $importDate, '$importDate');
204 204
 
205
-		$timestamp = wfTimestamp( TS_MW, $importDate );
206
-		if ( !$timestamp ) {
207
-			throw new InvalidArgumentException( '$updatedAt has invalid timestamp format.' );
205
+		$timestamp = wfTimestamp(TS_MW, $importDate);
206
+		if (!$timestamp) {
207
+			throw new InvalidArgumentException('$updatedAt has invalid timestamp format.');
208 208
 		}
209 209
 
210 210
 		$this->importDate = $importDate;
@@ -215,13 +215,13 @@  discard block
 block discarded – undo
215 215
 	 *
216 216
 	 * @throws InvalidArgumentException
217 217
 	 */
218
-	private function setSourceUrl( $sourceUrl ) {
219
-		Assert::parameterType( 'string', $sourceUrl, '$sourceUrl' );
220
-		if ( strlen( $sourceUrl ) > 300 ) {
221
-			throw new InvalidArgumentException( '$sourceUrl must not be longer than 300 characters.' );
218
+	private function setSourceUrl($sourceUrl) {
219
+		Assert::parameterType('string', $sourceUrl, '$sourceUrl');
220
+		if (strlen($sourceUrl) > 300) {
221
+			throw new InvalidArgumentException('$sourceUrl must not be longer than 300 characters.');
222 222
 		}
223
-		if ( !filter_var( $sourceUrl, FILTER_VALIDATE_URL ) ) {
224
-			throw new InvalidArgumentException( '$sourceUrl is not a valid url.' );
223
+		if (!filter_var($sourceUrl, FILTER_VALIDATE_URL)) {
224
+			throw new InvalidArgumentException('$sourceUrl is not a valid url.');
225 225
 		}
226 226
 
227 227
 		$this->sourceUrl = $sourceUrl;
@@ -232,10 +232,10 @@  discard block
 block discarded – undo
232 232
 	 *
233 233
 	 * @throws InvalidArgumentException
234 234
 	 */
235
-	private function setSize( $size ) {
236
-		Assert::parameterType( 'integer', $size, '$size' );
237
-		if ( $size <= 0 ) {
238
-			throw new InvalidArgumentException( '$size must be positive integer.' );
235
+	private function setSize($size) {
236
+		Assert::parameterType('integer', $size, '$size');
237
+		if ($size <= 0) {
238
+			throw new InvalidArgumentException('$size must be positive integer.');
239 239
 		}
240 240
 
241 241
 		$this->size = $size;
Please login to merge, or discard this patch.
includes/CrossCheck/Result/CrossCheckResult.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -73,8 +73,8 @@
 block discarded – undo
73 73
 		ComparisonResult $comparisonResult,
74 74
 		ReferenceResult $referenceResult
75 75
 	) {
76
-		Assert::parameterType( 'string', $claimGuid, '$claimGuid' );
77
-		Assert::parameterType( 'string', $externalId, '$externalId' );
76
+		Assert::parameterType('string', $claimGuid, '$claimGuid');
77
+		Assert::parameterType('string', $externalId, '$externalId');
78 78
 
79 79
 		$this->propertyId = $propertyId;
80 80
 		$this->claimGuid = $claimGuid;
Please login to merge, or discard this patch.