Completed
Push — master ( a187dc...dcf65c )
by
unknown
24:50
created
includes/CrossCheck/ValueParser/ComparativeValueParser.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 		ValueParserFactory $comparativeValueParserFactory,
39 39
 		$languageCode
40 40
 	) {
41
-		Assert::parameterType( 'string', $languageCode, '$languageCode' );
41
+		Assert::parameterType('string', $languageCode, '$languageCode');
42 42
 
43 43
 		$this->comparativeValueParserFactory = $comparativeValueParserFactory;
44 44
 		$this->languageCode = $languageCode;
@@ -52,11 +52,11 @@  discard block
 block discarded – undo
52 52
 	 *
53 53
 	 * @return DataValue
54 54
 	 */
55
-	public function parse( $value, $propertyType ) {
56
-		Assert::parameterType( 'string', $value, '$value' );
57
-		Assert::parameterType( 'string', $propertyType, '$propertyType' );
55
+	public function parse($value, $propertyType) {
56
+		Assert::parameterType('string', $value, '$value');
57
+		Assert::parameterType('string', $propertyType, '$propertyType');
58 58
 
59
-		return $this->getValueParser( $propertyType )->parse( $value );
59
+		return $this->getValueParser($propertyType)->parse($value);
60 60
 	}
61 61
 
62 62
 	/**
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 	 *
65 65
 	 * @return ValueParser
66 66
 	 */
67
-	private function getValueParser( $type ) {
68
-		if ( !array_key_exists( $type, $this->valueParsers ) ) {
67
+	private function getValueParser($type) {
68
+		if (!array_key_exists($type, $this->valueParsers)) {
69 69
 			$parserOptions = $this->getParserOptions();
70 70
 			$this->valueParsers[$type] = $this->comparativeValueParserFactory->newParser(
71 71
 				$type,
@@ -81,8 +81,8 @@  discard block
 block discarded – undo
81 81
 	 */
82 82
 	private function getParserOptions() {
83 83
 		$options = new ParserOptions();
84
-		$options->setOption( 'valuelang', $this->languageCode );
85
-		$options->setOption( ValueParser::OPT_LANG, $this->languageCode );
84
+		$options->setOption('valuelang', $this->languageCode);
85
+		$options->setOption(ValueParser::OPT_LANG, $this->languageCode);
86 86
 
87 87
 		return $options;
88 88
 	}
Please login to merge, or discard this patch.
WikibaseQualityExternalValidation.alias.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -10,6 +10,6 @@
 block discarded – undo
10 10
 
11 11
 /** English (English) */
12 12
 $specialPageAliases['en'] = [
13
-	'CrossCheck' => [ 'CrossCheck', 'Cross Check' ],
14
-	'ExternalDatabases' => [ 'ExternalDatabases', 'ExternalDbs', 'External Dbs' ],
13
+	'CrossCheck' => ['CrossCheck', 'Cross Check'],
14
+	'ExternalDatabases' => ['ExternalDatabases', 'ExternalDbs', 'External Dbs'],
15 15
 ];
Please login to merge, or discard this patch.
specials/SpecialExternalDatabases.php 1 patch
Spacing   +38 added lines, -38 removed lines patch added patch discarded remove patch
@@ -53,10 +53,10 @@  discard block
 block discarded – undo
53 53
 		TermLookup $termLookup,
54 54
 		EntityIdHtmlLinkFormatterFactory $entityIdHtmlLinkFormatterFactory,
55 55
 		DumpMetaInformationLookup $dumpMetaInformationRepo ) {
56
-		parent::__construct( 'ExternalDatabases' );
56
+		parent::__construct('ExternalDatabases');
57 57
 
58 58
 		$this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter(
59
-			new LanguageLabelDescriptionLookup( $termLookup, $this->getLanguage()->getCode() )
59
+			new LanguageLabelDescriptionLookup($termLookup, $this->getLanguage()->getCode())
60 60
 		);
61 61
 
62 62
 		$this->dumpMetaInformationRepo = $dumpMetaInformationRepo;
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 	 * @return string
78 78
 	 */
79 79
 	public function getDescription() {
80
-		return $this->msg( 'wbqev-externaldbs' )->text();
80
+		return $this->msg('wbqev-externaldbs')->text();
81 81
 	}
82 82
 
83 83
 	/**
@@ -85,51 +85,51 @@  discard block
 block discarded – undo
85 85
 	 *
86 86
 	 * @param string|null $subPage
87 87
 	 */
88
-	public function execute( $subPage ) {
88
+	public function execute($subPage) {
89 89
 		$out = $this->getOutput();
90 90
 
91 91
 		$this->setHeaders();
92 92
 
93 93
 		$out->addHTML(
94
-			Html::openElement( 'p' )
95
-			. $this->msg( 'wbqev-externaldbs-instructions' )->parse()
96
-			. Html::closeElement( 'p' )
97
-			. Html::openElement( 'h3' )
98
-			. $this->msg( 'wbqev-externaldbs-overview-headline' )->parse()
99
-			. Html::closeElement( 'h3' )
94
+			Html::openElement('p')
95
+			. $this->msg('wbqev-externaldbs-instructions')->parse()
96
+			. Html::closeElement('p')
97
+			. Html::openElement('h3')
98
+			. $this->msg('wbqev-externaldbs-overview-headline')->parse()
99
+			. Html::closeElement('h3')
100 100
 		);
101 101
 
102 102
 		$dumps = $this->dumpMetaInformationRepo->getAll();
103
-		if ( count( $dumps ) > 0 ) {
103
+		if (count($dumps) > 0) {
104 104
 			$groupedDumpMetaInformation = [];
105
-			foreach ( $dumps as $dump ) {
105
+			foreach ($dumps as $dump) {
106 106
 				$sourceItemId = $dump->getSourceItemId()->getSerialization();
107 107
 				$groupedDumpMetaInformation[$sourceItemId][] = $dump;
108 108
 			}
109 109
 
110 110
 			$table = new HtmlTableBuilder(
111 111
 				[
112
-					$this->msg( 'wbqev-externaldbs-name' )->escaped(),
113
-					$this->msg( 'wbqev-externaldbs-id' )->escaped(),
114
-					$this->msg( 'wbqev-externaldbs-import-date' )->escaped(),
115
-					$this->msg( 'wbqev-externaldbs-language' )->escaped(),
116
-					$this->msg( 'wbqev-externaldbs-source-urls' )->escaped(),
117
-					$this->msg( 'wbqev-externaldbs-size' )->escaped(),
118
-					$this->msg( 'wbqev-externaldbs-license' )->escaped()
112
+					$this->msg('wbqev-externaldbs-name')->escaped(),
113
+					$this->msg('wbqev-externaldbs-id')->escaped(),
114
+					$this->msg('wbqev-externaldbs-import-date')->escaped(),
115
+					$this->msg('wbqev-externaldbs-language')->escaped(),
116
+					$this->msg('wbqev-externaldbs-source-urls')->escaped(),
117
+					$this->msg('wbqev-externaldbs-size')->escaped(),
118
+					$this->msg('wbqev-externaldbs-license')->escaped()
119 119
 				],
120 120
 				true
121 121
 			);
122 122
 
123
-			foreach ( $groupedDumpMetaInformation as $dumpMetaInformation ) {
124
-				$table->appendRows( $this->getRowGroup( $dumpMetaInformation ) );
123
+			foreach ($groupedDumpMetaInformation as $dumpMetaInformation) {
124
+				$table->appendRows($this->getRowGroup($dumpMetaInformation));
125 125
 			}
126 126
 
127
-			$out->addHTML( $table->toHtml() );
127
+			$out->addHTML($table->toHtml());
128 128
 		} else {
129 129
 			$out->addHTML(
130
-				Html::openElement( 'p' )
131
-				. $this->msg( 'wbqev-externaldbs-no-databases' )->escaped()
132
-				. Html::closeElement( 'p' )
130
+				Html::openElement('p')
131
+				. $this->msg('wbqev-externaldbs-no-databases')->escaped()
132
+				. Html::closeElement('p')
133 133
 			);
134 134
 		}
135 135
 	}
@@ -141,12 +141,12 @@  discard block
 block discarded – undo
141 141
 	 *
142 142
 	 * @return array
143 143
 	 */
144
-	private function getRowGroup( array $dumpMetaInformationGroup ) {
144
+	private function getRowGroup(array $dumpMetaInformationGroup) {
145 145
 		$rows = [];
146 146
 
147
-		foreach ( $dumpMetaInformationGroup as $dumpMetaInformation ) {
147
+		foreach ($dumpMetaInformationGroup as $dumpMetaInformation) {
148 148
 			$dumpId = $dumpMetaInformation->getDumpId();
149
-			$importDate = $this->getLanguage()->timeanddate( $dumpMetaInformation->getImportDate() );
149
+			$importDate = $this->getLanguage()->timeanddate($dumpMetaInformation->getImportDate());
150 150
 			$language = Language::fetchLanguageName(
151 151
 				$dumpMetaInformation->getLanguageCode(),
152 152
 				$this->getLanguage()->getCode()
@@ -155,23 +155,23 @@  discard block
 block discarded – undo
155 155
 				$dumpMetaInformation->getSourceUrl(),
156 156
 				$dumpMetaInformation->getSourceUrl()
157 157
 			);
158
-			$size = $this->getLanguage()->formatSize( $dumpMetaInformation->getSize() );
159
-			$license = $this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformation->getLicenseItemId() );
158
+			$size = $this->getLanguage()->formatSize($dumpMetaInformation->getSize());
159
+			$license = $this->entityIdLinkFormatter->formatEntityId($dumpMetaInformation->getLicenseItemId());
160 160
 			$rows[] = [
161
-				new HtmlTableCellBuilder( $dumpId ),
162
-				new HtmlTableCellBuilder( $importDate ),
163
-				new HtmlTableCellBuilder( $language ),
164
-				new HtmlTableCellBuilder( $sourceUrl, [], true ),
165
-				new HtmlTableCellBuilder( $size ),
166
-				new HtmlTableCellBuilder( $license, [], true )
161
+				new HtmlTableCellBuilder($dumpId),
162
+				new HtmlTableCellBuilder($importDate),
163
+				new HtmlTableCellBuilder($language),
164
+				new HtmlTableCellBuilder($sourceUrl, [], true),
165
+				new HtmlTableCellBuilder($size),
166
+				new HtmlTableCellBuilder($license, [], true)
167 167
 			];
168 168
 		}
169 169
 
170 170
 		array_unshift(
171 171
 			$rows[0],
172 172
 			new HtmlTableCellBuilder(
173
-				$this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformationGroup[0]->getSourceItemId() ),
174
-				[ 'rowspan' => (string)count( $dumpMetaInformationGroup ) ],
173
+				$this->entityIdLinkFormatter->formatEntityId($dumpMetaInformationGroup[0]->getSourceItemId()),
174
+				['rowspan' => (string)count($dumpMetaInformationGroup)],
175 175
 				true
176 176
 			)
177 177
 		);
Please login to merge, or discard this patch.
includes/Serializer/ComparisonResultSerializer.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $dataValueSerializer
24 24
 	 */
25
-	public function __construct( Serializer $dataValueSerializer ) {
25
+	public function __construct(Serializer $dataValueSerializer) {
26 26
 		$this->dataValueSerializer = $dataValueSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof ComparisonResult;
38 38
 	}
39 39
 
@@ -45,29 +45,29 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'ComparisonResultSerializer can only serialize ComparisonResult objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( ComparisonResult $comparisonResult ) {
59
+	private function getSerialized(ComparisonResult $comparisonResult) {
60 60
 		$dataValueSerializer = $this->dataValueSerializer;
61 61
 		$externalValues = array_map(
62
-			function ( $dataValue ) use ( $dataValueSerializer ) {
63
-				return $dataValueSerializer->serialize( $dataValue );
62
+			function($dataValue) use ($dataValueSerializer) {
63
+				return $dataValueSerializer->serialize($dataValue);
64 64
 			},
65 65
 			$comparisonResult->getExternalValues()
66 66
 		);
67
-		$this->setIndexedTagName( $externalValues, 'dataValue' );
67
+		$this->setIndexedTagName($externalValues, 'dataValue');
68 68
 
69 69
 		return [
70
-			'localValue' => $this->dataValueSerializer->serialize( $comparisonResult->getLocalValue() ),
70
+			'localValue' => $this->dataValueSerializer->serialize($comparisonResult->getLocalValue()),
71 71
 			'externalValues' => $externalValues,
72 72
 			'result' => $comparisonResult->getStatus()
73 73
 		];
Please login to merge, or discard this patch.
includes/Serializer/CrossCheckResultListSerializer.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $crossCheckResultSerializer
24 24
 	 */
25
-	public function __construct( Serializer $crossCheckResultSerializer ) {
25
+	public function __construct(Serializer $crossCheckResultSerializer) {
26 26
 		$this->crossCheckResultSerializer = $crossCheckResultSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof CrossCheckResultList;
38 38
 	}
39 39
 
@@ -45,29 +45,29 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( CrossCheckResultList $resultList ) {
59
+	private function getSerialized(CrossCheckResultList $resultList) {
60 60
 		$serialization = [];
61
-		$this->setKeyAttributeName( $serialization, 'property', 'id' );
61
+		$this->setKeyAttributeName($serialization, 'property', 'id');
62 62
 
63
-		foreach ( $resultList->getPropertyIds() as $propertyId ) {
63
+		foreach ($resultList->getPropertyIds() as $propertyId) {
64 64
 			$id = $propertyId->getSerialization();
65 65
 			$resultSerialization = [];
66 66
 
67
-			$this->setIndexedTagName( $resultSerialization, 'result' );
67
+			$this->setIndexedTagName($resultSerialization, 'result');
68 68
 
69
-			foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) {
70
-				$resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result );
69
+			foreach ($resultList->getByPropertyId($propertyId) as $result) {
70
+				$resultSerialization[] = $this->crossCheckResultSerializer->serialize($result);
71 71
 			}
72 72
 
73 73
 			$serialization[$id] = $resultSerialization;
Please login to merge, or discard this patch.
includes/Serializer/DumpMetaInformationSerializer.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	 *
22 22
 	 * @return bool
23 23
 	 */
24
-	public function isSerializerFor( $object ) {
24
+	public function isSerializerFor($object) {
25 25
 		return $object instanceof DumpMetaInformation;
26 26
 	}
27 27
 
@@ -33,32 +33,32 @@  discard block
 block discarded – undo
33 33
 	 * @return array
34 34
 	 * @throws UnsupportedObjectException
35 35
 	 */
36
-	public function serialize( $object ) {
37
-		if ( !$this->isSerializerFor( $object ) ) {
36
+	public function serialize($object) {
37
+		if (!$this->isSerializerFor($object)) {
38 38
 			throw new UnsupportedObjectException(
39 39
 				$object,
40 40
 				'DumpMetaInformationSerializer can only serialize DumpMetaInformation objects.'
41 41
 			);
42 42
 		}
43 43
 
44
-		return $this->getSerialized( $object );
44
+		return $this->getSerialized($object);
45 45
 	}
46 46
 
47
-	private function getSerialized( DumpMetaInformation $dumpMetaInformation ) {
47
+	private function getSerialized(DumpMetaInformation $dumpMetaInformation) {
48 48
 		$identifierPropertyIds = array_map(
49
-			function( PropertyId $id ) {
49
+			function(PropertyId $id) {
50 50
 				return $id->getSerialization();
51 51
 			},
52 52
 			$dumpMetaInformation->getIdentifierPropertyIds()
53 53
 		);
54 54
 
55
-		$this->setIndexedTagName( $identifierPropertyIds, 'propertyId' );
55
+		$this->setIndexedTagName($identifierPropertyIds, 'propertyId');
56 56
 
57 57
 		return [
58 58
 			'dumpId' => $dumpMetaInformation->getDumpId(),
59 59
 			'sourceItemId' => $dumpMetaInformation->getSourceItemId()->getSerialization(),
60 60
 			'identifierPropertyIds' => $identifierPropertyIds,
61
-			'importDate' => wfTimestamp( TS_ISO_8601, $dumpMetaInformation->getImportDate() ),
61
+			'importDate' => wfTimestamp(TS_ISO_8601, $dumpMetaInformation->getImportDate()),
62 62
 			'language' => $dumpMetaInformation->getLanguageCode(),
63 63
 			'sourceUrl' => $dumpMetaInformation->getSourceUrl(),
64 64
 			'size' => $dumpMetaInformation->getSize(),
Please login to merge, or discard this patch.
includes/Serializer/CrossCheckResultSerializer.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	 *
52 52
 	 * @return bool
53 53
 	 */
54
-	public function isSerializerFor( $object ) {
54
+	public function isSerializerFor($object) {
55 55
 		return $object instanceof CrossCheckResult;
56 56
 	}
57 57
 
@@ -63,25 +63,25 @@  discard block
 block discarded – undo
63 63
 	 * @return array
64 64
 	 * @throws UnsupportedObjectException
65 65
 	 */
66
-	public function serialize( $object ) {
67
-		if ( !$this->isSerializerFor( $object ) ) {
66
+	public function serialize($object) {
67
+		if (!$this->isSerializerFor($object)) {
68 68
 			throw new UnsupportedObjectException(
69 69
 				$object,
70 70
 				'CrossCheckResultSerializer can only serialize CrossCheckResult objects.'
71 71
 			);
72 72
 		}
73 73
 
74
-		return $this->getSerialized( $object );
74
+		return $this->getSerialized($object);
75 75
 	}
76 76
 
77
-	private function getSerialized( CrossCheckResult $crossCheckResult ) {
77
+	private function getSerialized(CrossCheckResult $crossCheckResult) {
78 78
 		return [
79 79
 			'propertyId' => $crossCheckResult->getPropertyId()->getSerialization(),
80 80
 			'claimGuid' => $crossCheckResult->getClaimGuid(),
81 81
 			'externalId' => $crossCheckResult->getExternalId(),
82
-			'dataSource' => $this->dumpMetaInformationSerializer->serialize( $crossCheckResult->getDumpMetaInformation() ),
83
-			'comparisonResult' => $this->comparisonResultSerializer->serialize( $crossCheckResult->getComparisonResult() ),
84
-			'referenceResult' => $this->referenceResultSerializer->serialize( $crossCheckResult->getReferenceResult() )
82
+			'dataSource' => $this->dumpMetaInformationSerializer->serialize($crossCheckResult->getDumpMetaInformation()),
83
+			'comparisonResult' => $this->comparisonResultSerializer->serialize($crossCheckResult->getComparisonResult()),
84
+			'referenceResult' => $this->referenceResultSerializer->serialize($crossCheckResult->getReferenceResult())
85 85
 		];
86 86
 	}
87 87
 
Please login to merge, or discard this patch.
includes/Serializer/ReferenceResultSerializer.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	/**
23 23
 	 * @param Serializer $referenceSerializer
24 24
 	 */
25
-	public function __construct( Serializer $referenceSerializer ) {
25
+	public function __construct(Serializer $referenceSerializer) {
26 26
 		$this->referenceSerializer = $referenceSerializer;
27 27
 	}
28 28
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	 *
34 34
 	 * @return bool
35 35
 	 */
36
-	public function isSerializerFor( $object ) {
36
+	public function isSerializerFor($object) {
37 37
 		return $object instanceof ReferenceResult;
38 38
 	}
39 39
 
@@ -45,20 +45,20 @@  discard block
 block discarded – undo
45 45
 	 * @return array
46 46
 	 * @throws UnsupportedObjectException
47 47
 	 */
48
-	public function serialize( $object ) {
49
-		if ( !$this->isSerializerFor( $object ) ) {
48
+	public function serialize($object) {
49
+		if (!$this->isSerializerFor($object)) {
50 50
 			throw new UnsupportedObjectException(
51 51
 				$object,
52 52
 				'ReferenceResultSerializer can only serialize ReferenceResult objects.'
53 53
 			);
54 54
 		}
55 55
 
56
-		return $this->getSerialized( $object );
56
+		return $this->getSerialized($object);
57 57
 	}
58 58
 
59
-	private function getSerialized( ReferenceResult $referenceResult ) {
59
+	private function getSerialized(ReferenceResult $referenceResult) {
60 60
 		return [
61
-			'reference' => $this->referenceSerializer->serialize( $referenceResult->getReference() ),
61
+			'reference' => $this->referenceSerializer->serialize($referenceResult->getReference()),
62 62
 			'status' => $referenceResult->getStatus()
63 63
 		];
64 64
 	}
Please login to merge, or discard this patch.
includes/CrossCheck/CrossChecker.php 1 patch
Spacing   +55 added lines, -55 removed lines patch added patch discarded remove patch
@@ -95,22 +95,22 @@  discard block
 block discarded – undo
95 95
 	 * @return CrossCheckResultList
96 96
 	 * @throws InvalidArgumentException
97 97
 	 */
98
-	public function crossCheckStatements( StatementList $entityStatements, StatementList $statements ) {
98
+	public function crossCheckStatements(StatementList $entityStatements, StatementList $statements) {
99 99
 		$statementsOfEntity = $entityStatements->toArray();
100 100
 
101
-		foreach ( $statements as $statement ) {
102
-			if ( !in_array( $statement, $statementsOfEntity ) ) {
103
-				throw new InvalidArgumentException( 'All statements in $statements must belong to the entity.' );
101
+		foreach ($statements as $statement) {
102
+			if (!in_array($statement, $statementsOfEntity)) {
103
+				throw new InvalidArgumentException('All statements in $statements must belong to the entity.');
104 104
 			}
105 105
 		}
106 106
 
107 107
 		$resultList = new CrossCheckResultList();
108
-		if ( $statements->count() > 0 ) {
109
-			$applicableDumps = $this->getApplicableDumps( $entityStatements );
110
-			foreach ( $applicableDumps as $identifierPropertyId => $dumpMetaInformationList ) {
111
-				$identifierPropertyId = new PropertyId( $identifierPropertyId );
108
+		if ($statements->count() > 0) {
109
+			$applicableDumps = $this->getApplicableDumps($entityStatements);
110
+			foreach ($applicableDumps as $identifierPropertyId => $dumpMetaInformationList) {
111
+				$identifierPropertyId = new PropertyId($identifierPropertyId);
112 112
 
113
-				if ( $this->isIdentifierProperty( $identifierPropertyId ) ) {
113
+				if ($this->isIdentifierProperty($identifierPropertyId)) {
114 114
 					$resultList->merge(
115 115
 						$this->crossCheckStatementsWithIdentifier(
116 116
 							$entityStatements,
@@ -133,17 +133,17 @@  discard block
 block discarded – undo
133 133
 	 *
134 134
 	 * @return array[]
135 135
 	 */
136
-	private function getApplicableDumps( StatementList $statements ) {
136
+	private function getApplicableDumps(StatementList $statements) {
137 137
 		$applicableDumps = [];
138 138
 		$identifierPropertyIds = $statements->getPropertyIds();
139 139
 		$dumpMetaInformation = $this->dumpMetaInformationLookup->getWithIdentifierProperties(
140 140
 			$identifierPropertyIds
141 141
 		);
142 142
 
143
-		foreach ( $dumpMetaInformation as $dump ) {
144
-			foreach ( $dump->getIdentifierPropertyIds() as $identifierPropertyId ) {
143
+		foreach ($dumpMetaInformation as $dump) {
144
+			foreach ($dump->getIdentifierPropertyIds() as $identifierPropertyId) {
145 145
 				$serialization = $identifierPropertyId->getSerialization();
146
-				$applicableDumps[ $serialization ][ $dump->getDumpId() ] = $dump;
146
+				$applicableDumps[$serialization][$dump->getDumpId()] = $dump;
147 147
 			}
148 148
 		}
149 149
 
@@ -168,36 +168,36 @@  discard block
 block discarded – undo
168 168
 	) {
169 169
 		$resultList = new CrossCheckResultList();
170 170
 
171
-		$externalIds = $this->getExternalIds( $entityStatements, $identifierPropertyId );
172
-		if ( !$externalIds ) {
171
+		$externalIds = $this->getExternalIds($entityStatements, $identifierPropertyId);
172
+		if (!$externalIds) {
173 173
 			return $resultList;
174 174
 		}
175 175
 
176 176
 		$dumpIds = array_map(
177
-			function ( DumpMetaInformation $dumpMetaInformation ) {
177
+			function(DumpMetaInformation $dumpMetaInformation) {
178 178
 				return $dumpMetaInformation->getDumpId();
179 179
 			},
180 180
 			$dumpMetaInformationList
181 181
 		);
182
-		$externalData = $this->externalDataRepo->getExternalData( $dumpIds, $externalIds, $statements->getPropertyIds() );
182
+		$externalData = $this->externalDataRepo->getExternalData($dumpIds, $externalIds, $statements->getPropertyIds());
183 183
 
184
-		foreach ( $externalData as $dumpId => $externalDataPerDump ) {
185
-			$dumpMetaInformation = $dumpMetaInformationList[ $dumpId ];
184
+		foreach ($externalData as $dumpId => $externalDataPerDump) {
185
+			$dumpMetaInformation = $dumpMetaInformationList[$dumpId];
186 186
 			$comparativeValueParser = $this->valueParserFactory->newComparativeValueParser(
187 187
 				$dumpMetaInformation->getLanguageCode()
188 188
 			);
189 189
 
190
-			foreach ( $externalDataPerDump as $externalId => $externalDataPerId ) {
190
+			foreach ($externalDataPerDump as $externalId => $externalDataPerId) {
191 191
 				$externalId = (string)$externalId;
192
-				foreach ( $externalDataPerId as $propertyId => $externalValues ) {
193
-					$propertyId = new PropertyId( $propertyId );
192
+				foreach ($externalDataPerId as $propertyId => $externalValues) {
193
+					$propertyId = new PropertyId($propertyId);
194 194
 					$resultList->merge(
195 195
 						$this->crossCheckExternalValues(
196 196
 							$dumpMetaInformation,
197 197
 							$identifierPropertyId,
198 198
 							$externalId,
199 199
 							$externalValues,
200
-							$statements->getByPropertyId( $propertyId ),
200
+							$statements->getByPropertyId($propertyId),
201 201
 							$comparativeValueParser
202 202
 						)
203 203
 					);
@@ -228,10 +228,10 @@  discard block
 block discarded – undo
228 228
 	) {
229 229
 		$resultList = new CrossCheckResultList();
230 230
 
231
-		foreach ( $statements->toArray() as $statement ) {
232
-			$comparisonResult = $this->compareStatement( $statement, $externalValues, $comparativeValueParser );
231
+		foreach ($statements->toArray() as $statement) {
232
+			$comparisonResult = $this->compareStatement($statement, $externalValues, $comparativeValueParser);
233 233
 
234
-			if ( $comparisonResult ) {
234
+			if ($comparisonResult) {
235 235
 				$referencesResult = $this->referenceHandler->checkForReferences(
236 236
 					$statement,
237 237
 					$identifierPropertyId,
@@ -265,31 +265,31 @@  discard block
 block discarded – undo
265 265
 	 * @return ComparisonResult|bool
266 266
 	 */
267 267
 	private function compareStatement(
268
-		Statement $statement,array $externalValues,
268
+		Statement $statement, array $externalValues,
269 269
 		ComparativeValueParser $comparativeValueParser
270 270
 	) {
271 271
 		$mainSnak = $statement->getMainSnak();
272
-		if ( $mainSnak instanceof PropertyValueSnak ) {
272
+		if ($mainSnak instanceof PropertyValueSnak) {
273 273
 			$dataValue = $mainSnak->getDataValue();
274 274
 
275 275
 			$results = [];
276
-			$comparativeValues = $this->parseExternalValues( $dataValue, $externalValues, $comparativeValueParser );
277
-			foreach ( $comparativeValues as $comparativeValue ) {
278
-				$result = $this->dataValueComparer->compare( $dataValue, $comparativeValue );
279
-				if ( $result ) {
276
+			$comparativeValues = $this->parseExternalValues($dataValue, $externalValues, $comparativeValueParser);
277
+			foreach ($comparativeValues as $comparativeValue) {
278
+				$result = $this->dataValueComparer->compare($dataValue, $comparativeValue);
279
+				if ($result) {
280 280
 					$results[] = $result;
281 281
 				}
282 282
 			}
283 283
 
284
-			if ( $results ) {
284
+			if ($results) {
285 285
 				$result = ComparisonResult::STATUS_MISMATCH;
286
-				if ( in_array( ComparisonResult::STATUS_MATCH, $results ) ) {
286
+				if (in_array(ComparisonResult::STATUS_MATCH, $results)) {
287 287
 					$result = ComparisonResult::STATUS_MATCH;
288
-				} elseif ( in_array( ComparisonResult::STATUS_PARTIAL_MATCH, $results ) ) {
288
+				} elseif (in_array(ComparisonResult::STATUS_PARTIAL_MATCH, $results)) {
289 289
 					$result = ComparisonResult::STATUS_PARTIAL_MATCH;
290 290
 				}
291 291
 
292
-				return new ComparisonResult( $dataValue, $comparativeValues, $result );
292
+				return new ComparisonResult($dataValue, $comparativeValues, $result);
293 293
 			}
294 294
 		}
295 295
 
@@ -309,13 +309,13 @@  discard block
 block discarded – undo
309 309
 		ComparativeValueParser $comparativeValueParser
310 310
 	) {
311 311
 		$parsedValues = [];
312
-		foreach ( $externalValues as $externalValue ) {
312
+		foreach ($externalValues as $externalValue) {
313 313
 			try {
314
-				$parsedValue = $comparativeValueParser->parse( $externalValue, $dataValue->getType() );
315
-				if ( $parsedValue ) {
314
+				$parsedValue = $comparativeValueParser->parse($externalValue, $dataValue->getType());
315
+				if ($parsedValue) {
316 316
 					$parsedValues[] = $parsedValue;
317 317
 				}
318
-			} catch ( ParseException $e ) {
318
+			} catch (ParseException $e) {
319 319
 			}
320 320
 		}
321 321
 
@@ -330,12 +330,12 @@  discard block
 block discarded – undo
330 330
 	 *
331 331
 	 * @return string[]
332 332
 	 */
333
-	private function getExternalIds( StatementList $statements, PropertyId $identifierPropertyId ) {
333
+	private function getExternalIds(StatementList $statements, PropertyId $identifierPropertyId) {
334 334
 		$externalIds = [];
335
-		$identifierStatements = $statements->getByPropertyId( $identifierPropertyId );
336
-		$values = $this->getDataValues( $identifierStatements );
337
-		foreach ( $values as $value ) {
338
-			if ( $value instanceof StringValue ) {
335
+		$identifierStatements = $statements->getByPropertyId($identifierPropertyId);
336
+		$values = $this->getDataValues($identifierStatements);
337
+		foreach ($values as $value) {
338
+			if ($value instanceof StringValue) {
339 339
 				$externalIds[] = $value->getValue();
340 340
 			}
341 341
 		}
@@ -347,15 +347,15 @@  discard block
 block discarded – undo
347 347
 	 * @param PropertyId $identifierPropertyId
348 348
 	 * @return bool
349 349
 	 */
350
-	private function isIdentifierProperty( PropertyId $identifierPropertyId ) {
350
+	private function isIdentifierProperty(PropertyId $identifierPropertyId) {
351 351
 		global $wgWBQEVInstanceOfPID, $wgWBQEVIdentifierPropertyQID;
352 352
 		/** @var Property $property */
353
-		$property = $this->entityLookup->getEntity( $identifierPropertyId );
354
-		$instanceOfPropertyId = new PropertyId( $wgWBQEVInstanceOfPID );
355
-		$statements = $property->getStatements()->getByPropertyId( $instanceOfPropertyId );
356
-		$values = $this->getDataValues( $statements );
357
-		foreach ( $values as $value ) {
358
-			if ( $value instanceof EntityIdValue
353
+		$property = $this->entityLookup->getEntity($identifierPropertyId);
354
+		$instanceOfPropertyId = new PropertyId($wgWBQEVInstanceOfPID);
355
+		$statements = $property->getStatements()->getByPropertyId($instanceOfPropertyId);
356
+		$values = $this->getDataValues($statements);
357
+		foreach ($values as $value) {
358
+			if ($value instanceof EntityIdValue
359 359
 				&& $value->getEntityId()->getSerialization() === $wgWBQEVIdentifierPropertyQID
360 360
 			) {
361 361
 				return true;
@@ -371,12 +371,12 @@  discard block
 block discarded – undo
371 371
 	 * @param StatementList $statementList
372 372
 	 * @return DataValue[]
373 373
 	 */
374
-	private function getDataValues( StatementList $statementList ) {
374
+	private function getDataValues(StatementList $statementList) {
375 375
 		$dataValues = [];
376 376
 
377
-		foreach ( $statementList->toArray() as $statement ) {
377
+		foreach ($statementList->toArray() as $statement) {
378 378
 			$mainSnak = $statement->getMainSnak();
379
-			if ( $mainSnak instanceof PropertyValueSnak ) {
379
+			if ($mainSnak instanceof PropertyValueSnak) {
380 380
 				$dataValues[] = $mainSnak->getDataValue();
381 381
 			}
382 382
 		}
Please login to merge, or discard this patch.