wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php

Spacing +48 added lines, -48 removed lines

@@ -28,14 +28,14 @@ 
 	 * @return DumpMetaInformation
 	 * @throws InvalidArgumentException
 	 */
-	public function getWithId( $dumpId ) {
-		if ( !is_string( $dumpId ) ) {
-			throw new InvalidArgumentException( '$dumpId must be string.' );
+	public function getWithId($dumpId) {
+		if (!is_string($dumpId)) {
+			throw new InvalidArgumentException('$dumpId must be string.');
 		}
 
-		$dumpMetaInformation = $this->getWithIds( array( $dumpId ) );
+		$dumpMetaInformation = $this->getWithIds(array($dumpId));
 
-		return reset( $dumpMetaInformation );
+		return reset($dumpMetaInformation);
 	}
 
 	/**
@@ -46,15 +46,15 @@ 
 	 * @return DumpMetaInformation[]
 	 * @throws InvalidArgumentException
 	 */
-	public function getWithIds( array $dumpIds ) {
-		foreach ( $dumpIds as $dumpId ) {
-			if ( !is_string( $dumpId ) ) {
-				throw new InvalidArgumentException( '$dumpIds must contain only strings.' );
+	public function getWithIds(array $dumpIds) {
+		foreach ($dumpIds as $dumpId) {
+			if (!is_string($dumpId)) {
+				throw new InvalidArgumentException('$dumpIds must contain only strings.');
 			}
 		}
 
-		if( count( $dumpIds ) > 0 ) {
-			$db = wfGetDB( DB_SLAVE );
+		if (count($dumpIds) > 0) {
+			$db = wfGetDB(DB_SLAVE);
 			$result = $db->select(
 				array(
 					self::META_TABLE_NAME,
@@ -74,7 +74,7 @@ 
 				)
 			);
 
-			return $this->buildDumpMetaInformationFromResult( $result );
+			return $this->buildDumpMetaInformationFromResult($result);
 		}
 
 		return array();
@@ -89,17 +89,17 @@ 
 	 * @throws InvalidArgumentException
 	 * @return DumpMetaInformation[]
 	 */
-	public function getWithIdentifierProperties( array $identifierPropertyIds ) {
-		foreach ( $identifierPropertyIds as $propertyId ) {
-			if ( !( $propertyId instanceof PropertyId ) ) {
-				throw new InvalidArgumentException( '$identifierProperties must contain only PropertyIds.' );
+	public function getWithIdentifierProperties(array $identifierPropertyIds) {
+		foreach ($identifierPropertyIds as $propertyId) {
+			if (!($propertyId instanceof PropertyId)) {
+				throw new InvalidArgumentException('$identifierProperties must contain only PropertyIds.');
 			}
 		}
 
-		if( count( $identifierPropertyIds ) > 0 ) {
-			$db = wfGetDB( DB_SLAVE );
+		if (count($identifierPropertyIds) > 0) {
+			$db = wfGetDB(DB_SLAVE);
 			$identifierPropertyIds = array_map(
-				function( PropertyId $id ) {
+				function(PropertyId $id) {
 					return $id->getSerialization();
 				},
 				$identifierPropertyIds
@@ -112,13 +112,13 @@ 
 				)
 			);
 			$dumpIds = array();
-			foreach ( $result as $row ) {
-				if ( !in_array( $row->dump_id, $dumpIds ) ) {
+			foreach ($result as $row) {
+				if (!in_array($row->dump_id, $dumpIds)) {
 					$dumpIds[] = $row->dump_id;
 				}
 			}
 
-			return $this->getWithIds( $dumpIds );
+			return $this->getWithIds($dumpIds);
 		}
 
 		return array();
@@ -130,7 +130,7 @@ 
 	 * @return ItemId[]
 	 */
 	public function getSourceItemIds() {
-		$db = wfGetDB( DB_SLAVE );
+		$db = wfGetDB(DB_SLAVE);
 		$result = $db->selectFieldValues(
 			self::META_TABLE_NAME,
 			'source_qid',
@@ -155,7 +155,7 @@ 
 	 * @return DumpMetaInformation[]
 	 */
 	public function getAll() {
-		$db = wfGetDB( DB_SLAVE );
+		$db = wfGetDB(DB_SLAVE);
 		$result = $db->select(
 			array(
 				self::META_TABLE_NAME,
@@ -173,7 +173,7 @@ 
 			)
 		);
 
-		return $this->buildDumpMetaInformationFromResult( $result );
+		return $this->buildDumpMetaInformationFromResult($result);
 	}
 
 	/**
@@ -181,34 +181,34 @@ 
 	 * @return null|array
 	 * @throws UnexpectedValueException
 	 */
-	private function buildDumpMetaInformationFromResult( ResultWrapper $result ) {
+	private function buildDumpMetaInformationFromResult(ResultWrapper $result) {
 		$aggregatedRows = array();
-		foreach ( $result as $row ) {
-			if ( array_key_exists( $row->id, $aggregatedRows ) ) {
-				$propertyId = new PropertyId( $row->identifier_pid );
+		foreach ($result as $row) {
+			if (array_key_exists($row->id, $aggregatedRows)) {
+				$propertyId = new PropertyId($row->identifier_pid);
 				$aggregatedRows[$row->id]->identifier_pid[] = $propertyId;
 			} else {
-				if ( $row->identifier_pid !== null ) {
-					$propertyId = new PropertyId( $row->identifier_pid );
-					$row->identifier_pid = array( $propertyId );
+				if ($row->identifier_pid !== null) {
+					$propertyId = new PropertyId($row->identifier_pid);
+					$row->identifier_pid = array($propertyId);
 				}
 				$aggregatedRows[$row->id] = $row;
 			}
 		}
 
 		$dumpMetaInformation = array();
-		foreach ( $aggregatedRows as $row ) {
+		foreach ($aggregatedRows as $row) {
 			$dumpId = $row->id;
-			$sourceItemId = new ItemId( $row->source_qid );
-			$importDate = wfTimestamp( TS_MW, $row->import_date );
+			$sourceItemId = new ItemId($row->source_qid);
+			$importDate = wfTimestamp(TS_MW, $row->import_date);
 			$language = $row->language;
 			$sourceUrl = $row->source_url;
 			$size = (int)$row->size;
-			$licenseItemId = new ItemId( $row->license_qid );
+			$licenseItemId = new ItemId($row->license_qid);
 			$identifierPropertyIds = $row->identifier_pid;
 
 			$dumpMetaInformation[$row->dump_id] =
-				new DumpMetaInformation( $dumpId,
+				new DumpMetaInformation($dumpId,
 					$sourceItemId,
 					$identifierPropertyIds,
 					$importDate,
@@ -227,22 +227,22 @@ 
 	 *
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 */
-	public function save( DumpMetaInformation $dumpMetaInformation ) {
-		$db = wfGetDB( DB_SLAVE );
+	public function save(DumpMetaInformation $dumpMetaInformation) {
+		$db = wfGetDB(DB_SLAVE);
 		$dumpId = $dumpMetaInformation->getDumpId();
-		$accumulator = $this->getDumpInformationFields( $db, $dumpMetaInformation );
+		$accumulator = $this->getDumpInformationFields($db, $dumpMetaInformation);
 
 		$existing = $db->selectRow(
 			self::META_TABLE_NAME,
-			array( 'id' ),
-			array( 'id' => $dumpId )
+			array('id'),
+			array('id' => $dumpId)
 		);
 
-		if ( $existing ) {
+		if ($existing) {
 			$db->update(
 				self::META_TABLE_NAME,
 				$accumulator,
-				array( 'id' => $dumpId )
+				array('id' => $dumpId)
 			);
 		} else {
 			$db->insert(
@@ -253,12 +253,12 @@ 
 
 		$db->delete(
 			self::IDENTIFIER_PROPERTIES_TABLE_NAME,
-			array( 'dump_id' => $dumpId )
+			array('dump_id' => $dumpId)
 		);
 		$db->insert(
 			self::IDENTIFIER_PROPERTIES_TABLE_NAME,
 			array_map(
-				function ( PropertyId $identifierPropertyId ) use ( $dumpId ) {
+				function(PropertyId $identifierPropertyId) use ($dumpId) {
 					return array(
 						'dump_id' => $dumpId,
 						'identifier_pid' => $identifierPropertyId->getSerialization()
@@ -274,11 +274,11 @@ 
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 * @return array
 	 */
-	private function getDumpInformationFields( Database $db,  DumpMetaInformation $dumpMetaInformation ) {
+	private function getDumpInformationFields(Database $db, DumpMetaInformation $dumpMetaInformation) {
 		return array(
 			'id' => $dumpMetaInformation->getDumpId(),
 			'source_qid' => $dumpMetaInformation->getSourceItemId()->getSerialization(),
-			'import_date' => $db->timestamp( $dumpMetaInformation->getImportDate() ),
+			'import_date' => $db->timestamp($dumpMetaInformation->getImportDate()),
 			'language' => $dumpMetaInformation->getLanguageCode(),
 			'source_url' => $dumpMetaInformation->getSourceUrl(),
 			'size' => $dumpMetaInformation->getSize(),