wikimedia / mediawiki-extensions-WikibaseQualityExternalValidation

includes/CrossCheck/Comparer/DataValueComparer.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue );
+	public function canCompare(DataValue $value, DataValue $comparativeValue);
 
 	/**
 	 * Runs the comparison of two DataValues.
@@ -28,6 +28,6 @@ 
 	 *
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue );
+	public function compare(DataValue $value, DataValue $comparativeValue);
 
 }

includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php

Spacing +8 added lines, -8 removed lines

@@ -23,9 +23,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -39,14 +39,14 @@ 
 		$extLat = $comparativeValue->getLatitude();
 		$extLong = $comparativeValue->getLongitude();
 
-		$diffLat = abs( $locLat - $extLat );
-		$diffLong = abs( $locLong - $extLong );
-		if ( ( $diffLat <= $precision ) && ( $diffLong <= $precision ) ) {
+		$diffLat = abs($locLat - $extLat);
+		$diffLong = abs($locLong - $extLong);
+		if (($diffLat <= $precision) && ($diffLong <= $precision)) {
 			return ComparisonResult::STATUS_MATCH;
 		}
 
 		$daumen = $precision;
-		if ( ( $diffLat <= pi() * $daumen ) && ( $diffLong <= pi() * $daumen ) ) {
+		if (($diffLat <= pi() * $daumen) && ($diffLong <= pi() * $daumen)) {
 			return ComparisonResult::STATUS_PARTIAL_MATCH;
 		}
 
@@ -60,7 +60,7 @@ 
 	 * @param DataValue $comparativeValue
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof GlobeCoordinateValue && $comparativeValue instanceof GlobeCoordinateValue;
 	}
 

includes/DumpMetaInformation/DumpMetaInformationStore.php

Spacing +1 added lines, -1 removed lines

@@ -15,6 +15,6 @@
 	 *
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 */
-	public function save( DumpMetaInformation $dumpMetaInformation );
+	public function save(DumpMetaInformation $dumpMetaInformation);
 
 }

includes/Serializer/IndexedTagsSerializer.php

Spacing +5 added lines, -5 removed lines

@@ -20,8 +20,8 @@ 
 	 * @param array &$arr
 	 * @param string $tag
 	 */
-	protected function setIndexedTagName( array &$arr, $tag ) {
-		ApiResult::setIndexedTagName( $arr, $tag );
+	protected function setIndexedTagName(array &$arr, $tag) {
+		ApiResult::setIndexedTagName($arr, $tag);
 	}
 
 	/**
@@ -33,9 +33,9 @@ 
 	 * @param string $tagName
 	 * @param string $idAttribute
 	 */
-	protected function setKeyAttributeName( array &$arr, $tagName, $idAttribute ) {
-		ApiResult::setArrayType( $arr, 'kvp', $idAttribute );
-		ApiResult::setIndexedTagName( $arr, $tagName );
+	protected function setKeyAttributeName(array &$arr, $tagName, $idAttribute) {
+		ApiResult::setArrayType($arr, 'kvp', $idAttribute);
+		ApiResult::setIndexedTagName($arr, $tagName);
 	}
 
 }

includes/UpdateExternalData/CsvImportSettings.php

Spacing +5 added lines, -5 removed lines

@@ -43,11 +43,11 @@
 	 * @param int $batchSize
 	 * @param bool $quiet
 	 */
-	public function __construct( $externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false ) {
-		Assert::parameterType( 'string', $externalValuesFilePath, '$externalValuesFilePath' );
-		Assert::parameterType( 'string', $dumpInformationFilePath, '$dumpInformationFilePath' );
-		Assert::parameterType( 'integer', $batchSize, '$batchSize' );
-		Assert::parameterType( 'boolean', $quiet, '$quiet' );
+	public function __construct($externalValuesFilePath, $dumpInformationFilePath, $batchSize, $quiet = false) {
+		Assert::parameterType('string', $externalValuesFilePath, '$externalValuesFilePath');
+		Assert::parameterType('string', $dumpInformationFilePath, '$dumpInformationFilePath');
+		Assert::parameterType('integer', $batchSize, '$batchSize');
+		Assert::parameterType('boolean', $quiet, '$quiet');
 
 		$this->externalValuesFilePath = $externalValuesFilePath;
 		$this->dumpInformationFilePath = $dumpInformationFilePath;

includes/DumpMetaInformation/DumpMetaInformationLookup.php

Spacing +2 added lines, -2 removed lines

@@ -20,7 +20,7 @@ 
 	 * @return DumpMetaInformation[]
 	 * @throws \InvalidArgumentException
 	 */
-	public function getWithIds( array $dumpIds );
+	public function getWithIds(array $dumpIds);
 
 	/**
 	 * Gets DumpMetaInformation for specific identifier properties from database
@@ -30,7 +30,7 @@ 
 	 *
 	 * @return DumpMetaInformation[]
 	 */
-	public function getWithIdentifierProperties( array $identifierPropertyIds );
+	public function getWithIdentifierProperties(array $identifierPropertyIds);
 
 	/**
 	 * Gets all DumpMetaInformation from database

maintenance/UpdateExternalData.php

Spacing +11 added lines, -11 removed lines

@@ -7,10 +7,10 @@ 
 use WikibaseQuality\ExternalValidation\UpdateExternalData\CsvImportSettings;
 use WikibaseQuality\ExternalValidation\UpdateExternalData\ExternalDataImporter;
 
-$basePath = getenv( 'MW_INSTALL_PATH' ) !== false
-	? getenv( 'MW_INSTALL_PATH' )
-	: __DIR__ . '/../../..';
-require_once $basePath . '/maintenance/Maintenance.php';
+$basePath = getenv('MW_INSTALL_PATH') !== false
+	? getenv('MW_INSTALL_PATH')
+	: __DIR__.'/../../..';
+require_once $basePath.'/maintenance/Maintenance.php';
 
 /**
  * Maintenance script that evokes updates of wbqev_external_data, wbqev_dump_information, wbqev_identifier_properties
@@ -25,17 +25,17 @@ 
 	public function __construct() {
 		parent::__construct();
 
-		$this->addDescription( 'Imports external entities from given CSV files into the local '
-			. 'database. CSV files can be generated using the DumpConverter.' );
-		$this->addOption( 'external-values-file', 'CSV file containing external values for import.', true, true );
-		$this->addOption( 'dump-information-file', 'CSV file containing dump meta information for import.', true, true );
-		$this->setBatchSize( 1000 );
+		$this->addDescription('Imports external entities from given CSV files into the local '
+			. 'database. CSV files can be generated using the DumpConverter.');
+		$this->addOption('external-values-file', 'CSV file containing external values for import.', true, true);
+		$this->addOption('dump-information-file', 'CSV file containing dump meta information for import.', true, true);
+		$this->setBatchSize(1000);
 	}
 
 	public function execute() {
 		$context = new CsvImportSettings(
-			$this->getOption( 'external-values-file' ),
-			$this->getOption( 'dump-information-file' ),
+			$this->getOption('external-values-file'),
+			$this->getOption('dump-information-file'),
 			$this->mBatchSize,
 			$this->isQuiet()
 		);

includes/CrossCheck/Comparer/QuantityValueComparer.php

Spacing +6 added lines, -6 removed lines

@@ -23,9 +23,9 @@ 
 	 * @throws InvalidArgumentException
 	 * @return string One of the ComparisonResult::STATUS_... constants.
 	 */
-	public function compare( DataValue $value, DataValue $comparativeValue ) {
-		if ( !$this->canCompare( $value, $comparativeValue ) ) {
-			throw new InvalidArgumentException( 'Given values can not be compared using this comparer.' );
+	public function compare(DataValue $value, DataValue $comparativeValue) {
+		if (!$this->canCompare($value, $comparativeValue)) {
+			throw new InvalidArgumentException('Given values can not be compared using this comparer.');
 		}
 
 		/**
@@ -33,8 +33,8 @@ 
 		 * @var QuantityValue $comparativeValue
 		 */
 
-		if ( $comparativeValue->getLowerBound()->compare( $value->getUpperBound() ) <= 0 &&
-			$comparativeValue->getUpperBound()->compare( $value->getLowerBound() ) >= 0
+		if ($comparativeValue->getLowerBound()->compare($value->getUpperBound()) <= 0 &&
+			$comparativeValue->getUpperBound()->compare($value->getLowerBound()) >= 0
 		) {
 			return ComparisonResult::STATUS_MATCH;
 		}
@@ -50,7 +50,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canCompare( DataValue $value, DataValue $comparativeValue ) {
+	public function canCompare(DataValue $value, DataValue $comparativeValue) {
 		return $value instanceof QuantityValue && $comparativeValue instanceof QuantityValue;
 	}
 

includes/CrossCheck/ReferenceChecker.php

Spacing +8 added lines, -8 removed lines

@@ -40,16 +40,16 @@ 
 		$externalId,
 		DumpMetaInformation $dumpMetaInformation
 	) {
-		Assert::parameterType( 'string', $externalId, '$externalId' );
+		Assert::parameterType('string', $externalId, '$externalId');
 
-		if ( count( $statement->getReferences() ) === 0 ) {
+		if (count($statement->getReferences()) === 0) {
 			$status = ReferenceResult::STATUS_REFERENCES_MISSING;
 		} else {
 			$status = ReferenceResult::STATUS_REFERENCES_STATED;
 		}
 
-		$externalReference = $this->buildReference( $identifierPropertyId, $externalId, $dumpMetaInformation );
-		return new ReferenceResult( $status, $externalReference );
+		$externalReference = $this->buildReference($identifierPropertyId, $externalId, $dumpMetaInformation);
+		return new ReferenceResult($status, $externalReference);
 	}
 
 	/**
@@ -60,17 +60,17 @@ 
 	 * @param DumpMetaInformation $dumpMetaInformation
 	 * @return Reference
 	 */
-	private function buildReference( PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation ) {
+	private function buildReference(PropertyId $identifierPropertyId, $externalId, DumpMetaInformation $dumpMetaInformation) {
 		global $wgWBQEVStatedInPID;
 
 		$sourceItemId = $dumpMetaInformation->getSourceItemId();
 		$statedInAuthoritySnak = new PropertyValueSnak(
-			new PropertyId( $wgWBQEVStatedInPID ),
-			new EntityIdValue( $sourceItemId )
+			new PropertyId($wgWBQEVStatedInPID),
+			new EntityIdValue($sourceItemId)
 		);
 		$authorityWithExternalIdSnak = new PropertyValueSnak(
 			$identifierPropertyId,
-			new StringValue( $externalId )
+			new StringValue($externalId)
 		);
 
 		return new Reference(