@@ -38,7 +38,7 @@ discard block |
||
38 | 38 | ValueParserFactory $comparativeValueParserFactory, |
39 | 39 | $languageCode |
40 | 40 | ) { |
41 | - Assert::parameterType( 'string', $languageCode, '$languageCode' ); |
|
41 | + Assert::parameterType('string', $languageCode, '$languageCode'); |
|
42 | 42 | |
43 | 43 | $this->comparativeValueParserFactory = $comparativeValueParserFactory; |
44 | 44 | $this->languageCode = $languageCode; |
@@ -52,11 +52,11 @@ discard block |
||
52 | 52 | * |
53 | 53 | * @return DataValue |
54 | 54 | */ |
55 | - public function parse( $value, $propertyType ) { |
|
56 | - Assert::parameterType( 'string', $value, '$value' ); |
|
57 | - Assert::parameterType( 'string', $propertyType, '$propertyType' ); |
|
55 | + public function parse($value, $propertyType) { |
|
56 | + Assert::parameterType('string', $value, '$value'); |
|
57 | + Assert::parameterType('string', $propertyType, '$propertyType'); |
|
58 | 58 | |
59 | - return $this->getValueParser( $propertyType )->parse( $value ); |
|
59 | + return $this->getValueParser($propertyType)->parse($value); |
|
60 | 60 | } |
61 | 61 | |
62 | 62 | /** |
@@ -64,8 +64,8 @@ discard block |
||
64 | 64 | * |
65 | 65 | * @return ValueParser |
66 | 66 | */ |
67 | - private function getValueParser( $type ) { |
|
68 | - if ( !array_key_exists( $type, $this->valueParsers ) ) { |
|
67 | + private function getValueParser($type) { |
|
68 | + if (!array_key_exists($type, $this->valueParsers)) { |
|
69 | 69 | $parserOptions = $this->getParserOptions(); |
70 | 70 | $this->valueParsers[$type] = $this->comparativeValueParserFactory->newParser( |
71 | 71 | $type, |
@@ -81,8 +81,8 @@ discard block |
||
81 | 81 | */ |
82 | 82 | private function getParserOptions() { |
83 | 83 | $options = new ParserOptions(); |
84 | - $options->setOption( 'valuelang', $this->languageCode ); |
|
85 | - $options->setOption( ValueParser::OPT_LANG, $this->languageCode ); |
|
84 | + $options->setOption('valuelang', $this->languageCode); |
|
85 | + $options->setOption(ValueParser::OPT_LANG, $this->languageCode); |
|
86 | 86 | |
87 | 87 | return $options; |
88 | 88 | } |
@@ -10,6 +10,6 @@ |
||
10 | 10 | |
11 | 11 | /** English (English) */ |
12 | 12 | $specialPageAliases['en'] = [ |
13 | - 'CrossCheck' => [ 'CrossCheck', 'Cross Check' ], |
|
14 | - 'ExternalDatabases' => [ 'ExternalDatabases', 'ExternalDbs', 'External Dbs' ], |
|
13 | + 'CrossCheck' => ['CrossCheck', 'Cross Check'], |
|
14 | + 'ExternalDatabases' => ['ExternalDatabases', 'ExternalDbs', 'External Dbs'], |
|
15 | 15 | ]; |
@@ -53,10 +53,10 @@ discard block |
||
53 | 53 | TermLookup $termLookup, |
54 | 54 | EntityIdHtmlLinkFormatterFactory $entityIdHtmlLinkFormatterFactory, |
55 | 55 | DumpMetaInformationLookup $dumpMetaInformationRepo ) { |
56 | - parent::__construct( 'ExternalDatabases' ); |
|
56 | + parent::__construct('ExternalDatabases'); |
|
57 | 57 | |
58 | 58 | $this->entityIdLinkFormatter = $entityIdHtmlLinkFormatterFactory->getEntityIdFormatter( |
59 | - new LanguageLabelDescriptionLookup( $termLookup, $this->getLanguage()->getCode() ) |
|
59 | + new LanguageLabelDescriptionLookup($termLookup, $this->getLanguage()->getCode()) |
|
60 | 60 | ); |
61 | 61 | |
62 | 62 | $this->dumpMetaInformationRepo = $dumpMetaInformationRepo; |
@@ -77,7 +77,7 @@ discard block |
||
77 | 77 | * @return string |
78 | 78 | */ |
79 | 79 | public function getDescription() { |
80 | - return $this->msg( 'wbqev-externaldbs' )->text(); |
|
80 | + return $this->msg('wbqev-externaldbs')->text(); |
|
81 | 81 | } |
82 | 82 | |
83 | 83 | /** |
@@ -85,51 +85,51 @@ discard block |
||
85 | 85 | * |
86 | 86 | * @param string|null $subPage |
87 | 87 | */ |
88 | - public function execute( $subPage ) { |
|
88 | + public function execute($subPage) { |
|
89 | 89 | $out = $this->getOutput(); |
90 | 90 | |
91 | 91 | $this->setHeaders(); |
92 | 92 | |
93 | 93 | $out->addHTML( |
94 | - Html::openElement( 'p' ) |
|
95 | - . $this->msg( 'wbqev-externaldbs-instructions' )->parse() |
|
96 | - . Html::closeElement( 'p' ) |
|
97 | - . Html::openElement( 'h3' ) |
|
98 | - . $this->msg( 'wbqev-externaldbs-overview-headline' )->parse() |
|
99 | - . Html::closeElement( 'h3' ) |
|
94 | + Html::openElement('p') |
|
95 | + . $this->msg('wbqev-externaldbs-instructions')->parse() |
|
96 | + . Html::closeElement('p') |
|
97 | + . Html::openElement('h3') |
|
98 | + . $this->msg('wbqev-externaldbs-overview-headline')->parse() |
|
99 | + . Html::closeElement('h3') |
|
100 | 100 | ); |
101 | 101 | |
102 | 102 | $dumps = $this->dumpMetaInformationRepo->getAll(); |
103 | - if ( count( $dumps ) > 0 ) { |
|
103 | + if (count($dumps) > 0) { |
|
104 | 104 | $groupedDumpMetaInformation = []; |
105 | - foreach ( $dumps as $dump ) { |
|
105 | + foreach ($dumps as $dump) { |
|
106 | 106 | $sourceItemId = $dump->getSourceItemId()->getSerialization(); |
107 | 107 | $groupedDumpMetaInformation[$sourceItemId][] = $dump; |
108 | 108 | } |
109 | 109 | |
110 | 110 | $table = new HtmlTableBuilder( |
111 | 111 | [ |
112 | - $this->msg( 'wbqev-externaldbs-name' )->escaped(), |
|
113 | - $this->msg( 'wbqev-externaldbs-id' )->escaped(), |
|
114 | - $this->msg( 'wbqev-externaldbs-import-date' )->escaped(), |
|
115 | - $this->msg( 'wbqev-externaldbs-language' )->escaped(), |
|
116 | - $this->msg( 'wbqev-externaldbs-source-urls' )->escaped(), |
|
117 | - $this->msg( 'wbqev-externaldbs-size' )->escaped(), |
|
118 | - $this->msg( 'wbqev-externaldbs-license' )->escaped() |
|
112 | + $this->msg('wbqev-externaldbs-name')->escaped(), |
|
113 | + $this->msg('wbqev-externaldbs-id')->escaped(), |
|
114 | + $this->msg('wbqev-externaldbs-import-date')->escaped(), |
|
115 | + $this->msg('wbqev-externaldbs-language')->escaped(), |
|
116 | + $this->msg('wbqev-externaldbs-source-urls')->escaped(), |
|
117 | + $this->msg('wbqev-externaldbs-size')->escaped(), |
|
118 | + $this->msg('wbqev-externaldbs-license')->escaped() |
|
119 | 119 | ], |
120 | 120 | true |
121 | 121 | ); |
122 | 122 | |
123 | - foreach ( $groupedDumpMetaInformation as $dumpMetaInformation ) { |
|
124 | - $table->appendRows( $this->getRowGroup( $dumpMetaInformation ) ); |
|
123 | + foreach ($groupedDumpMetaInformation as $dumpMetaInformation) { |
|
124 | + $table->appendRows($this->getRowGroup($dumpMetaInformation)); |
|
125 | 125 | } |
126 | 126 | |
127 | - $out->addHTML( $table->toHtml() ); |
|
127 | + $out->addHTML($table->toHtml()); |
|
128 | 128 | } else { |
129 | 129 | $out->addHTML( |
130 | - Html::openElement( 'p' ) |
|
131 | - . $this->msg( 'wbqev-externaldbs-no-databases' )->escaped() |
|
132 | - . Html::closeElement( 'p' ) |
|
130 | + Html::openElement('p') |
|
131 | + . $this->msg('wbqev-externaldbs-no-databases')->escaped() |
|
132 | + . Html::closeElement('p') |
|
133 | 133 | ); |
134 | 134 | } |
135 | 135 | } |
@@ -141,12 +141,12 @@ discard block |
||
141 | 141 | * |
142 | 142 | * @return array |
143 | 143 | */ |
144 | - private function getRowGroup( array $dumpMetaInformationGroup ) { |
|
144 | + private function getRowGroup(array $dumpMetaInformationGroup) { |
|
145 | 145 | $rows = []; |
146 | 146 | |
147 | - foreach ( $dumpMetaInformationGroup as $dumpMetaInformation ) { |
|
147 | + foreach ($dumpMetaInformationGroup as $dumpMetaInformation) { |
|
148 | 148 | $dumpId = $dumpMetaInformation->getDumpId(); |
149 | - $importDate = $this->getLanguage()->timeanddate( $dumpMetaInformation->getImportDate() ); |
|
149 | + $importDate = $this->getLanguage()->timeanddate($dumpMetaInformation->getImportDate()); |
|
150 | 150 | $language = Language::fetchLanguageName( |
151 | 151 | $dumpMetaInformation->getLanguageCode(), |
152 | 152 | $this->getLanguage()->getCode() |
@@ -155,23 +155,23 @@ discard block |
||
155 | 155 | $dumpMetaInformation->getSourceUrl(), |
156 | 156 | $dumpMetaInformation->getSourceUrl() |
157 | 157 | ); |
158 | - $size = $this->getLanguage()->formatSize( $dumpMetaInformation->getSize() ); |
|
159 | - $license = $this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformation->getLicenseItemId() ); |
|
158 | + $size = $this->getLanguage()->formatSize($dumpMetaInformation->getSize()); |
|
159 | + $license = $this->entityIdLinkFormatter->formatEntityId($dumpMetaInformation->getLicenseItemId()); |
|
160 | 160 | $rows[] = [ |
161 | - new HtmlTableCellBuilder( $dumpId ), |
|
162 | - new HtmlTableCellBuilder( $importDate ), |
|
163 | - new HtmlTableCellBuilder( $language ), |
|
164 | - new HtmlTableCellBuilder( $sourceUrl, [], true ), |
|
165 | - new HtmlTableCellBuilder( $size ), |
|
166 | - new HtmlTableCellBuilder( $license, [], true ) |
|
161 | + new HtmlTableCellBuilder($dumpId), |
|
162 | + new HtmlTableCellBuilder($importDate), |
|
163 | + new HtmlTableCellBuilder($language), |
|
164 | + new HtmlTableCellBuilder($sourceUrl, [], true), |
|
165 | + new HtmlTableCellBuilder($size), |
|
166 | + new HtmlTableCellBuilder($license, [], true) |
|
167 | 167 | ]; |
168 | 168 | } |
169 | 169 | |
170 | 170 | array_unshift( |
171 | 171 | $rows[0], |
172 | 172 | new HtmlTableCellBuilder( |
173 | - $this->entityIdLinkFormatter->formatEntityId( $dumpMetaInformationGroup[0]->getSourceItemId() ), |
|
174 | - [ 'rowspan' => (string)count( $dumpMetaInformationGroup ) ], |
|
173 | + $this->entityIdLinkFormatter->formatEntityId($dumpMetaInformationGroup[0]->getSourceItemId()), |
|
174 | + ['rowspan' => (string)count($dumpMetaInformationGroup)], |
|
175 | 175 | true |
176 | 176 | ) |
177 | 177 | ); |
@@ -51,13 +51,13 @@ discard block |
||
51 | 51 | public function import() { |
52 | 52 | $dumpIds = $this->insertMetaInformation(); |
53 | 53 | |
54 | - $this->log( "\nDelete old database entries...\n" ); |
|
54 | + $this->log("\nDelete old database entries...\n"); |
|
55 | 55 | |
56 | - foreach ( $dumpIds as $dumpId ) { |
|
57 | - $this->externalDataRepo->deleteOfDump( $dumpId, $this->importSettings->getBatchSize() ); |
|
56 | + foreach ($dumpIds as $dumpId) { |
|
57 | + $this->externalDataRepo->deleteOfDump($dumpId, $this->importSettings->getBatchSize()); |
|
58 | 58 | } |
59 | 59 | |
60 | - $this->log( "\n" ); |
|
60 | + $this->log("\n"); |
|
61 | 61 | |
62 | 62 | $this->insertExternalValues(); |
63 | 63 | } |
@@ -68,52 +68,52 @@ discard block |
||
68 | 68 | * @return array |
69 | 69 | */ |
70 | 70 | protected function insertMetaInformation() { |
71 | - $this->log( "Insert new dump meta information\n" ); |
|
71 | + $this->log("Insert new dump meta information\n"); |
|
72 | 72 | |
73 | - $csvFile = fopen( $this->importSettings->getDumpInformationFilePath(), 'rb' ); |
|
74 | - if ( !$csvFile ) { |
|
75 | - exit( 'Error while reading CSV file.' ); |
|
73 | + $csvFile = fopen($this->importSettings->getDumpInformationFilePath(), 'rb'); |
|
74 | + if (!$csvFile) { |
|
75 | + exit('Error while reading CSV file.'); |
|
76 | 76 | } |
77 | 77 | |
78 | 78 | $i = 0; |
79 | 79 | $dumpIds = []; |
80 | - while ( $data = fgetcsv( $csvFile ) ) { |
|
80 | + while ($data = fgetcsv($csvFile)) { |
|
81 | 81 | $identifierPropertyIds = array_map( |
82 | - function ( $propertyId ) { |
|
83 | - return new PropertyId( $propertyId ); |
|
82 | + function($propertyId) { |
|
83 | + return new PropertyId($propertyId); |
|
84 | 84 | }, |
85 | - json_decode( $data[2] ) |
|
85 | + json_decode($data[2]) |
|
86 | 86 | ); |
87 | 87 | try { |
88 | 88 | $dumpMetaInformation = new DumpMetaInformation( |
89 | 89 | $data[0], |
90 | - new ItemId( $data[1] ), |
|
90 | + new ItemId($data[1]), |
|
91 | 91 | $identifierPropertyIds, |
92 | 92 | $data[3], |
93 | 93 | $data[4], |
94 | 94 | $data[5], |
95 | - intval( $data[6] ), |
|
96 | - new ItemId( $data[7] ) |
|
95 | + intval($data[6]), |
|
96 | + new ItemId($data[7]) |
|
97 | 97 | ); |
98 | - } catch ( \InvalidArgumentException $e ) { |
|
99 | - exit( 'Input file has bad formatted values.' ); |
|
98 | + } catch (\InvalidArgumentException $e) { |
|
99 | + exit('Input file has bad formatted values.'); |
|
100 | 100 | } |
101 | 101 | $dumpIds[] = $dumpMetaInformation->getDumpId(); |
102 | 102 | |
103 | 103 | try { |
104 | - $this->dumpMetaInformationStore->save( $dumpMetaInformation ); |
|
105 | - } catch ( \DBError $e ) { |
|
106 | - exit( 'Unknown database error occurred.' ); |
|
104 | + $this->dumpMetaInformationStore->save($dumpMetaInformation); |
|
105 | + } catch (\DBError $e) { |
|
106 | + exit('Unknown database error occurred.'); |
|
107 | 107 | } |
108 | 108 | |
109 | 109 | $i++; |
110 | - $this->log( "\r\033[K" ); |
|
111 | - $this->log( "$i rows inserted or updated" ); |
|
110 | + $this->log("\r\033[K"); |
|
111 | + $this->log("$i rows inserted or updated"); |
|
112 | 112 | } |
113 | 113 | |
114 | - fclose( $csvFile ); |
|
114 | + fclose($csvFile); |
|
115 | 115 | |
116 | - $this->log( "\n" ); |
|
116 | + $this->log("\n"); |
|
117 | 117 | |
118 | 118 | return $dumpIds; |
119 | 119 | } |
@@ -122,31 +122,31 @@ discard block |
||
122 | 122 | * Inserts external values stored in csv file into database |
123 | 123 | */ |
124 | 124 | private function insertExternalValues() { |
125 | - $this->log( "Insert new data values\n" ); |
|
125 | + $this->log("Insert new data values\n"); |
|
126 | 126 | |
127 | - $csvFile = fopen( $this->importSettings->getExternalValuesFilePath(), 'rb' ); |
|
128 | - if ( !$csvFile ) { |
|
129 | - exit( 'Error while reading CSV file.' ); |
|
127 | + $csvFile = fopen($this->importSettings->getExternalValuesFilePath(), 'rb'); |
|
128 | + if (!$csvFile) { |
|
129 | + exit('Error while reading CSV file.'); |
|
130 | 130 | } |
131 | 131 | |
132 | 132 | $i = 0; |
133 | 133 | $accumulator = []; |
134 | - while ( true ) { |
|
135 | - $data = fgetcsv( $csvFile ); |
|
136 | - if ( $data === false || ++$i % $this->importSettings->getBatchSize() === 0 ) { |
|
134 | + while (true) { |
|
135 | + $data = fgetcsv($csvFile); |
|
136 | + if ($data === false || ++$i % $this->importSettings->getBatchSize() === 0) { |
|
137 | 137 | try { |
138 | - $this->externalDataRepo->insertBatch( $accumulator ); |
|
139 | - } catch ( \DBError $e ) { |
|
140 | - exit( 'Unknown database error occurred.' ); |
|
138 | + $this->externalDataRepo->insertBatch($accumulator); |
|
139 | + } catch (\DBError $e) { |
|
140 | + exit('Unknown database error occurred.'); |
|
141 | 141 | } |
142 | 142 | wfGetLBFactory()->waitForReplication(); |
143 | 143 | |
144 | - $this->log( "\r\033[K" ); |
|
145 | - $this->log( "$i rows inserted" ); |
|
144 | + $this->log("\r\033[K"); |
|
145 | + $this->log("$i rows inserted"); |
|
146 | 146 | |
147 | 147 | $accumulator = []; |
148 | 148 | |
149 | - if ( $data === false ) { |
|
149 | + if ($data === false) { |
|
150 | 150 | break; |
151 | 151 | } |
152 | 152 | } |
@@ -154,16 +154,16 @@ discard block |
||
154 | 154 | $accumulator[] = $data; |
155 | 155 | } |
156 | 156 | |
157 | - fclose( $csvFile ); |
|
157 | + fclose($csvFile); |
|
158 | 158 | |
159 | - $this->log( "\n" ); |
|
159 | + $this->log("\n"); |
|
160 | 160 | } |
161 | 161 | |
162 | 162 | /** |
163 | 163 | * @param string $text |
164 | 164 | */ |
165 | - private function log( $text ) { |
|
166 | - if ( !$this->importSettings->isQuiet() ) { |
|
165 | + private function log($text) { |
|
166 | + if (!$this->importSettings->isQuiet()) { |
|
167 | 167 | print $text; |
168 | 168 | } |
169 | 169 | } |
@@ -22,7 +22,7 @@ discard block |
||
22 | 22 | /** |
23 | 23 | * @param Serializer $dataValueSerializer |
24 | 24 | */ |
25 | - public function __construct( Serializer $dataValueSerializer ) { |
|
25 | + public function __construct(Serializer $dataValueSerializer) { |
|
26 | 26 | $this->dataValueSerializer = $dataValueSerializer; |
27 | 27 | } |
28 | 28 | |
@@ -33,7 +33,7 @@ discard block |
||
33 | 33 | * |
34 | 34 | * @return bool |
35 | 35 | */ |
36 | - public function isSerializerFor( $object ) { |
|
36 | + public function isSerializerFor($object) { |
|
37 | 37 | return $object instanceof ComparisonResult; |
38 | 38 | } |
39 | 39 | |
@@ -45,29 +45,29 @@ discard block |
||
45 | 45 | * @return array |
46 | 46 | * @throws UnsupportedObjectException |
47 | 47 | */ |
48 | - public function serialize( $object ) { |
|
49 | - if ( !$this->isSerializerFor( $object ) ) { |
|
48 | + public function serialize($object) { |
|
49 | + if (!$this->isSerializerFor($object)) { |
|
50 | 50 | throw new UnsupportedObjectException( |
51 | 51 | $object, |
52 | 52 | 'ComparisonResultSerializer can only serialize ComparisonResult objects.' |
53 | 53 | ); |
54 | 54 | } |
55 | 55 | |
56 | - return $this->getSerialized( $object ); |
|
56 | + return $this->getSerialized($object); |
|
57 | 57 | } |
58 | 58 | |
59 | - private function getSerialized( ComparisonResult $comparisonResult ) { |
|
59 | + private function getSerialized(ComparisonResult $comparisonResult) { |
|
60 | 60 | $dataValueSerializer = $this->dataValueSerializer; |
61 | 61 | $externalValues = array_map( |
62 | - function ( $dataValue ) use ( $dataValueSerializer ) { |
|
63 | - return $dataValueSerializer->serialize( $dataValue ); |
|
62 | + function($dataValue) use ($dataValueSerializer) { |
|
63 | + return $dataValueSerializer->serialize($dataValue); |
|
64 | 64 | }, |
65 | 65 | $comparisonResult->getExternalValues() |
66 | 66 | ); |
67 | - $this->setIndexedTagName( $externalValues, 'dataValue' ); |
|
67 | + $this->setIndexedTagName($externalValues, 'dataValue'); |
|
68 | 68 | |
69 | 69 | return [ |
70 | - 'localValue' => $this->dataValueSerializer->serialize( $comparisonResult->getLocalValue() ), |
|
70 | + 'localValue' => $this->dataValueSerializer->serialize($comparisonResult->getLocalValue()), |
|
71 | 71 | 'externalValues' => $externalValues, |
72 | 72 | 'result' => $comparisonResult->getStatus() |
73 | 73 | ]; |
@@ -22,7 +22,7 @@ discard block |
||
22 | 22 | /** |
23 | 23 | * @param Serializer $crossCheckResultSerializer |
24 | 24 | */ |
25 | - public function __construct( Serializer $crossCheckResultSerializer ) { |
|
25 | + public function __construct(Serializer $crossCheckResultSerializer) { |
|
26 | 26 | $this->crossCheckResultSerializer = $crossCheckResultSerializer; |
27 | 27 | } |
28 | 28 | |
@@ -33,7 +33,7 @@ discard block |
||
33 | 33 | * |
34 | 34 | * @return bool |
35 | 35 | */ |
36 | - public function isSerializerFor( $object ) { |
|
36 | + public function isSerializerFor($object) { |
|
37 | 37 | return $object instanceof CrossCheckResultList; |
38 | 38 | } |
39 | 39 | |
@@ -45,29 +45,29 @@ discard block |
||
45 | 45 | * @return array |
46 | 46 | * @throws UnsupportedObjectException |
47 | 47 | */ |
48 | - public function serialize( $object ) { |
|
49 | - if ( !$this->isSerializerFor( $object ) ) { |
|
48 | + public function serialize($object) { |
|
49 | + if (!$this->isSerializerFor($object)) { |
|
50 | 50 | throw new UnsupportedObjectException( |
51 | 51 | $object, |
52 | 52 | 'CrossCheckResultListSerializer can only serialize CrossCheckResultList objects.' |
53 | 53 | ); |
54 | 54 | } |
55 | 55 | |
56 | - return $this->getSerialized( $object ); |
|
56 | + return $this->getSerialized($object); |
|
57 | 57 | } |
58 | 58 | |
59 | - private function getSerialized( CrossCheckResultList $resultList ) { |
|
59 | + private function getSerialized(CrossCheckResultList $resultList) { |
|
60 | 60 | $serialization = []; |
61 | - $this->setKeyAttributeName( $serialization, 'property', 'id' ); |
|
61 | + $this->setKeyAttributeName($serialization, 'property', 'id'); |
|
62 | 62 | |
63 | - foreach ( $resultList->getPropertyIds() as $propertyId ) { |
|
63 | + foreach ($resultList->getPropertyIds() as $propertyId) { |
|
64 | 64 | $id = $propertyId->getSerialization(); |
65 | 65 | $resultSerialization = []; |
66 | 66 | |
67 | - $this->setIndexedTagName( $resultSerialization, 'result' ); |
|
67 | + $this->setIndexedTagName($resultSerialization, 'result'); |
|
68 | 68 | |
69 | - foreach ( $resultList->getByPropertyId( $propertyId ) as $result ) { |
|
70 | - $resultSerialization[] = $this->crossCheckResultSerializer->serialize( $result ); |
|
69 | + foreach ($resultList->getByPropertyId($propertyId) as $result) { |
|
70 | + $resultSerialization[] = $this->crossCheckResultSerializer->serialize($result); |
|
71 | 71 | } |
72 | 72 | |
73 | 73 | $serialization[$id] = $resultSerialization; |
@@ -21,7 +21,7 @@ discard block |
||
21 | 21 | * |
22 | 22 | * @return bool |
23 | 23 | */ |
24 | - public function isSerializerFor( $object ) { |
|
24 | + public function isSerializerFor($object) { |
|
25 | 25 | return $object instanceof DumpMetaInformation; |
26 | 26 | } |
27 | 27 | |
@@ -33,32 +33,32 @@ discard block |
||
33 | 33 | * @return array |
34 | 34 | * @throws UnsupportedObjectException |
35 | 35 | */ |
36 | - public function serialize( $object ) { |
|
37 | - if ( !$this->isSerializerFor( $object ) ) { |
|
36 | + public function serialize($object) { |
|
37 | + if (!$this->isSerializerFor($object)) { |
|
38 | 38 | throw new UnsupportedObjectException( |
39 | 39 | $object, |
40 | 40 | 'DumpMetaInformationSerializer can only serialize DumpMetaInformation objects.' |
41 | 41 | ); |
42 | 42 | } |
43 | 43 | |
44 | - return $this->getSerialized( $object ); |
|
44 | + return $this->getSerialized($object); |
|
45 | 45 | } |
46 | 46 | |
47 | - private function getSerialized( DumpMetaInformation $dumpMetaInformation ) { |
|
47 | + private function getSerialized(DumpMetaInformation $dumpMetaInformation) { |
|
48 | 48 | $identifierPropertyIds = array_map( |
49 | - function( PropertyId $id ) { |
|
49 | + function(PropertyId $id) { |
|
50 | 50 | return $id->getSerialization(); |
51 | 51 | }, |
52 | 52 | $dumpMetaInformation->getIdentifierPropertyIds() |
53 | 53 | ); |
54 | 54 | |
55 | - $this->setIndexedTagName( $identifierPropertyIds, 'propertyId' ); |
|
55 | + $this->setIndexedTagName($identifierPropertyIds, 'propertyId'); |
|
56 | 56 | |
57 | 57 | return [ |
58 | 58 | 'dumpId' => $dumpMetaInformation->getDumpId(), |
59 | 59 | 'sourceItemId' => $dumpMetaInformation->getSourceItemId()->getSerialization(), |
60 | 60 | 'identifierPropertyIds' => $identifierPropertyIds, |
61 | - 'importDate' => wfTimestamp( TS_ISO_8601, $dumpMetaInformation->getImportDate() ), |
|
61 | + 'importDate' => wfTimestamp(TS_ISO_8601, $dumpMetaInformation->getImportDate()), |
|
62 | 62 | 'language' => $dumpMetaInformation->getLanguageCode(), |
63 | 63 | 'sourceUrl' => $dumpMetaInformation->getSourceUrl(), |
64 | 64 | 'size' => $dumpMetaInformation->getSize(), |
@@ -51,7 +51,7 @@ discard block |
||
51 | 51 | * |
52 | 52 | * @return bool |
53 | 53 | */ |
54 | - public function isSerializerFor( $object ) { |
|
54 | + public function isSerializerFor($object) { |
|
55 | 55 | return $object instanceof CrossCheckResult; |
56 | 56 | } |
57 | 57 | |
@@ -63,25 +63,25 @@ discard block |
||
63 | 63 | * @return array |
64 | 64 | * @throws UnsupportedObjectException |
65 | 65 | */ |
66 | - public function serialize( $object ) { |
|
67 | - if ( !$this->isSerializerFor( $object ) ) { |
|
66 | + public function serialize($object) { |
|
67 | + if (!$this->isSerializerFor($object)) { |
|
68 | 68 | throw new UnsupportedObjectException( |
69 | 69 | $object, |
70 | 70 | 'CrossCheckResultSerializer can only serialize CrossCheckResult objects.' |
71 | 71 | ); |
72 | 72 | } |
73 | 73 | |
74 | - return $this->getSerialized( $object ); |
|
74 | + return $this->getSerialized($object); |
|
75 | 75 | } |
76 | 76 | |
77 | - private function getSerialized( CrossCheckResult $crossCheckResult ) { |
|
77 | + private function getSerialized(CrossCheckResult $crossCheckResult) { |
|
78 | 78 | return [ |
79 | 79 | 'propertyId' => $crossCheckResult->getPropertyId()->getSerialization(), |
80 | 80 | 'claimGuid' => $crossCheckResult->getClaimGuid(), |
81 | 81 | 'externalId' => $crossCheckResult->getExternalId(), |
82 | - 'dataSource' => $this->dumpMetaInformationSerializer->serialize( $crossCheckResult->getDumpMetaInformation() ), |
|
83 | - 'comparisonResult' => $this->comparisonResultSerializer->serialize( $crossCheckResult->getComparisonResult() ), |
|
84 | - 'referenceResult' => $this->referenceResultSerializer->serialize( $crossCheckResult->getReferenceResult() ) |
|
82 | + 'dataSource' => $this->dumpMetaInformationSerializer->serialize($crossCheckResult->getDumpMetaInformation()), |
|
83 | + 'comparisonResult' => $this->comparisonResultSerializer->serialize($crossCheckResult->getComparisonResult()), |
|
84 | + 'referenceResult' => $this->referenceResultSerializer->serialize($crossCheckResult->getReferenceResult()) |
|
85 | 85 | ]; |
86 | 86 | } |
87 | 87 |
@@ -22,7 +22,7 @@ discard block |
||
22 | 22 | /** |
23 | 23 | * @param Serializer $referenceSerializer |
24 | 24 | */ |
25 | - public function __construct( Serializer $referenceSerializer ) { |
|
25 | + public function __construct(Serializer $referenceSerializer) { |
|
26 | 26 | $this->referenceSerializer = $referenceSerializer; |
27 | 27 | } |
28 | 28 | |
@@ -33,7 +33,7 @@ discard block |
||
33 | 33 | * |
34 | 34 | * @return bool |
35 | 35 | */ |
36 | - public function isSerializerFor( $object ) { |
|
36 | + public function isSerializerFor($object) { |
|
37 | 37 | return $object instanceof ReferenceResult; |
38 | 38 | } |
39 | 39 | |
@@ -45,20 +45,20 @@ discard block |
||
45 | 45 | * @return array |
46 | 46 | * @throws UnsupportedObjectException |
47 | 47 | */ |
48 | - public function serialize( $object ) { |
|
49 | - if ( !$this->isSerializerFor( $object ) ) { |
|
48 | + public function serialize($object) { |
|
49 | + if (!$this->isSerializerFor($object)) { |
|
50 | 50 | throw new UnsupportedObjectException( |
51 | 51 | $object, |
52 | 52 | 'ReferenceResultSerializer can only serialize ReferenceResult objects.' |
53 | 53 | ); |
54 | 54 | } |
55 | 55 | |
56 | - return $this->getSerialized( $object ); |
|
56 | + return $this->getSerialized($object); |
|
57 | 57 | } |
58 | 58 | |
59 | - private function getSerialized( ReferenceResult $referenceResult ) { |
|
59 | + private function getSerialized(ReferenceResult $referenceResult) { |
|
60 | 60 | return [ |
61 | - 'reference' => $this->referenceSerializer->serialize( $referenceResult->getReference() ), |
|
61 | + 'reference' => $this->referenceSerializer->serialize($referenceResult->getReference()), |
|
62 | 62 | 'status' => $referenceResult->getStatus() |
63 | 63 | ]; |
64 | 64 | } |